From: Miod Vallat <miod.vallat@powerdns.com>
Date: Fri, 25 Jul 2025 10:34:23 +0000 (+0200)
Subject: Build the DNSName in order in keyUnconv.
X-Git-Tag: auth-5.1.0-alpha0~5^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F15928%2Fhead;p=thirdparty%2Fpdns.git

Build the DNSName in order in keyUnconv.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index 769e1a3ad..d1e5e162c 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -1469,10 +1469,11 @@ static DNSName keyUnconv(std::string& instr)
 
   DNSName tmp;
 
-  for (auto const& label : labels) {
-    tmp.appendRawLabel(label);
+  while (!labels.empty()) {
+    tmp.appendRawLabel(labels.back());
+    labels.pop_back();
   }
-  return tmp.labelReverse();
+  return tmp;
 }
 
 static std::string makeBadDataExceptionMessage(const std::string& where, std::exception& exc, MDBOutVal& key, MDBOutVal& val)