From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Tue, 9 Sep 2025 12:17:17 +0000 (+0200)
Subject: dnsproxy: drop bogus endianness workaround
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F16105%2Fhead;p=thirdparty%2Fpdns.git

dnsproxy: drop bogus endianness workaround
---

diff --git a/pdns/dnsproxy.cc b/pdns/dnsproxy.cc
index 2f497f457..7ef7fc44d 100644
--- a/pdns/dnsproxy.cc
+++ b/pdns/dnsproxy.cc
@@ -256,10 +256,6 @@ void DNSProxy::mainloop()
       memcpy(&dHead, &buffer[0], sizeof(dHead));
       {
         auto conntrack = d_conntrack.lock();
-        if (BYTE_ORDER == BIG_ENDIAN) {
-          // this is needed because spoof ID down below does not respect the native byteorder
-          dHead.id = (256 * (uint16_t)buffer[1]) + (uint16_t)buffer[0];
-        }
 
         auto iter = conntrack->find(dHead.id ^ d_xor);
         if (iter == conntrack->end()) {