From: Miod Vallat <miod.vallat@powerdns.com>
Date: Fri, 12 Sep 2025 07:28:00 +0000 (+0200)
Subject: Do not make SIGCHLD ignored when the pipe backend launches.
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F16114%2Fhead;p=thirdparty%2Fpdns.git

Do not make SIGCHLD ignored when the pipe backend launches.

The pipe code makes sure to properly invoke waitpid() to reap its child
process, if any. And ignoring SIGCHLD would prevent other legitimate
waitpid() calls from working, such the editor spawned by pdnsutil zone edit.

Fixes: #3680

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/modules/pipebackend/pipebackend.cc b/modules/pipebackend/pipebackend.cc
index 753bf96e1..431b87692 100644
--- a/modules/pipebackend/pipebackend.cc
+++ b/modules/pipebackend/pipebackend.cc
@@ -111,7 +111,6 @@ void CoWrapper::receive(string& line)
 PipeBackend::PipeBackend(const string& suffix)
 {
   d_disavow = false;
-  signal(SIGCHLD, SIG_IGN);
   setArgPrefix("pipe" + suffix);
   try {
     launch();