From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Tue, 14 Oct 2025 12:51:32 +0000 (+0200)
Subject: chore(dnsdist): Improve InternalQueryState field ordering
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F16182%2Fhead;p=thirdparty%2Fpdns.git

chore(dnsdist): Improve InternalQueryState field ordering
---

diff --git a/pdns/dnsdistdist/dnsdist-idstate.hh b/pdns/dnsdistdist/dnsdist-idstate.hh
index 9287f4fddd..972c4c6f74 100644
--- a/pdns/dnsdistdist/dnsdist-idstate.hh
+++ b/pdns/dnsdistdist/dnsdist-idstate.hh
@@ -120,8 +120,6 @@ struct InternalQueryState
     std::string d_requestorID;
   };
 
-  // Whether or not Open Telemetry tracing is enabled for this query
-  bool tracingEnabled = false;
   /**
    * @brief Returns the Tracer, but only if OpenTelemetry tracing is globally enabled
    *
@@ -180,6 +178,10 @@ struct InternalQueryState
   PacketBuffer xskPacketHeader; // 24
 #endif /* HAVE_XSK */
   StopWatch queryRealTime{true}; // 24
+private:
+  std::shared_ptr<pdns::trace::dnsdist::Tracer> d_OTTracer{nullptr};
+
+public:
   std::shared_ptr<DNSDistPacketCache> packetCache{nullptr}; // 16
   std::unique_ptr<DNSCryptQuery> dnsCryptQuery{nullptr}; // 8
   std::unique_ptr<QTag> qTag{nullptr}; // 8
@@ -221,9 +223,7 @@ struct InternalQueryState
   bool selfGenerated{false};
   bool cacheHit{false};
   bool staleCacheHit{false};
-
-private:
-  std::shared_ptr<pdns::trace::dnsdist::Tracer> d_OTTracer{nullptr};
+  bool tracingEnabled{false}; // Whether or not Open Telemetry tracing is enabled for this query
 };
 
 struct IDState