From: Ruben Kerkhof <ruben@rubenkerkhof.com>
Date: Sun, 14 Dec 2014 12:23:08 +0000 (+0100)
Subject: Only log remote nameservers
X-Git-Tag: rec-3.7.0-rc1~109^2~14^2~7^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F1946%2Fhead;p=thirdparty%2Fpdns.git

Only log remote nameservers

Skip the A/AAAA records.

Previously, we would log:
Unable to find backend willing to host example.com for potential supermaster x.x.x.x. 4 remote nameservers:
test1.example.com
test2.example.com
x.x.x.x
x.x.x.y
---

diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index 12a5968b53..7d1185d263 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -745,9 +745,10 @@ int PacketHandler::trySuperMasterSynchronous(DNSPacket *p)
   string nameserver, account;
   DNSBackend *db;
   if(!B.superMasterBackend(p->getRemote(), p->qdomain, nsset, &nameserver, &account, &db)) {
-    L<<Logger::Error<<"Unable to find backend willing to host "<<p->qdomain<<" for potential supermaster "<<p->getRemote()<<". "<<nsset.size()<<" remote nameservers: "<<endl;
+    L<<Logger::Error<<"Unable to find backend willing to host "<<p->qdomain<<" for potential supermaster "<<p->getRemote()<<". Remote nameservers: "<<endl;
     BOOST_FOREACH(class DNSResourceRecord& rr, nsset) {
-      L<<Logger::Error<<rr.content<<endl;
+      if(rr.qtype.getCode()==QType::NS)
+        L<<Logger::Error<<rr.content<<endl;
     }
     return RCode::Refused;
   }