From: Julia Kartseva <hex@fb.com>
Date: Mon, 10 Jan 2022 05:35:35 +0000 (-0800)
Subject: bpf: fix bpf_can_link_lsm_program condition
X-Git-Tag: v251-rc1~556^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F22050%2Fhead;p=thirdparty%2Fsystemd.git

bpf: fix bpf_can_link_lsm_program condition

Since bpf_can_link_lsm_program return value is boolean, the expression
`r < 0` is always false.
---

diff --git a/src/core/bpf-lsm.c b/src/core/bpf-lsm.c
index 4ca082a0050..83f3199349c 100644
--- a/src/core/bpf-lsm.c
+++ b/src/core/bpf-lsm.c
@@ -167,9 +167,9 @@ int lsm_bpf_supported(void) {
         if (r < 0)
                 return supported = 0;
 
-        r = bpf_can_link_lsm_program(obj->progs.restrict_filesystems);
-        if (r < 0) {
-                log_warning_errno(r, "Failed to link BPF program. Assuming BPF is not available: %m");
+        if (!bpf_can_link_lsm_program(obj->progs.restrict_filesystems)) {
+                log_warning_errno(SYNTHETIC_ERRNO(EOPNOTSUPP),
+                                  "Failed to link BPF program. Assuming BPF is not available");
                 return supported = 0;
         }