From: Michele Cella <michele.cella@gmail.com>
Date: Thu, 28 Apr 2011 10:49:03 +0000 (-0700)
Subject: RequestHandler.get_argument should raise an HTTP 400 Bad Request if the argument... 
X-Git-Tag: v2.0.0~95^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F253%2Fhead;p=thirdparty%2Ftornado.git

RequestHandler.get_argument should raise an HTTP 400 Bad Request if the argument is missing, not a misleading HTTP 404 Not Found.
---

diff --git a/tornado/web.py b/tornado/web.py
index e32f03bf1..755ccd0a4 100644
--- a/tornado/web.py
+++ b/tornado/web.py
@@ -220,7 +220,7 @@ class RequestHandler(object):
         """Returns the value of the argument with the given name.
 
         If default is not provided, the argument is considered to be
-        required, and we throw an HTTP 404 exception if it is missing.
+        required, and we throw an HTTP 400 exception if it is missing.
 
         If the argument appears in the url more than once, we return the
         last value.
@@ -230,7 +230,7 @@ class RequestHandler(object):
         args = self.get_arguments(name, strip=strip)
         if not args:
             if default is self._ARG_DEFAULT:
-                raise HTTPError(404, "Missing argument %s" % name)
+                raise HTTPError(400, "Missing argument %s" % name)
             return default
         return args[-1]