From: Luca Boccassi <bluca@debian.org>
Date: Sun, 18 Dec 2022 10:58:37 +0000 (+0000)
Subject: journal-remote: fix memory leak on initialization error
X-Git-Tag: v253-rc1~248^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F25779%2Fhead;p=thirdparty%2Fsystemd.git

journal-remote: fix memory leak on initialization error

Follow-up for f12b399dd6362a03379cb769954ebfb9972236ed from
https://github.com/systemd/systemd/pull/25076

CID#1501550
---

diff --git a/src/journal-remote/journal-remote-write.c b/src/journal-remote/journal-remote-write.c
index 2e58c6d91ee..f6c3d83732b 100644
--- a/src/journal-remote/journal-remote-write.c
+++ b/src/journal-remote/journal-remote-write.c
@@ -22,7 +22,7 @@ static int do_rotate(ManagedJournalFile **f, MMapCache *m, JournalFileFlags file
 }
 
 Writer* writer_new(RemoteServer *server) {
-        Writer *w;
+        _cleanup_(writer_unrefp) Writer *w = NULL;
         int r;
 
         w = new0(Writer, 1);
@@ -33,7 +33,7 @@ Writer* writer_new(RemoteServer *server) {
 
         w->mmap = mmap_cache_new();
         if (!w->mmap)
-                return mfree(w);
+                return NULL;
 
         w->n_ref = 1;
         w->server = server;
@@ -50,7 +50,7 @@ Writer* writer_new(RemoteServer *server) {
                 }
         }
 
-        return w;
+        return TAKE_PTR(w);
 }
 
 static Writer* writer_free(Writer *w) {