From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Thu, 10 Aug 2023 01:23:59 +0000 (+0900)
Subject: core/mount: disable timer event source when USEC_INFINITY
X-Git-Tag: v255-rc1~700^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F28751%2Fhead;p=thirdparty%2Fsystemd.git

core/mount: disable timer event source when USEC_INFINITY

Setting USEC_INFINITY to timer event source should not cause any
problem. But, disabling timer event source should be preferable.

[zjs: simplify the call to sd_event_source_set_enabled()]
---

diff --git a/src/core/mount.c b/src/core/mount.c
index b773ce5fcae..f93bad7074b 100644
--- a/src/core/mount.c
+++ b/src/core/mount.c
@@ -195,6 +195,9 @@ static int mount_arm_timer(Mount *m, usec_t usec) {
 
         assert(m);
 
+        if (usec == USEC_INFINITY)
+                return sd_event_source_set_enabled(m->timer_event_source, SD_EVENT_OFF);
+
         if (m->timer_event_source) {
                 r = sd_event_source_set_time(m->timer_event_source, usec);
                 if (r < 0)
@@ -203,9 +206,6 @@ static int mount_arm_timer(Mount *m, usec_t usec) {
                 return sd_event_source_set_enabled(m->timer_event_source, SD_EVENT_ONESHOT);
         }
 
-        if (usec == USEC_INFINITY)
-                return 0;
-
         r = sd_event_add_time(
                         UNIT(m)->manager->event,
                         &m->timer_event_source,