From: Andreas Jakum <aj-gh@users.noreply.github.com>
Date: Fri, 13 Nov 2015 15:17:29 +0000 (+0100)
Subject: Add source IP when logging incorrect (ignored) TCP packets.
X-Git-Tag: dnsdist-1.0.0-alpha1~219^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F2889%2Fhead;p=thirdparty%2Fpdns.git

Add source IP when logging incorrect (ignored) TCP packets.
Similar to what is already in place for UDP packets.
---

diff --git a/pdns/pdns_recursor.cc b/pdns/pdns_recursor.cc
index 3d3a375176..21ecf25637 100644
--- a/pdns/pdns_recursor.cc
+++ b/pdns/pdns_recursor.cc
@@ -1009,12 +1009,12 @@ void handleRunningTCPQuestion(int fd, FDMultiplexer::funcparam_t& var)
       dc->setRemote(&conn->d_remote);
       if(dc->d_mdp.d_header.qr) {
         delete dc;
-        L<<Logger::Error<<"Ignoring answer on server socket!"<<endl;
+        L<<Logger::Error<<"Ignoring answer from TCP client "<< conn->d_remote.toString() <<" on server socket!"<<endl;
         return;
       }
       if(dc->d_mdp.d_header.opcode) {
         delete dc;
-        L<<Logger::Error<<"Ignoring non-query opcode on server socket!"<<endl;
+        L<<Logger::Error<<"Ignoring non-query opcode from TCP client "<< conn->d_remote.toString() <<" on server socket!"<<endl;
         return;
       }
       else {