From: Christian Hofstaedtler <christian@hofstaedtler.name>
Date: Sun, 22 Nov 2015 22:19:20 +0000 (+0100)
Subject: Fix signed/unsigned type confusion warnings in checkForCorrectTSIG
X-Git-Tag: dnsdist-1.0.0-alpha1~208^2^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F2918%2Fhead;p=thirdparty%2Fpdns.git

Fix signed/unsigned type confusion warnings in checkForCorrectTSIG
---

diff --git a/pdns/dnspacket.cc b/pdns/dnspacket.cc
index 7a21eebffe..1c330446ae 100644
--- a/pdns/dnspacket.cc
+++ b/pdns/dnspacket.cc
@@ -656,9 +656,9 @@ bool checkForCorrectTSIG(const DNSPacket* q, UeberBackend* B, DNSName* keyname,
   string message;
 
   q->getTSIGDetails(trc, keyname, &message);
-  int64_t now = time(0);
-  if(abs((int64_t)trc->d_time - now) > trc->d_fudge) {
-    L<<Logger::Error<<"Packet for '"<<q->qdomain<<"' denied: TSIG (key '"<<*keyname<<"') time delta "<< abs(trc->d_time - now)<<" > 'fudge' "<<trc->d_fudge<<endl;
+  uint64_t delta = std::abs((int64_t)trc->d_time - (int64_t)time(0));
+  if(delta > trc->d_fudge) {
+    L<<Logger::Error<<"Packet for '"<<q->qdomain<<"' denied: TSIG (key '"<<*keyname<<"') time delta "<< delta <<" > 'fudge' "<<trc->d_fudge<<endl;
     return false;
   }