From: moisseev <moiseev@mezonplus.ru>
Date: Wed, 3 Jun 2020 16:41:52 +0000 (+0300)
Subject: [Minor] Fix HTTP status code
X-Git-Tag: 2.6~359^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F3389%2Fhead;p=thirdparty%2Frspamd.git

[Minor] Fix HTTP status code

We should treat invalid selector as a negative result of the check.
---

diff --git a/rules/controller/selectors.lua b/rules/controller/selectors.lua
index 58065fc85b..905757c76c 100644
--- a/rules/controller/selectors.lua
+++ b/rules/controller/selectors.lua
@@ -30,11 +30,7 @@ local function handle_check_selector(_, conn, req_params)
   if req_params.selector then
     local selector = lua_selectors.create_selector_closure(rspamd_config,
         req_params.selector, '', true)
-    if not selector then
-      conn:send_error(500, 'invalid selector')
-    else
-      conn:send_ucl({success = true})
-    end
+      conn:send_ucl({success = selector and true})
   else
     conn:send_error(404, 'missing selector')
   end
@@ -74,4 +70,4 @@ return {
     enable = true,
     need_task = true,
   }
-}
\ No newline at end of file
+}