From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 18 Oct 2024 12:16:53 +0000 (+0200)
Subject: dissect-image: generate better log message for EUCLEAN dissect error
X-Git-Tag: v257-rc1~183^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F34820%2Fhead;p=thirdparty%2Fsystemd.git

dissect-image: generate better log message for EUCLEAN dissect error

Fixes: #31799
---

diff --git a/src/shared/dissect-image.c b/src/shared/dissect-image.c
index 9c2f35d58bb..86fd1ef865d 100644
--- a/src/shared/dissect-image.c
+++ b/src/shared/dissect-image.c
@@ -708,7 +708,9 @@ static int dissect_image(
          * Returns -ERFKILL if image doesn't match image policy
          * Returns -EBADR if verity data was provided externally for an image that has a GPT partition table (i.e. is not just a naked fs)
          * Returns -EPROTONOSUPPORT if DISSECT_IMAGE_ADD_PARTITION_DEVICES is set but the block device does not have partition logic enabled
-         * Returns -ENOMSG if we didn't find a single usable partition (and DISSECT_IMAGE_REFUSE_EMPTY is set) */
+         * Returns -ENOMSG if we didn't find a single usable partition (and DISSECT_IMAGE_REFUSE_EMPTY is set)
+         * Returns -EUCLEAN if some file system had an ambiguous file system superblock signature
+         */
 
         uint64_t diskseq = m->loop ? m->loop->diskseq : 0;
 
@@ -1664,6 +1666,9 @@ int dissect_log_error(int log_level, int r, const char *name, const VeritySettin
         case -ENOMSG:
                 return log_full_errno(log_level, r, "%s: No suitable partitions found.", name);
 
+        case -EUCLEAN:
+                return log_full_errno(log_level, r, "%s: Partition with ambiguous file system superblock signature found.", name);
+
         default:
                 return log_full_errno(log_level, r, "%s: Cannot dissect image: %m", name);
         }