From: Andrey Volk <andywolk@gmail.com>
Date: Fri, 14 Feb 2020 14:39:15 +0000 (+0400)
Subject: [apr-util] Fix issues reported by scan-build.
X-Git-Tag: v1.10.3^2~173^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F359%2Fhead;p=thirdparty%2Ffreeswitch.git

[apr-util] Fix issues reported by scan-build.
---

diff --git a/libs/apr-util/hooks/apr_hooks.c b/libs/apr-util/hooks/apr_hooks.c
index da0ae97058..776bc884e7 100644
--- a/libs/apr-util/hooks/apr_hooks.c
+++ b/libs/apr-util/hooks/apr_hooks.c
@@ -180,7 +180,9 @@ static TSort *tsort(TSort *pData,int nItems)
 		    break;
 		}
     }
-    pTail->pNext=NULL;  /* unfudge the tail */
+	if (pTail) {
+		pTail->pNext = NULL;  /* unfudge the tail */
+	}
     return pHead;
 }
 
diff --git a/libs/apr-util/misc/apr_queue.c b/libs/apr-util/misc/apr_queue.c
index e905a53ebb..a947df8a08 100644
--- a/libs/apr-util/misc/apr_queue.c
+++ b/libs/apr-util/misc/apr_queue.c
@@ -222,7 +222,7 @@ APU_DECLARE(apr_status_t) apr_queue_trypush(apr_queue_t *queue, void *data)
     }
 
     if (apr_queue_full(queue)) {
-        rv = apr_thread_mutex_unlock(queue->one_big_mutex);
+        apr_thread_mutex_unlock(queue->one_big_mutex);
         return APR_EAGAIN;
     }
     
@@ -397,7 +397,7 @@ APU_DECLARE(apr_status_t) apr_queue_trypop(apr_queue_t *queue, void **data)
     }
 
     if (apr_queue_empty(queue)) {
-        rv = apr_thread_mutex_unlock(queue->one_big_mutex);
+        apr_thread_mutex_unlock(queue->one_big_mutex);
         return APR_EAGAIN;
     } 
 
diff --git a/libs/apr-util/xml/apr_xml.c b/libs/apr-util/xml/apr_xml.c
index 73543555ff..a05348d60f 100644
--- a/libs/apr-util/xml/apr_xml.c
+++ b/libs/apr-util/xml/apr_xml.c
@@ -82,7 +82,7 @@ static int find_prefix(apr_xml_parser *parser, const char *prefix)
     ** prefix.
     */
     for (; elem; elem = elem->parent) {
-	apr_xml_ns_scope *ns_scope = elem->ns_scope;
+	apr_xml_ns_scope *ns_scope;
 
 	for (ns_scope = elem->ns_scope; ns_scope; ns_scope = ns_scope->next) {
 	    if (strcmp(prefix, ns_scope->prefix) == 0) {