From: Mike Yuan <me@yhndnzj.com>
Date: Tue, 27 May 2025 12:25:12 +0000 (+0200)
Subject: cgroup-util: assert on attribute for cg_{get,set}_attribute()
X-Git-Tag: v258-rc1~472^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F37630%2Fhead;p=thirdparty%2Fsystemd.git

cgroup-util: assert on attribute for cg_{get,set}_attribute()

It makes zero sense to ever perform IO operations on cgroup dirs.
---

diff --git a/src/basic/cgroup-util.c b/src/basic/cgroup-util.c
index c70b04650c1..f3ce1742448 100644
--- a/src/basic/cgroup-util.c
+++ b/src/basic/cgroup-util.c
@@ -1594,6 +1594,8 @@ int cg_set_attribute(const char *controller, const char *path, const char *attri
         _cleanup_free_ char *p = NULL;
         int r;
 
+        assert(attribute);
+
         r = cg_get_path(controller, path, attribute, &p);
         if (r < 0)
                 return r;
@@ -1605,6 +1607,8 @@ int cg_get_attribute(const char *controller, const char *path, const char *attri
         _cleanup_free_ char *p = NULL;
         int r;
 
+        assert(attribute);
+
         r = cg_get_path(controller, path, attribute, &p);
         if (r < 0)
                 return r;