From: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
Date: Fri, 19 Jan 2018 23:57:51 +0000 (+0100)
Subject: recursor: abort when unused arguments remain
X-Git-Tag: dnsdist-1.3.0~138^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F6210%2Fhead;p=thirdparty%2Fpdns.git

recursor: abort when unused arguments remain

Copied this over from receiver.cc, as @ahupowerdns pointed out that Auth handles this.
---

diff --git a/pdns/pdns_recursor.cc b/pdns/pdns_recursor.cc
index d96a64be97..63b3db1a30 100644
--- a/pdns/pdns_recursor.cc
+++ b/pdns/pdns_recursor.cc
@@ -3435,6 +3435,11 @@ int main(int argc, char **argv)
     }
     cleanSlashes(configname);
 
+    if(!::arg().getCommands().empty()) {
+      cerr<<"Fatal: non-option on the command line, perhaps a '--setting=123' statement missed the '='?"<<endl;
+      exit(99);
+    }
+
     if(::arg().mustDo("config")) {
       cout<<::arg().configstring()<<endl;
       exit(0);