From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Mon, 19 Mar 2018 08:41:38 +0000 (+0100)
Subject: dnsdist: Fix 'unreachable code' warnings reported by SonarCloud
X-Git-Tag: dnsdist-1.3.0~43^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F6364%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Fix 'unreachable code' warnings reported by SonarCloud
---

diff --git a/pdns/dnsdist-snmp.cc b/pdns/dnsdist-snmp.cc
index 4d3adf51a5..90cad68731 100644
--- a/pdns/dnsdist-snmp.cc
+++ b/pdns/dnsdist-snmp.cc
@@ -404,8 +404,9 @@ bool DNSDistSNMPAgent::sendBackendStatusChangeTrap(const std::shared_ptr<Downstr
                             backendStatus.size());
 
   return sendTrap(d_trapPipe[1], varList);
-#endif /* HAVE_NET_SNMP */
+#else
   return true;
+#endif /* HAVE_NET_SNMP */
 }
 
 bool DNSDistSNMPAgent::sendCustomTrap(const std::string& reason)
@@ -428,8 +429,9 @@ bool DNSDistSNMPAgent::sendCustomTrap(const std::string& reason)
                             reason.size());
 
   return sendTrap(d_trapPipe[1], varList);
-#endif /* HAVE_NET_SNMP */
+#else
   return true;
+#endif /* HAVE_NET_SNMP */
 }
 
 bool DNSDistSNMPAgent::sendDNSTrap(const DNSQuestion& dq, const std::string& reason)
@@ -533,8 +535,9 @@ bool DNSDistSNMPAgent::sendDNSTrap(const DNSQuestion& dq, const std::string& rea
                             reason.size());
 
   return sendTrap(d_trapPipe[1], varList);
-#endif /* HAVE_NET_SNMP */
+#else
   return true;
+#endif /* HAVE_NET_SNMP */
 }
 
 DNSDistSNMPAgent::DNSDistSNMPAgent(const std::string& name, const std::string& masterSocket): SNMPAgent(name, masterSocket)
diff --git a/pdns/misc.cc b/pdns/misc.cc
index 92d173f6a9..b4c6d5cf8b 100644
--- a/pdns/misc.cc
+++ b/pdns/misc.cc
@@ -1058,8 +1058,9 @@ bool setSocketTimestamps(int fd)
 #ifdef SO_TIMESTAMP
   int on=1;
   return setsockopt(fd, SOL_SOCKET, SO_TIMESTAMP, (char*)&on, sizeof(on)) == 0;
-#endif
+#else
   return true; // we pretend this happened.
+#endif
 }
 
 bool setTCPNoDelay(int sock)
@@ -1402,6 +1403,7 @@ int mapThreadToCPUList(pthread_t tid, const std::set<int>& cpus)
                                 sizeof(cpuset),
                                 &cpuset);
 #  endif
-#endif /* HAVE_PTHREAD_SETAFFINITY_NP */
+#else
   return ENOSYS;
+#endif /* HAVE_PTHREAD_SETAFFINITY_NP */
 }