From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Thu, 23 Aug 2018 15:23:18 +0000 (+0200)
Subject: dnsdist: Fix a sign-comparison warning in isEDNSOptionInOpt()
X-Git-Tag: dnsdist-1.3.3~139^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F6877%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Fix a sign-comparison warning in isEDNSOptionInOpt()
---

diff --git a/pdns/dnsdist-ecs.cc b/pdns/dnsdist-ecs.cc
index ff40bd8662..1d35a84288 100644
--- a/pdns/dnsdist-ecs.cc
+++ b/pdns/dnsdist-ecs.cc
@@ -437,7 +437,7 @@ bool isEDNSOptionInOpt(const std::string& packet, const size_t optStart, const s
   size_t p = optStart + 9;
   uint16_t rdLen = (0x100*packet.at(p) + packet.at(p+1));
   p += sizeof(rdLen);
-  if (11 + rdLen > optLen) {
+  if (rdLen > (optLen - 11)) {
     return false;
   }