From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Sat, 13 Oct 2018 08:44:40 +0000 (+0200)
Subject: dnsdist: Remove potential double-free in GnuTLS session tickets error handling
X-Git-Tag: dnsdist-1.3.3~43^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F7060%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Remove potential double-free in GnuTLS session tickets error handling
---

diff --git a/pdns/dnsdistdist/tcpiohandler.cc b/pdns/dnsdistdist/tcpiohandler.cc
index bb9331c019..eb05d81e61 100644
--- a/pdns/dnsdistdist/tcpiohandler.cc
+++ b/pdns/dnsdistdist/tcpiohandler.cc
@@ -636,8 +636,6 @@ public:
 
       if (file.fail()) {
         file.close();
-        safe_memory_release(d_key.data, d_key.size);
-        gnutls_free(d_key.data);
         throw std::runtime_error("Invalid GnuTLS tickets key file " + keyFile);
       }