From: Rafael Buchbinder <r-bk@users.noreply.github.com>
Date: Tue, 16 Oct 2018 12:39:20 +0000 (+0300)
Subject: pdns-recursor: avoid a memory leak in catch-all exception handler
X-Git-Tag: dnsdist-1.3.3~40^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F7070%2Fhead;p=thirdparty%2Fpdns.git

pdns-recursor: avoid a memory leak in catch-all exception handler

This commit prevents a leak of DNSComboWriter in the catch-all exception
handler.
---

diff --git a/pdns/pdns_recursor.cc b/pdns/pdns_recursor.cc
index 3c7ec0ee31..f537f62d29 100644
--- a/pdns/pdns_recursor.cc
+++ b/pdns/pdns_recursor.cc
@@ -1590,6 +1590,7 @@ static void startDoResolve(void *p)
   }
   catch(...) {
     g_log<<Logger::Error<<"Any other exception in a resolver context "<< makeLoginfo(dc) <<endl;
+    delete dc;
   }
 
   g_stats.maxMThreadStackUsage = max(MT->getMaxStackUsage(), g_stats.maxMThreadStackUsage);