From: Rafael Buchbinder <r-bk@users.noreply.github.com>
Date: Tue, 16 Oct 2018 12:39:20 +0000 (+0300)
Subject: pdns-recursor: avoid a memory leak in catch-all exception handler
X-Git-Tag: rec-4.1.5~4^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F7073%2Fhead;p=thirdparty%2Fpdns.git

pdns-recursor: avoid a memory leak in catch-all exception handler

This commit prevents a leak of DNSComboWriter in the catch-all exception
handler.

(cherry picked from commit cbb097d8581dbb27d81be3a3022a96b8ad08e295)
---

diff --git a/pdns/pdns_recursor.cc b/pdns/pdns_recursor.cc
index 43601c2f3f..f2ac9dd2a0 100644
--- a/pdns/pdns_recursor.cc
+++ b/pdns/pdns_recursor.cc
@@ -1344,6 +1344,7 @@ static void startDoResolve(void *p)
   }
   catch(...) {
     L<<Logger::Error<<"Any other exception in a resolver context "<< makeLoginfo(dc) <<endl;
+    delete dc;
   }
 
   g_stats.maxMThreadStackUsage = max(MT->getMaxStackUsage(), g_stats.maxMThreadStackUsage);