From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Tue, 23 Apr 2019 13:02:56 +0000 (+0200)
Subject: dnsdist: remove maxEntries from newPacketCache opts
X-Git-Tag: dnsdist-1.4.0-alpha2~5^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F7741%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: remove maxEntries from newPacketCache opts

maxEntries is already a mandatory parameter for `newPacketCache`.
---

diff --git a/pdns/dnsdist-lua-bindings.cc b/pdns/dnsdist-lua-bindings.cc
index b29fc3edf3..64b48b6c58 100644
--- a/pdns/dnsdist-lua-bindings.cc
+++ b/pdns/dnsdist-lua-bindings.cc
@@ -275,10 +275,6 @@ void setupLuaBindings(bool client)
           keepStaleData = boost::get<bool>((*vars)["keepStaleData"]);
         }
 
-        if (vars->count("maxEntries")) {
-          maxEntries = boost::get<size_t>((*vars)["maxEntries"]);
-        }
-
         if (vars->count("maxNegativeTTL")) {
           maxNegativeTTL = boost::get<size_t>((*vars)["maxNegativeTTL"]);
         }
diff --git a/pdns/dnsdistdist/docs/reference/config.rst b/pdns/dnsdistdist/docs/reference/config.rst
index b51b01ba9e..e81b706b72 100644
--- a/pdns/dnsdistdist/docs/reference/config.rst
+++ b/pdns/dnsdistdist/docs/reference/config.rst
@@ -614,7 +614,6 @@ See :doc:`../guides/cache` for a how to.
   * ``deferrableInsertLock=true``: bool - Whether the cache should give up insertion if the lock is held by another thread, or simply wait to get the lock.
   * ``dontAge=false``: bool - Don't reduce TTLs when serving from the cache. Use this when :program:`dnsdist` fronts a cluster of authoritative servers.
   * ``keepStaleData=false``: bool - Whether to suspend the removal of expired entries from the cache when there is no backend available in at least one of the pools using this cache.
-  * ``maxEntries``: int - The maximum number of entries in this cache.
   * ``maxNegativeTTL=3600``: int - Cache a NXDomain or NoData answer from the backend for at most this amount of seconds, even if the TTL of the SOA record is higher.
   * ``maxTTL=86400``: int - Cap the TTL for records to his number.
   * ``minTTL=0``: int - Don't cache entries with a TTL lower than this.