From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Wed, 17 Jul 2019 08:24:55 +0000 (+0200)
Subject: dnsdist: Drop the response if the IDState has been reused under our feet
X-Git-Tag: dnsdist-1.4.0-rc1~38^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F7927%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Drop the response if the IDState has been reused under our feet
---

diff --git a/pdns/dnsdist.cc b/pdns/dnsdist.cc
index 244b3ba543..bb35f68047 100644
--- a/pdns/dnsdist.cc
+++ b/pdns/dnsdist.cc
@@ -586,6 +586,9 @@ try {
         } else {
           /* someone updated the state in the meantime, we can't touch the existing pointer */
           du = nullptr;
+          /* since the state has been updated, we can't safely access it so let's just drop
+             this response */
+          continue;
         }
 
         if(dh->tc && g_truncateTC) {