From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Mon, 22 Jul 2019 13:13:33 +0000 (+0200)
Subject: dnsdist: Fix a UnicodeDecodeError with py2 in the regression tests
X-Git-Tag: dnsdist-1.4.0-rc1~27^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F8116%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Fix a UnicodeDecodeError with py2 in the regression tests
---

diff --git a/regression-tests.dnsdist/test_BrokenAnswer.py b/regression-tests.dnsdist/test_BrokenAnswer.py
index a706dfa7e4..78bd713358 100644
--- a/regression-tests.dnsdist/test_BrokenAnswer.py
+++ b/regression-tests.dnsdist/test_BrokenAnswer.py
@@ -25,7 +25,7 @@ def responseCallback(request):
     raw = response.to_wire()
     # first label length of this rrset is at 12 (dnsheader) + length(qname) + 2 (leading label length + trailing 0) + 2 (qtype) + 2 (qclass)
     offset = 12 + len(str(request.question[0].name)) + 2 + 2 + 2
-    altered = raw[:offset] + chr(255).encode() + raw[offset+1:]
+    altered = raw[:offset] + b'\xff' + raw[offset+1:]
     return altered
 
 class TestBrokenAnswerECS(DNSDistTest):