From: Aki Tuomi <cmouse@desteem.org>
Date: Tue, 28 May 2013 11:46:42 +0000 (+0300)
Subject: Added warning if trailing dot is used.
X-Git-Tag: auth-3.3-rc2~66^2^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F834%2Fhead;p=thirdparty%2Fpdns.git

Added warning if trailing dot is used.
---

diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index 549cac397e..5ac1645682 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -1372,7 +1372,12 @@ DNSPacket *PacketHandler::questionOrRecurse(DNSPacket *p, bool *shouldRecurse)
       DLOG(L<<"Have unauth data, so need to hunt for best NS records"<<endl);
       if(tryReferral(p, r, sd, target))
         goto sendit;
-      L<<Logger::Error<<"Should not get here ("<<p->qdomain<<"|"<<p->qtype.getCode()<<"): please run pdnssec rectify-zone "<<sd.qname<<endl;
+      // check whether this could be fixed easily
+      if (*(rr.qname.rbegin()) == '.') {
+           L<<Logger::Error<<"Should not get here ("<<p->qdomain<<"|"<<p->qtype.getCode()<<"): you have a trailing dot, this could be the problem (or run pdnssec rectify-zone " <<sd.qname<<")"<<endl;
+      } else {
+           L<<Logger::Error<<"Should not get here ("<<p->qdomain<<"|"<<p->qtype.getCode()<<"): please run pdnssec rectify-zone "<<sd.qname<<endl;
+      }
     }
     else {
       DLOG(L<<"Have some data, but not the right data"<<endl);