From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Wed, 2 Oct 2019 09:14:50 +0000 (+0200)
Subject: dnsdist: Also lowercase custom DoH header names for early responses
X-Git-Tag: dnsdist-1.4.0-rc4~50^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F8365%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Also lowercase custom DoH header names for early responses
---

diff --git a/pdns/dnsdist-lua-bindings.cc b/pdns/dnsdist-lua-bindings.cc
index efa8d94b7b..6a01adf1fc 100644
--- a/pdns/dnsdist-lua-bindings.cc
+++ b/pdns/dnsdist-lua-bindings.cc
@@ -374,7 +374,7 @@ void setupLuaBindings(bool client)
     if (customHeaders) {
       headers = std::vector<std::pair<std::string, std::string>>();
       for (const auto& header : *customHeaders) {
-        headers->push_back({ header.first, header.second });
+        headers->push_back({ boost::to_lower_copy(header.first), header.second });
       }
     }
     return std::make_shared<DOHResponseMapEntry>(regex, status, content, headers);
diff --git a/regression-tests.dnsdist/test_DOH.py b/regression-tests.dnsdist/test_DOH.py
index 4bd0089e67..bee0c29fc2 100644
--- a/regression-tests.dnsdist/test_DOH.py
+++ b/regression-tests.dnsdist/test_DOH.py
@@ -152,7 +152,7 @@ class TestDOH(DNSDistDOHTest):
 
     addDOHLocal("127.0.0.1:%s", "%s", "%s", { "/" }, {customResponseHeaders={["access-control-allow-origin"]="*",["user-agent"]="derp",["UPPERCASE"]="VaLuE"}})
     dohFE = getDOHFrontend(0)
-    dohFE:setResponsesMap({newDOHResponseMapEntry('^/coffee$', 418, 'C0FFEE', {['foo']='bar'})})
+    dohFE:setResponsesMap({newDOHResponseMapEntry('^/coffee$', 418, 'C0FFEE', {['FoO']='bar'})})
 
     addAction("drop.doh.tests.powerdns.com.", DropAction())
     addAction("refused.doh.tests.powerdns.com.", RCodeAction(DNSRCode.REFUSED))