From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Thu, 28 Nov 2019 10:39:51 +0000 (+0100)
Subject: dnsdist: Wait longer for the TLS ticket to arrive in our tests
X-Git-Tag: auth-4.3.0-alpha1~15^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F8591%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Wait longer for the TLS ticket to arrive in our tests

In TLS 1.3 the server sends the TLS ticket after the handshake has
been completed, but not necessarily right after that.
Ideally we would like to wait for up to several seconds, but stop
waiting as soon as we receive a ticket. Unfortunately we can't ask
that from `openssl s_client`, and we are currently not always waiting
long enough to get a ticket, leading to spurious failures.
Let's try waiting a bit longer to see if that helps.
---

diff --git a/regression-tests.dnsdist/test_TLSSessionResumption.py b/regression-tests.dnsdist/test_TLSSessionResumption.py
index 190a32af6d..4f9dfd6194 100644
--- a/regression-tests.dnsdist/test_TLSSessionResumption.py
+++ b/regression-tests.dnsdist/test_TLSSessionResumption.py
@@ -32,7 +32,7 @@ class DNSDistTLSSessionResumptionTest(DNSDistTest):
         try:
             process = subprocess.Popen(testcmd, stdout=subprocess.PIPE, stdin=subprocess.PIPE, stderr=subprocess.STDOUT, close_fds=True)
             # we need to wait just a bit so that the Post-Handshake New Session Ticket has the time to arrive..
-            time.sleep(0.1)
+            time.sleep(0.5)
             output = process.communicate(input=b'')
         except subprocess.CalledProcessError as exc:
             raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, process.output))