From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Wed, 29 Jan 2020 14:41:45 +0000 (+0100)
Subject: Remove the empty user-defined destructor of DNSResourceRecord
X-Git-Tag: auth-4.3.0-beta2~51^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F8763%2Fhead;p=thirdparty%2Fpdns.git

Remove the empty user-defined destructor of DNSResourceRecord

Having a user-defined destructor prevents the compiler from generating
implicit definition of the move constructor and the move assignment
operator, which might have a serious performance impact.
---

diff --git a/pdns/dns.hh b/pdns/dns.hh
index adc8536dbe..8a138476cb 100644
--- a/pdns/dns.hh
+++ b/pdns/dns.hh
@@ -82,7 +82,6 @@ class DNSResourceRecord
 {
 public:
   DNSResourceRecord() : last_modified(0), ttl(0), signttl(0), domain_id(-1), qclass(1), scopeMask(0), auth(1), disabled(0) {};
-  ~DNSResourceRecord(){};
   static DNSResourceRecord fromWire(const DNSRecord& d);
 
   enum Place : uint8_t {QUESTION=0, ANSWER=1, AUTHORITY=2, ADDITIONAL=3}; //!< Type describing the positioning within, say, a DNSPacket