From: Ruben d'Arco <cyclops@prof-x.net>
Date: Mon, 29 Jul 2013 20:17:33 +0000 (+0200)
Subject: output warning message when no to be notified NS's are found
X-Git-Tag: rec-3.6.0-rc1~536^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F928%2Fhead;p=thirdparty%2Fpdns.git

output warning message when no to be notified NS's are found

fixes #926
---

diff --git a/pdns/mastercommunicator.cc b/pdns/mastercommunicator.cc
index c8cf3dbf28..2c1e80762d 100644
--- a/pdns/mastercommunicator.cc
+++ b/pdns/mastercommunicator.cc
@@ -39,6 +39,7 @@
 
 void CommunicatorClass::queueNotifyDomain(const string &domain, DNSBackend *B)
 {
+  bool hasQueuedItem=false;
   set<string> ips;
   FindNS fns;
   
@@ -60,6 +61,7 @@ void CommunicatorClass::queueNotifyDomain(const string &domain, DNSBackend *B)
   for(set<string>::const_iterator j=ips.begin();j!=ips.end();++j) {
     L<<Logger::Warning<<"Queued notification of domain '"<<domain<<"' to "<<*j<<endl;
     d_nq.add(domain,*j);
+    hasQueuedItem=true;
   }
   set<string>alsoNotify;
   B->alsoNotifies(domain, &alsoNotify);
@@ -67,7 +69,11 @@ void CommunicatorClass::queueNotifyDomain(const string &domain, DNSBackend *B)
   for(set<string>::const_iterator j=alsoNotify.begin();j!=alsoNotify.end();++j) {
     L<<Logger::Warning<<"Queued also-notification of domain '"<<domain<<"' to "<<*j<<endl;
     d_nq.add(domain,*j);
+    hasQueuedItem=true;
   }
+  if (!hasQueuedItem)
+    L<<Logger::Warning<<"Request to queue notification for domain '"<<domain<<"' was processed, but no nameservers or also-notify's found. Not notifying!"<<endl;
+
 }
 
 bool CommunicatorClass::notifyDomain(const string &domain)