From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Thu, 19 Nov 2020 11:27:53 +0000 (+0100)
Subject: auth: Don't steal resources from additional records
X-Git-Tag: auth-4.5.0-alpha0~19^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F9749%2Fhead;p=thirdparty%2Fpdns.git

auth: Don't steal resources from additional records
---

diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index c4ce0d8d1f..909581c0e1 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -504,13 +504,13 @@ void PacketHandler::doAdditionalProcessing(DNSPacket& p, std::unique_ptr<DNSPack
     if(rr.dr.d_place != DNSResourceRecord::ADDITIONAL) {
       switch(rr.dr.d_type) {
         case QType::NS:
-          content=std::move(getRR<NSRecordContent>(rr.dr)->getNS());
+          content=getRR<NSRecordContent>(rr.dr)->getNS();
           break;
         case QType::MX:
-          content=std::move(getRR<MXRecordContent>(rr.dr)->d_mxname);
+          content=getRR<MXRecordContent>(rr.dr)->d_mxname;
           break;
         case QType::SRV:
-          content=std::move(getRR<SRVRecordContent>(rr.dr)->d_target);
+          content=getRR<SRVRecordContent>(rr.dr)->d_target;
           break;
         case QType::SVCB: {
           auto rrc = getRR<SVCBRecordContent>(rr.dr);