From: Christian Hofstaedtler <christian@hofstaedtler.name>
Date: Wed, 28 Aug 2013 18:23:45 +0000 (+0200)
Subject: rfc2136handler: Close socket when write fails
X-Git-Tag: rec-3.6.0-rc1~479^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F978%2Fhead;p=thirdparty%2Fpdns.git

rfc2136handler: Close socket when write fails

Fix for Coverity CID 1066217.
---

diff --git a/pdns/rfc2136handler.cc b/pdns/rfc2136handler.cc
index ae2fe7e4b8..4e3d116732 100644
--- a/pdns/rfc2136handler.cc
+++ b/pdns/rfc2136handler.cc
@@ -611,6 +611,7 @@ int PacketHandler::forwardPacket(const string &msgPrefix, DNSPacket *p, DomainIn
     buffer.append(forwardPacket.getString());
     if(write(sock, buffer.c_str(), buffer.length()) < 0) {
       L<<Logger::Error<<msgPrefix<<"Unable to forward update message to "<<remote.toStringWithPort()<<", error:"<<stringerror()<<endl;
+      Utility::closesocket(sock);
       continue;
     }