From: Gary Lockyer Date: Thu, 31 Jul 2025 19:58:52 +0000 (+1200) Subject: librpc:ndr:keycredlink fix CID 1660828 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fremotes%2Fgitlab%2Fmaster;p=thirdparty%2Fsamba.git librpc:ndr:keycredlink fix CID 1660828 Fixes: *** CID 1660828: Control flow issues (UNREACHABLE) /librpc/ndr/ndr_keycredlink.c: 752 in pull_DER_RSA_KEY() 746 goto out; 747 } 748 if (!asn1_end_tag(asn)) { /* PublicKeyInfo */ 749 return ndr_pull_error(ndr, 750 NDR_ERR_UNREAD_BYTES, 751 "ASN1 element PublicKeyInfo"); >>> CID 1660828: Control flow issues (UNREACHABLE) >>> This code cannot be reached: "goto out;". 752 goto out; 753 } Signed-off-by: Gary Lockyer Reviewed-by: Douglas Bagnall Reviewed-by: Anoop C S Autobuild-User(master): Anoop C S Autobuild-Date(master): Fri Aug 1 14:21:17 UTC 2025 on atb-devel-224 --- diff --git a/librpc/ndr/ndr_keycredlink.c b/librpc/ndr/ndr_keycredlink.c index 2222e3bf666..286236060c4 100644 --- a/librpc/ndr/ndr_keycredlink.c +++ b/librpc/ndr/ndr_keycredlink.c @@ -746,9 +746,9 @@ static enum ndr_err_code pull_DER_RSA_KEY(struct ndr_pull *ndr, goto out; } if (!asn1_end_tag(asn)) { /* PublicKeyInfo */ - return ndr_pull_error(ndr, - NDR_ERR_UNREAD_BYTES, - "ASN1 element PublicKeyInfo"); + ret = ndr_pull_error(ndr, + NDR_ERR_UNREAD_BYTES, + "ASN1 element PublicKeyInfo"); goto out; }