python: Allow passing a confirm callback from Python

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

python: Add a basic Transaction class

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

transaction: Remove unused flags

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

db: Fail graciously when we could not open the database

This mainly changes the return code and does some minor code cleanups

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

po: Update translations

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Add yet another kind of GitHub URL

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

arch: Don't use TLS to store the utsname struct

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Ignore cgroups if they are not fully functional

This is an experimental change to see how this will all turn out on
Jenkins.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Fix printing erros when repos config could not be written

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Fix makefile tests

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

repo: Fix writing configuration

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Make it less verbose

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Log less when creating/freeing a jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jenkins: Move the asan logs to the root

Because otherwise I am too stupid to find them.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Avoid leaking memory in parser tests

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jenkins: Upload asan logs only when tests have failed

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Dump the current status less often

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfopen: Include limits.h

We need this for ULONG_MAX.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Have pakfire_string_format_interval write to a preallocated buffer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jenkins: Use multiple CPU cores for the static analyzer & LCOV

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jenkins: Run the testsuite with address sanitization

There are still some things that are broken (Python), so for now, we
won't care if this fails.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Let the compiler figure out what to link for ASAN

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

CLI: Refactor progressbar to use statically allocated buffers

This might take a little bit of pressure off the allocator and we don't
have to deal with asprintf() loosing memory.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

transactions: Free the job queue

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshots: Be less verbose when destroying a snapshot

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Fix buffer overrun when reading the scriptlet

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

asan: Use libunwind for better stack traces

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Remove various smaller memory "leaks"

There are not critical because the test suite does not run for very
long.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Free the timeout timer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Use the reference to the loop that we already have

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Refactor making the filelist

There seems to have been a leak when initializing the string, so we
format it on the stack first and then copy it to the heap later.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Add function to add formatted strings to a buffer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

log buffer: Free all held lines when freeing the buffer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

db: Ensure to free the deps list after each iteration

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Build with debugging information when using asan

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Add option to enable the address sanitizer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jenkins: Remove any traces for Almalinux

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jenkins: Use more modern command line to install dev tools on Fedora

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Ignore comments regardless what state the scanner is in

Fixes: #13363 - A comment character anywhere in the build or packages section causes the build to fail
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dist: Fix return codes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Properly handle yyparse() return codes

This patch converts them into our usual errno codes.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jenkins: Strictly name releases

For Ubuntu, latest points at the latest LTS release, which is not what I
expected. To avoid any confusion, let's name the releases that we want
to support by their number or code name.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jenkins: Add Ubuntu latest for the tests

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Run setuid/gid mapping even when we are running in /

Since we always create a new namespace, we need to always run this, too.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ctx: Remove another hard-coded configuration path

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Bump version to 0.9.30

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Permit to uninstall or downgrade packages in installcheck

Whenever we have a snapshot loaded, the solver might want to have a
little bit more liberty to find a solution. As we give it that liberty
later, we should not let the install check become a barrier.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Fix path of default configuration file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Compile everything with -std=gnu17

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire: Log everything to the console by default

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Makefile: Ship i18n.h

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Fix check for BUILDROOT

The actual variable was not reachable which is changed in this patch.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

PTY: Automatically connect stdout/stderr in some cases

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

PTY: Connect stdout/stderr to /dev/null unless something else was requested

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Reformat arguments for systemd-sysusers

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Make the systemd sysusers filter logic slightly more obvious

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packages: Always check if the file size matches

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

OCI: Initialize size

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Don't fail if we could not parse some DWARF information

This is in line with what has been recommended from upstream.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

PTY: Increase maximum line length to 16k

Some compiler command lines massively exceed the 4k, so let's try with
something much larger.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive writer: Don't use --long for Zstandard

This seems to be too complicated and there is too little value in it.
Packages cannot be uncompressed using the zstd command without enabling
long mode, too. libarchive requires the same which is also not
implemented.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Use assert() to make the static analyzer happy

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Skip all ELF checks for relocatable objects

This is a little bit more accurate than checking for the file extension.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

config: Drop unused function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Add a GitHub URL macro for tags (instead of releases)

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Add helpers to make GitHub URLs

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Dump all information about the source package

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packages: Return the actual error when we fail to open an archive

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Print debug messages as well

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packages: Use the new path function to find the package

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Improve error message if the URL could not be put together

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Improve our user agent

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Show a message if we are running out of mirrors

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Skip linting any object files

We seem to only have very few of these, but this might be easier than
keeping any kind of whitelist.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive writer: Don't compress in parallel

There is almost no speed benefit here because most packages are rather
small so that Zstandard does not fan out. The result will however be a
couple of percent larger which is something we don't want.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packager: Compress source archives less

There is no reason to try to compress the compressed tarballs again.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pty: Connect stdin to /dev/null when not connected

We don't want to run an interactive console and nothing should think
that we are.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pty: Close the file descriptor of the console

This file descriptor was otherwise just leaked.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

daemon: Use macros to make time deltas easier to understand

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

log file: Never write any debug stuff to the file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

daemon: Don't remove the stats timer

We used to free the stats timer whenever the daemon lost the connection
to the build service. Although that should be supported, it could make
the event loop abort because of some unexpected conditions.

This patch simply allocates the timer once and we just arm and disarm it
as needed.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Fix adding Python ABI dependencies

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Remove unused variable

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pty: Move filtering escape characters to the PTY

This is probably the place where this should live. We are now processing
cursor positioning events inside the same line and we are filtering out
any escape sequences that we don't know.

It is a bit sad to lose the colors, but I don't have to have two places
where we process this. At least this is going to be more robust and we
can be sure to not forward anything malicious to the controlling
terminal.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

log file: Try to process any ANSI escape sequences

This is a rather basic implementation and it has the problem that it
erases the entire timestamp on carriage return, too.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Add CLI switch to write the build log to file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfopen: Don't set errno when we don't fail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Ensure that we will always send the entire message before starting the next one

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfopen: Add more tests for invalid inputs

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

string: Fix error handling for strftime functions

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Remove an unused variable

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

json: Remove superfluous semicolon

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Refactor formatting time

The previous function was generating wrong outputs, and strtime() should
be used for timestamps instead of deltas.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Don't warn if an address always evaluates

We have a couple of statically allocate strings that will trigger some
checks in the macros which is annoying.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: string: Fail with a clear error code on invalid input

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests/string.c: add test function for time formatting

Signed-off-by: Rico Hoppe <rico.hoppe@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

json: Add string formatting attribute

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

oci: Add some missing metadata

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

json: Add function to add formatted strings to an array

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

OCI: Add an entrypoint to the image

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>