pmderodat [Tue, 29 May 2018 09:42:34 +0000 (09:42 +0000)]
[Ada] Wrong equality on untagged private type
When a private type declaration T1 is completed with a derivation of an
untagged private type that overrides the predefined equality primitive, and the
full view of T2 is a derivation of another private type T2 whose full view is a
tagged type, the compiler may generate code that references the wrong equality
primitive when processing comparisons of objects of type T1.
2018-05-29 Javier Miranda <miranda@adacore.com>
gcc/ada/
* exp_ch4.adb (Expand_N_Op_Eq, Expand_Composite_Equality): Use the new
subprogram Inherits_From_Tagged_Full_View to identify more reliably
untagged private types completed with a derivation of an untagged
private whose full view is a tagged type.
* sem_util.ads, sem_util.adb (Inherits_From_Tagged_Full_View): New
subprogram.
(Collect_Primitive_Operations): Handle untagged private types completed
with a derivation of an untagged private type whose full view is a
tagged type. In such case, collecting the list of primitives we may
find two equality primitives: one associated with the untagged private
and another associated with the ultimate tagged type (and we must
remove from the returned list this latter one).
pmderodat [Tue, 29 May 2018 09:42:16 +0000 (09:42 +0000)]
[Ada] Plug small hole in -gnatR output
The -gnatR switch outputs representation information for locally-defined
types but it was skipping those defined in blocks without label, unlike
those defined in named blocks. This change plugs this small hole.
The following procedure:
procedure P is
begin
declare
type R is record
I : Integer;
end record;
begin
null;
end;
end;
must now generate the following output with -gnatR:
Representation information for unit P (body)
--------------------------------------------
for B_1.R'Size use 32;
for B_1.R'Alignment use 4;
for B_1.R use record
I at 0 range 0 .. 31;
end record;
2018-05-29 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* repinfo.adb (List_Entities): Also recurse into blocks without label.
pmderodat [Tue, 29 May 2018 09:42:11 +0000 (09:42 +0000)]
[Ada] Unnesting: do not generate push/pop for exceptions
2018-05-29 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_ch6.adb (Expand_N_Subprogram_Body): Do not generate push/pop for
exceptions if subprogram unnesting is in effect, because these branch
nodes are relevant only in the presence of nested subprograms.
pmderodat [Tue, 29 May 2018 09:42:05 +0000 (09:42 +0000)]
[Ada] Improper behavior of floating-point attributes
This patch fixes an error in the handling of attributes Pred qnd Succ when
applied to the limit values of a floating-point type. The RM mandates that
such operations must raise constraint_error, but GNAT generated in most cases
an infinite value, regardless of whether overflow checks were enabled.
2018-05-29 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* libgnat/s-fatgen.adb (Succ, Pred): Raise Constraint_Error
unconditionally when applied to the largest positive (resp. largest
negative) value of a floating-point type.
gcc/testsuite/
* gnat.dg/float_attributes_overflows.adb: New testcase.
pmderodat [Tue, 29 May 2018 09:41:59 +0000 (09:41 +0000)]
[Ada] Clarify use of Activation_Record_Component
2018-05-29 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* einfo.ads, einfo.adb: Clarify use of Activation_Record_Component:
discriminants and exceptions are never components of such. The flag
Needs_Activation_Record is set on subprogram types, not on access to
them.
pmderodat [Tue, 29 May 2018 09:41:45 +0000 (09:41 +0000)]
[Ada] Unnesting: exclude selected components whose prefix carry no type
2018-05-29 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_unst.adb (Visit_Node): Exclude selected components whose prefix
carry no type. Such selected components appear in unit names that are
child units, both in the specification and possibly in an end label for
the unit, and they do not contain any relevant uplevel references.
pmderodat [Tue, 29 May 2018 09:41:34 +0000 (09:41 +0000)]
[Ada] Add system-vxworks7 variants of system.ads files for Vx7
Based on the Vx6 versions, using a different link spec to accomodate VxWorks 7
specificities, in particular the ability in some configurations to rely on
.ctor sections to trigger constructors in kernel modules.
2018-05-29 Olivier Hainque <hainque@adacore.com>
gcc/ada/
* libgnat/system-vxworks7-ppc-rtp.ads: New file.
* libgnat/system-vxworks7-ppc-kernel.ads: New file.
* libgnat/system-vxworks7-e500-rtp.ads: New file.
* libgnat/system-vxworks7-e500-kernel.ads: New file.
* libgnat/system-vxworks7-x86-rtp.ads: New file.
* libgnat/system-vxworks-ppc64-kernel.ads: Rename as ...
* libgnat/system-vxworks7-ppc64-kernel.ads: and adjust name of
gnat-crtbe link spec to use the vx7 variant.
pmderodat [Tue, 29 May 2018 09:41:02 +0000 (09:41 +0000)]
[Ada] Tighten crtbegin files for VxWorks
Enforce a more explicit distinction of crtbegin objects holding
either functions with ctor/dtor attributes or _ctors/_dtors arrays,
or none of the two (no array, no attributes). Then allow/enforce
different linking strategies for VxWorks 7.
2018-05-29 Olivier Hainque <hainque@adacore.com>
gcc/ada/
* vx_crtbegin.inc: Use a consistent naming convention for the
registration/deregistration functions across RTP or kernel. Remove the
ctor/dtor attribute setting based on RTP/kernel, expect the optional
attribute extension to be provided by includers instead.
* vx_crtbegin.c: Mere inclusion of vx_crtbegin.inc with empty attribute
extension for the registration/deregistration functions.
* vx_crtbegin_attr.c: New file. Include vx_crtbegin.inc with explicit
constructor/destructor attribute extensions.
* vx_crtbegin_array.c: New file. Include vx_crtbegin.inc with empty
attribute extensions and declare _ctors/_dtors arrays.
* vx_crtbegin_auto.c: Remove.
* libgnat/system-vxworks7-aarch64-rtp-smp.ads: Use
vxworks7-gnat-crtbe-link.spec.
* libgnat/system-vxworks7-aarch64.ads: Likewise.
* libgnat/system-vxworks7-e500-rtp-smp.ads: Likewise.
* libgnat/system-vxworks7-ppc-rtp-smp.ads: Likewise.
* libgnat/system-vxworks7-ppc64-rtp-smp.ads: Likewise.
* libgnat/system-vxworks7-x86-kernel.ads: Likewise.
* libgnat/system-vxworks7-x86-rtp-smp.ads: Likewise.
* libgnat/system-vxworks7-x86_64-kernel.ads: Likewise.
* libgnat/system-vxworks7-x86_64-rtp-smp.ads: Likewise.
pmderodat [Tue, 29 May 2018 09:38:17 +0000 (09:38 +0000)]
[Ada] New function to return nanoseconds from Unix Epoch
2018-05-29 Doug Rupp <rupp@adacore.com>
gcc/ada/
* libgnat/a-calend.adb (Epoch_Offset): Move from body to ...
* libgnat/a-calend.ads (Epoch_Offset): to private part of spec
* libgnat/a-calcon.ads (To_Unix_Nano_Time): New function spec.
* libgnat/a-calcon.adb (To_Unix_Nano_Time): New function body.
pmderodat [Tue, 29 May 2018 09:37:43 +0000 (09:37 +0000)]
[Ada] Enhance output of discriminants with -gnatR in JSON mode
This arranges for the Discriminant_Number of discriminants to be output
by -gnatR in JSON mode. This number is referenced in symbolic expressions
present for offsets and sizes, so its definition is also required for the
sake of completeness.
2018-05-29 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* repinfo.ads (JSON format): Document new pair for components.
* repinfo.adb (Derived_Discriminant): New function.
(List_Structural_Record_Layout): Add Outer_Ent parameter and pass it
in recursive calls. If the record type is the parent of an extension,
find and list the derived discriminant from the extension, if any.
(List_Component_Layout): List the Discriminant_Number in JSON mode.
(List_Record_Info): Adjust call to List_Structural_Record_Layout.
pmderodat [Tue, 29 May 2018 09:36:51 +0000 (09:36 +0000)]
[Ada] Implement machine parsable format for -gnatR output
This adds a new variant to the -gnatR switch, namely -gnatRj, which causes
the compiler to output representation information to a file in the JSON
data interchange format. It can be combined with -gnatR0/1/2/3/m (but is
incompatible with -gnaRe and -gnatRs).
The information output in this mode is a superset of that output in the
traditional -gnatR mode, but is otherwise equivalent for the common part.
2018-05-29 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* doc/gnat_ugn/building_executable_programs_with_gnat.rst (Alphabetical
List of All Switches): Document -gnatRj.
(Debugging Control): Likewise.
* gnat_ugn.texi: Regenerate.
* opt.ads (List_Representation_Info_To_JSON): New boolean variable.
* osint-c.adb (Create_Repinfo_File): Use the .json instead of .rep
extension if List_Representation_Info_To_JSON is true.
* repinfo.ads: Document the JSON output format.
* repinfo.adb (List_Location): New procedure.
(List_Array_Info): Add support for JSON output.
(List_Entities): Likewise.
(Unop): Likewise.
(Binop): Likewise.
(Print_Expr): Likewise.
(List_Linker_Section): Likewise.
(List_Mechanisms): Likewise.
(List_Name): Likewise.
(List_Object_Info): Likewise.
(List_Record_Info): Likewise.
(List_Component_Layout): Likewise. Add Indent parameter.
(List_Structural_Record_Layout): New procedure.
(List_Attr): Add support for JSON output.
(List_Type_Info): Likewise.
(Write_Unknown_Val): Likewise.
* switch-c.adb (Scan_Front_End_Switches) <R>: Deal with 'j'.
* usage.adb (Usage): List -gnatRj.
pmderodat [Tue, 29 May 2018 09:34:47 +0000 (09:34 +0000)]
[Ada] Lib.Write: avoid use of System.Case_Util
2018-05-29 Arnaud Charlet <charlet@adacore.com>
gcc/ada/
* lib-writ.adb (Write_ALI): Do not use new function from s-casuti yet.
This breaks build of cross compilers with older versions of GNAT, so
better avoid it.
pmderodat [Tue, 29 May 2018 09:29:28 +0000 (09:29 +0000)]
[Ada] Fix irregular output with -gnatRm
The information displayed by -gnatRm was using slightly different naming
and formatting conventions than the rest of the -gnatR information with
no justification, so this adjusts it for the sake of consistency.
For the following package:
package P is
function F (I : Integer) return Integer;
type Rec is limited record
I : Integer;
end record;
procedure P1 (R : Rec; I : out Integer);
procedure P2 (R : Rec; I : out Integer);
pragma Linker_Section (P2, ".my_section");
package Inner is
procedure P3;
end Inner;
end P;
package body P is
function F (I : Integer) return Integer is
begin
return I;
end;
procedure P1 (R : Rec; I : out Integer) is
begin
I := R.I;
end;
procedure P2 (R : Rec; I : out Integer) is
begin
I := R.I;
end;
package body Inner is
procedure P3 is
begin
null;
end;
end Inner;
end P;
the output of -gnatRm must be:
Representation information for unit P (body)
--------------------------------------------
Representation information for unit P (spec)
--------------------------------------------
function F declared at p7.ads:3:12
convention : Ada
I : passed by copy
returns by copy
for Rec'Size use 32;
for Rec'Alignment use 4;
for Rec use record
I at 0 range 0 .. 31;
end record;
procedure P1 declared at p7.ads:9:13
convention : Ada
R : passed by reference
I : passed by copy
procedure P2 declared at p7.ads:11:13
convention : Ada
R : passed by reference
I : passed by copy
pragma Linker_Section (P2, ".my_section");
procedure Inner.P3 declared at p7.ads:16:15
convention : Ada
2018-05-29 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* repinfo.adb (List_Entities): Do not list the Linker_Section for
subprograms here...
(List_Mechanisms): ...but here instead. Use consistent name output
and formatting conventions.
pmderodat [Tue, 29 May 2018 09:28:59 +0000 (09:28 +0000)]
[Ada] Preliminary work to avoid full pathnames in ALI files
Normally, ALI files refer to source files using simple names. This allows files
to be moved around without disturbing things (causing extra recompilations,
etc). However, for configuration files, the full pathname is stored. This patch
preparates the code base to store the simple name in this case.
2018-05-29 Bob Duff <duff@adacore.com>
gcc/ada/
* lib-writ.adb (Write_ALI): Cleanup: avoid use of global var; call new
To_Lower function.
* libgnat/s-casuti.ads, libgnat/s-casuti.adb (To_Upper, To_Lower,
To_Mixed): New functions.
* osint.adb: Cleanup: use Is_Directory_Separator, which correctly
allows both '\' and '/' on Windows.
vries [Tue, 29 May 2018 07:08:23 +0000 (07:08 +0000)]
[testsuite] Use correct proc names in scanasm.exp
2018-05-29 Tom de Vries <tom@codesourcery.com>
* lib/scanasm.exp (scan-stack-usage, scan-stack-usage-not)
(scan-ada-spec, scan-ada-spec-not, scan-lto-assembler):
Use proc name as first argument to dg-scan.
mark [Mon, 28 May 2018 09:06:02 +0000 (09:06 +0000)]
DWARF: Handle expressions containing "-1" in dw2_asm_output_delta_uleb128.
In dwarf2out.c dwarf2out_var_location () we create loclabels that might
contain -1 (for example ".LVL5-1"). Technically those are expressions,
not just plain labels. But they work fine everywhere we use them, except
when calculating an uleb128 delta between two labels.
For example we might create the following DWARF5 location list entry:
.byte 0x3 # DW_LLE_startx_length (*.LLST0)
.uleb128 0x6 # Location list range start index (*.LVL5-1)
.uleb128 .LFE1-.LVL5-1 # Location list length (*.LLST0)
.uleb128 0x1 # Location expression size
.byte 0x54 # DW_OP_reg4
.byte 0 # DW_LLE_end_of_list (*.LLST0)
Note the length is calculated using .uleb128 .LFE1-.LVL5-1. This is
wrong, since both .LVL5 and 1 are substracted from .LFE1, instead of
1 being subtracted from .LVL5 first, before substracting from .LFE1.
This happens because dw2_asm_output_delta_uleb128 expects two plain
labels and simply inserts a minus sign between them. To fix this we
simply look if the second label is actually an expression containing
a minus sign and then add brackets around it. That will emit the
correct .uleb128 expression:
.uleb128 .LFE1-(.LVL5-1) # Location list length (*.LLST0)
We cannot simply generate the loclabel containing brackets directly
because we do use them also in contexts that don't take a full
expression (for example we use them with .quad too).
gcc/
* dwarf2asm.c (dw2_asm_output_delta_uleb128): Add brackets around
lab2 if it is an expression containing a minus sign.
pmderodat [Mon, 28 May 2018 08:56:08 +0000 (08:56 +0000)]
[Ada] Minor cleanup in repinfo unit
This removes the Truth_Andif_Expr and Truth_Orif_Expr codes for expressions
handled by the repinfo unit, since they are redundant with Truth_And_Expr
and Truth_Or_Expr respectively in this context. No functional changes.
2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* repinfo.ads (TCode): Adjust range.
(Truth_Andif_Expr): Remove.
(Truth_Orif_Expr): Likewise.
(Truth_And_Expr .. Dynamic_Val): Adjust value.
* repinfo.adb (Print_Expr): Remove handling of Truth_{And,Or}if_Expr.
(Rep_Value): Likewise.
* repinfo.h (Truth_Andif_Expr): Remove.
(Truth_Orif_Expr): Likewise.
(Truth_And_Expr .. Dynamic_Val): Adjust value.
* gcc-interface/decl.c (annotate_value) <TRUTH_ANDIF_EXPR>: Fall
through to TRUTH_AND_EXPR case.
<TRUTH_ORIF_EXPR>: Fall through to TRUTH_OR_EXPR case.
pmderodat [Mon, 28 May 2018 08:56:03 +0000 (08:56 +0000)]
[Ada] Unnesting: check index expressions for uplevel references
2018-05-28 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_unst.adb (Visit_Node): For indexed components and attribute
references, examine index expressions or associated expressions as well
to record uplevel references.
(Vist_Node): For function and procedure calls, if a formal is an
unconstrained array and the actual is constrained, check whether bounds
of actual have uplevel references.
pmderodat [Mon, 28 May 2018 08:55:57 +0000 (08:55 +0000)]
[Ada] Unnesting: allow uplevel references to exceptions
2018-05-28 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* einfo.ads, einfo.adb: Exceptions can be uplevel references, and thus
they can appear as components of activation records.
* exp_unst.adb (Visit_Node): A reference to an exception may be an
uplevel reference.
pmderodat [Mon, 28 May 2018 08:55:52 +0000 (08:55 +0000)]
[Ada] Fix internal error on renaming of equality for record type
This adjusts the previous change to the cases where the array type is not
yet frozen and, therefore, where Size_Depends_On_Discriminant is not yet
computed, by doing the computation manually.
2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_ch4.adb (Expand_Composite_Equality): Compute whether the size
depends on a discriminant manually instead of using the predicate
Size_Depends_On_Discriminant in the array type case.
gcc/testsuite/
* gnat.dg/renaming12.adb, gnat.dg/renaming12.ads: New testcase.
pmderodat [Mon, 28 May 2018 08:55:47 +0000 (08:55 +0000)]
[Ada] Improve unnesting for discriminants of record subtypes
2018-05-28 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_unst.adb (Check_Static_Type): For a record subtype, check
discriminant constraints as well.
(Visit_Node): For a selected component, check type of prefix, as is
done for indexed components and slices.
pmderodat [Mon, 28 May 2018 08:55:42 +0000 (08:55 +0000)]
[Ada] Fix regression of ACATS c46032a with CCG back end
2018-05-28 Javier Miranda <miranda@adacore.com>
gcc/ada/
* exp_ch4.adb (Real_Range_Check): Add a temporary to store the integer
value when converting a float value to a fixed-point value. This is
required for CCG because it handles fixed-point types by means of
unsigned integer type variables. The range check is now performed using
the integer value stored in this temporary.
pmderodat [Mon, 28 May 2018 08:55:35 +0000 (08:55 +0000)]
[Ada] Update FE check following change in SPARK RM 7.1.3(12)
SPARK Reference Manual changed to accept attributes First, Last and Length
as not leading to an evaluation of a part of the prefix object. This is
reflected here in the checking code for that rule.
2018-05-28 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_util.adb (Is_OK_Volatile_Context): Add attributes First, Last and
Length as valid non-interfering contexts for SPARK.
pmderodat [Mon, 28 May 2018 08:55:22 +0000 (08:55 +0000)]
[Ada] Allow for GNATprove specific versions of routines from Sem_Disp
2018-05-28 Claire Dross <dross@adacore.com>
gcc/ada/
* sem_disp.ads, sem_disp.adb (Inheritance_Utilities): Package for
generic inheritance utilities.
(Generic_Inherited_Subprograms): Generic version of
Inherited_Subprograms, generic in Find_Dispatching_Type function.
(Generic_Is_Overriding_Subprogram): Generic version of
Is_Overriding_Subprogram, generic in Find_Dispatching_Type function.
(Inherited_Subprograms): Instance of Generic_Inherited_Subprograms with
Sem_Disp.Find_Dispatching_Type.
(Is_Overriding_Subprogram): Instance of
Generic_Is_Overriding_Subprogram with Sem_Disp.Find_Dispatching_Type.
(Inheritance_Utilities_Inst): Instance of Inheritance_Utilities
with Sem_Disp.Find_Dispatching_Type.
pmderodat [Mon, 28 May 2018 08:54:55 +0000 (08:54 +0000)]
[Ada] Fix internal error on nested record types with representation clause
This fixes a long-standing issue with the expansion of equality functions
generated for discriminated record types with variant part. In this case
the front-end recursively expands equality functions for the composite
sub-components, in particular the array sub-components.
But it systematically uses the unconstrained base type for them, which leads
to both a more complex equality function, because of the need to compare
the bounds, and an additional unchecked conversion from type to base type.
Now this unchecked conversion may block a further expansion of the array
sub-component, for example if it is a large array of record types subject
to a component clause that causes it not to start on a byte boundary, and
thus may lead to an internal error downstream in the back-end.
2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_ch4.adb (Expand_Composite_Equality): For a composite (or FP)
component type, do not expand array equality using the unconstrained
base type, except for the case where the bounds of the type depend on a
discriminant.
gcc/testsuite/
* gnat.dg/rep_clause6.adb, gnat.dg/rep_clause6.ads: New testcase.
pmderodat [Mon, 28 May 2018 08:54:46 +0000 (08:54 +0000)]
[Ada] Introduce a new Needs_Activation_Record entity flag
2018-05-28 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* einfo.ads, einfo.adb (Needs_Activation_Record): New flag on
access-to-subprogram types, to indicate that an indirect call through
such a type requires an activation record when compiling for LLVM.
* sem_ch3.adb (Access_Subprogram_Declaration): Set new flag as needed.
pmderodat [Mon, 28 May 2018 08:54:41 +0000 (08:54 +0000)]
[Ada] Better accuracy in float-to-fixed conversions
This patch improves the accuracy of conversions from a floating point to
a fixed point type when the fixed point type has a specified Snall that is
not a power of two. Previously the conversion of Fixed_Point_Type'First to
some floating point number and back to Fixed_Point_Type raised Constraint
error. This result is within the accuracy imposed by tne Numerics annex of
the RM but is certainly undesirable. This patch transforms the conversion
to avoid extra manipulations of the 'Small of the type, so that the
identity:
Fixed_T (Float_T (Fixed_Val)) = Fixed_Val
holds over the range of Fixed_T.
2018-05-28 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_ch4.adb (Real_Range_Check): Specialize float-to-fixed conversions
when bounds of fixed type are static, to remove some spuerfluous
implicit conversions and provide an accurate result when converting
back and forth between the fixed point type and a floating point type.
pmderodat [Mon, 28 May 2018 08:54:27 +0000 (08:54 +0000)]
[Ada] Improve unnesting of indexed references
2018-05-28 Richard Kenner <kenner@vlsi1.ultra.nyu.edu>
gcc/ada/
* exp_unst.adb (Check_Static_Type): Add argument to indicate node to be
replaced, if any; all callers changed.
(Note_Uplevel_Ref): Likewise. Also replace reference to deferred
constant with private view so we take the address of that entity.
(Note_Uplevel_Bound): Add argument to indicate node to be replaced, if
any; all callers changed. Handle N_Indexed_Component like
N_Attribute_Reference. Add N_Type_Conversion case.
(Visit_Node): Indexed references can be uplevel if the type isn't
static.
(Unnest_Subprograms): Don't rewrite if no reference given. If call has
been relocated, set first_named pointer in original node as well.
pmderodat [Mon, 28 May 2018 08:54:18 +0000 (08:54 +0000)]
[Ada] Copy index expression trees rather than relocating them
2018-05-28 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_aggr.adb (Flatten): Copy tree of expression in a component
association with a range or a set of discrete choices, rather than
relocating the node. This avoids inconsistencies in the tree when
handling nested subprograms with uplevel references for LLVM.
pmderodat [Mon, 28 May 2018 08:53:54 +0000 (08:53 +0000)]
[Ada] Crash on aspect/pragma Linked_Section with -gnatR2
This patch modifies the output of the representation information related to
aspect or pragma Linker_Section, achieved with compiler switch -gnatR2. The
value of the section argument is now properly retrieved. Previously it was
assumed that the value is always a N_String_Literal, however the semantics
of the annotation allow for any static string expression, including a
reference to a static string.
pmderodat [Mon, 28 May 2018 08:53:49 +0000 (08:53 +0000)]
[Ada] Update user manual for the -D binder switch
2018-05-28 Patrick Bernardi <bernardi@adacore.com>
gcc/ada/
* doc/gnat_ugn/building_executable_programs_with_gnat.rst: Update the
description of the -D binder switch to reflect current usage.
* gnat_ugn.texi: Regenerate.
pmderodat [Mon, 28 May 2018 08:53:36 +0000 (08:53 +0000)]
[Ada] Spurious constraint error on array of null-excluding components
This patch fixes an issue whereby the compiler would raise spurious runtime
errors when an array of null-excluding components was initialized with an
expression which required the secondary stack (such as with an concatination
operation) due to certain generated checks which were incorrected performed
on internal object declarations.
2018-05-28 Justin Squirek <squirek@adacore.com>
gcc/ada/
* exp_ch3.adb
(Build_Initialization_Call): Add logic to pass the appropriate actual to match
new formal.
(Init_Formals): Add new formal *_skip_null_excluding_check
* exp_util.adb, exp_util.ads
(Enclosing_Init_Proc): Added to fetch the enclosing Init_Proc from the current
scope.
(Inside_Init_Proc): Refactored to use Enclosing_Init_Proc
(Needs_Conditional_Null_Excluding_Check): Added to factorize the predicate
used to determine how to generate an Init_Proc for a given type.
(Needs_Constant_Address): Minor reformatting
* sem_res.adb
(Resolve_Null): Add logic to generate a conditional check in certain cases
pmderodat [Mon, 28 May 2018 08:53:22 +0000 (08:53 +0000)]
[Ada] Spurious error on aspect Volatile
This patch modifies the analysis of aspect/pragma Volatile to correct accept
the annotation when it applies to single protected and single task types, and
SPARK_Mode On is in effect.
------------
-- Source --
------------
-- pack.ads
package Pack with SPARK_Mode is
protected PO_Aspect with Volatile is end; -- OK
protected PO_Pragma is end;
pragma Volatile (PO_Pragma); -- OK
task TO_Aspect with Volatile; -- OK
task TO_Pragma;
pragma Volatile (TO_Pragma); -- OK
end Pack;
----------------------------
-- Compilation and output --
----------------------------
* sem_prag.adb (Process_Atomic_Independent_Shared_Volatile): Include
the declarations of single concurrent types because they fall in the
category of full type and object declarations.
pmderodat [Mon, 28 May 2018 08:53:13 +0000 (08:53 +0000)]
[Ada] Minor tweak to output of -gnatR
This changes the output of -gnatR for extensions of tagged record types to
avoid displaying the internal _Parent component, which overlaps with other
components and is thus more confusing than helpful.
For the following hierarchy:
type R1 is tagged record
I : Integer;
end record;
type R2 is new R1 with record
C : Character;
end record;
the output -gnatR must now be:
for R1'Object_Size use 128;
for R1'Value_Size use 96;
for R1'Alignment use 8;
for R1 use record
_Tag at 0 range 0 .. 63;
I at 8 range 0 .. 31;
end record;
for R2'Object_Size use 192;
for R2'Value_Size use 136;
for R2'Alignment use 8;
for R2 use record
_Tag at 0 range 0 .. 63;
I at 8 range 0 .. 31;
C at 16 range 0 .. 7;
end record;
pmderodat [Mon, 28 May 2018 08:53:06 +0000 (08:53 +0000)]
[Ada] Warning on recursive call within postcondition
This patch adds a warning to a function call that appears within a
postcondition for said function. This may mean an omission of an attribute
reference 'Result, and may lead to an infinite loop on a call to that function.
Compiling post_error.ads must yield:
post_error.ads:3:11:
warning: postcondition does not mention function result
post_error.ads:3:19:
warning: call to "Foo" within its postcondition will lead
to infinite recursion
----
package Post_Error is
function Foo (A : out Integer) return Integer
with Post => Foo (A) /= 0;
pragma Import (C, Foo);
end Post_Error;
2018-05-28 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_util.adb (Is_Function_Result): Add a warning if a postcondition
includes a call to function to which it applies. This may mean an
omission of an attribute reference 'Result, in particular if the
function is pqrameterless.
pmderodat [Mon, 28 May 2018 08:53:00 +0000 (08:53 +0000)]
[Ada] Misleading warning on unresolvable package name
This patch fixes an issue whereby the compiler misidentified a package name
containing the name of a standard runtime package as said package - leading to
and improper error message prompting the user to "With" a package already in
scope.
2018-05-28 Justin Squirek <squirek@adacore.com>
gcc/ada/
* sem_ch8.adb (Find_Expanded_Name): Add extra guard to make sure the
misresolved package name is not a case of mistaken identity.
gcc/testsuite/
* gnat.dg/warn15-core-main.adb, gnat.dg/warn15-core.ads,
gnat.dg/warn15-interfaces.ads, gnat.dg/warn15.ads: New testcase.
pmderodat [Mon, 28 May 2018 08:52:53 +0000 (08:52 +0000)]
[Ada] Further evaluation of type bounds in GNATprove mode
Some static bounds of types are not recognized and evaluated as such in the
semantic analysis phase of the frontend, which leads to incomplete information
in GNATprove. Fix that in the GNATprove mode only, as this is not needed when
full expansion is used.
There is no impact on compilation.
2018-05-28 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_res.adb (Resolve_Range): Re-resolve the low bound of a range in
GNATprove mode, as the order of resolution (low then high) means that
all the information is not available when resolving the low bound the
first time.
pmderodat [Mon, 28 May 2018 08:52:42 +0000 (08:52 +0000)]
[Ada] Minor internal cleanup in repinfo unit
This steamlines a bit the implementation. No functional changes.
2018-05-28 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* repinfo.adb (List_Array_Info): Start with an explicit blank line and
end with the linker section, if any.
(List_Entities): Do not output the linker section for record types,
array types and variables.
(Print_Expr): Factor out common processing for unary operators and
special values. Adjust and reorder the various cases.
(List_Object_Info): End with the linker section, if any.
(List_Record_Info): Likewise.
(List_Type_Info): Do not start with a blank line.
jvdelisle [Sat, 26 May 2018 18:22:18 +0000 (18:22 +0000)]
2018-05-26 Jerry DeLisle <jvdelisle@gcc.gnu.org>
PR libgfortran/89506
* io/write.c (write_integer): Initialise the fnode format to
FMT_NONE, used for list directed write.
(BUF_STACK_SZ): Bump default buffer size up to avoid allocs on
small stuff.
wilson [Fri, 25 May 2018 22:29:17 +0000 (22:29 +0000)]
RISC-V: Add interrupt attribute support.
gcc/
* config/riscv/riscv-protos.h (riscv_epilogue_uses): New.
* config/riscv/riscv.c (struct machine_function): Add
interrupt_handler_p and attribute_checked_p fields.
(riscv_attribute_table): Add interrupt.
(riscv_interrupt_type_p): New.
(riscv_save_reg_p): Save extra regs for interrupt handler.
(riscv_use_save_libcall): Return false for interrupt handler.
(riscv_first_stack_step): Add forward declaration.
(riscv_compute_frame_info): New local interrupt_save_t1. Set it
for interrupt handler with large frame. Use it for saved reg list.
(riscv_expand_prologue): Move flag_stack_usage_info support to
eliminate duplication.
(riscv_expand_epilogue): Generate mret for interrupt handler.
(riscv_epilogue_uses): New.
(riscv_can_use_return_insn): Return false for interrupt handler.
(riscv_function_ok_for_sibcall): Likewise.
(riscv_set_current_function): Add interrupt handler support.
* config/riscv/riscv.h (EPILOGUE_USES): Call riscv_epilogue_uses.
* config/riscv/riscv.md (UNSPECV_MRET): New.
(GP_REGNUM): New.
(riscv_frflags, riscv_fsflags): Use tab after opcode.
(riscv_mret): New.
* doc/extend.texi (RISC-V Function Attributes) <interrupt>: New.
jason [Fri, 25 May 2018 21:03:07 +0000 (21:03 +0000)]
PR c++/85815 - reference to member of enclosing template.
* search.c (lookup_base): Use currently_open_class.
(lookup_member): Use it regardless of -fconcepts.
* parser.c (cp_parser_postfix_dot_deref_expression): Check it.
wschmidt [Fri, 25 May 2018 19:12:16 +0000 (19:12 +0000)]
2018-05-25 Bill Schmidt <wschmidt@linux.ibm.com>
PR tree-optimization/85712
* gimple-ssa-strength-reduction.c (replace_one_candidate): Skip if
this candidate has already been replaced in-situ by a copy.
projects / thirdparty / gcc.git / log
