Volker Lendecke [Thu, 10 Nov 2011 08:39:23 +0000 (09:39 +0100)]
s3: Avoid a race with the async echo handler
We can not read from the echo handler socket when we have the main socket
locked. This leads to the echo responder to lock up sitting in the fcntl lock
while the parent wants to read the remainder of a large packet.
libcli/cldap: fix a crash bug in cldap_socket_recv_dgram() (bug #8593)
After a calling any wrapper of tevent_req_notify_callback(),
e.g. tevent_req_nterror(), tevent_req_done(), tevent_req_nomem(),
a function has to return immediately otherwise it is very likely to
crash, unless in calls tevent_req_defer_callback() before.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 10 16:31:59 CET 2011 on sn-devel-104
Martin Schwenke [Wed, 9 Nov 2011 23:46:10 +0000 (10:46 +1100)]
Fix -Wunused-but-set-variable compiler warnings in tevent_signal.c
The results of some read(2) and write(2) calls are assigned into a
variable that is never used. Presumably this used to avoid compiler
warnings or similar.
However, from (approximately) GCC 4.6 this produces some warnings:
[ 609/3910] Compiling lib/tevent/tevent_signal.c
../lib/tevent/tevent_signal.c: In function ‘tevent_common_signal_handler’:
../lib/tevent/tevent_signal.c:85:10: warning: variable ‘res’ set but not used [-Wunused-but-set-variable]
../lib/tevent/tevent_signal.c: In function ‘signal_pipe_handler’:
../lib/tevent/tevent_signal.c:183:10: warning: variable ‘res’ set but not used [-Wunused-but-set-variable]
The simplest thing to do is remove the variables and cast the function
return to void. There is already a comment above each call.
Signed-off-by: Martin Schwenke <martin@meltin.net> Signed-off-by: Stefan Metzmacher <metze@samba.org>
Theresa Halloran [Thu, 10 Nov 2011 01:16:33 +0000 (20:16 -0500)]
s4: samba-tool time --help documentation improvements
Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com> Signed-off-by: Andrew Tridgell <tridge@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov 10 06:04:22 CET 2011 on sn-devel-104
Andrew Bartlett [Thu, 3 Nov 2011 21:45:49 +0000 (08:45 +1100)]
s4-setup Remove servicePrincipalName: DNS/${DNSDOMAIN} from new installations
This servicePrincipalName is incorrect (windows does not use that
servicePrincipalName, as it targets the server it is updating, not the
root of the DNS tree), and now that we have multiple DNS backends that
use the internal database, it is quite incorrect (as it cannot exist
on more than one account).
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Nov 10 01:11:46 CET 2011 on sn-devel-104
s4:join.py - fix up "DsAddEntry" against Windows Server 2000
It is important to consider the result level regarding error
information. Windows 2000 seems to send us back v2, all other
implementations v3. Consider post "Joining W2k AD domain"
Reviewed-by: abartlet
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Nov 9 23:37:08 CET 2011 on sn-devel-104
Matthias, the bad effect of this change was that actually all failed password
change attempts will always return NT_STATUS_OK because the last 4 bytes (the
resulting status code) were not marshalled anymore.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Nov 9 00:41:13 CET 2011 on sn-devel-104
Andrew Bartlett [Thu, 3 Nov 2011 22:07:17 +0000 (09:07 +1100)]
s4-provision Remove options for LDAP backend to reduce user confusion
We do not support the LDAP backend any more, but keep the code in case someone
comes up with an interesting use case that could leverage this in a very
particular situation. In order to keep the code, we must test it, so
we keep just this much of the support around.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Nov 8 04:33:49 CET 2011 on sn-devel-104
Andrew Bartlett [Tue, 1 Nov 2011 20:43:43 +0000 (07:43 +1100)]
s4-smb_server No longer follow the security=share smb.conf directive
By ignoring the value of security= from the smb.conf, we can allow this
to instead set the value of 'server role' in a manner compatible
with the Samba 3.x release stream.
Amitay Isaacs [Thu, 3 Nov 2011 05:59:23 +0000 (16:59 +1100)]
s4-dnsserver: Fix enumeration of zones in ComplexOperation RPC call
zone_request_flags are interpreted in different groups rather than
a single group. This correctly returns 0 zones when there are no
reverse zones and DNS_ZONE_REQUEST_REVERSE is set in zone_request_flags.
Björn Baumbach [Mon, 7 Nov 2011 13:24:40 +0000 (14:24 +0100)]
s3-wafbuild: Fix inotify detection (bug 8580)
Enable inotify if sys or kernel inotify is available.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Nov 7 16:28:38 CET 2011 on sn-devel-104
s4: samba-tool user --help documenation improvements Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov 7 01:39:25 CET 2011 on sn-devel-104
Dave Craft [Thu, 3 Nov 2011 17:39:53 +0000 (12:39 -0500)]
samba_kcc addtion
Scaffolding and initial implementations of
portions of the KCC in python. This code currently
properly computes the graph nodes for the intrasite
topology as well as enumerating all steps for a full
run of the KCC.
Dave Craft [Thu, 3 Nov 2011 17:37:24 +0000 (12:37 -0500)]
add python KCC utility classes and methods
New file source4/scripting/python/samba/kcc_utils.py
contains classes and methods for:
DirectoryServiceAgent
NTDSConnection
GraphNode
NamingContext
NCReplica
These are consumed by a new samba_kcc python script
for KCC topology computation
Dave Craft [Thu, 3 Nov 2011 17:33:38 +0000 (12:33 -0500)]
python dsdb flag addtions (NTDSSETTINGS, NTDSCONN)
Add missing flags present in C code base to python
code base dsdb/pydsdb.c
INSTANCE_TYPE...
DS_NTDSSETTINGS_OPT...
NTDSCONN_OPT...
These are consumed by the python KCC scripts
projects / thirdparty / samba.git / log
