]> git.ipfire.org Git - thirdparty/rrdtool-1.x.git/log
thirdparty/rrdtool-1.x.git
11 years agoFix all usages of setlocale: setlocale might (and on linux DOES)
Peter Stamfest [Sun, 16 Mar 2014 16:36:23 +0000 (17:36 +0100)] 
Fix all usages of setlocale: setlocale might (and on linux DOES)
return a pointer to memory handled internally by libc, calling
setlocale twice and using the data returned from the first call
later on causes access to already free'd memory. This was clearly
seen through valgrind. Eg. use

  TESTS_STYLE=valgrind ./tests/tune2

with this cs backed-out and you will see valgrind problems
related to setlocale.

11 years agorrd_tune: establish a single cleanup/return code path
Peter Stamfest [Sun, 16 Mar 2014 07:40:45 +0000 (08:40 +0100)] 
rrd_tune: establish a single cleanup/return code path
- fix a couple of resource leaks on the way

11 years agoactivate tune tests in test-suite
Peter Stamfest [Sun, 16 Mar 2014 09:39:20 +0000 (10:39 +0100)] 
activate tune tests in test-suite

11 years agoAnother "tune" test
Peter Stamfest [Sun, 16 Mar 2014 09:37:16 +0000 (10:37 +0100)] 
Another "tune" test
(there is a fd leak in parts of the tune code, used this test to
demonstrate it - kept for reference and general testing)

11 years agoadd some tune tests
Peter Stamfest [Sun, 16 Mar 2014 07:55:59 +0000 (08:55 +0100)] 
add some tune tests

11 years agoTrack open fds through valgrind
Peter Stamfest [Sun, 16 Mar 2014 08:37:53 +0000 (09:37 +0100)] 
Track open fds through valgrind

11 years agoMerge branch 'memory-management' into rrdmodify-master
Peter Stamfest [Sun, 16 Mar 2014 08:31:15 +0000 (09:31 +0100)] 
Merge branch 'memory-management' into rrdmodify-master

11 years agoFix nasty double-free error in rrd_free (duh!)
Peter Stamfest [Sun, 16 Mar 2014 08:27:24 +0000 (09:27 +0100)] 
Fix nasty double-free error in rrd_free (duh!)

11 years agoStart modify/tune unification
Peter Stamfest [Sat, 15 Mar 2014 20:48:48 +0000 (21:48 +0100)] 
Start modify/tune unification

11 years agoUse RRD_READVALUES to read data
Peter Stamfest [Sat, 15 Mar 2014 20:23:07 +0000 (21:23 +0100)] 
Use RRD_READVALUES to read data

11 years agoadd RRD_READVALUES option to rrd_open
Peter Stamfest [Sat, 15 Mar 2014 20:19:32 +0000 (21:19 +0100)] 
add RRD_READVALUES option to rrd_open
- in case of mmap just point to the correct position within the file

11 years agoMake rrd_free idempotent by resetting free'd pointers to NULL
Peter Stamfest [Sat, 15 Mar 2014 20:21:00 +0000 (21:21 +0100)] 
Make rrd_free idempotent by resetting free'd pointers to NULL

11 years agoget rid of temporarily introduced fixed hash value
Peter Stamfest [Fri, 14 Mar 2014 07:40:12 +0000 (08:40 +0100)] 
get rid of temporarily introduced fixed hash value

11 years agoMerge branch 'automake-based-checks' into memory-management
Peter Stamfest [Fri, 14 Mar 2014 07:19:38 +0000 (08:19 +0100)] 
Merge branch 'automake-based-checks' into memory-management

11 years agoNever ever should a function free an object that was passed in. At least this
Peter Stamfest [Wed, 12 Mar 2014 16:42:10 +0000 (17:42 +0100)] 
Never ever should a function free an object that was passed in. At least this
is my opinion.
Also get rid of a specialised rrd_free function and clean up exit paths of
functions.

11 years agoTry to handle freeing of mmapped and malloced rrd_t objects transparently
Peter Stamfest [Wed, 12 Mar 2014 16:39:13 +0000 (17:39 +0100)] 
Try to handle freeing of mmapped and malloced rrd_t objects transparently

This IS rather hackish - an OO inspired approach might be better, but adding
knowledge about mmapped memory to the free path even allows mixed
mmapped/malloced objects

11 years agoif a test fails report original exit code instead of just 1
Peter Stamfest [Fri, 14 Mar 2014 06:31:00 +0000 (07:31 +0100)] 
if a test fails report original exit code instead of just 1

11 years agoname individual tests in Makefile.am
Peter Stamfest [Thu, 13 Mar 2014 20:18:08 +0000 (21:18 +0100)] 
name individual tests in Makefile.am

11 years agoValgrind changes for travis - show log and include supressions
Peter Stamfest [Thu, 13 Mar 2014 10:50:27 +0000 (11:50 +0100)] 
Valgrind changes for travis - show log and include supressions

11 years agoCurrently, tests have to run in the CET timezone.
Peter Stamfest [Wed, 12 Mar 2014 21:15:46 +0000 (22:15 +0100)] 
Currently, tests have to run in the CET timezone.

11 years agoinstall valgrind - needed for test suite
Peter Stamfest [Wed, 12 Mar 2014 20:56:45 +0000 (21:56 +0100)] 
install valgrind - needed for test suite

11 years agotry to get travis to run the test suite....
Peter Stamfest [Wed, 12 Mar 2014 20:48:11 +0000 (21:48 +0100)] 
try to get travis to run the test suite....

11 years agoUse valgrind via travis
Peter Stamfest [Wed, 12 Mar 2014 20:12:30 +0000 (21:12 +0100)] 
Use valgrind via travis

11 years agoValgrind support for the test suite. valgrind gets used when called as "make check...
Peter Stamfest [Wed, 12 Mar 2014 20:11:12 +0000 (21:11 +0100)] 
Valgrind support for the test suite. valgrind gets used when called as "make check TESTS_STYLE=valgrind"

11 years agoUse automake based checks ("make check") and use the mechanism for travis
Peter Stamfest [Wed, 12 Mar 2014 16:50:33 +0000 (17:50 +0100)] 
Use automake based checks ("make check") and use the mechanism for travis

11 years agoRevert "Make modify command available using RRDs" 452/head
Peter Stamfest [Sat, 8 Mar 2014 12:32:49 +0000 (13:32 +0100)] 
Revert "Make modify command available using RRDs"

This reverts commit c77b6b7a567bd787baa98a9e459bd64e9ef39154.
This cs should not have been on this branch, but because the branch was
pushed before, it can only be reverted...

11 years agoimproved rrdmodify documentation
Peter Stamfest [Sat, 8 Mar 2014 10:20:54 +0000 (11:20 +0100)] 
improved rrdmodify documentation

11 years agoMake modify command available using RRDs
Peter Stamfest [Sat, 8 Mar 2014 08:22:37 +0000 (09:22 +0100)] 
Make modify command available using RRDs

11 years agoTake care to change CDPs when changing step size and change resize semantics
Peter Stamfest [Sat, 8 Mar 2014 08:21:04 +0000 (09:21 +0100)] 
Take care to change CDPs when changing step size and change resize semantics
- all RRA modifications are now done AFTER resizing

11 years agoimprove step resizing, this still is experimental
Peter Stamfest [Fri, 7 Mar 2014 06:38:35 +0000 (07:38 +0100)] 
improve step resizing, this still is experimental

11 years agoFurther chop up rrd_modify_r in order to integrate step changes into DS/RRA
Peter Stamfest [Thu, 6 Mar 2014 21:54:13 +0000 (22:54 +0100)] 
Further chop up rrd_modify_r in order to integrate step changes into DS/RRA
modifications.

11 years agoextremely experimental RRD step stretching
Peter Stamfest [Thu, 6 Mar 2014 18:06:48 +0000 (19:06 +0100)] 
extremely experimental RRD step stretching

11 years agoanother try with travis
Tobias Oetiker [Thu, 6 Mar 2014 09:54:03 +0000 (10:54 +0100)] 
another try with travis

11 years agoadded new tests to travis build
Tobias Oetiker [Thu, 6 Mar 2014 09:47:30 +0000 (10:47 +0100)] 
added new tests to travis build

11 years agoMerge pull request #450 from stamfest/rrdmodify-master
Tobias Oetiker [Thu, 6 Mar 2014 09:40:52 +0000 (10:40 +0100)] 
Merge pull request #450 from stamfest/rrdmodify-master

Rrdmodify master

11 years agoMerge pull request #451 from stamfest/small-fixes
Tobias Oetiker [Thu, 6 Mar 2014 09:39:28 +0000 (10:39 +0100)] 
Merge pull request #451 from stamfest/small-fixes

small fixes

11 years agobetter test flexibility - use a specific rrdtool to do the tests 450/head
Peter Stamfest [Thu, 6 Mar 2014 07:49:41 +0000 (08:49 +0100)] 
better test flexibility - use a specific rrdtool to do the tests

11 years agoFix nasty off-by-one error, causing incorrect CDP calculations when adding
Peter Stamfest [Thu, 6 Mar 2014 07:26:06 +0000 (08:26 +0100)] 
Fix nasty off-by-one error, causing incorrect CDP calculations when adding
new RRAs

11 years agoAdd alltests script to run all tests at once
Peter Stamfest [Wed, 5 Mar 2014 20:30:28 +0000 (21:30 +0100)] 
Add alltests script to run all tests at once

11 years agoAvoid some "unused" warnings during compilation 451/head
Peter Stamfest [Wed, 5 Mar 2014 19:51:52 +0000 (20:51 +0100)] 
Avoid some "unused" warnings during compilation

11 years agoAllow to ask for continuing tests for intergration testing
Peter Stamfest [Wed, 5 Mar 2014 19:48:38 +0000 (20:48 +0100)] 
Allow to ask for continuing tests for intergration testing

11 years agoSecond round of refactoring: Ripping apart rrd_modify_r into more digestable
Peter Stamfest [Wed, 5 Mar 2014 18:58:17 +0000 (19:58 +0100)] 
Second round of refactoring: Ripping apart rrd_modify_r into more digestable
pieces.

11 years agoRefactoring
Peter Stamfest [Wed, 5 Mar 2014 17:01:51 +0000 (18:01 +0100)] 
Refactoring
 - rename variables
 - modularize rrd_modify_r function (it really is a mess, right now...)

11 years agoMention modify operation in main man page
Peter Stamfest [Wed, 5 Mar 2014 17:00:57 +0000 (18:00 +0100)] 
Mention modify operation in main man page

11 years agoMerge branch 'master' into rrdmodify-master
Peter Stamfest [Wed, 5 Mar 2014 07:45:09 +0000 (08:45 +0100)] 
Merge branch 'master' into rrdmodify-master

11 years agothere is no total CF
Tobias Oetiker [Sun, 2 Mar 2014 10:27:45 +0000 (11:27 +0100)] 
there is no total CF

11 years agosuppress error message from libxml when reading XML from stdin.
Peter Stamfest [Wed, 19 Feb 2014 21:34:20 +0000 (22:34 +0100)] 
suppress error message from libxml when reading XML from stdin.
This avoids breakage of the pipe protocol in case of errors.

11 years agoAvoid endless looping in case of XML errors.
Peter Stamfest [Wed, 19 Feb 2014 21:25:48 +0000 (22:25 +0100)] 
Avoid endless looping in case of XML errors.

11 years agoFix double-free bug
Peter Stamfest [Wed, 19 Feb 2014 20:54:27 +0000 (21:54 +0100)] 
Fix double-free bug

11 years agoAdd support for rrd restore to explicitly end xml files when using
Peter Stamfest [Wed, 19 Feb 2014 08:56:16 +0000 (09:56 +0100)] 
Add support for rrd restore to explicitly end xml files when using
the pipe interface by using the "-" special filename and using
ctrl-Z/newline as an end-of-file indicator.

11 years agoMerge pull request #449 from stamfest/rrdmodify-master
Tobias Oetiker [Tue, 4 Mar 2014 23:25:59 +0000 (00:25 +0100)] 
Merge pull request #449 from stamfest/rrdmodify-master

Rrdmodify master

11 years agoMerge branch 'master' of https://github.com/oetiker/rrdtool-1.x into rrdmodify-master 449/head
Peter Stamfest [Tue, 4 Mar 2014 21:52:27 +0000 (22:52 +0100)] 
Merge branch 'master' of https://github.com/oetiker/rrdtool-1.x into rrdmodify-master

11 years agoadd/update tests
Peter Stamfest [Tue, 4 Mar 2014 21:39:44 +0000 (22:39 +0100)] 
add/update tests

11 years agoFurther improve rrd modify.
Peter Stamfest [Tue, 4 Mar 2014 21:36:11 +0000 (22:36 +0100)] 
Further improve rrd modify.
I am quite sure, that this code contains a lot of hidden assumptions.

11 years agomake update_cdp usable from other modules
Peter Stamfest [Tue, 4 Mar 2014 20:46:49 +0000 (21:46 +0100)] 
make update_cdp usable from other modules

11 years agowe can also use a single RRA as a candidate
Peter Stamfest [Mon, 3 Mar 2014 08:38:13 +0000 (09:38 +0100)] 
we can also use a single RRA as a candidate

11 years agofactor out candidate finding from populate_row
Peter Stamfest [Mon, 3 Mar 2014 08:35:54 +0000 (09:35 +0100)] 
factor out candidate finding from populate_row

11 years agoAdd RRDs in tests directory to the ignore list
Peter Stamfest [Mon, 3 Mar 2014 07:28:32 +0000 (08:28 +0100)] 
Add RRDs in tests directory to the ignore list

11 years agoadd more test code and data required for testing
Peter Stamfest [Mon, 3 Mar 2014 00:04:17 +0000 (01:04 +0100)] 
add more test code and data required for testing

11 years agoskip populating values for just added DS
Peter Stamfest [Mon, 3 Mar 2014 00:01:46 +0000 (01:01 +0100)] 
skip populating values for just added DS

11 years agoFix off-by-one error when adding a new RRA
Peter Stamfest [Sun, 2 Mar 2014 23:59:23 +0000 (00:59 +0100)] 
Fix off-by-one error when adding a new RRA

11 years agoSkip RRA values already defined when populating rows.
Peter Stamfest [Sun, 2 Mar 2014 23:58:16 +0000 (00:58 +0100)] 
Skip RRA values already defined when populating rows.

11 years agoSupport version 4 RRD files
Peter Stamfest [Sun, 2 Mar 2014 23:05:06 +0000 (00:05 +0100)] 
Support version 4 RRD files

11 years agoAdd some test scripts in new tests directory
Peter Stamfest [Mon, 3 Mar 2014 07:25:54 +0000 (08:25 +0100)] 
Add some test scripts in new tests directory

11 years agoMake RRA modifications work in presence of simultanous DS modifications
Peter Stamfest [Mon, 3 Mar 2014 07:25:12 +0000 (08:25 +0100)] 
Make RRA modifications work in presence of simultanous DS modifications

11 years agoGet rid of hard-coded hash value
Peter Stamfest [Sun, 2 Mar 2014 20:51:57 +0000 (21:51 +0100)] 
Get rid of hard-coded hash value

11 years agoFix some commented out code to change RRD version when certain RRA
Peter Stamfest [Sun, 2 Mar 2014 20:47:39 +0000 (21:47 +0100)] 
Fix some commented out code to change RRD version when certain RRA
definitions require this.

11 years agoUse code to populate new RRAs from existing data
Peter Stamfest [Sun, 2 Mar 2014 10:29:19 +0000 (11:29 +0100)] 
Use code to populate new RRAs from existing data

11 years agoMerge branch 'master' of github.com:oetiker/rrdtool-1.x
Tobias Oetiker [Sun, 2 Mar 2014 10:28:55 +0000 (11:28 +0100)] 
Merge branch 'master' of github.com:oetiker/rrdtool-1.x

11 years agoAdd code to populate newly added RRA rows, but do not use it yet
Peter Stamfest [Sun, 2 Mar 2014 10:28:46 +0000 (11:28 +0100)] 
Add code to populate newly added RRA rows, but do not use it yet

11 years agothere is no total CF
Tobias Oetiker [Sun, 2 Mar 2014 10:27:45 +0000 (11:27 +0100)] 
there is no total CF

11 years agoRead all input data at once - this is in preparation of upcoming code
Peter Stamfest [Sun, 2 Mar 2014 10:27:04 +0000 (11:27 +0100)] 
Read all input data at once - this is in preparation of upcoming code
for populating newly added rows

11 years agoRip out a lot of too complicated code doing reordering of
Peter Stamfest [Fri, 28 Feb 2014 20:48:47 +0000 (21:48 +0100)] 
Rip out a lot of too complicated code doing reordering of
RRA rows. This is now done during the copying of the data to the
out RRA. This should also assist with the upcoming planned
population of newly added RRAs or RRA rows.

11 years agoPull out add_rrds in an attempt to shorten functions to a manageable size
Peter Stamfest [Thu, 27 Feb 2014 22:31:06 +0000 (23:31 +0100)] 
Pull out add_rrds in an attempt to shorten functions to a manageable size

11 years agoFix DEL command
Peter Stamfest [Thu, 27 Feb 2014 22:03:43 +0000 (23:03 +0100)] 
Fix DEL command

11 years agoupdate documentation
Peter Stamfest [Thu, 27 Feb 2014 22:01:09 +0000 (23:01 +0100)] 
update documentation

11 years agoadd support for explicit DELRRA
Peter Stamfest [Thu, 27 Feb 2014 21:41:47 +0000 (22:41 +0100)] 
add support for explicit DELRRA

11 years agoAllow to add new RRAs
Peter Stamfest [Thu, 27 Feb 2014 21:19:40 +0000 (22:19 +0100)] 
Allow to add new RRAs

11 years agoFix CDP init problems introduced with original add DS code
Peter Stamfest [Thu, 27 Feb 2014 21:14:03 +0000 (22:14 +0100)] 
Fix CDP init problems introduced with original add DS code

11 years agofactor out init_cdp and make it globally available
Peter Stamfest [Thu, 27 Feb 2014 20:53:45 +0000 (21:53 +0100)] 
factor out init_cdp and make it globally available

11 years agomake parseRRA and handle_dependent_rras globally available
Peter Stamfest [Thu, 27 Feb 2014 20:50:50 +0000 (21:50 +0100)] 
make parseRRA and handle_dependent_rras globally available

11 years agoFactor out RRA definition parsing so it may be reused for rrdtool modify.
Peter Stamfest [Thu, 27 Feb 2014 13:33:33 +0000 (14:33 +0100)] 
Factor out RRA definition parsing so it may be reused for rrdtool modify.

11 years agoAllow RRA resize to absolutely specified row_count
Peter Stamfest [Thu, 27 Feb 2014 10:01:33 +0000 (11:01 +0100)] 
Allow RRA resize to absolutely specified row_count

11 years agoMake it possible to add / remove a given number of rows for existing RRAs
Peter Stamfest [Thu, 27 Feb 2014 09:26:58 +0000 (10:26 +0100)] 
Make it possible to add / remove a given number of rows for existing RRAs

11 years agofactor out rrd file writing in rrd_modify_r
Peter Stamfest [Thu, 27 Feb 2014 07:41:12 +0000 (08:41 +0100)] 
factor out rrd file writing in rrd_modify_r

11 years agoallow to remove RRAs entirely
Peter Stamfest [Thu, 27 Feb 2014 03:25:24 +0000 (04:25 +0100)] 
allow to remove RRAs entirely

11 years agoSupport for RRA modification command line syntax
Peter Stamfest [Thu, 27 Feb 2014 02:38:24 +0000 (03:38 +0100)] 
Support for RRA modification command line syntax

11 years agoMerge pull request #448 from stamfest/pipe-restore-master
Tobias Oetiker [Thu, 27 Feb 2014 07:16:33 +0000 (08:16 +0100)] 
Merge pull request #448 from stamfest/pipe-restore-master

Pipe restore master

11 years agosuppress error message from libxml when reading XML from stdin. 448/head
Peter Stamfest [Wed, 19 Feb 2014 21:34:20 +0000 (22:34 +0100)] 
suppress error message from libxml when reading XML from stdin.
This avoids breakage of the pipe protocol in case of errors.

11 years agoAvoid endless looping in case of XML errors.
Peter Stamfest [Wed, 19 Feb 2014 21:25:48 +0000 (22:25 +0100)] 
Avoid endless looping in case of XML errors.

11 years agoFix double-free bug
Peter Stamfest [Wed, 19 Feb 2014 20:54:27 +0000 (21:54 +0100)] 
Fix double-free bug

11 years agoAdd support for rrd restore to explicitly end xml files when using
Peter Stamfest [Wed, 19 Feb 2014 08:56:16 +0000 (09:56 +0100)] 
Add support for rrd restore to explicitly end xml files when using
the pipe interface by using the "-" special filename and using
ctrl-Z/newline as an end-of-file indicator.

11 years agoMerge pull request #447 from stamfest/rrdmodify-master
Tobias Oetiker [Wed, 26 Feb 2014 14:22:11 +0000 (15:22 +0100)] 
Merge pull request #447 from stamfest/rrdmodify-master

Rrdmodify master

11 years agoAdd documentation for modify command 447/head
Peter Stamfest [Mon, 24 Feb 2014 20:10:01 +0000 (21:10 +0100)] 
Add documentation for modify command

11 years agorrdcached handling
Peter Stamfest [Mon, 24 Feb 2014 19:51:01 +0000 (20:51 +0100)] 
rrdcached handling

11 years agoAdd some documentation
Peter Stamfest [Mon, 24 Feb 2014 19:42:10 +0000 (20:42 +0100)] 
Add some documentation

11 years agostreamline and clean up
Peter Stamfest [Mon, 24 Feb 2014 19:50:18 +0000 (20:50 +0100)] 
streamline and clean up

11 years agoprovide new write_fh function
Peter Stamfest [Mon, 24 Feb 2014 19:08:40 +0000 (20:08 +0100)] 
provide new write_fh function

11 years agoExtend rrdcached client API to be able to also send FORGET and other
Peter Stamfest [Mon, 24 Feb 2014 19:06:32 +0000 (20:06 +0100)] 
Extend rrdcached client API to be able to also send FORGET and other
filename based commands easily

11 years agoAllow to add data sources to an RRD
Peter Stamfest [Mon, 24 Feb 2014 07:21:25 +0000 (08:21 +0100)] 
Allow to add data sources to an RRD