]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
3 months agorun dsymutil if we have it and libbacktrace
Alan T. DeKok [Mon, 14 Jul 2025 13:29:04 +0000 (09:29 -0400)] 
run dsymutil if we have it and libbacktrace

3 months agoThe pid file may reference a process that doesn't exist
Nick Porter [Mon, 14 Jul 2025 08:14:43 +0000 (09:14 +0100)] 
The pid file may reference a process that doesn't exist

3 months agoadd p_result to unlang_tmpl_push()
Alan T. DeKok [Thu, 10 Jul 2025 19:35:06 +0000 (15:35 -0400)] 
add p_result to unlang_tmpl_push()

3 months agoRegression test for internal encoder
Arran Cudbard-Bell [Mon, 14 Jul 2025 00:22:00 +0000 (18:22 -0600)] 
Regression test for internal encoder

3 months agoAdd support for libbacktrace
Arran Cudbard-Bell [Mon, 14 Jul 2025 00:21:41 +0000 (18:21 -0600)] 
Add support for libbacktrace

3 months agoAdd utility functions to trim paths
Arran Cudbard-Bell [Mon, 14 Jul 2025 00:16:11 +0000 (18:16 -0600)] 
Add utility functions to trim paths

3 months agoDon't pass a pointer to the password value box...
Arran Cudbard-Bell [Mon, 14 Jul 2025 00:14:19 +0000 (18:14 -0600)] 
Don't pass a pointer to the password value box...

3 months agoAdd libbacktrace as a submodule
Arran Cudbard-Bell [Mon, 14 Jul 2025 00:14:03 +0000 (18:14 -0600)] 
Add libbacktrace as a submodule

3 months agoremove radius_packet_t
Alan T. DeKok [Sun, 13 Jul 2025 15:43:05 +0000 (11:43 -0400)] 
remove radius_packet_t

structs require alignment.  But packets can come from anywhere,
and aren't always aligned.

3 months agoregularize pool configuration for tests
Alan T. DeKok [Sun, 13 Jul 2025 12:04:03 +0000 (08:04 -0400)] 
regularize pool configuration for tests

it makes absolutely zero sense to have "uses = 2".  This means
that the connections will get closed in the middle of the unit
tests.

3 months agoshow when we hit boundaries
Alan T. DeKok [Sun, 13 Jul 2025 11:56:42 +0000 (07:56 -0400)] 
show when we hit boundaries

so that the poor admin reading the debug output can find out
why the connection was closed

3 months agoadd and use automatic re-init on connection failure
Alan T. DeKok [Sat, 12 Jul 2025 12:52:49 +0000 (08:52 -0400)] 
add and use automatic re-init on connection failure

Some SQL modules use a thread-specific connection hamdle for
escaping. However, that connection may fail for some reason.
When that happens, the connection should be reopened.

Otherwise, the connection will go down, and will never come back
up again.

3 months agoFix unaligned access in DHCPv4 "get_option" on MacOS
Arran Cudbard-Bell [Sun, 13 Jul 2025 15:15:42 +0000 (09:15 -0600)] 
Fix unaligned access in DHCPv4 "get_option" on MacOS

3 months agorework load balance
Alan T. DeKok [Fri, 11 Jul 2025 15:20:18 +0000 (11:20 -0400)] 
rework load balance

it now supports all data types via fr_value_box_hash()

more sanity checks and simplifications

3 months agoUpdate docs from raddb
Nick Porter [Fri, 11 Jul 2025 16:47:26 +0000 (17:47 +0100)] 
Update docs from raddb

3 months agoWhitespace
Nick Porter [Fri, 11 Jul 2025 16:48:07 +0000 (17:48 +0100)] 
Whitespace

3 months agoUpdate section names referenced in sample modules
Nick Porter [Fri, 11 Jul 2025 16:46:01 +0000 (17:46 +0100)] 
Update section names referenced in sample modules

3 months agoUpdate sample rest module
Nick Porter [Fri, 11 Jul 2025 16:21:35 +0000 (17:21 +0100)] 
Update sample rest module

3 months agoUpdate rlm_rest test config
Nick Porter [Fri, 11 Jul 2025 16:18:13 +0000 (17:18 +0100)] 
Update rlm_rest test config

3 months agoUse call_env to detect which sections rlm_rest is called in
Nick Porter [Thu, 10 Jul 2025 15:03:42 +0000 (16:03 +0100)] 
Use call_env to detect which sections rlm_rest is called in

And find conf sections based on the section name where the module is called.

3 months agoMake call_env_parse a public function
Nick Porter [Fri, 11 Jul 2025 12:46:04 +0000 (13:46 +0100)] 
Make call_env_parse a public function

So we can use a custom parser to point at a specific CONF_SECTION rather
than having them hard coded in to the parser config.

3 months agoadd comments and macros for mod_action
Alan T. DeKok [Fri, 11 Jul 2025 11:48:20 +0000 (07:48 -0400)] 
add comments and macros for mod_action

3 months agoadd error message to xlat_redundant when it fails
Alan T. DeKok [Fri, 11 Jul 2025 11:18:19 +0000 (07:18 -0400)] 
add error message to xlat_redundant when it fails

3 months agoadd tmpl_dump
Alan T. DeKok [Thu, 10 Jul 2025 16:18:30 +0000 (12:18 -0400)] 
add tmpl_dump

3 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Thu, 10 Jul 2025 04:33:55 +0000 (04:33 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

3 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Thu, 10 Jul 2025 04:33:53 +0000 (04:33 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

3 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar
github-actions[bot] [Thu, 10 Jul 2025 04:33:43 +0000 (04:33 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar

3 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Thu, 10 Jul 2025 04:33:40 +0000 (04:33 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

3 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Thu, 10 Jul 2025 04:33:37 +0000 (04:33 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

3 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Thu, 10 Jul 2025 04:33:31 +0000 (04:33 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

3 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Thu, 10 Jul 2025 04:32:55 +0000 (04:32 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

3 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Thu, 10 Jul 2025 04:31:56 +0000 (04:31 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

3 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Thu, 10 Jul 2025 04:31:47 +0000 (04:31 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

3 months agoCorrect #ifdef wrapped logic
Nick Porter [Wed, 9 Jul 2025 11:41:19 +0000 (12:41 +0100)] 
Correct #ifdef wrapped logic

3 months agoIf we send using pcap, use pcap to receive
Nick Porter [Wed, 9 Jul 2025 11:29:20 +0000 (12:29 +0100)] 
If we send using pcap, use pcap to receive

Calling recvfrom() on the pcap fd returns EWOULDBLOCK or EAGAIN

3 months agoCorrect UDP checksum calculation
Nick Porter [Wed, 9 Jul 2025 08:35:26 +0000 (09:35 +0100)] 
Correct UDP checksum calculation

3 months agoMove variable initialisation (CID #1655307)
Nick Porter [Wed, 9 Jul 2025 06:51:21 +0000 (07:51 +0100)] 
Move variable initialisation (CID #1655307)

3 months agoCorrect return value for comparison (CID #1655308)
Nick Porter [Wed, 9 Jul 2025 06:41:24 +0000 (07:41 +0100)] 
Correct return value for comparison (CID #1655308)

3 months agoAdd libpcap option for sending DHCP replies
Nick Porter [Tue, 8 Jul 2025 17:18:29 +0000 (18:18 +0100)] 
Add libpcap option for sending DHCP replies

Which will be used on non-Linux systems.

Also, can be used on Linux for testing, using the hidden listener conf
option of use_pcap

3 months agoNo need for dhcp_packet_t
Nick Porter [Tue, 8 Jul 2025 16:14:31 +0000 (17:14 +0100)] 
No need for dhcp_packet_t

Since we're just sending data - not decoding the header.
Using dhcp_packet_t also can cause spurious alignment complaints from
sanitizers.

3 months agolet's take the result back up the stack
Alan T. DeKok [Mon, 7 Jul 2025 16:07:18 +0000 (12:07 -0400)] 
let's take the result back up the stack

3 months agobetter debug output and clarifications
Alan T. DeKok [Mon, 7 Jul 2025 16:01:24 +0000 (12:01 -0400)] 
better debug output and clarifications

3 months agoUse module name in custom call_env_parse functions
Nick Porter [Mon, 7 Jul 2025 15:12:53 +0000 (16:12 +0100)] 
Use module name in custom call_env_parse functions

So call_env_parse() can be made public

3 months agoAdd checks that tmpl expansion created a value
Nick Porter [Mon, 7 Jul 2025 15:03:47 +0000 (16:03 +0100)] 
Add checks that tmpl expansion created a value

3 months agoIf the query tmpl did not expand, fail the module call
Nick Porter [Mon, 7 Jul 2025 13:38:43 +0000 (14:38 +0100)] 
If the query tmpl did not expand, fail the module call

3 months agoMore consistent handling of dcursors in xlat args
Nick Porter [Mon, 7 Jul 2025 08:24:00 +0000 (09:24 +0100)] 
More consistent handling of dcursors in xlat args

xlat_frame_eval doesn't know if the arg is required, so if no pairs are
matched, allow a cursor to be returned.
Then xlat_process_arg_list can do the right thing depending on whether
the argument is required or not.

3 months agoSpelling
Nick Porter [Thu, 3 Jul 2025 07:43:51 +0000 (08:43 +0100)] 
Spelling

3 months agoit turns out that we care if the xlat fails
Alan T. DeKok [Sun, 6 Jul 2025 16:07:01 +0000 (12:07 -0400)] 
it turns out that we care if the xlat fails

so we return an error when that happens

3 months agoquery must exist
Alan T. DeKok [Sun, 6 Jul 2025 13:38:01 +0000 (09:38 -0400)] 
query must exist

otherwise it means that one of the expansions failed, and the
interpreter did not pop the stack.  Instead, it just kept going

3 months agofailed cast is fail, not OK
Alan T. DeKok [Sun, 6 Jul 2025 13:26:23 +0000 (09:26 -0400)] 
failed cast is fail, not OK

3 months agodocs: Add guidelines for documentation for contributors, coders, and me. Update Termi...
nolade [Tue, 6 May 2025 16:03:00 +0000 (12:03 -0400)] 
docs: Add guidelines for documentation for contributors, coders, and me. Update Terminolgy.adoc standardizing on UK/British spelling. Update accessibility section & included more details in other sections.

3 months agoAdded documentation for trigger_exec
ewelsh-inkbridge [Tue, 1 Jul 2025 19:35:04 +0000 (15:35 -0400)] 
Added documentation for trigger_exec

3 months agoupdate docs for parallel for intended behavior
Alan T. DeKok [Fri, 4 Jul 2025 14:11:06 +0000 (10:11 -0400)] 
update docs for parallel for intended behavior

3 months agohoist "set default actions"
Alan T. DeKok [Thu, 3 Jul 2025 19:22:53 +0000 (15:22 -0400)] 
hoist "set default actions"

so that it's done in only one place

and then since we're cleaning things up, do a bit more work
on unlang_compile_children()

3 months agounlang_register() no longer needs a type argument
Alan T. DeKok [Thu, 3 Jul 2025 19:02:37 +0000 (15:02 -0400)] 
unlang_register() no longer needs a type argument

the type is now in the unlang_op_t.  And even that will be removed.

also reformat for consistency.

and add unlang_t size and name for each instruction

3 months agoremove debugging
Alan T. DeKok [Fri, 4 Jul 2025 15:20:26 +0000 (11:20 -0400)] 
remove debugging

3 months agomove keyword compile_foo() to foo.c
Alan T. DeKok [Thu, 3 Jul 2025 17:24:30 +0000 (13:24 -0400)] 
move keyword compile_foo() to foo.c

mostly. compile_edit(), compile_tmpl(), compile_module(), and
compile_function() are still in compile.c

Many helper functions are exported in interpret_priv.h.  Some of
those should be cleaned up / renamed / un-exported.

The function names could likely be cleaned up.  Much of the code
uses unlang_foo() for private functions.  It should arguably use
private function names.

The unlang_register() function takes a type as both a function
argument, and as a field in unlang_op_t.  Fixing that will require
changing instruction->type to instruction->op in the interpreter,
which should be a next step.

The hash function is just fr_hash().  We should arguably come up
with a perfect hash for the keywords, which will help simplify
the lookups.

3 months agopoint to correct function
Alan T. DeKok [Thu, 3 Jul 2025 17:18:20 +0000 (13:18 -0400)] 
point to correct function

3 months agolink in "next"
Alan T. DeKok [Thu, 3 Jul 2025 15:57:11 +0000 (11:57 -0400)] 
link in "next"

3 months agoUpdate and format. Manual merge of #5618
Alan T. DeKok [Wed, 2 Jul 2025 18:19:13 +0000 (14:19 -0400)] 
Update and format.  Manual merge of #5618

3 months agonotes on multiple return codes
Alan T. DeKok [Wed, 2 Jul 2025 18:15:49 +0000 (14:15 -0400)] 
notes on multiple return codes

3 months agomore trigger fixes.
Alan T. DeKok [Tue, 1 Jul 2025 21:39:46 +0000 (17:39 -0400)] 
more trigger fixes.

allow back-ticks for exec, and run the exec tmpl type

3 months agoallocate a main loop, so that triggers can use it
Alan T. DeKok [Wed, 2 Jul 2025 11:52:01 +0000 (07:52 -0400)] 
allocate a main loop, so that triggers can use it

3 months agoassert when we enter the tokenize function, not later
Alan T. DeKok [Wed, 2 Jul 2025 11:48:35 +0000 (07:48 -0400)] 
assert when we enter the tokenize function, not later

when we call xlat_finalize().  This helps to hoist errors earlier
in the call flow.

3 months ago"frame" is not talloc'd
Alan T. DeKok [Wed, 2 Jul 2025 11:48:22 +0000 (07:48 -0400)] 
"frame" is not talloc'd

3 months agoTMPL_TYPE_EXEC can have xlats, too
Alan T. DeKok [Tue, 1 Jul 2025 21:04:11 +0000 (17:04 -0400)] 
TMPL_TYPE_EXEC can have xlats, too

3 months agouse the local thread interpreter here, too
Alan T. DeKok [Tue, 1 Jul 2025 18:41:18 +0000 (14:41 -0400)] 
use the local thread interpreter here, too

3 months agoAdd note on SQLite WAL
Nick Porter [Wed, 2 Jul 2025 09:50:34 +0000 (10:50 +0100)] 
Add note on SQLite WAL

3 months agoOnly the top level bio needs to be shut down
Nick Porter [Wed, 2 Jul 2025 09:33:52 +0000 (10:33 +0100)] 
Only the top level bio needs to be shut down

3 months agoEnsure request is runnable after error
Nick Porter [Wed, 2 Jul 2025 08:56:29 +0000 (09:56 +0100)] 
Ensure request is runnable after error

3 months agoAvoid producing stateful cache entries when TLS 1.3 is negotiated
Nick Porter [Tue, 1 Jul 2025 16:58:32 +0000 (17:58 +0100)] 
Avoid producing stateful cache entries when TLS 1.3 is negotiated

3 months agoallow xlats in triggers, and update tests to match
Alan T. DeKok [Tue, 1 Jul 2025 16:55:17 +0000 (12:55 -0400)] 
allow xlats in triggers, and update tests to match

3 months agoSimplify configuration of EPEL / CRB
Nick Porter [Tue, 1 Jul 2025 16:32:00 +0000 (17:32 +0100)] 
Simplify configuration of EPEL / CRB

PowerTools was the pre-RHEL 9 repo name

3 months agoShutdown bios when closing the connection
Nick Porter [Tue, 1 Jul 2025 16:30:38 +0000 (17:30 +0100)] 
Shutdown bios when closing the connection

3 months agoRemove unsed attrs and dict
Nick Porter [Tue, 1 Jul 2025 12:56:51 +0000 (13:56 +0100)] 
Remove unsed attrs and dict

3 months agominor cleanups on trigger code
Alan T. DeKok [Tue, 1 Jul 2025 14:48:49 +0000 (10:48 -0400)] 
minor cleanups on trigger code

don't allow triggers to be specified from the root of the config.
They MUST be within a trigger{...} section.

3 months agoreset destructor on shutdown
Alan T. DeKok [Tue, 1 Jul 2025 15:44:48 +0000 (11:44 -0400)] 
reset destructor on shutdown

3 months agoDon't create Module-Failure-Message instances with passwords when debug < 3
Nick Porter [Tue, 1 Jul 2025 10:44:29 +0000 (11:44 +0100)] 
Don't create Module-Failure-Message instances with passwords when debug < 3

REDEBUGn() creates the pair regardless of the debug level

3 months agoAlign Docker build setup with Crossbuild
Nick Porter [Tue, 1 Jul 2025 10:38:24 +0000 (11:38 +0100)] 
Align Docker build setup with Crossbuild

3 months agoDon't call fr_tls_session_async_handshake_push when sending application data
Nick Porter [Tue, 1 Jul 2025 09:57:52 +0000 (10:57 +0100)] 
Don't call fr_tls_session_async_handshake_push when sending application data

3 months agoAdd dynamic_timeout
Nick Porter [Mon, 30 Jun 2025 12:55:45 +0000 (13:55 +0100)] 
Add dynamic_timeout

To separate timeout of connected clients from dynamic clients.

Dynamic client definitions often want long(ish) lifetimes to avoid
repeated verifications of the same client.

4 months agomove unlang_ext_t fields to unlang_op_t
Alan T. DeKok [Mon, 30 Jun 2025 16:09:25 +0000 (12:09 -0400)] 
move unlang_ext_t fields to unlang_op_t

in preparation for adding function-style arguments to keywords

4 months agojust pass xlat_arg_parser_t*, not xlat_t*
Alan T. DeKok [Mon, 30 Jun 2025 10:11:07 +0000 (06:11 -0400)] 
just pass xlat_arg_parser_t*, not xlat_t*

the argument parser only needs the arguments, and not the rest
of the function definition

4 months agoprint out size of unlang structs, too
Alan T. DeKok [Sun, 29 Jun 2025 17:47:52 +0000 (13:47 -0400)] 
print out size of unlang structs, too

4 months agorearrange for syntax change
Alan T. DeKok [Sun, 29 Jun 2025 10:38:55 +0000 (06:38 -0400)] 
rearrange for syntax change

4 months agoEnsure we only fetch one URL
Nick Porter [Mon, 30 Jun 2025 11:17:39 +0000 (12:17 +0100)] 
Ensure we only fetch one URL

4 months agoAdd Cisco VSA 90
Nick Porter [Mon, 30 Jun 2025 09:58:02 +0000 (10:58 +0100)] 
Add Cisco VSA 90

Found in
https://www.cisco.com/c/en/us/td/docs/routers/asr9000/software/710x/bng/configuration/guide/b-bng-cg-asr9000-710x/radius-attributes.pdf

4 months agorearrange in preparation for function arguments
Alan T. DeKok [Sat, 28 Jun 2025 15:11:41 +0000 (11:11 -0400)] 
rearrange in preparation for function arguments

4 months agoFix test now emailAddress is in the dictionary
Nick Porter [Fri, 27 Jun 2025 18:59:23 +0000 (19:59 +0100)] 
Fix test now emailAddress is in the dictionary

4 months agoAdd dictionary entry for emailAddress in certificate subject
Nick Porter [Fri, 27 Jun 2025 16:34:04 +0000 (17:34 +0100)] 
Add dictionary entry for emailAddress in certificate subject

4 months agoMake fr_der_decode_pair_dbuff a public function
Nick Porter [Fri, 27 Jun 2025 16:33:29 +0000 (17:33 +0100)] 
Make fr_der_decode_pair_dbuff a public function

So the DER decoder can be used from other modules

4 months agoclean up parent/current/frame brace checking
Alan T. DeKok [Fri, 27 Jun 2025 18:01:44 +0000 (14:01 -0400)] 
clean up parent/current/frame brace checking

so that it works by looking at what it's supposed to be looking at,
and not sort of by accident

4 months agofix case where the section already exists
Alan T. DeKok [Fri, 27 Jun 2025 15:49:04 +0000 (11:49 -0400)] 
fix case where the section already exists

and check for dups

4 months agoadd SHUTDOWN error, too
Alan T. DeKok [Thu, 26 Jun 2025 20:42:14 +0000 (16:42 -0400)] 
add SHUTDOWN error, too

4 months agoon fatal error, shutdown the socket.
Alan T. DeKok [Thu, 26 Jun 2025 20:37:53 +0000 (16:37 -0400)] 
on fatal error, shutdown the socket.

don't silently change r/w to functions which don't do anything

4 months agoon shutdown, set r/w to return new SHUTDOWN error
Alan T. DeKok [Thu, 26 Jun 2025 20:37:29 +0000 (16:37 -0400)] 
on shutdown, set r/w to return new SHUTDOWN error

4 months agofix: Resolved issue where CSR's where not having the full subject field decoded since...
Ethan Thompson [Fri, 27 Jun 2025 15:30:12 +0000 (11:30 -0400)] 
fix: Resolved issue where CSR's where not having the full subject field decoded since the dictionary did not denote that it is a sequence of sets. (#5614)

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
4 months agomove UDP check so that it's always run
Alan T. DeKok [Thu, 26 Jun 2025 15:36:38 +0000 (11:36 -0400)] 
move UDP check so that it's always run

4 months agoadd @policy example with pre/post proxy
Alan T. DeKok [Thu, 26 Jun 2025 14:41:43 +0000 (10:41 -0400)] 
add @policy example with pre/post proxy

Hmm... the "conf2adoc" functionality doesn't put the configuration
in-line for @policy statements.  We'll have to edit that, and then
regenerate the examples

4 months agoautomatically set DH parameters for ephemeral keying
Alan T. DeKok [Thu, 26 Jun 2025 14:18:01 +0000 (10:18 -0400)] 
automatically set DH parameters for ephemeral keying

and update sample config / docs to match