]> git.ipfire.org Git - thirdparty/sqlite.git/log
thirdparty/sqlite.git
16 years agoAn additional memory leak in the parser fixed. Ticket #3911. (CVS 6751)
drh [Fri, 12 Jun 2009 03:47:36 +0000 (03:47 +0000)] 
An additional memory leak in the parser fixed.  Ticket #3911. (CVS 6751)

FossilOrigin-Name: 6197b492714e16396941ae6ba61f90f708d54728

16 years agoMake sure nested queries with USING clauses do not leak memory.
drh [Fri, 12 Jun 2009 03:27:26 +0000 (03:27 +0000)] 
Make sure nested queries with USING clauses do not leak memory.
Preliminary fix for ticket #3911. (CVS 6750)

FossilOrigin-Name: bd341a103c25395b1189d05edebfe4af8a943941

16 years agoModifications to the parser to eliminate unreachable code. (CVS 6749)
drh [Fri, 12 Jun 2009 02:27:14 +0000 (02:27 +0000)] 
Modifications to the parser to eliminate unreachable code. (CVS 6749)

FossilOrigin-Name: 457e0b245b1833c0d297bc6f4ff9785e6a2cee02

16 years agoHonor the SQLITE_OPEN_READONLY flag even on a :memory: or temporary database,
drh [Thu, 11 Jun 2009 17:32:45 +0000 (17:32 +0000)] 
Honor the SQLITE_OPEN_READONLY flag even on a :memory: or temporary database,
even though such a database is pointless.  Ticket #3908. (CVS 6748)

FossilOrigin-Name: 73ba841ac1ed39fb09b3917bafe0ce349e88eb04

16 years agoAdd an ALWAYS() to a conditional in where.c. (CVS 6747)
drh [Thu, 11 Jun 2009 17:04:28 +0000 (17:04 +0000)] 
Add an ALWAYS() to a conditional in where.c. (CVS 6747)

FossilOrigin-Name: 1fdb3e1e9af0672072f133dde06594fea2ef13c5

16 years agoChanges to reenable codec operation and to handle memory allocation
drh [Thu, 11 Jun 2009 00:47:20 +0000 (00:47 +0000)] 
Changes to reenable codec operation and to handle memory allocation
failures within a codec. (CVS 6746)

FossilOrigin-Name: 43a6ca98b1a6aff1f0f674ecabdc929efb314db7

16 years agoDo not let the reverse_unordered_selects pragma force the use of an index that
drh [Wed, 10 Jun 2009 19:33:28 +0000 (19:33 +0000)] 
Do not let the reverse_unordered_selects pragma force the use of an index that
would not otherwise be used.  Ticket #3904.
Also: remove an test which is always true. (CVS 6745)

FossilOrigin-Name: 78a391dca05dbe3ad1d8124b80b31bc2ce75778f

16 years agoRemove a NEVER() that can sometimes occur on an OOM error. (CVS 6744)
drh [Wed, 10 Jun 2009 11:07:00 +0000 (11:07 +0000)] 
Remove a NEVER() that can sometimes occur on an OOM error. (CVS 6744)

FossilOrigin-Name: c27f23bbafd2e4fa453c8e3b83667ea8173183a7

16 years agoMinor tweak to balance_quick() to save a few instructions. (CVS 6743)
danielk1977 [Wed, 10 Jun 2009 09:11:06 +0000 (09:11 +0000)] 
Minor tweak to balance_quick() to save a few instructions. (CVS 6743)

FossilOrigin-Name: 9ace995910c8b0b9e95dc20fd70be487199e37af

16 years agoRemove the actual checks that verify that memory pools (such as set up
drh [Tue, 9 Jun 2009 19:53:58 +0000 (19:53 +0000)] 
Remove the actual checks that verify that memory pools (such as set up
using SQLITE_CONFIG_HEAP) are 8-byte aligned.  But document that 8-byte
alignment is required. (CVS 6742)

FossilOrigin-Name: e9b55ccc8b6d4f21c9c8f8e7ba053475833fc833

16 years agoFix compiler warnings with MSVC build. (CVS 6741)
shane [Tue, 9 Jun 2009 18:58:52 +0000 (18:58 +0000)] 
Fix compiler warnings with MSVC build. (CVS 6741)

FossilOrigin-Name: 0bd84e7387802c58c820369ff27ef54adbdf2e96

16 years agoAvoid a false failure report in the test scripts caused by the vdbe stack "compressio...
shane [Tue, 9 Jun 2009 18:14:18 +0000 (18:14 +0000)] 
Avoid a false failure report in the test scripts caused by the vdbe stack "compression" script. (CVS 6740)

FossilOrigin-Name: 9d3329891c2227a1a3ded1c636ac615864010ca7

16 years agoRequire that the buffer specified by SQLITE_CONFIG_HEAP be 8-byte aligned. (CVS 6739)
drh [Tue, 9 Jun 2009 18:02:10 +0000 (18:02 +0000)] 
Require that the buffer specified by SQLITE_CONFIG_HEAP be 8-byte aligned. (CVS 6739)

FossilOrigin-Name: 18b78068cc94de51f081824c93f7b14c7c35726d

16 years agoChanges to tokenize.c to facilitate full coverage testing. (CVS 6738)
drh [Tue, 9 Jun 2009 18:01:37 +0000 (18:01 +0000)] 
Changes to tokenize.c to facilitate full coverage testing. (CVS 6738)

FossilOrigin-Name: 5e8c48cff7e96e6030b796dba409844f4c758a60

16 years agoChange savepoint4.test to limit database growth. Otherwise the test can take a very...
danielk1977 [Tue, 9 Jun 2009 15:25:33 +0000 (15:25 +0000)] 
Change savepoint4.test to limit database growth. Otherwise the test can take a very long time to run, depending on the prng. (CVS 6737)

FossilOrigin-Name: ed1d4f47ee9a2bcafdee92ee6bfcb2b0d1758f76

16 years agoModify mkkeywordhash.c so that it puts the original text of each token in
drh [Tue, 9 Jun 2009 14:27:41 +0000 (14:27 +0000)] 
Modify mkkeywordhash.c so that it puts the original text of each token in
a comment beside the "testcase()" macros. (CVS 6736)

FossilOrigin-Name: a7d0817c176832a88788cc973c0aae8dcab57364

16 years agoEnable cell overflow checking in sqlite3BtreeInitPage() using the
drh [Tue, 9 Jun 2009 13:42:24 +0000 (13:42 +0000)] 
Enable cell overflow checking in sqlite3BtreeInitPage() using the
compile-time option SQLITE_ENABLE_OVERSIZE_CELL_CHECK.  Change the tests
so that they recognize different error messages depending on the setting
of this macro. (CVS 6735)

FossilOrigin-Name: 56bff6eb2fc5f0afbd96afc986671ec744bd40e1

16 years agoAvoid calling fillInCell() to create an internal node intkey cell from balance_nonroo...
danielk1977 [Tue, 9 Jun 2009 11:34:10 +0000 (11:34 +0000)] 
Avoid calling fillInCell() to create an internal node intkey cell from balance_nonroot(). A single putVarint() does the same thing more quickly. (CVS 6734)

FossilOrigin-Name: 2e5d42aeb40c3c6eea373a9ae3fbdf4e8087cd58

16 years agoOnly do the cell overread checks in sqlite3BtreeInitPage if
drh [Tue, 9 Jun 2009 10:37:03 +0000 (10:37 +0000)] 
Only do the cell overread checks in sqlite3BtreeInitPage if
SQLITE_OVERREAD_CHECK is defined at compile-time. (CVS 6733)

FossilOrigin-Name: 49f544ebae8dc3cf7cf6189536c56ebb7d258a86

16 years agoDo not clear the MemPage.nFree variable when insertCell() adds an overflow cell to...
danielk1977 [Tue, 9 Jun 2009 09:41:00 +0000 (09:41 +0000)] 
Do not clear the MemPage.nFree variable when insertCell() adds an overflow cell to a page. Not doing this means balance_quick() can avoid a call to sqlite3BtreeInitPage(). (CVS 6732)

FossilOrigin-Name: 8f1c1f61f7bc5270212725cf0a056872df983f49

16 years agoAdditional comments to clarify the operation of the LIKE optimizer in
drh [Mon, 8 Jun 2009 19:44:36 +0000 (19:44 +0000)] 
Additional comments to clarify the operation of the LIKE optimizer in
where.c. (CVS 6731)

FossilOrigin-Name: cc9c12170c3f6f0f485977e47e7fbb75c50e82b1

16 years agoClarification of the operation of the OR-term optimizer in where.c. (CVS 6730)
drh [Mon, 8 Jun 2009 17:11:08 +0000 (17:11 +0000)] 
Clarification of the operation of the OR-term optimizer in where.c. (CVS 6730)

FossilOrigin-Name: 6b42dc3d04e98f91c203c277926ed6ead62a9270

16 years agoChange the btree balance code so that it does not call balance_nonroot() recursively...
danielk1977 [Mon, 8 Jun 2009 14:49:45 +0000 (14:49 +0000)] 
Change the btree balance code so that it does not call balance_nonroot() recursively. (CVS 6729)

FossilOrigin-Name: 7863db904d6fc36417c923e3d135eb2c145b9013

16 years agoIncrease the version number to 3.6.15 in preparation for the next release. (CVS 6728)
drh [Mon, 8 Jun 2009 12:52:47 +0000 (12:52 +0000)] 
Increase the version number to 3.6.15 in preparation for the next release. (CVS 6728)

FossilOrigin-Name: 456ea541d67221a573b63e264c83f4448f2ed569

16 years agoDisable the LIKE optimization if the affinity of the LHS column is
drh [Sun, 7 Jun 2009 23:45:10 +0000 (23:45 +0000)] 
Disable the LIKE optimization if the affinity of the LHS column is
not TEXT.  Ticket #3901. (CVS 6727)

FossilOrigin-Name: a255c645c46ae03b65f862858fe57e462076e1fc

16 years agoUpdate the error message on one of the corruption tests to account for the fact
drh [Sat, 6 Jun 2009 19:21:13 +0000 (19:21 +0000)] 
Update the error message on one of the corruption tests to account for the fact
that we are finding the corruption sooner. (CVS 6726)

FossilOrigin-Name: ba9848e7b89df1fb6bf6db2b9d66cd3ffce375df

16 years agoFix an error in the malloc.test test script causing a small buffer overread. (CVS...
danielk1977 [Sat, 6 Jun 2009 16:08:22 +0000 (16:08 +0000)] 
Fix an error in the malloc.test test script causing a small buffer overread. (CVS 6725)

FossilOrigin-Name: 4d129bee696f3a537f7ea5501a387012fc08c27e

16 years agoMake sure the result of sqlite3VdbeGetOp() is not used as an array following
drh [Sat, 6 Jun 2009 15:17:27 +0000 (15:17 +0000)] 
Make sure the result of sqlite3VdbeGetOp() is not used as an array following
an OOM error, since after (6691) it might be a single-entry dummy opcode. (CVS 6724)

FossilOrigin-Name: 127b13981960a9690de09e8f9d0b38a4bd76015f

16 years agoWhen building in debug mode with gcc, force the nullMem variable in function columnMe...
danielk1977 [Sat, 6 Jun 2009 14:13:26 +0000 (14:13 +0000)] 
When building in debug mode with gcc, force the nullMem variable in function columnMem() to be aligned to an 8-byte boundary. Otherwise an assert() statement may fail. (CVS 6723)

FossilOrigin-Name: 3fd6c72da599347af70897b30b86a4ba641d4cd9

16 years agoDetect when database corruption causes an attemp to set the pointer map
drh [Fri, 5 Jun 2009 18:44:15 +0000 (18:44 +0000)] 
Detect when database corruption causes an attemp to set the pointer map
value for a pointer map page and report the corruption. (CVS 6722)

FossilOrigin-Name: 3ae4880bee3a0312c61cdd36f4fa50286cc2ef48

16 years agoRemove leftover "breakpoint" commands from test scripts. Also remove blank
drh [Fri, 5 Jun 2009 17:09:11 +0000 (17:09 +0000)] 
Remove leftover "breakpoint" commands from test scripts.  Also remove blank
lines at the end of scripts. (CVS 6721)

FossilOrigin-Name: 1fef16ec2b89981770cf44f606a420fbe031a7a4

16 years agoDo not cast an unsigned int into an int for comparison. (CVS 6720)
drh [Fri, 5 Jun 2009 16:46:53 +0000 (16:46 +0000)] 
Do not cast an unsigned int into an int for comparison. (CVS 6720)

FossilOrigin-Name: 302ab855e62dfae8507800302dae479e0494b81a

16 years agoTake care that a corrupt variable-length integer does not cause 32-bit
drh [Fri, 5 Jun 2009 14:17:21 +0000 (14:17 +0000)] 
Take care that a corrupt variable-length integer does not cause 32-bit
integer overflow when parsing a record format, nor cause excessively large
memory allocations. (CVS 6719)

FossilOrigin-Name: 38b20327a80996c7044b88be32161ac4ac0ec3a9

16 years agoEarlier detection of freelist corruption in the page allocation routines. (CVS 6718)
drh [Thu, 4 Jun 2009 19:06:09 +0000 (19:06 +0000)] 
Earlier detection of freelist corruption in the page allocation routines. (CVS 6718)

FossilOrigin-Name: e557c8e5846f9c4eaaeb3bd07614ac101bb0b3d0

16 years agoFix an assertion fault in balance_quick() that occurs when an interior
drh [Thu, 4 Jun 2009 17:02:51 +0000 (17:02 +0000)] 
Fix an assertion fault in balance_quick() that occurs when an interior
btree node has zero cells due to database corruption.  Also update the
corrupt7.test result vectors for a couple of cases where the error report
on database corruption changed due to earlier detection. (CVS 6717)

FossilOrigin-Name: 1335e4440f5a3d24ce9ce187e0e23fc9b166ca98

16 years agoIf the root page of a btree is empty and is also not a leaf page and the
drh [Thu, 4 Jun 2009 16:14:33 +0000 (16:14 +0000)] 
If the root page of a btree is empty and is also not a leaf page and the
page is not page 1, then report database corruption. (CVS 6716)

FossilOrigin-Name: 52b02ca5f3e5fdf2f3e02e9d8e016028d0842818

16 years agoReduce the stack usage of balance_quick(). (CVS 6715)
danielk1977 [Thu, 4 Jun 2009 14:46:08 +0000 (14:46 +0000)] 
Reduce the stack usage of balance_quick(). (CVS 6715)

FossilOrigin-Name: e7ad68e93b19b59cb16205c4b48fd9d6492dbb02

16 years agoMinor updates to comments in test scripts. (CVS 6714)
shane [Thu, 4 Jun 2009 02:47:03 +0000 (02:47 +0000)] 
Minor updates to comments in test scripts. (CVS 6714)

FossilOrigin-Name: 453ff88f73a01a54ff464563effdb63014b1972c

16 years agoMinor tweak to test script to ensure every byte in file touched at least once. (CVS...
shane [Thu, 4 Jun 2009 02:46:19 +0000 (02:46 +0000)] 
Minor tweak to test script to ensure every byte in file touched at least once. (CVS 6713)

FossilOrigin-Name: bc6c2d894b711361808a19b673803186d3a28369

16 years agoFix two instances where a malformed header in a database file (in other words
drh [Thu, 4 Jun 2009 00:11:56 +0000 (00:11 +0000)] 
Fix two instances where a malformed header in a database file (in other words
a corrupt database file) can lead to an assertion fault. (CVS 6712)

FossilOrigin-Name: 4e92c7f20afa51849128aa1d784ab885b517a73d

16 years agoChange the pcache1.c implementation so that the "header" occurs at the end
drh [Wed, 3 Jun 2009 21:04:35 +0000 (21:04 +0000)] 
Change the pcache1.c implementation so that the "header" occurs at the end
of page buffer, not at the beginning.  This insures that the 20 bytes
immediately following the page buffer are mapped if a read of the page
buffer overruns due to a malformed cell. (CVS 6711)

FossilOrigin-Name: c54de1f54080de7e134d7b562498abb5337a0a46

16 years agoAdd corruptD.test, a container for testing the "cell overflow" problem. Also shuffle...
danielk1977 [Wed, 3 Jun 2009 17:26:17 +0000 (17:26 +0000)] 
Add corruptD.test, a container for testing the "cell overflow" problem. Also shuffle a small amount of code in BtreeInitPage() to check that the page header pointer to the start of the cell offset array is set to a sane value. (CVS 6710)

FossilOrigin-Name: 7fa5d3cb0fa05f7d901bcc139c2c037ce5944caa

16 years agoDefine a set of constants to use as the "index" argument to sqlite3BtreeGetMeta and...
danielk1977 [Wed, 3 Jun 2009 11:25:07 +0000 (11:25 +0000)] 
Define a set of constants to use as the "index" argument to sqlite3BtreeGetMeta and UpdateMeta. This makes some parts of the code easier to follow. (CVS 6709)

FossilOrigin-Name: 6dbf4eca00f845baa7200aba421d0bc158ba96aa

16 years agoAdditional changes to reduce stack usage. The SQLITE_SMALL_STACK compile-time
drh [Wed, 3 Jun 2009 01:24:54 +0000 (01:24 +0000)] 
Additional changes to reduce stack usage.  The SQLITE_SMALL_STACK compile-time
option is now available. (CVS 6708)

FossilOrigin-Name: baea79fd0cfeb860973846c3f2776776c87f0ae3

16 years agoFurther reductions in the amount of stack space required. (CVS 6707)
drh [Tue, 2 Jun 2009 21:31:38 +0000 (21:31 +0000)] 
Further reductions in the amount of stack space required. (CVS 6707)

FossilOrigin-Name: 04bad9eb6dd8bf7cafc9f3918b676e95d5b1c984

16 years agoTweaks to vdbe.c to further reduce stack space requirements. (CVS 6706)
drh [Tue, 2 Jun 2009 16:06:03 +0000 (16:06 +0000)] 
Tweaks to vdbe.c to further reduce stack space requirements. (CVS 6706)

FossilOrigin-Name: 6f2aab3f7be12710b703eda22b1d5c0e8f85f814

16 years agoAdd a test case for ticket #3893 and ticket #3894. (CVS 6705)
drh [Tue, 2 Jun 2009 15:47:37 +0000 (15:47 +0000)] 
Add a test case for ticket #3893 and ticket #3894. (CVS 6705)

FossilOrigin-Name: 2472f6db95cd537a908bdbbbbc41bad2bd987b2f

16 years agoAdd the vdbe-compress.tcl script which automatically refactors the
drh [Tue, 2 Jun 2009 15:21:42 +0000 (15:21 +0000)] 
Add the vdbe-compress.tcl script which automatically refactors the
sqlite3VdbeExec() routine to use less stack space.  Use this script
when constructing the amalgamation. (CVS 6704)

FossilOrigin-Name: 7f43391831b03e53d967acee6ae02089740aaedb

16 years agoAvoid allocating large objects on the stack in the incremental BLOB I/O
drh [Mon, 1 Jun 2009 19:53:30 +0000 (19:53 +0000)] 
Avoid allocating large objects on the stack in the incremental BLOB I/O
interface. (CVS 6703)

FossilOrigin-Name: ea7dfde700fb57ed0ecb5000a55abbf45aa1e09d

16 years agoMalloc for space to hold the Parse object in sqlite3_prepare() and friends.
drh [Mon, 1 Jun 2009 18:18:20 +0000 (18:18 +0000)] 
Malloc for space to hold the Parse object in sqlite3_prepare() and friends.
Or, if compiled with SQLITE_USE_ALLOCA, obtain space for the object from
alloca(). (CVS 6702)

FossilOrigin-Name: c7c0c58e472cd8277b2ad58bb60834190bace4fa

16 years agoAdded assert to verify winMutex system is inited before "static" mutexes are used...
shane [Mon, 1 Jun 2009 17:10:22 +0000 (17:10 +0000)] 
Added assert to verify winMutex system is inited before "static" mutexes are used. (CVS 6701)

FossilOrigin-Name: b126013b5a1d6526810139d19acbec7fd0ab8168

16 years agoEnsure that "static" mutexes are deleted on shutdown so that they are not leaked...
shane [Mon, 1 Jun 2009 17:06:07 +0000 (17:06 +0000)] 
Ensure that "static" mutexes are deleted on shutdown so that they are not leaked across restarts. (CVS 6700)

FossilOrigin-Name: 4e75897ee177bd24145f9dbfccd41a03c108440f

16 years agoFix compiler warnings with MSVC build. (CVS 6699)
shane [Mon, 1 Jun 2009 16:53:09 +0000 (16:53 +0000)] 
Fix compiler warnings with MSVC build. (CVS 6699)

FossilOrigin-Name: 0791588520603d106aa0b8ce24d68b740b7b80c8

16 years agoFix a couple of Windows only issues with test scripts. (CVS 6698)
shane [Mon, 1 Jun 2009 16:42:17 +0000 (16:42 +0000)] 
Fix a couple of Windows only issues with test scripts. (CVS 6698)

FossilOrigin-Name: 0f6bc5e1ba6937b36df08ed3b5903839389021bb

16 years agoCode simplifications to facilitate coverage testing following the recent
drh [Sun, 31 May 2009 21:21:40 +0000 (21:21 +0000)] 
Code simplifications to facilitate coverage testing following the recent
changes to the Expr object. (CVS 6697)

FossilOrigin-Name: ee9a144d448a76f29c3ca03851c1aeef539068e2

16 years agoFix the ".genfkey" command of the CLI so that it does not leak memory
drh [Sun, 31 May 2009 17:16:09 +0000 (17:16 +0000)] 
Fix the ".genfkey" command of the CLI so that it does not leak memory
if sqlite3_realloc() fails.  Ticket #3891. (CVS 6696)

FossilOrigin-Name: a028d69c70ae961f418052a91aa1518e80a8ddf5

16 years agoFix typo reported by ticket #3888. Other minor edits to facilitate
drh [Sat, 30 May 2009 23:35:43 +0000 (23:35 +0000)] 
Fix typo reported by ticket #3888.  Other minor edits to facilitate
coverage testing. (CVS 6695)

FossilOrigin-Name: 164adf261d2536f16c83e44f6482dfb3d04a45d5

16 years agoSimplifications to the expr.c source module resulting from structural
drh [Sat, 30 May 2009 20:49:20 +0000 (20:49 +0000)] 
Simplifications to the expr.c source module resulting from structural
testing. (CVS 6694)

FossilOrigin-Name: f760bb7a0372d11ac7e3287b8a56fc4261e6371c

16 years agoFix for ticket #3887. Other unrelated bits of code cleanup in the expr.c
drh [Sat, 30 May 2009 14:16:31 +0000 (14:16 +0000)] 
Fix for ticket #3887.  Other unrelated bits of code cleanup in the expr.c
source module. (CVS 6693)

FossilOrigin-Name: 00e7250f11e190cd915870438d172f574d110e6d

16 years agoIn vacuum.c use "PagerIsMemdb(X)" instead of "PagerFile(X)->pMethods==0". (CVS 6692)
danielk1977 [Sat, 30 May 2009 10:46:10 +0000 (10:46 +0000)] 
In vacuum.c use "PagerIsMemdb(X)" instead of "PagerFile(X)->pMethods==0". (CVS 6692)

FossilOrigin-Name: 874295ce71380da3f4c9296df0e0ce5ece136220

16 years agoEnhance the sqlite3VdbeGetOp() routine so that it always returns a pointer
drh [Fri, 29 May 2009 19:00:12 +0000 (19:00 +0000)] 
Enhance the sqlite3VdbeGetOp() routine so that it always returns a pointer
to VdbeOp, even following an OOM fault.  This simplifies error handling in
callers.  Cleanup to the column cache logic and the expr.c source module. (CVS 6691)

FossilOrigin-Name: ede06dacdf7acab23cd9666a0a0d092a637bcb78

16 years agoRefinements in expression handling logic that have resulted from recent
drh [Fri, 29 May 2009 14:39:07 +0000 (14:39 +0000)] 
Refinements in expression handling logic that have resulted from recent
structural testing. (CVS 6690)

FossilOrigin-Name: bd89f2c29b00e6b473f30c2e929d2f626721ad92

16 years agoStill more refinements to the hasHotJournal() fix of ticket #3883. (CVS 6689)
drh [Fri, 29 May 2009 11:57:38 +0000 (11:57 +0000)] 
Still more refinements to the hasHotJournal() fix of ticket #3883. (CVS 6689)

FossilOrigin-Name: 726b425e43e5d864e7e83853bdf134debc1ffb59

16 years agoThe hasHotJournal() fix of check-in (6687) causes some minor problems in
drh [Fri, 29 May 2009 10:55:29 +0000 (10:55 +0000)] 
The hasHotJournal() fix of check-in (6687) causes some minor problems in
various alternative operating modes, such as locking_mode=EXCLUSIVE.  This
additional patch attempts to fix those concerns.  Ticket #3883. (CVS 6688)

FossilOrigin-Name: a2ba61d927a06c390a9a818a013328092b802222

16 years agoModify the hasHotJournal() routine to return a false-positive if it is
drh [Fri, 29 May 2009 00:30:30 +0000 (00:30 +0000)] 
Modify the hasHotJournal() routine to return a false-positive if it is
unable to open the journal file to check its header due to a race
condition.  Processing downstream of hasHotJournal() already knows how to
deal with false-positives.  Ticket #3883. (CVS 6687)

FossilOrigin-Name: d6b5d8e1ab8e5d3348ace560230702718a2a8af9

16 years agoRemove references to deleted function sqlite3ExprRegister(). Changes to
drh [Thu, 28 May 2009 21:04:37 +0000 (21:04 +0000)] 
Remove references to deleted function sqlite3ExprRegister().  Changes to
the expr.c source module to promote better testing. (CVS 6686)

FossilOrigin-Name: 6ae4ad6ebee4db88c411df97bb1de574708dd53c

16 years agoFix a NULL pointer dereference following an OOM error in the column name
drh [Thu, 28 May 2009 14:34:49 +0000 (14:34 +0000)] 
Fix a NULL pointer dereference following an OOM error in the column name
resolver. (CVS 6685)

FossilOrigin-Name: 3b46142532934d17aa136c2e56e58e7828df0f54

16 years agoMake sure the column name resolver does not try to duplicate Expr.u.zToken
drh [Thu, 28 May 2009 12:49:53 +0000 (12:49 +0000)] 
Make sure the column name resolver does not try to duplicate Expr.u.zToken
when the Expr.u.iValue union member is the element being used. (CVS 6684)

FossilOrigin-Name: 376ecf0d87e4a2329f5861401f83ed9ceb35d528

16 years agoWorkaround the need for internal API sqlite3BtreeCursorDb(). It was only being used...
danielk1977 [Thu, 28 May 2009 11:05:57 +0000 (11:05 +0000)] 
Workaround the need for internal API sqlite3BtreeCursorDb(). It was only being used for an assert() statement, which can be done differently. (CVS 6683)

FossilOrigin-Name: 5904af6e6df3effdaaa30e7cf96ee316fc09b28d

16 years agoAdditional refinements to Expr handling. Restore compression of trigger
drh [Thu, 28 May 2009 01:00:55 +0000 (01:00 +0000)] 
Additional refinements to Expr handling.  Restore compression of trigger
expressions.  Change Expr.zToken to Expr.u.zToken and added Expr.u.iValue.
Remove an unnecessary ExprDup from CHECK constraint processing.  And so forth. (CVS 6682)

FossilOrigin-Name: 4ac2bdfbb4230b6ceaae87e738fa61036bbe03cb

16 years agoSimplifications to the Expr object: Remove Expr.span completely and convert
drh [Wed, 27 May 2009 10:31:29 +0000 (10:31 +0000)] 
Simplifications to the Expr object:  Remove Expr.span completely and convert
Expr.token into a char* Expr.zToken.  Also simplify the Token object by
removing the Token.dyn and Token.quoted fields. (CVS 6681)

FossilOrigin-Name: 7cb1c3ba0759539cb035978fdaff6316775986f3

16 years agoFix the rtree test module so that it works even if the ext/ subfolder is
drh [Mon, 25 May 2009 14:17:35 +0000 (14:17 +0000)] 
Fix the rtree test module so that it works even if the ext/ subfolder is
omitted from the tree. (CVS 6679)

FossilOrigin-Name: 086206e1f51e22ce7b9f45865b370088db126cd2

16 years agoWhen pinning a temp register after it is reused by the column cache, make
drh [Mon, 25 May 2009 11:46:29 +0000 (11:46 +0000)] 
When pinning a temp register after it is reused by the column cache, make
sure all instances of that register in the cache are pinned so that the
register is never reused for a different purpose.  Ticket #3879. (CVS 6676)

FossilOrigin-Name: 5f358e63712e8de93bd6fecc5131badeef0292be

16 years agoAdd a test case for ticket #3879. (CVS 6675)
danielk1977 [Mon, 25 May 2009 11:46:10 +0000 (11:46 +0000)] 
Add a test case for ticket #3879. (CVS 6675)

FossilOrigin-Name: 5b9b66f47b0b8178427806149958387d32b70dc2

16 years agoAdditional clarification of the 3rd parameter to sqlite3_create_function().
drh [Sun, 24 May 2009 21:59:27 +0000 (21:59 +0000)] 
Additional clarification of the 3rd parameter to sqlite3_create_function().
Documentation change only; no changes to code.  Ticket #3875. (CVS 6674)

FossilOrigin-Name: dd75e376e8fed4f2e347672d483ee7c1929007cf

16 years agoIn the previous, the upper bound on the number of function arguments is
drh [Sun, 24 May 2009 11:08:49 +0000 (11:08 +0000)] 
In the previous, the upper bound on the number of function arguments is
127, not 255.  Ticket #3876 (CVS 6673)

FossilOrigin-Name: 4fe4c5fac51c0a5b50f839a3f43d786e1ff4a4e0

16 years agoCorrect and clarify the documentation on the third parameter to
drh [Sun, 24 May 2009 11:07:49 +0000 (11:07 +0000)] 
Correct and clarify the documentation on the third parameter to
sqlite3_create_function(). (CVS 6672)

FossilOrigin-Name: 6b7929ed36fa14291b6cb09de5808100945ad7a0

16 years agoDo not transform a WHERE clause of the form "a = ? OR a = ?" to "a IN (?, ?)" if...
danielk1977 [Fri, 22 May 2009 15:43:26 +0000 (15:43 +0000)] 
Do not transform a WHERE clause of the form "a = ? OR a = ?" to "a IN (?, ?)" if "a" is a column of a virtual table. Ticket #3871. (CVS 6671)

FossilOrigin-Name: fad88e71cf195e703f7b56b13f0c1818fd0dac84

16 years agoAdd an assert() to pcache1.c to double-check that page cache buffer memory
drh [Fri, 22 May 2009 11:12:23 +0000 (11:12 +0000)] 
Add an assert() to pcache1.c to double-check that page cache buffer memory
is never allocated if pcache1 is not enabled.  Ticket #3872 (CVS 6670)

FossilOrigin-Name: 93369d91abe10975507ea9302c145e3ddd0c2c76

16 years agoAdditional changes to pcache1 to prevent the page buffer memory from being
drh [Fri, 22 May 2009 11:10:24 +0000 (11:10 +0000)] 
Additional changes to pcache1 to prevent the page buffer memory from being
configured if pcache1 is not enabled.  Ticket #3872. (CVS 6669)

FossilOrigin-Name: 5153ad19daf0f3b0334b2a06655142899203abbf

16 years agoMake sure sqlite3_shutdown() completely disables the default pager cache
drh [Fri, 22 May 2009 10:53:29 +0000 (10:53 +0000)] 
Make sure sqlite3_shutdown() completely disables the default pager cache
mechanism in pcache1.c.  Ticket #3872.  Also fix some comments associated
with configuring the page cache. (CVS 6668)

FossilOrigin-Name: 6240992cef5cb867d7a638f1906d05aa8efd0652

16 years agoAdd omitted word in the documentation for total_change_count().
drh [Fri, 22 May 2009 01:02:26 +0000 (01:02 +0000)] 
Add omitted word in the documentation for total_change_count().
ticket #3870. (CVS 6667)

FossilOrigin-Name: 3f6fd16f92a16445891142b0a7dc9f6d6dc06546

16 years agoFix an 8-byte alignment problem on HP/UX. Ticket #3869 (CVS 6666)
drh [Fri, 22 May 2009 01:00:12 +0000 (01:00 +0000)] 
Fix an 8-byte alignment problem on HP/UX.  Ticket #3869 (CVS 6666)

FossilOrigin-Name: fc64f8509299a398ac1513e1778f271083e3eabc

16 years agoSimplifications to expr.c in support of full coverage testing. (CVS 6665)
drh [Thu, 21 May 2009 20:41:32 +0000 (20:41 +0000)] 
Simplifications to expr.c in support of full coverage testing. (CVS 6665)

FossilOrigin-Name: 309adb5e22af2735b69460c164d870aea99c6da3

16 years agoIn the CLI in the ".dump" command, do not attempt to clear the sqlite_sequence
drh [Thu, 21 May 2009 15:15:00 +0000 (15:15 +0000)] 
In the CLI in the ".dump" command, do not attempt to clear the sqlite_sequence
table until the first row of content of that table is seen.  Ticket #3867 (CVS 6664)

FossilOrigin-Name: bedd5ad1942021ef2b3defde3ff3e8aead86137e

16 years agoIn the CLI, always "dump" the sqlite_sequence table last. Ticket #3867 (CVS 6663)
drh [Thu, 21 May 2009 14:51:03 +0000 (14:51 +0000)] 
In the CLI, always "dump" the sqlite_sequence table last.  Ticket #3867 (CVS 6663)

FossilOrigin-Name: a0028d4808275cb1d020d56344d90b2a04603f4d

16 years agoAdd conditional 'extern "C"' block to sqlite3async.h. Ticket #3866. (CVS 6662)
danielk1977 [Thu, 21 May 2009 04:42:19 +0000 (04:42 +0000)] 
Add conditional 'extern "C"' block to sqlite3async.h. Ticket #3866. (CVS 6662)

FossilOrigin-Name: e4d1b117c90dca341bfa74291c7dfc2afca38cc6

16 years agoFix a memory leak that occurs when an out-of-memory error occurs while
drh [Wed, 20 May 2009 20:10:47 +0000 (20:10 +0000)] 
Fix a memory leak that occurs when an out-of-memory error occurs while
preparing a statement that has multiple virtual table updates within
triggers.  Other virtual table changes to support full-coverage testing. (CVS 6661)

FossilOrigin-Name: 02b77a582c65e0eb45eb1a9abbdeef11f52d7ce6

16 years agoRemove unused, undocumented, and untested error reporting logic from the
drh [Wed, 20 May 2009 16:22:02 +0000 (16:22 +0000)] 
Remove unused, undocumented, and untested error reporting logic from the
xFindFunction interface in virtual tables. (CVS 6660)

FossilOrigin-Name: 55d6ced262f5281076e4a68097ed21e150a9c225

16 years agoUpdates to the extension loading logic to support full coverage testing. (CVS 6659)
drh [Wed, 20 May 2009 02:40:45 +0000 (02:40 +0000)] 
Updates to the extension loading logic to support full coverage testing. (CVS 6659)

FossilOrigin-Name: 929cfbc66f6e2ea6b44417305d0f4ae36567c9bf

16 years agoChanges to select.c to facilitate full coverage testing. (CVS 6658)
drh [Tue, 19 May 2009 19:04:58 +0000 (19:04 +0000)] 
Changes to select.c to facilitate full coverage testing. (CVS 6658)

FossilOrigin-Name: f678ed34faab88f4e126e553119773386c7c84fa

16 years agoImprovements to the SQLITE_INT_TO_PTR macro to reduce the number of
drh [Tue, 19 May 2009 14:21:28 +0000 (14:21 +0000)] 
Improvements to the SQLITE_INT_TO_PTR macro to reduce the number of
warnings.  For some platforms it might be necessary to compile with
the -DHAVE_STDINT_H flag.  Ticket #3860. (CVS 6657)

FossilOrigin-Name: 1b0ee9d188c000a2331caae2e9c8b89b0bcbc0b0

16 years agoUpdate the showdb.c utility so that it works with databases larger than 4GiB. (CVS...
drh [Tue, 19 May 2009 03:21:52 +0000 (03:21 +0000)] 
Update the showdb.c utility so that it works with databases larger than 4GiB. (CVS 6656)

FossilOrigin-Name: 9675b6223645fe01b202cbefae63f3209a50efcc

16 years agoFix memdb.test so that it works when OMIT_AUTOVACUUM is defined. (CVS 6649)
danielk1977 [Mon, 18 May 2009 16:04:38 +0000 (16:04 +0000)] 
Fix memdb.test so that it works when OMIT_AUTOVACUUM is defined. (CVS 6649)

FossilOrigin-Name: 8c3c0c24c82606df41653dbf7324bf9f166c933a

16 years agoChanges to select.c in support of full coverage testing. (CVS 6647)
drh [Mon, 18 May 2009 15:46:07 +0000 (15:46 +0000)] 
Changes to select.c in support of full coverage testing. (CVS 6647)

FossilOrigin-Name: e225f365bd9353f753161887e05fe1eccaf9be1d

16 years agoFix a typo on a comment associated with check-in (6641) and ticket #3860. (CVS 6646)
drh [Mon, 18 May 2009 13:34:37 +0000 (13:34 +0000)] 
Fix a typo on a comment associated with check-in (6641) and ticket #3860. (CVS 6646)

FossilOrigin-Name: 43051e0315246d734a81ccef2cf1a0cc159f239b

16 years agoRemove debugging code accidently left in check-in (6642). Ticket #3862. (CVS 6645)
drh [Sun, 17 May 2009 15:29:31 +0000 (15:29 +0000)] 
Remove debugging code accidently left in check-in (6642).  Ticket #3862. (CVS 6645)

FossilOrigin-Name: 0d974613473b9d2af71638248a57036f903ef387

16 years agoTake care to free the memory for the ORDER BY clause on SELECT statements
drh [Sun, 17 May 2009 15:26:20 +0000 (15:26 +0000)] 
Take care to free the memory for the ORDER BY clause on SELECT statements
containing errors and contained within triggers.  Ticket #3863. (CVS 6644)

FossilOrigin-Name: dd665eac8c04259e44a95827ebd1f037460fe1b2

16 years agoFix a typo in the sqlite3_blob_open() documentation. (CVS 6643)
drh [Sun, 17 May 2009 12:07:47 +0000 (12:07 +0000)] 
Fix a typo in the sqlite3_blob_open() documentation. (CVS 6643)

FossilOrigin-Name: 92866482ef7cc91b5ac7bebec7e6edf900aa64c6

16 years agoTweaks and simplifications to select.c to facility full coverage testing. (CVS 6642)
drh [Sun, 17 May 2009 02:06:14 +0000 (02:06 +0000)] 
Tweaks and simplifications to select.c to facility full coverage testing. (CVS 6642)

FossilOrigin-Name: e3ccbc69babd05d45db8065f6612751eda1aa645