linter: Remove the unused ELF stuff

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Move RUNPATH check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Move the CF Protection check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Move RELRO check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Move execstack check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Move SSP check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Don't strip unneeded stuff

We will otherwise loose the symtab and then we cannot perform the SSP
check any more.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Move the PIE check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Use the new strip check for debug information

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Use new functions to check the Build ID

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Implement reading the Debuglink

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Use the ELF strip check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Replace the ELF check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Use the new ELF object

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Only strip files that are not stripped, yet

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Add function to check if a file is stripped

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Actually only replace /usr/bin/env as interpreter

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Use the new ELF abstraction to read the Build ID

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Add function to read the Build ID

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Add a convenience function to open from a file object

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Keep a simple reference to the ELF header at all times

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Store the path

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

elf: Begin scaffolding for an object that handles ELF files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

digests: Don't rewind file after processing to keep r set

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Fix ELF check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Fix script interpreters again

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Allow passing the mode on fopen()

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

util: Terminate pakfire_copy() even if feof() does not work

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Silence the RUNPATH check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Remove any previously existing debuglinks

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Ignore if source files don't exist

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

FHS: Permit sub-directories in /usr/src/debug

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Jenkins: Disable the broken branch check

For some reason this is (yet again) not working.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packages: Ignore dependencies starting with "#"

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

path: Convince the static analyzer that path is set

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Only call linkat() with a valid file descriptor

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Initialize tmppath in case there is an error

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

util: Implement rewind() that returns any errors

The Clang Static Analyzer complains that we don't check errno after
using rewind(). This patch adds a new version of this function which
returns an error.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Fix RELRO check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packagelist: Fix keep going logic

This is supposed to store the last error code and return it when the
flag is set.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Fix check if we have an ELF file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Revert "tests: Don't collect coverage information about tests"

This reverts commit bcb8a8de463b9a29969ef7acd78a58021f0bda55.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: (Re-)compress all debug information using Zstandard

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

CFLAGS: Deduplicate debugging information

  https://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html#index-fdebug-types-section

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Makefile: Link tests with -lgcov again

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

scripts: Remove the old strip script

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Actually strip binaries

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Don't complain if there is no symbol table

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Add function to replace file content from another fd

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Check that files in /usr/lib/debug are ELF and not stripped

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Fix removing items

This also now shrinks the array whenever possible so that we won't waste
any memory if the filelist shrinks by a large amount.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Clear number of entries after the filelist has been cleared

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Write the debug information directory the Build ID file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Add option to pass flags to open()

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Extract debug information into a separate file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Extract sources in the main process again

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Revert "configure: Link against libbfd"

This reverts commit 2a6657e51c66a5dc5cf1f5a059197d0be15a8ba1.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Revert "stripper: Use libbfd to extract the Build ID"

This reverts commit 44ffbd6f1f47115072e8c8d4ea751f6eacb05dba.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Use libbfd to extract the Build ID

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Link against libbfd

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Extract the GNU Build ID

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Check if we actually returned a file handle

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packager: Improve passing on error codes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Open the file only once

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor unquoting strings

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Don't collect coverage information about tests

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Create a unified stripping function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

scripts: Don't extract sources in the strip script any more

This has been moved to the stripper.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Show progress bar when stripping files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Implement copying sources

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

FHS: Permit debug sources

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Actually sort when adding files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Drop the sort function again

The filelist was intended to be sorted all the time.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Fix return code when we run out of buffer space

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Don't overwrite r when using a progress bar

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Run the stripping inside the jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Keep a reference to the jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Fix path when opening a file inside the jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ctx: Set a flag when we are running inside the jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Change callback signature to include the context instead the inaccessible jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Add a function to call a custom callback inside the jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Pass the environment to the interactive shell

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Rename pakfire_jail_exec to pakfire_jail_exec_command

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

env: Declare the struct before importing anything

This silences a compiler warning.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Add tests for env

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Merge the basic environment with the custom environment

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Simplify reading the parser environment

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Move the environment into an extra object

This allows us to pass a custom environment to each command that we are
running. This helps us to keep the environment a lot cleaner.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Add struct to pass more stuff to commands

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Create a callback function that is called in the child process

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Revert "file: Remove ELF detection with libelf"

This reverts commit 65fcf2eb3c4fceb81887bd969e68ceae8613e26e.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Revert "stripper: Throw this away"

This reverts commit 76774bf62a622da82ca589519331371c71b87bf1.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Add a test to check if the log buffer limit works

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Check for matching files in a loop

When sending the filelist to scripts, we require the event loop to call
us again and again. This seems to cause a deadlock situation and we now
rather search for matching files in a loop until we have found a result
(or not).

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packager: Sort files before writing the archive

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: log buffer: Test invalid function calls

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

log buffer: Check inputs on dequeue

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

log buffer: Since length is signed, we cannot assign -1

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Add simple tests for the log buffer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

log buffer: Reset pointers when there is no more data

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>