]> git.ipfire.org Git - thirdparty/curl.git/log
thirdparty/curl.git
5 years agotest1148: tolerate progress updates better (again)
Jay Satiro [Tue, 7 Apr 2020 04:50:11 +0000 (00:50 -0400)] 
test1148: tolerate progress updates better (again)

- Ignore intermediate progress updates.

- Support locales that use a character other than period as decimal
  separator (eg 100,0%).

test1148 checks that the progress finishes at 100% and has the right
bar width. Prior to this change the test assumed that the only progress
reported for such a quick transfer was 100%, however in rare instances
(like in the CI where transfer time can slow considerably) there may be
intermediate updates. For example, below is stderrlog1148 from a failed
CI run with explicit \r and \n added (it is one line; broken up so that
it's easier to understand).

\r
\r##################################                                        48.3%
\r######################################################################## 100.0%
\n

Closes https://github.com/curl/curl/pull/5194

5 years agosshserver.pl: use cached Win32 environment check variable
Marc Hoersken [Sun, 5 Apr 2020 16:46:42 +0000 (18:46 +0200)] 
sshserver.pl: use cached Win32 environment check variable

5 years agoappveyor: partially revert 3413a110 to keep build without proxy
Marc Hoersken [Fri, 10 Apr 2020 19:01:19 +0000 (21:01 +0200)] 
appveyor: partially revert 3413a110 to keep build without proxy

Ref: #5211 and #4526
Reported-by: Marcel Raad
5 years agoappveyor: ignore failing 'connect to non-listening proxy' tests
Marc Hoersken [Thu, 9 Apr 2020 23:02:30 +0000 (01:02 +0200)] 
appveyor: ignore failing 'connect to non-listening proxy' tests

Closes #5211

5 years agoCI/macos: convert CRLF to LF and align indentation
Marc Hoersken [Thu, 9 Apr 2020 22:59:35 +0000 (00:59 +0200)] 
CI/macos: convert CRLF to LF and align indentation

5 years agourl: allow non-HTTPS altsvc-matching for debug builds
Daniel Stenberg [Thu, 9 Apr 2020 13:08:46 +0000 (15:08 +0200)] 
url: allow non-HTTPS altsvc-matching for debug builds

This is already partly supported but this part was missing.
Reported-by: James Fuller
Closes #5205

5 years agoserver/resolve: remove AI_CANONNAME to make macos tell the truth
Daniel Stenberg [Wed, 8 Apr 2020 14:40:51 +0000 (16:40 +0200)] 
server/resolve: remove AI_CANONNAME to make macos tell the truth

With this bit set, my mac successfully resolves "ip6-localhost" when in
fact there is no such host known to my machine! That in turn made test
241 wrongly execute and fail.

Closes #5202

5 years agoruntests: fix warning about using an undefined variable
Daniel Stenberg [Wed, 8 Apr 2020 14:40:25 +0000 (16:40 +0200)] 
runtests: fix warning about using an undefined variable

Follow-up from 4d939ef6ceb2db1

5 years agorelease-notes: fix the initial reference list output
Daniel Stenberg [Wed, 8 Apr 2020 12:51:53 +0000 (14:51 +0200)] 
release-notes: fix the initial reference list output

5 years agogithub actions: run when pushed to master or */ci + PRs
Daniel Stenberg [Wed, 8 Apr 2020 09:54:31 +0000 (11:54 +0200)] 
github actions: run when pushed to master or */ci + PRs

Avoid double-builds when using "local" branches for PRs. For both macos
and fuzz jobs.

Closes #5201

5 years agoruntests: provide nicer errormsg when protocol "dump" file is empty
Daniel Stenberg [Wed, 8 Apr 2020 07:44:33 +0000 (09:44 +0200)] 
runtests: provide nicer errormsg when protocol "dump" file is empty

5 years agoschannel: support .P12 or .PFX client certificates
Gilles Vollant [Sun, 15 Sep 2019 12:37:36 +0000 (14:37 +0200)] 
schannel: support .P12 or .PFX client certificates

Used with curl command line option like this: --cert
<filename>:<password> --cert-type p12

Closes #5193

5 years agotests: verify split initial HTTP requests with CURL_SMALLREQSEND
Daniel Stenberg [Tue, 7 Apr 2020 13:10:37 +0000 (15:10 +0200)] 
tests: verify split initial HTTP requests with CURL_SMALLREQSEND

test1294: "split request" being when the entire request isn't sent in
the first go, and the remainder is sent in the PERFORM state. A GET
request is otherwise not sending anything during PERFORM.

test1295: same kind of split but with POST

Closes #5197

5 years agohttp: don't consider upload done if the request isn't completely sent off
Daniel Stenberg [Tue, 7 Apr 2020 16:16:01 +0000 (18:16 +0200)] 
http: don't consider upload done if the request isn't completely sent off

Fixes #4919
Closes #5197

5 years agohttp: allow Curl_add_buffer_send() to do a short first send by force
Daniel Stenberg [Tue, 7 Apr 2020 13:09:04 +0000 (15:09 +0200)] 
http: allow Curl_add_buffer_send() to do a short first send by force

In a debug build, settting the environment variable "CURL_SMALLREQSEND"
will make the first HTTP request send not send more bytes than the set
amount, thus ending up verifying that the logic for handling a split
HTTP request send works correctly.

5 years agoconnect: store connection info for QUIC connections
Daniel Stenberg [Tue, 7 Apr 2020 21:15:30 +0000 (23:15 +0200)] 
connect: store connection info for QUIC connections

Restores the --head functionality to the curl utility which extracts
'protocol' that is stored that way.

Reported-by: James Fuller
Fixes #5196
Closes #5198

5 years agotests/README: update the port numbers list
Daniel Stenberg [Tue, 7 Apr 2020 11:15:14 +0000 (13:15 +0200)] 
tests/README: update the port numbers list

Since the pipelining server is long gone.
Reported-by: James Fuller
5 years agoselect: remove typecast from SOCKET_WRITABLE/READABLE macros
Daniel Stenberg [Mon, 6 Apr 2020 15:00:39 +0000 (17:00 +0200)] 
select: remove typecast from SOCKET_WRITABLE/READABLE macros

So that they don't hide conversions-by-mistake

Reviewed-by: Jay Satiro
Closes #5190

5 years agoCURLOPT_WRITEFUNCTION.3: add inline example and new see-also
Daniel Stenberg [Mon, 6 Apr 2020 16:14:10 +0000 (18:14 +0200)] 
CURLOPT_WRITEFUNCTION.3: add inline example and new see-also

Closes #5192

5 years agorelease-notes: output trailing references sorted numerically
Daniel Stenberg [Mon, 6 Apr 2020 21:45:31 +0000 (23:45 +0200)] 
release-notes: output trailing references sorted numerically

5 years agocleanup: correct copyright year range on a few files
Daniel Stenberg [Mon, 6 Apr 2020 21:21:52 +0000 (23:21 +0200)] 
cleanup: correct copyright year range on a few files

5 years agoconfigure: remove use of -vec-report0 from CFLAGS with icc
Daniel Stenberg [Mon, 6 Apr 2020 15:07:38 +0000 (17:07 +0200)] 
configure: remove use of -vec-report0 from CFLAGS with icc

... as it apparently isn't (always) supported.
Reported-by: Alain Miniussi
Fixes #5096
Closes #5191

5 years agowarnless: remove code block for icc that didn't work
Daniel Stenberg [Mon, 6 Apr 2020 15:06:45 +0000 (17:06 +0200)] 
warnless: remove code block for icc that didn't work

Reported-by: Alain Miniussi
Fixes #5096

5 years agodist: add missing setup-win32.h
Marc Hoersken [Mon, 6 Apr 2020 16:05:13 +0000 (18:05 +0200)] 
dist: add missing setup-win32.h

Follow up to d820224b8b

5 years agoRELEASE-NOTES: synced
Daniel Stenberg [Mon, 6 Apr 2020 14:43:32 +0000 (16:43 +0200)] 
RELEASE-NOTES: synced

5 years agoscripts/release-notes.pl: add helper script for RELEASE-NOTES maintenance
Daniel Stenberg [Mon, 6 Apr 2020 14:20:27 +0000 (16:20 +0200)] 
scripts/release-notes.pl: add helper script for RELEASE-NOTES maintenance

This script helps putting entries in the RELEASE-NOTES using a coherent
style and sorting with a minimal human editing effort - as long as the
first line in the commit message is good enough! There's a short howto
at the top of the file.

5 years agoconfigure: don't check for Security.framework when cross-compiling
Dennis Felsing [Mon, 6 Apr 2020 11:56:07 +0000 (13:56 +0200)] 
configure: don't check for Security.framework when cross-compiling

Since it checks for the local file, not the cross-compiled one.

Closes #5189

5 years agoTODO: Option to make -Z merge lined based outputs on stdout
Daniel Stenberg [Sun, 5 Apr 2020 22:05:42 +0000 (00:05 +0200)] 
TODO: Option to make -Z merge lined based outputs on stdout

Closes #5175

5 years agolib: never define CURL_CA_BUNDLE with a getenv
Daniel Stenberg [Sun, 5 Apr 2020 09:19:39 +0000 (11:19 +0200)] 
lib: never define CURL_CA_BUNDLE with a getenv

- it breaks the build (since 6de756c9b1de34b7a1)
- it's not documented and not consistent across platforms
- the curl tool does that getenv magic

Bug: https://github.com/curl/curl/commit/6de756c#r38127030
Reported-by: Gisle Vanem
Closes #5187

5 years agolib670: use the same Win32 API check as all other lib tests
Marc Hoersken [Sun, 5 Apr 2020 16:25:03 +0000 (18:25 +0200)] 
lib670: use the same Win32 API check as all other lib tests

5 years agoappveyor: use random test server ports based upon APPVEYOR_API_URL
Marc Hoersken [Mon, 9 Mar 2020 12:51:35 +0000 (13:51 +0100)] 
appveyor: use random test server ports based upon APPVEYOR_API_URL

Avoid conflicts of test server ports with AppVeyor API on localhost.

Closes #5034

5 years agoappveyor: sort builds by type and add two new variants
Marc Hoersken [Fri, 6 Mar 2020 20:02:18 +0000 (21:02 +0100)] 
appveyor: sort builds by type and add two new variants

Related to #5034 and #5063

5 years agoappveyor: show failed tests in log even if test is ignored
Marc Hoersken [Fri, 6 Mar 2020 20:41:06 +0000 (21:41 +0100)] 
appveyor: show failed tests in log even if test is ignored

And print API response with newline only if there is one

5 years agoappveyor: turn disabled tests into ignored result tests
Marc Hoersken [Thu, 5 Mar 2020 17:56:57 +0000 (18:56 +0100)] 
appveyor: turn disabled tests into ignored result tests

5 years agoKNOWN_BUGS: fixed "USE_UNIX_SOCKETS on Windows"
Daniel Stenberg [Sun, 5 Apr 2020 09:23:25 +0000 (11:23 +0200)] 
KNOWN_BUGS: fixed "USE_UNIX_SOCKETS on Windows"

Fixed with #5170 (commit 23a870f2fd041278)

5 years agotest1566: verify --etag-compare that gets a 304 back
Daniel Stenberg [Sat, 4 Apr 2020 22:05:47 +0000 (00:05 +0200)] 
test1566: verify --etag-compare that gets a 304 back

Verifies the fix in #5183

Closes #5186

5 years agoCURLINFO_CONDITION_UNMET: return true for 304 http status code
Kwon-Young Choi [Sat, 4 Apr 2020 15:27:18 +0000 (17:27 +0200)] 
CURLINFO_CONDITION_UNMET: return true for 304 http status code

In libcurl, CURLINFO_CONDITION_UNMET is used to avoid writing to the
output file if the server did not transfered a file based on time
condition. In the same manner, getting a 304 HTTP response back from the
server, for example after passing a custom If-Match-* header, also
fulfill this condition.

Fixes #5181
Closes #5183

5 years agocurl: allow both --etag-compare and --etag-save with same file name
Kwon-Young Choi [Fri, 3 Apr 2020 18:51:14 +0000 (20:51 +0200)] 
curl: allow both --etag-compare and --etag-save with same file name

This change inverse the order of processing for the --etag-compare and
--etag-save option to process first --etag-compare. This in turn allows
to use the same file name to compare and save an etag.

The original behavior of not failing if the etag file does not exists is
conserved.

Fixes #5179
Closes #5180

5 years agowindows: enable UnixSockets with all build toolchains
Viktor Szakats [Sat, 4 Apr 2020 17:49:20 +0000 (17:49 +0000)] 
windows: enable UnixSockets with all build toolchains

Extend existing unix socket support in Windows builds to be
enabled for all toolchain vendors or versions. (Previously
it was only supported with certain MSVC versions + more recent
Windows 10 SDKs)

Ref: https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/
Ref: https://github.com/curl/curl/issues/5162
Closes: https://github.com/curl/curl/pull/5170
5 years agoKNOWN_BUGS: Store TLS context per transfer instead of per connection
Daniel Stenberg [Fri, 3 Apr 2020 22:01:35 +0000 (00:01 +0200)] 
KNOWN_BUGS: Store TLS context per transfer instead of per connection

Closes #5102

5 years agosockfilt: remove redundancy in timeout handling
Marc Hoersken [Sun, 29 Mar 2020 15:18:34 +0000 (17:18 +0200)] 
sockfilt: remove redundancy in timeout handling

And update other logmsg output in select_ws on Windows.

5 years agosockfilt: fix handling of ready closed sockets on Windows
Marc Hoersken [Sun, 29 Mar 2020 16:25:31 +0000 (18:25 +0200)] 
sockfilt: fix handling of ready closed sockets on Windows

Replace the incomplete workaround regarding FD_CLOSE
only signalling once by instead doing a pre-check with
standard select and storing the result for later use.

select keeps triggering on closed sockets on Windows while
WSAEventSelect fires only once with data still available.
By doing the pre-check we do not run in a deadlock
due to waiting forever for another FD_CLOSE event.

5 years agosockfilt: fix race-condition of waiting threads and event handling
Marc Hoersken [Thu, 2 Apr 2020 16:41:11 +0000 (18:41 +0200)] 
sockfilt: fix race-condition of waiting threads and event handling

Fix race-condition of waiting threads finishing while events are
already being processed which lead to invalid or skipped events.

Use mutex to check for one event at a time or do post-processing.
In addition to mutex-based locking use specific event as signal.

Closes #5156

5 years agoCI-fuzz: increase fuzz time to 40 minutes
Leo Neat [Thu, 2 Apr 2020 17:12:24 +0000 (10:12 -0700)] 
CI-fuzz: increase fuzz time to 40 minutes

Closes #5174

5 years agoCI: increase Azure Pipelines timeouts due to performance issues
Marc Hoersken [Thu, 2 Apr 2020 17:27:30 +0000 (19:27 +0200)] 
CI: increase Azure Pipelines timeouts due to performance issues

The current demand on Azure negatively impacts the CI performance.

5 years agoruntests.pl: log host OS as detected by Perl environment
Marc Hoersken [Thu, 2 Apr 2020 16:33:22 +0000 (18:33 +0200)] 
runtests.pl: log host OS as detected by Perl environment

5 years agoftpserver.pl: log before and after data connection is closed
Marc Hoersken [Thu, 2 Apr 2020 16:31:02 +0000 (18:31 +0200)] 
ftpserver.pl: log before and after data connection is closed

5 years agoRELEASE-NOTES: synced
Daniel Stenberg [Wed, 1 Apr 2020 21:10:16 +0000 (23:10 +0200)] 
RELEASE-NOTES: synced

5 years agoRELEASE-PROCEDURE.md: run the copyright.pl script!
Daniel Stenberg [Tue, 31 Mar 2020 12:50:15 +0000 (14:50 +0200)] 
RELEASE-PROCEDURE.md: run the copyright.pl script!

5 years agovquic/ngtcp2.h: update copyright year range
Daniel Stenberg [Tue, 31 Mar 2020 12:42:20 +0000 (14:42 +0200)] 
vquic/ngtcp2.h: update copyright year range

Follow-up to 0736ee73d346a52

5 years agoCI: add build with ngtcp2 + gnutls on Travis CI
Daiki Ueno [Sun, 29 Mar 2020 13:13:04 +0000 (15:13 +0200)] 
CI: add build with ngtcp2 + gnutls on Travis CI

5 years agovquic: add support for GnuTLS backend of ngtcp2
Daiki Ueno [Wed, 25 Mar 2020 21:49:02 +0000 (22:49 +0100)] 
vquic: add support for GnuTLS backend of ngtcp2

Currently, the TLS backend used by vquic/ngtcp2.c is selected at compile
time. Therefore OpenSSL support needs to be explicitly disabled.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
Closes #5148

5 years agoexamples/sessioninfo.c: add include to fix compiler warning
Gisle Vanem [Tue, 31 Mar 2020 12:32:29 +0000 (14:32 +0200)] 
examples/sessioninfo.c: add include to fix compiler warning

Fixes #5171

5 years agomisc: copyright year updates
Daniel Stenberg [Tue, 31 Mar 2020 09:02:18 +0000 (11:02 +0200)] 
misc: copyright year updates

Follow-up to 7a71965e9

5 years agobuild: fixed build for systems with select() in unistd.h
Harry Sintonen [Mon, 30 Mar 2020 13:52:43 +0000 (16:52 +0300)] 
build: fixed build for systems with select() in unistd.h

Closes #5169

5 years agomemdebug: don't log free(NULL)
Daniel Stenberg [Mon, 30 Mar 2020 21:51:45 +0000 (23:51 +0200)] 
memdebug: don't log free(NULL)

... it serves no purpose and fills up the log.

5 years agocleanup: insert newline after if() conditions
Daniel Stenberg [Mon, 30 Mar 2020 08:55:31 +0000 (10:55 +0200)] 
cleanup: insert newline after if() conditions

Our code style mandates we put the conditional block on a separate
line. These mistakes are now detected by the updated checksrc.

5 years agochecksrc: warn on obvious conditional blocks on the same line as if()
Daniel Stenberg [Mon, 30 Mar 2020 08:52:48 +0000 (10:52 +0200)] 
checksrc: warn on obvious conditional blocks on the same line as if()

Closes #5164

5 years agocmake: add CMAKE_MSVC_RUNTIME_LIBRARY
Roger Orr [Mon, 30 Mar 2020 10:31:21 +0000 (11:31 +0100)] 
cmake: add CMAKE_MSVC_RUNTIME_LIBRARY

Fixes #5165
Closes #5167

5 years agongtcp2: update to git master for the key installation API change
Daiki Ueno [Sun, 29 Mar 2020 12:53:39 +0000 (14:53 +0200)] 
ngtcp2: update to git master for the key installation API change

This updates the ngtcp2 OpenSSL backend to follow the API change in
commit 32e703164 of ngtcp2.

Notable changes are:
- ngtcp2_crypto_derive_and_install_{rx,tx}_key have been added to replace
  ngtcp2_crypto_derive_and_install_key
- the 'side' argument of ngtcp2_crypto_derive_and_install_initial_key
  has been removed

Fixes #5166
Closes #5168

5 years agoSECURITY.md: minor rephrase
Cyrus [Sat, 28 Mar 2020 00:34:51 +0000 (17:34 -0700)] 
SECURITY.md: minor rephrase

Closes #5158

5 years agooutput.d: quote the URL when globbing
Daniel Stenberg [Sun, 29 Mar 2020 21:51:52 +0000 (23:51 +0200)] 
output.d: quote the URL when globbing

Some shells do globbing of their own unless the URL is quoted, so maybe
encourage this.

Co-authored-by: Jay Satiro
Closes #5160

5 years agodist: add tests/version-scan.pl to tarball
Daniel Stenberg [Sun, 29 Mar 2020 21:30:51 +0000 (23:30 +0200)] 
dist: add tests/version-scan.pl to tarball

... used in test 1177.

Follow-up to a97d826f6de3

5 years agotest1177: verify that all the CURL_VERSION_ bits are documented
Daniel Stenberg [Fri, 27 Mar 2020 23:04:51 +0000 (00:04 +0100)] 
test1177: verify that all the CURL_VERSION_ bits are documented

5 years agocurl.h: remnove CURL_VERSION_ESNI. Never supported nor documented
Daniel Stenberg [Fri, 27 Mar 2020 23:00:27 +0000 (00:00 +0100)] 
curl.h: remnove CURL_VERSION_ESNI. Never supported nor documented

Considered experimental and therefore we can do this.

Closes #5157

5 years agoKNOWN_BUGS: DoH doesn't inherit all transfer options
Daniel Stenberg [Sat, 28 Mar 2020 22:09:45 +0000 (23:09 +0100)] 
KNOWN_BUGS: DoH doesn't inherit all transfer options

Closes #4578
Closes #4579

5 years agoKNOWN_BUGS: DoH leaks memory after followlocation
Daniel Stenberg [Sat, 28 Mar 2020 22:06:39 +0000 (23:06 +0100)] 
KNOWN_BUGS: DoH leaks memory after followlocation

Closes #4592

5 years agoKNOWN_BUGS: "FTPS needs session reuse"
Daniel Stenberg [Sat, 28 Mar 2020 22:04:14 +0000 (23:04 +0100)] 
KNOWN_BUGS: "FTPS needs session reuse"

Closes #4654

5 years agoKNOWN_BUGS: "stick to same family over SOCKS pro" is presumed fixed
Daniel Stenberg [Sat, 28 Mar 2020 22:01:42 +0000 (23:01 +0100)] 
KNOWN_BUGS: "stick to same family over SOCKS pro" is presumed fixed

5 years agoTODO: Set custom client ip when using haproxy protocol
Daniel Stenberg [Sat, 28 Mar 2020 21:58:50 +0000 (22:58 +0100)] 
TODO: Set custom client ip when using haproxy protocol

Closes #5125

5 years agowriteout_json: Fix data type issues
Michael Kaufmann [Thu, 26 Mar 2020 22:15:37 +0000 (23:15 +0100)] 
writeout_json: Fix data type issues

Load long values correctly (e.g. for http_code).

Use curl_off_t (not long) for:
- size_download (CURLINFO_SIZE_DOWNLOAD_T)
- size_upload (CURLINFO_SIZE_UPLOAD_T)

The unit for these values is bytes/second, not microseconds:
- speed_download (CURLINFO_SPEED_DOWNLOAD_T)
- speed_upload (CURLINFO_SPEED_UPLOAD_T)

Fixes #5131
Closes #5152

5 years agomailmap: fixup a few author names/fields
Daniel Stenberg [Fri, 27 Mar 2020 11:08:05 +0000 (12:08 +0100)] 
mailmap: fixup a few author names/fields

Douglas Steinwand, Gökhan Şengün, Jessa Chandler, Julian Z and
Svyatoslav Mishyn

5 years agoversion: add 'cainfo' and 'capath' to version info struct
Daniel Stenberg [Thu, 26 Mar 2020 12:05:03 +0000 (13:05 +0100)] 
version: add 'cainfo' and 'capath' to version info struct

Suggested-by: Timothe Litt
URL: https://curl.haxx.se/mail/lib-2020-03/0090.html
Reviewed-by: Jay Satiro
Closes #5150

5 years agoRELEASE-NOTES: synced
Daniel Stenberg [Thu, 26 Mar 2020 23:08:14 +0000 (00:08 +0100)] 
RELEASE-NOTES: synced

5 years agoSSLCERTS.md: Fix example code for setting CA cert file
Jay Satiro [Thu, 26 Mar 2020 22:11:28 +0000 (18:11 -0400)] 
SSLCERTS.md: Fix example code for setting CA cert file

Prior to this change the documentation erroneously said use
CURLOPT_CAPATH to set a CA cert file.

Bug: https://curl.haxx.se/mail/lib-2020-03/0121.html
Reported-by: Timothe Litt
Closes https://github.com/curl/curl/pull/5151

5 years agosockfilt: add logmsg output to select_ws_wait_thread on Windows
Marc Hoersken [Wed, 11 Mar 2020 13:19:59 +0000 (14:19 +0100)] 
sockfilt: add logmsg output to select_ws_wait_thread on Windows

Assisted-by: Jay Satiro
Reviewed-by: Daniel Stenberg
Closes #5086

5 years agodocs/make: generate curl.1 from listed files only
Daniel Stenberg [Wed, 25 Mar 2020 22:16:28 +0000 (23:16 +0100)] 
docs/make: generate curl.1 from listed files only

Previously it rendered the page from files matching "*.d" in the correct
directory, which worked fine in git builds when the files were added but
made it easy to forget adding the files to the dist.

Now, only man page sections listed in DPAGES in Makefile.inc will be
used, thus "forcing" us to update this to get the man page right and get
it included in the dist at the same time.

Ref: #5146
Closes #5149

5 years agoopenssl: adapt to functions marked as deprecated since version 3
Daniel Stenberg [Mon, 23 Mar 2020 11:28:20 +0000 (12:28 +0100)] 
openssl: adapt to functions marked as deprecated since version 3

OpenSSL 3 deprecates SSL_CTX_load_verify_locations and the MD4, DES
functions we use.

Fix the MD4 and SSL_CTX_load_verify_locations warnings.

In configure, detect OpenSSL v3 and if so, inhibit the deprecation
warnings. OpenSSL v3 deprecates the DES functions we use for NTLM and
until we rewrite the code to use non-deprecated functions we better
ignore these warnings as they don't help us.

Closes #5139

5 years agodist: add mail-rcpt-allowfails.d to the tarball
Daniel Stenberg [Wed, 25 Mar 2020 15:31:13 +0000 (16:31 +0100)] 
dist: add mail-rcpt-allowfails.d to the tarball

Reported-by: Maksim Stsepanenka
Reviewed-by: Jat Satiro
Closes #5146

5 years agotravis: update the ngtcp2 build to use the latest OpenSSL patch
Daniel Stenberg [Tue, 24 Mar 2020 22:16:03 +0000 (23:16 +0100)] 
travis: update the ngtcp2 build to use the latest OpenSSL patch

... which also makes it OpenSSL 1.1.1d based and not v3.

5 years agoCI: remove default Ubuntu build from GitHub Actions
Marc Hoersken [Tue, 24 Mar 2020 17:24:52 +0000 (18:24 +0100)] 
CI: remove default Ubuntu build from GitHub Actions

We are already running a very similar Ubuntu build on Travis CI.
The macOS variant of this default build is kept on Github Actions.

5 years agoCI: bring GitHub Actions fuzzing job in line with macOS jobs
Marc Hoersken [Tue, 24 Mar 2020 17:19:35 +0000 (18:19 +0100)] 
CI: bring GitHub Actions fuzzing job in line with macOS jobs

Update YAML formatting, job naming and triggers.

5 years agoCI: migrate macOS jobs from Azure and Travis CI to GitHub Actions
Marc Hoersken [Tue, 24 Mar 2020 17:18:15 +0000 (18:18 +0100)] 
CI: migrate macOS jobs from Azure and Travis CI to GitHub Actions

Reduce workload on Azure Pipelines and Travis CI while
consolidating macOS jobs onto less utilized GitHub Actions.

Reviewed-by: Daniel Stenberg
Closes #5124

5 years agoconfig: remove all defines of HAVE_DES_H
Daniel Stenberg [Tue, 24 Mar 2020 14:22:48 +0000 (15:22 +0100)] 
config: remove all defines of HAVE_DES_H

As there's no code using it.

Closes #5144

5 years agocopyright: fix out-of-date copyright ranges and missing headers
Daniel Stenberg [Mon, 23 Mar 2020 13:44:29 +0000 (14:44 +0100)] 
copyright: fix out-of-date copyright ranges and missing headers

Reported by the new script 'scripts/copyright.pl'. The script has a
regex whitelist for the files that don't need copyright headers.

Removed three (mostly usesless) README files from docs/

Closes #5141

5 years agopackages: add OS400/chkstrings.c to the dist
Daniel Stenberg [Tue, 24 Mar 2020 11:54:03 +0000 (12:54 +0100)] 
packages: add OS400/chkstrings.c to the dist

Reported-by: Jon Rumsey
Fixes #5142
Closes #5143

5 years agonghttp2: 1.12.0 required
Clément Notin [Mon, 23 Mar 2020 20:17:21 +0000 (21:17 +0100)] 
nghttp2: 1.12.0 required

since nghttp2_session_set_local_window_size is needed

Closes #5140

5 years agoRELEASE-NOTES: synced
Daniel Stenberg [Mon, 23 Mar 2020 09:47:10 +0000 (10:47 +0100)] 
RELEASE-NOTES: synced

5 years agoOS400: Update strings for ccsid-ifier
Calvin Buckley [Sat, 21 Mar 2020 18:54:16 +0000 (19:54 +0100)] 
OS400: Update strings for ccsid-ifier

Fixes build.

Closes #5132

5 years agocirrus: make freebsd ignore the tests instead of skipping
Daniel Stenberg [Fri, 20 Mar 2020 22:59:13 +0000 (23:59 +0100)] 
cirrus: make freebsd ignore the tests instead of skipping

To allow us to see in the CI logs how they actually behave

Closes #5091

5 years agocirrus: move the sanitizer build from freebsd 13 to freebsd 12
Daniel Stenberg [Thu, 19 Mar 2020 13:33:53 +0000 (14:33 +0100)] 
cirrus: move the sanitizer build from freebsd 13 to freebsd 12

5 years agoRevert "cirrus-ci: disable the FreeBSD 13 builds"
Daniel Stenberg [Thu, 12 Mar 2020 14:29:42 +0000 (15:29 +0100)] 
Revert "cirrus-ci: disable the FreeBSD 13 builds"

This reverts commit 691b71be930f0e285c8f7a76efd56bbe0576cda6.

5 years agogetinfo: provide CURLINFO_HEADER_SIZE and CURLINFO_REQUEST_SIZE override
Daniel Stenberg [Sun, 22 Mar 2020 11:25:46 +0000 (12:25 +0100)] 
getinfo: provide CURLINFO_HEADER_SIZE and CURLINFO_REQUEST_SIZE override

To let debug-builds return fake values, like in test 970.

Ref: #5131
Closes #5136

5 years agotest970: improve the test
Daniel Stenberg [Sun, 22 Mar 2020 11:08:39 +0000 (12:08 +0100)] 
test970: improve the test

- send more data to make problems more obvious
- don't start the data with minus, it makes diffs harder to read
- skip the headers in the stdout comparison
- save to a file name to also verify 'filename_effective'

Ref: #5131

5 years agoCURLINFO_NUM_CONNECTS: improve accuracy
Daniel Stenberg [Sun, 22 Mar 2020 10:49:16 +0000 (11:49 +0100)] 
CURLINFO_NUM_CONNECTS: improve accuracy

The counter was not bumped in all cases correctly.

Reported-by: Marcel Raad
Ref: #5131
Closes #5135

5 years agoTODO: Use "random" ports for the test servers
Daniel Stenberg [Sun, 22 Mar 2020 22:30:09 +0000 (23:30 +0100)] 
TODO: Use "random" ports for the test servers

5 years agolib/curl_setup: adjust the copyright year range
Daniel Stenberg [Sat, 21 Mar 2020 22:19:39 +0000 (23:19 +0100)] 
lib/curl_setup: adjust the copyright year range

Follow-up from d820224b8

5 years agocurl_setup: define _WIN32_WINNT_[OS] symbols
Jay Satiro [Sat, 7 Mar 2020 08:21:33 +0000 (03:21 -0500)] 
curl_setup: define _WIN32_WINNT_[OS] symbols

.. because not all Windows build systems have those symbols, and even
those that do may be missing newer symbols (eg the Windows 7 SDK does
not define _WIN32_WINNT_WIN10).

Those symbols are used in build-time logic to decide which API to use
and prior to this change if the symbols were missing it would have
resulted in deprecated API being used when more recent functions were
available (eg GetVersionEx used instead of VerifyVersionInfo).

Reported-by: FuccDucc@users.noreply.github.com
Probably fixes https://github.com/curl/curl/issues/4995
Closes https://github.com/curl/curl/pull/5057

5 years agocurl-functions.m4: remove inappropriate AC_REQUIRE
Ross Burton [Fri, 20 Mar 2020 21:16:24 +0000 (21:16 +0000)] 
curl-functions.m4: remove inappropriate AC_REQUIRE

AC_REQUIRE means "if this macro hasn't been executed already, execute
it".  So in a wrapper around AC_RUN_IFELSE, AC_REQUIRE(AC_RUN_IFELSE)
isn't correct at that will execute AC_RUN_IFELSE without any arguments.

With autoconf 2.69 this is basically a no-op, but with autoconf 2.70,
AC_RUN_IFELSE without a default value when cross-compiling is fatal.
The result is that curl with autoconf 2.70 cannot cross-compile.

Fixes https://github.com/curl/curl/issues/5126
Closes https://github.com/curl/curl/pull/5130

5 years agoci/tests: fix Azure Pipelines not running Windows containers
Marc Hoersken [Fri, 20 Mar 2020 17:18:04 +0000 (18:18 +0100)] 
ci/tests: fix Azure Pipelines not running Windows containers

Workaround posted here: microsoft/azure-pipelines-agent#2864

Assisted-by: Simon Chalifoux
Assisted-by: Tommy Petty
Fixes #5117
Closes #5129