]> git.ipfire.org Git - thirdparty/openssl.git/log
thirdparty/openssl.git
9 months agoAPPS/{ecparam,pkeyparam}: fix case where infile and outfile are the same
Dr. David von Oheimb [Fri, 27 Sep 2024 05:58:20 +0000 (07:58 +0200)] 
APPS/{ecparam,pkeyparam}: fix case where infile and outfile are the same

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25552)

9 months agoAPPS/dsaparam: fix case where infile and outfile are the same
Dr. David von Oheimb [Fri, 27 Sep 2024 05:39:17 +0000 (07:39 +0200)] 
APPS/dsaparam: fix case where infile and outfile are the same

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25552)

9 months agoAPPS/dhparam: fix case where infile and outfile are the same
Dr. David von Oheimb [Fri, 27 Sep 2024 05:31:36 +0000 (07:31 +0200)] 
APPS/dhparam: fix case where infile and outfile are the same

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25552)

9 months agoos-zoo.yml: Disable stringop-overflow warning on alpine edge
Tomas Mraz [Thu, 3 Oct 2024 07:24:05 +0000 (09:24 +0200)] 
os-zoo.yml: Disable stringop-overflow warning on alpine edge

fortify-headers are broken due to this warning.

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25599)

9 months agoUpdate fips-label.yml to make 'Cleanup artifact' conditional
Richard Levitte [Tue, 1 Oct 2024 07:52:59 +0000 (09:52 +0200)] 
Update fips-label.yml to make 'Cleanup artifact' conditional

If it's not conditional in the same manner as the other steps, it fails
because the artifacts aren't present => job failure.

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25584)

9 months agofips: add lots of potentially missing ossl_prov_is_running checks
Dimitri John Ledkov [Mon, 30 Sep 2024 14:54:45 +0000 (15:54 +0100)] 
fips: add lots of potentially missing ossl_prov_is_running checks

After rudimentary analysis, it appears the below functions can
potentially produce output, whilst the provider is in error state.

These functions were detected using this method:

```
CFLAGS='-save-temps' ./Configure enable-fips --debug
make -j10
find . -name '*.i' | xargs git add -f
git grep --cached -p ossl_prov_is_running | grep libfips-lib > ossl_prov_is_running.txt
git grep --cached -p 'return' | grep  libfips-lib > return.txt
grep '\.i=' return.txt > func-with_return.txt
grep '\.i=' ossl_prov_is_running.txt > func-with-ossl_prov_is_running.txt
grep --fixed-strings --line-regexp --file=func-with-ossl_prov_is_running.txt return.txt > func-without-ossl_prov_is_running.txt
grep -e newctx -e initctx -e dupctx func-without-ossl_prov_is_running.txt  | grep -v ossl_prov_is_running
```

And from there doing manual inspection, as the list was short at that
point.

As in compile with keeping pre-processed source code; and use `git
grep --cached -p` to find these preprocessed files, and scan for calls
to return or opssl_prov_is_running, with function name printed. And
then exclude one from the other, to hopefully get a list of all the
functions that do not check for ossl_prov_is_running.

As number of functions without "func-without-ossl_prov_is_running"
check is large, I do wonder which other functions are "interesting" to
check for. I think I'm not scanning for _update functions
correctly. Any tips on improving above analysis will help with
maintaining such checks going forward.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25580)

9 months agoUse the correct length value for input salt
Simo Sorce [Mon, 30 Sep 2024 13:25:48 +0000 (09:25 -0400)] 
Use the correct length value for input salt

In this function the salt can be either a zero buffer of exactly mdlen
length, or an arbitrary salt of prevsecretlen length.
Although in practice OpenSSL will always pass in a salt of mdlen size
bytes in the current TLS 1.3 code, the openssl kdf command can pass in
arbitrary values (I did it for testing), and a future change in the
higher layer code could also result in unmatched lengths.

If prevsecretlen is > mdlen this will cause incorrect salt expansion, if
prevsecretlen < mdlen this could cause a crash or reading random
information. Inboth case the generated output would be incorrect.

Signed-off-by: Simo Sorce <simo@redhat.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25579)

9 months agoci: add 3.4 to prov-compat-label tests
Pauli [Tue, 1 Oct 2024 05:16:37 +0000 (15:16 +1000)] 
ci: add 3.4 to prov-compat-label tests

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25583)

9 months agoci: add 3.4 to the provider compatibility test
Pauli [Tue, 1 Oct 2024 05:05:29 +0000 (15:05 +1000)] 
ci: add 3.4 to the provider compatibility test

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25583)

10 months agotest: add FIPS version check for EC cofactor derive tests
Pauli [Mon, 30 Sep 2024 23:23:28 +0000 (09:23 +1000)] 
test: add FIPS version check for EC cofactor derive tests

These were added in #25548 but didn't include a FIPS version check which
causes failures testing older FIPS providers against later versions.

Also change some skips to use TEST_skip.

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25582)

10 months agoFix bugs in ECDH cofactor FIPS indicator.
slontis [Thu, 26 Sep 2024 05:18:59 +0000 (15:18 +1000)] 
Fix bugs in ECDH cofactor FIPS indicator.

The code was not detecting that the cofactor was set up correctly
if OSSL_PKEY_PARAM_USE_COFACTOR_ECDH was set, resulting in an incorrect
FIPS indicator error being triggered.

Added a test for all possible combinations of a EVP_PKEY setting
OSSL_PKEY_PARAM_USE_COFACTOR_ECDH and the derive context setting
OSSL_EXCHANGE_PARAM_EC_ECDH_COFACTOR_MODE.

This only affects the B & K curves (which have a cofactor that is not 1).

Bug reported by @abkarcher

Testing this properly, also detected a memory leak of privk when the
FIPS indicator error was triggered (in the case where mode = 0 and
use_cofactor was 1).

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25548)

10 months agokdfs: implement key length check in X9.42
Dimitri John Ledkov [Sat, 21 Sep 2024 14:25:53 +0000 (15:25 +0100)] 
kdfs: implement key length check in X9.42

Similar to other KDFs, the input key should be 112 bits long.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25529)

10 months agodocs: document options added in openssl-fipsinstall 3.4+
Dimitri John Ledkov [Mon, 30 Sep 2024 09:49:02 +0000 (10:49 +0100)] 
docs: document options added in openssl-fipsinstall 3.4+

Document new command line options added in 3.4.0

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25546)

10 months agodocs: document options added in openssl-fipsinstall 3.2+
Dimitri John Ledkov [Mon, 30 Sep 2024 09:48:29 +0000 (10:48 +0100)] 
docs: document options added in openssl-fipsinstall 3.2+

Document new command line options added in 3.2.0

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25546)

10 months agodocs: document options added in openssl-fipsinstall 3.1+
Dimitri John Ledkov [Mon, 30 Sep 2024 09:46:28 +0000 (10:46 +0100)] 
docs: document options added in openssl-fipsinstall 3.1+

Document new command line options added in 3.1.0

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25546)

10 months agodocs: add HISTORY section to openssl-fipsinstall (3.0+)
Dimitri John Ledkov [Mon, 30 Sep 2024 09:45:28 +0000 (10:45 +0100)] 
docs: add HISTORY section to openssl-fipsinstall (3.0+)

Documents when the command was added.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25546)

10 months agoAdd CHANGES entry
Pauli [Wed, 25 Sep 2024 22:11:30 +0000 (08:11 +1000)] 
Add CHANGES entry

To match changes in #25526

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25536)

10 months agotest: fix unit tests for fips CRNG tests
Pauli [Wed, 25 Sep 2024 00:30:58 +0000 (10:30 +1000)] 
test: fix unit tests for fips CRNG tests

To match changes in #25526

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25536)

10 months agodoc: fix typo in CRNG test documentation.
Pauli [Wed, 25 Sep 2024 00:03:42 +0000 (10:03 +1000)] 
doc: fix typo in CRNG test documentation.

To match changes in #25526

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25536)

10 months agofips: Prohibit SHA1 in DH & ECDH exchange
Dimitri John Ledkov [Mon, 23 Sep 2024 11:57:22 +0000 (12:57 +0100)] 
fips: Prohibit SHA1 in DH & ECDH exchange

See Section 5 Key Agreement Using Diffie-Hellman and MQV of
[NIST SP 800-131Ar2](https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-131Ar2.pdf).

Strengths less than 112bits is disallowed, thus eliminating SHA1.

Skip cms test case that requires use of SHA1 with X9.42 DH.

Rename ossl_fips_ind_digest_check to ossl_fips_ind_digest_exch_check

Add myself to Changes for fips indicator work

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/25517)

10 months agoCheck file name for not being NULL before opening it
Зишан Мирза [Fri, 13 Sep 2024 22:24:24 +0000 (00:24 +0200)] 
Check file name for not being NULL before opening it

Fixes #24416

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25458)

10 months agoFix examples in EVP_PKEY_encapsulate/decapsulate documentation
Зишан Мирза [Thu, 12 Sep 2024 14:01:21 +0000 (16:01 +0200)] 
Fix examples in EVP_PKEY_encapsulate/decapsulate documentation

Fixes #25448

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25450)

10 months agoRemove double engine reference in ossl_ec_key_dup()
Зишан Мирза [Mon, 16 Sep 2024 21:20:58 +0000 (23:20 +0200)] 
Remove double engine reference in ossl_ec_key_dup()

Fixes #25260

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25453)

10 months agoFix NULL ptr dereference on EC_POINT *point
Shawn C [Thu, 19 Sep 2024 17:14:09 +0000 (17:14 +0000)] 
Fix NULL ptr dereference on EC_POINT *point

Use non-usual params of pkcs11 module will trigger a null ptr deref bug. Fix it for #25493

CLA: trivial

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25496)

10 months agoRename list macros
Neil Horman [Mon, 23 Sep 2024 16:11:01 +0000 (12:11 -0400)] 
Rename list macros

The quic implementation defined a set of LIST_* macros for list
manipulation, which conflicts with the generally support BSD api found
in the queue.h system header.  While this isn't normally a problem, A
report arrived indicating that MacOSX appears to implicitly include
queue.h from another system header which causes definition conflicts.

As the openssl macros are internal only, it seems the most sensible
thing to do is place them in a well known namespace for our library to
avoid the conflict, so add an OSSL_ prefix to all our macros

Fixes #25516

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from https://github.com/openssl/openssl/pull/25519)

10 months agocheck-format.pl: do checks regarding statement/block after for() also on {OSSL_,...
Dr. David von Oheimb [Tue, 24 Sep 2024 20:00:59 +0000 (22:00 +0200)] 
check-format.pl: do checks regarding statement/block after for() also on {OSSL_,}LIST_FOREACH{,_*}

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/25535)

10 months agoctr-drbg: always use the DF for OpenSSL's DRBGs
Pauli [Mon, 23 Sep 2024 04:45:41 +0000 (14:45 +1000)] 
ctr-drbg: always use the DF for OpenSSL's DRBGs

Force the use of the derivation function when creating OpenSSL's internal
DRBGs.

FIPS mandates the use of a derivation function, so 3.4 cannot be validated as
it stands which run counter to the indicator work that was included.

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Hugo Landau <hlandau@devever.net>
(Merged from https://github.com/openssl/openssl/pull/25511)

(cherry picked from commit 0ab796ef9674b378ac644ad8d477685619a2ff37)

10 months agoCheck sk_X509_value result before dereference
JohnnySavages [Wed, 24 Jul 2024 11:17:49 +0000 (07:17 -0400)] 
Check sk_X509_value result before dereference

issuer passed as second parameter to check_issued may result in
NULL dereference

CLA: trivial

Reviewed-by: Hugo Landau <hlandau@devever.net>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24760)

10 months agodocument the format of DSA signature
Vladimir Kotal [Wed, 6 Mar 2024 14:37:58 +0000 (15:37 +0100)] 
document the format of DSA signature

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/23762)

10 months ago80-test_cmp_http.t: fix handling of IPv6 server host (localhost '::1')
David von Oheimb [Fri, 26 Jul 2024 13:34:05 +0000 (15:34 +0200)] 
80-test_cmp_http.t: fix handling of IPv6 server host (localhost '::1')

Fixes 22467

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25010)

10 months agodoc/man{1,3}: fix details on IPv6 host addresses and of whitespace in no_proxy
David von Oheimb [Thu, 1 Aug 2024 19:36:02 +0000 (21:36 +0200)] 
doc/man{1,3}: fix details on IPv6 host addresses and of whitespace in no_proxy

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25010)

10 months agoOSSL_HTTP_adapt_proxy(): fix handling of escaped IPv6 host addresses and of whitespac...
David von Oheimb [Thu, 1 Aug 2024 19:33:18 +0000 (21:33 +0200)] 
OSSL_HTTP_adapt_proxy(): fix handling of escaped IPv6 host addresses and of whitespace in no_proxy

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25010)

10 months agoOSSL_HTTP_open(): fix completion with default port for IPv6 host addresses
David von Oheimb [Thu, 1 Aug 2024 19:25:44 +0000 (21:25 +0200)] 
OSSL_HTTP_open(): fix completion with default port for IPv6 host addresses

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25010)

10 months agohttp_server.{c,h}: make clear that IPv4 or IPv6 is used by http_server_init()
David von Oheimb [Wed, 31 Jul 2024 17:36:16 +0000 (19:36 +0200)] 
http_server.{c,h}: make clear that IPv4 or IPv6 is used by http_server_init()

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25010)

10 months agohttp_server.c: fix checks of error return code in http_server_init()
David von Oheimb [Wed, 31 Jul 2024 17:32:44 +0000 (19:32 +0200)] 
http_server.c: fix checks of error return code in http_server_init()

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25010)

10 months agoBIO_s_accept.pod: fix whitespace nits: '<=0' -> '<= 0'
David von Oheimb [Wed, 31 Jul 2024 17:32:07 +0000 (19:32 +0200)] 
BIO_s_accept.pod: fix whitespace nits: '<=0' -> '<= 0'

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25010)

10 months agoFix smime-type for AuthEnvelopedData
Jakub Zelenka [Tue, 17 Sep 2024 13:21:33 +0000 (14:21 +0100)] 
Fix smime-type for AuthEnvelopedData

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25482)

10 months agodoc/man3/OSSL_PARAM.pod: Correct the type of data_type
Alex Shaindlin [Wed, 18 Sep 2024 09:29:19 +0000 (12:29 +0300)] 
doc/man3/OSSL_PARAM.pod: Correct the type of data_type

CLA: trivial

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/25486)

10 months agoClarify Tag Length Setting in OCB Mode
erbsland-dev [Tue, 10 Sep 2024 17:20:17 +0000 (19:20 +0200)] 
Clarify Tag Length Setting in OCB Mode

Fixes #8331: Updated the description for setting the tag length in OCB mode to remove the misleading “when encrypting” and “during encryption” phrasing. This change emphasizes that setting a custom tag length requires a call with NULL, applicable to both encryption and decryption contexts.

Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25424)

10 months agoFix big-endian Power10 chacha20 implementation
Paul E. Murphy [Tue, 17 Sep 2024 15:22:58 +0000 (15:22 +0000)] 
Fix big-endian Power10 chacha20 implementation

Some of the BE specific permutes were incorrect. Fix them.

This passes all tests on a P10/ppc64 debian unstable host.

Fixes #25451

CLA: trivial

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25483)

10 months agodeactivate failing Cloudflare PQ interop tests
Michael Baentsch [Wed, 18 Sep 2024 16:13:30 +0000 (18:13 +0200)] 
deactivate failing Cloudflare PQ interop tests

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25488)

10 months agotest: add unit tests for fips CRNG tests
Pauli [Tue, 10 Sep 2024 02:10:03 +0000 (12:10 +1000)] 
test: add unit tests for fips CRNG tests

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25415)

10 months agodoc: document the health test EVP_RAND
Pauli [Mon, 9 Sep 2024 00:46:05 +0000 (10:46 +1000)] 
doc: document the health test EVP_RAND

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25415)

10 months agofips: continuous random bit generator tests
Pauli [Thu, 5 Sep 2024 00:24:07 +0000 (10:24 +1000)] 
fips: continuous random bit generator tests

For FIPS 140-3 the continuous tests specified in SP 800-90B need to be
included on the output of any entropy source.

They are implemented here as a replacement for the primary DRBG in the FIPS
provider.  This results in a setup that looks like this:

               +-------------+
               |             |
               | Seed Source |
               |             |
               +------+------+
                      |
                      |
                      v
               +-------------+
               |             |
               |  CRNG Test  |
               |             |
               ++----------+-+
                |          |
                |          |
                v          v
    +--------------+     +--------------+
    |              |     |              |
    | Public DRBG  |     | Private DRBG |
    |              |     |              |
    +--------------+     +--------------+

An additional benefit, that of avoiding DRBG chains, is also gained.
The current standards do not permit the output of one DRBG to be used
as the input for a second (i.e. a chain).

This also leaves open the future possibility of incorporating a seed
source inside the FIPS boundary.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25415)

10 months agorand: remove unused field in DRBG structure
Pauli [Tue, 3 Sep 2024 23:43:37 +0000 (09:43 +1000)] 
rand: remove unused field in DRBG structure

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25415)

10 months agoAdd failed entropy continuous test error
Pauli [Tue, 3 Sep 2024 23:42:52 +0000 (09:42 +1000)] 
Add failed entropy continuous test error

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25415)

10 months agodrbg: Fix typo
Pauli [Wed, 4 Sep 2024 03:15:26 +0000 (13:15 +1000)] 
drbg: Fix typo

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25415)

10 months agoDon't restrict what EVP_PKEY_Q_keygen can be used for
Matt Caswell [Mon, 16 Sep 2024 11:00:32 +0000 (12:00 +0100)] 
Don't restrict what EVP_PKEY_Q_keygen can be used for

The EVP_PKEY_Q_keygen function contains a list of algorithm type names
and fails if the requested name is not in the list. This prevents the use
of this function for externally supplied key type names.

We should just assume that any unrecognised key type name does not require
a parameter.

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/25468)

10 months agoBuild: Fix circular object deps with old GCC
Orgad Shaneh [Thu, 12 Sep 2024 20:23:46 +0000 (23:23 +0300)] 
Build: Fix circular object deps with old GCC

When both -o and -MT are used, GCC 4.1 prints the object file twice in
the dependency file. e.g.:

foo.o foo.o: foo.c

If the file name is long, then the second occurrence moves to the next
line. e.g.:

ssl/statem/libssl-shlib-statem_dtls.o \
  ssl/statem/libssl-shlib-statem_dtls.o: ../ssl/statem/statem_dtls.c \

add-depends script scans one line at a time, so when the first line is
processed, the object file becomes a dependency itself.

Fix by removing -MT altogether.

This also fixes makedepend for nonstop platform.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25455)

10 months agofeat: use ossl_serial_number_print in X509_print_ex
Jonathan M. Wilbur [Mon, 16 Sep 2024 21:39:57 +0000 (23:39 +0200)] 
feat: use ossl_serial_number_print in X509_print_ex

fixup: Remove trailing space previously added

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25428)

10 months agofeat: use ossl_serial_number_print in X509_print_ex
Jonathan M. Wilbur [Thu, 12 Sep 2024 11:07:04 +0000 (11:07 +0000)] 
feat: use ossl_serial_number_print in X509_print_ex

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25428)

10 months agofeat: add ossl_serial_number_print
Jonathan M. Wilbur [Thu, 12 Sep 2024 10:52:20 +0000 (10:52 +0000)] 
feat: add ossl_serial_number_print

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25428)

10 months agotest: the roleSpecCertIdentifier X.509v3 extension
Jonathan M. Wilbur [Wed, 11 Sep 2024 00:46:33 +0000 (00:46 +0000)] 
test: the roleSpecCertIdentifier X.509v3 extension

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25428)

10 months agodoc: support the roleSpecCertIdentifier X.509v3 extension
Jonathan M. Wilbur [Wed, 11 Sep 2024 00:46:10 +0000 (00:46 +0000)] 
doc: support the roleSpecCertIdentifier X.509v3 extension

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25428)

10 months agofeat: support the roleSpecCertIdentifier X.509v3 extension
Jonathan M. Wilbur [Wed, 11 Sep 2024 00:44:35 +0000 (00:44 +0000)] 
feat: support the roleSpecCertIdentifier X.509v3 extension

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25428)

10 months agoEVP_get_default_properties - tests
Dmitry Belyavskiy [Wed, 11 Sep 2024 14:48:44 +0000 (16:48 +0200)] 
EVP_get_default_properties - tests

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25434)

10 months agoEVP_get_default_properties - make update
Dmitry Belyavskiy [Wed, 11 Sep 2024 14:04:21 +0000 (16:04 +0200)] 
EVP_get_default_properties - make update

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25434)

10 months agoEVP_get_default_properties - documentation
Dmitry Belyavskiy [Wed, 11 Sep 2024 14:02:38 +0000 (16:02 +0200)] 
EVP_get_default_properties - documentation

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25434)

10 months agoEVP_get_default_properties - implementation
Dmitry Belyavskiy [Wed, 11 Sep 2024 14:02:14 +0000 (16:02 +0200)] 
EVP_get_default_properties - implementation

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25434)

10 months agoreview fixups for quic-hq-interop
Neil Horman [Wed, 11 Sep 2024 13:53:49 +0000 (09:53 -0400)] 
review fixups for quic-hq-interop

Reviewed-by: Sasa Nedvedicky <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25426)

10 months agoClean up style issues
Neil Horman [Tue, 10 Sep 2024 20:42:47 +0000 (16:42 -0400)] 
Clean up style issues

Reviewed-by: Sasa Nedvedicky <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25426)

10 months agoAdd some more tests to the interop matrix and fixup a typo
Neil Horman [Tue, 10 Sep 2024 19:51:14 +0000 (15:51 -0400)] 
Add some more tests to the interop matrix and fixup a typo

* Add resumption and multiplexing tests
* Remove needless head -n operation when patching implementation.json

Reviewed-by: Sasa Nedvedicky <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25426)

10 months agoAdding more documentation
Neil Horman [Tue, 10 Sep 2024 19:46:02 +0000 (15:46 -0400)] 
Adding more documentation

Reviewed-by: Sasa Nedvedicky <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25426)

10 months agoDo batching of stream requests
Neil Horman [Fri, 6 Sep 2024 14:57:55 +0000 (10:57 -0400)] 
Do batching of stream requests

We have a limited number of streams to use
send requests in accordance with the number of streams we have
and batch requests according to that limit

Reviewed-by: Sasa Nedvedicky <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25426)

10 months agosupport polling of multiple streams
Neil Horman [Wed, 4 Sep 2024 20:16:51 +0000 (16:16 -0400)] 
support polling of multiple streams

Reviewed-by: Sasa Nedvedicky <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25426)

10 months agoupdate quic docker container files
Neil Horman [Fri, 30 Aug 2024 16:48:33 +0000 (12:48 -0400)] 
update quic docker container files

1) Limit clone depth to allow faster fetches
2) Supply OPENSSL_URL and OPENSSL_BRANCH args to allow for branch
   testing

Reviewed-by: Sasa Nedvedicky <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25426)

10 months agoAdd lots of docs
Neil Horman [Thu, 29 Aug 2024 20:36:20 +0000 (16:36 -0400)] 
Add lots of docs

Reviewed-by: Sasa Nedvedicky <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25426)

10 months agoAdding session resume support to hq-interop
Neil Horman [Thu, 29 Aug 2024 17:52:58 +0000 (13:52 -0400)] 
Adding session resume support to hq-interop

Reviewed-by: Sasa Nedvedicky <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25426)

10 months agoConvert retry test to use hq-interop client
Neil Horman [Thu, 29 Aug 2024 16:11:15 +0000 (12:11 -0400)] 
Convert retry test to use hq-interop client

Reviewed-by: Sasa Nedvedicky <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25426)

10 months agoAdding an hq-interop alpn client
Neil Horman [Thu, 22 Aug 2024 19:17:32 +0000 (15:17 -0400)] 
Adding an hq-interop alpn client

Reviewed-by: Sasa Nedvedicky <sashan@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25426)

10 months agoDetect fin state of a QUIC stream for streams which are completely read
Neil Horman [Thu, 5 Sep 2024 19:49:14 +0000 (15:49 -0400)] 
Detect fin state of a QUIC stream for streams which are completely read

SSL_poll indicates that a stream which has had the fin bit set on it,
should generate SSL_POLL_EVENT_R events, so that applications can detect
stream completion via SSL_read_ex and SSL_get_error returning
SSL_ERROR_ZERO_RETURN.

However, the quic polling code misses on this, as a client that
completely reads a buffer after receipt has its underlying stream buffer
freed, loosing the fin status

We can however detect stream completion still, as a stream which has
been finalized, and had all its data read will be in the
QUIC_RSTREAM_STATE_DATA_READ state, iff the fin bit was set.

Fix it by checking in test_poll_event_r for that state, and generating a
SSL_POLL_EVENT_R if its found to be true, so as to stay in line with the
docs.

Fixes openssl/private#627

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Sasa Nedvedicky <sashan@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25399)

10 months agodocs: Correct bad link to provider-keymgmt(7) in provider-signature(7)
Richard Levitte [Fri, 13 Sep 2024 04:25:26 +0000 (06:25 +0200)] 
docs: Correct bad link to provider-keymgmt(7) in provider-signature(7)

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25423)

10 months agodocs: Document the new signature interface for providers
Richard Levitte [Tue, 10 Sep 2024 16:16:10 +0000 (18:16 +0200)] 
docs: Document the new signature interface for providers

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25423)

10 months agoIANA has assigned numbers for new TLS Supported Groups in ML-KEM
Sahana Prasad [Thu, 12 Sep 2024 10:21:30 +0000 (12:21 +0200)] 
IANA has assigned numbers for new TLS Supported Groups in ML-KEM
https://www.ietf.org/archive/id/draft-kwiatkowski-tls-ecdhe-mlkem-01.html#name-iana-considerations
Signed-off-by: Sahana Prasad <sahana@redhat.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/25477)

10 months agoAdd Missing Error Messages for AES-OCB Tag Length Validation
erbsland-dev [Tue, 10 Sep 2024 19:24:59 +0000 (21:24 +0200)] 
Add Missing Error Messages for AES-OCB Tag Length Validation

Related to #8331
Addressing found issues by adding specific error messages to improve
feedback when tag length checks fail for the `EVP_CTRL_AEAD_SET_TAG`
parameter in the AES-OCB algorithm.

- Added PROV_R_INVALID_TAG_LENGTH error to indicate when the current tag
  length exceeds the maximum tag length of the algorithm.
- Added `PROV_R_INVALID_TAG_LENGTH` error to indicate when the current tag
  length in the context does not match a custom tag length provided as
  a parameter.
- Added `ERR_R_PASSED_INVALID_ARGUMENT` error to handle cases where an
  invalid pointer is passed in encryption mode.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25425)

10 months agos390x: Add hardware acceleration for full AES-XTS
Holger Dengler [Tue, 6 Aug 2024 12:00:49 +0000 (14:00 +0200)] 
s390x: Add hardware acceleration for full AES-XTS

The CPACF instruction KM provides support for accelerating the full
AES-XTS algorithm on newer machines for AES_XTS_128 and AES_XTS_256.

Preliminary measurements showed performance improvements of up to 50%,
dependent on the message size.

Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25414)

10 months agoUpdate the version to 3.5.0-dev
Tomas Mraz [Wed, 11 Sep 2024 15:58:01 +0000 (17:58 +0200)] 
Update the version to 3.5.0-dev

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/25437)

10 months agodocs: Document the implemented composite signature+hash algorithms
Richard Levitte [Tue, 10 Sep 2024 14:43:43 +0000 (16:43 +0200)] 
docs: Document the implemented composite signature+hash algorithms

The details for RSA and EdDSA have already been documented, albeit the
RSA documentation wasn't conforming properly to the POD format.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25422)

10 months agos_server: Support reading HTTP request from early data
Daiki Ueno [Wed, 11 Sep 2024 01:13:55 +0000 (10:13 +0900)] 
s_server: Support reading HTTP request from early data

This would be useful when testing with browsers / downloaders which
support 0-RTT only through HTTP.

Signed-off-by: Daiki Ueno <dueno@redhat.com>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/16055)

10 months agofix small footprint builds on arm
Gerd Hoffmann [Mon, 9 Sep 2024 15:09:34 +0000 (17:09 +0200)] 
fix small footprint builds on arm

Building with '-D OPENSSL_SMALL_FOOTPRINT' for aarch64 fails due to
'gcm_ghash_4bit' being undeclared.  Fix that by not setting the function
pointer when building with OPENSSL_SMALL_FOOTPRINT, matching openssl
behavior on x86.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25419)

10 months agodocument provider dependency handling
Michael Baentsch [Mon, 15 Jul 2024 04:54:48 +0000 (06:54 +0200)] 
document provider dependency handling

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24884)

10 months agoCleanup of unused functions and macros in ssl_local.h
Frederik Wedel-Heinen [Fri, 14 Jun 2024 12:01:40 +0000 (14:01 +0200)] 
Cleanup of unused functions and macros in ssl_local.h

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24648)

10 months agofeat: print <none> in issuer serials in ac targeting extension
Jonathan M. Wilbur [Sat, 7 Sep 2024 09:50:34 +0000 (09:50 +0000)] 
feat: print <none> in issuer serials in ac targeting extension

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25244)

10 months agotest: authorityAttributeIdentifier X.509v3 extension
Jonathan M. Wilbur [Wed, 21 Aug 2024 02:25:03 +0000 (02:25 +0000)] 
test: authorityAttributeIdentifier X.509v3 extension

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25244)

10 months agodoc: authorityAttributeIdentifier-related ASN.1 symbols
Jonathan M. Wilbur [Wed, 21 Aug 2024 02:24:49 +0000 (02:24 +0000)] 
doc: authorityAttributeIdentifier-related ASN.1 symbols

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25244)

10 months agofeat: support the authorityAttributeIdentifier X.509v3 extension
Jonathan M. Wilbur [Wed, 21 Aug 2024 02:24:15 +0000 (02:24 +0000)] 
feat: support the authorityAttributeIdentifier X.509v3 extension

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25244)

10 months agoAdd NonStop KLT Configuration for new platform kernel treading model.
Randall S. Becker [Wed, 17 Apr 2024 21:11:42 +0000 (05:11 +0800)] 
Add NonStop KLT Configuration for new platform kernel treading model.

This fix supports the new NonStop KLT threading model, including
configurations and documentation for using this model.

Fixes: fix-24175
Signed-off-by: Randall S. Becker <randall.becker@nexbridge.ca>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25016)

10 months agoUse Jq to add openssl to interop test harness
Neil Horman [Mon, 9 Sep 2024 12:02:13 +0000 (08:02 -0400)] 
Use Jq to add openssl to interop test harness

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25256)

10 months agoCollapse errors down by using || in run_endpoint.sh
Neil Horman [Thu, 29 Aug 2024 20:54:19 +0000 (16:54 -0400)] 
Collapse errors down by using || in run_endpoint.sh

Makes for smaller more consistent coding

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25256)

10 months agoAdd interop status badge
Neil Horman [Wed, 21 Aug 2024 16:32:28 +0000 (12:32 -0400)] 
Add interop status badge

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25256)

10 months agoNeed to remove our bash settings as we need to interrogate failures
Neil Horman [Mon, 19 Aug 2024 19:39:16 +0000 (15:39 -0400)] 
Need to remove our bash settings as we need to interrogate failures

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25256)

10 months agoAdd local nightly interop running
Neil Horman [Fri, 16 Aug 2024 19:42:50 +0000 (15:42 -0400)] 
Add local nightly interop running

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25256)

10 months agoReduce footprint of Windows CI
Tomas Mraz [Wed, 4 Sep 2024 09:34:12 +0000 (11:34 +0200)] 
Reduce footprint of Windows CI

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Hugo Landau <hlandau@devever.net>
(Merged from https://github.com/openssl/openssl/pull/25378)

10 months agoAdd Windows build with enable-fips no-thread-pool no-quic
Tomas Mraz [Wed, 4 Sep 2024 07:27:52 +0000 (09:27 +0200)] 
Add Windows build with enable-fips no-thread-pool no-quic

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Hugo Landau <hlandau@devever.net>
(Merged from https://github.com/openssl/openssl/pull/25378)

10 months agoFix no-thread-pool build on Windows
Tomas Mraz [Wed, 4 Sep 2024 07:27:28 +0000 (09:27 +0200)] 
Fix no-thread-pool build on Windows

thread/arch/thread_win.c must be included into libcrypto as rcu depends
on ossl_crypto_mutex implementation on Windows.

Fixes #25337

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Hugo Landau <hlandau@devever.net>
(Merged from https://github.com/openssl/openssl/pull/25378)

10 months agoAdd a test for the nonce-type sigopt
Matt Caswell [Thu, 8 Aug 2024 15:12:11 +0000 (16:12 +0100)] 
Add a test for the nonce-type sigopt

Check that using the nonce-type sigopt via the dgst app works correctly

Based on the reproducer from #25012

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25057)

10 months agoDon't restrict the ECDSA settable ctx params unnecessarily
Matt Caswell [Wed, 31 Jul 2024 13:24:12 +0000 (14:24 +0100)] 
Don't restrict the ECDSA settable ctx params unnecessarily

We just allow all possible settables all the time. Some things like the
digest name can't actually be changed in some circumstances - but we already
have checks for those things. It's still possible to pass a digest of the
same name to one that's already been set for example.

Fixes #25012

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25057)

10 months agoComplain about a missing digest when doing deterministic ECDSA
Matt Caswell [Wed, 31 Jul 2024 13:08:40 +0000 (14:08 +0100)] 
Complain about a missing digest when doing deterministic ECDSA

We need a digest for the none when doing deterministic ECDSA. Give a
better error message if one hasn't been supplied.

See openssl/openssl#25012

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25057)

10 months agoAdd missing security rules about NULL check to various manpages
icy17 [Wed, 7 Aug 2024 08:54:14 +0000 (16:54 +0800)] 
Add missing security rules about NULL check to various manpages

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25083)

10 months agoMinor WINDOWS.md cleanups
ha1215 [Tue, 23 Apr 2024 01:54:36 +0000 (21:54 -0400)] 
Minor WINDOWS.md cleanups

The possessive form of "Windows" has been updated from "Windows's"
to "Windows'".

The function call "a poll(2) call" has been specified as
"a poll(2) system call" for clarity.

The phrase "and supposed" has been corrected to "and was supposed" to
improve sentence structure.

The phrase "However Microsoft has" now includes a comma, revised to
"However, Microsoft has" to enhance readability.

The statement "Supporting these is a pain" has been adjusted to
"Supporting these can be a pain" to better convey potential variability
in user experience.

CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24242)