]> git.ipfire.org Git - thirdparty/xz.git/log
thirdparty/xz.git
2 years agoliblzma: Improve comment in string_conversion.c.
Jia Tan [Tue, 18 Jul 2023 14:49:57 +0000 (22:49 +0800)] 
liblzma: Improve comment in string_conversion.c.

The comment used "flag" when referring to decoder options. Just
referring to them as options is more clear and consistent.

2 years agoliblzma: Reword lzma_str_list_filters() documentation.
Jia Tan [Sat, 13 May 2023 13:21:54 +0000 (21:21 +0800)] 
liblzma: Reword lzma_str_list_filters() documentation.

Reword "options required" to "options read". The previous wording
may have suggested that the options listed were all required when
the filters are used for encoding or decoding. Now it should be
more clear that the options listed are the ones relevant for
encoding or decoding.

2 years agoxz: Translate the second "%s: " in message.c since French needs "%s : ".
Lasse Collin [Tue, 18 Jul 2023 14:37:33 +0000 (17:37 +0300)] 
xz: Translate the second "%s: " in message.c since French needs "%s : ".

This string is used to print a filename when using "xz -v" and
stderr isn't a terminal.

2 years agoxz: Make "%s: %s" translatable because French needs "%s : %s".
Lasse Collin [Tue, 18 Jul 2023 11:35:33 +0000 (14:35 +0300)] 
xz: Make "%s: %s" translatable because French needs "%s : %s".

2 years agoliblzma: Tweak #if condition in memcmplen.h.
Lasse Collin [Tue, 18 Jul 2023 10:57:54 +0000 (13:57 +0300)] 
liblzma: Tweak #if condition in memcmplen.h.

Maybe ICC always #defines _MSC_VER on Windows but now
it's very clear which code will get used.

2 years agoliblzma: Omit unnecessary parenthesis in a preprocessor directive.
Lasse Collin [Tue, 18 Jul 2023 10:49:43 +0000 (13:49 +0300)] 
liblzma: Omit unnecessary parenthesis in a preprocessor directive.

2 years agoliblzma: Prevent warning for MSYS2 Windows build.
Jia Tan [Wed, 28 Jun 2023 12:22:38 +0000 (20:22 +0800)] 
liblzma: Prevent warning for MSYS2 Windows build.

In lzma_memcmplen(), the <intrin.h> header file is only included if
_MSC_VER and _M_X64 are both defined but _BitScanForward64() was
previously used if _M_X64 was defined. GCC for MSYS2 defines _M_X64 but
not _MSC_VER so _BitScanForward64() was used without including
<intrin.h>.

Now, lzma_memcmplen() will use __builtin_ctzll() for MSYS2 GCC builds as
expected.

2 years agoDocs: Add a new section to INSTALL for Tests.
Jia Tan [Fri, 14 Jul 2023 15:20:33 +0000 (23:20 +0800)] 
Docs: Add a new section to INSTALL for Tests.

The new Tests section describes basic information about the tests, how
to run them, and important details when cross compiling. We have had a
few questions about how to compile the tests without running them, so
hopefully this information will help others with the same question in the
future.

Fixes: https://github.com/tukaani-project/xz/issues/54
2 years agoDocs: Update README.
Jia Tan [Fri, 14 Jul 2023 13:10:27 +0000 (21:10 +0800)] 
Docs: Update README.

This adds an entry to "Other implementations of the .xz format" for
XZ for Java.

2 years agoxz: Fix typo in man page.
Jia Tan [Tue, 18 Jul 2023 10:27:46 +0000 (13:27 +0300)] 
xz: Fix typo in man page.

The Memory limit information section described three output
columns when it actually has six. This was reworded to
"multiple" to make it more future proof.

2 years agoTests: Improve feature testing for skipping.
Jia Tan [Fri, 14 Jul 2023 13:30:25 +0000 (21:30 +0800)] 
Tests: Improve feature testing for skipping.

Fixed a bug where test_compress_* would all fail if arm64 or armthumb
filters were enabled for compression but arm was disabled. Since the
grep tests only checked for "define HAVE_ENCODER_ARM", this would match
on HAVE_ENCODER_ARM64 or HAVE_ENCODER_ARMTHUMB.

Now the config.h feature test requires " 1" at the end to prevent the
prefix problem. have_feature() was also updated for this even though
there were known current bugs affecting it. This is just in case future
features have a similar prefix problem.

2 years agoTranslations: Update the Chinese (traditional) translation.
Jia Tan [Mon, 10 Jul 2023 12:56:28 +0000 (20:56 +0800)] 
Translations: Update the Chinese (traditional) translation.

2 years agoTranslations: Update the Vietnamese translation.
Jia Tan [Sat, 8 Jul 2023 12:03:59 +0000 (20:03 +0800)] 
Translations: Update the Vietnamese translation.

2 years agoTests: Fix memory leaks in test_index.
Jia Tan [Wed, 28 Jun 2023 12:46:31 +0000 (20:46 +0800)] 
Tests: Fix memory leaks in test_index.

Several tests were missing calls to lzma_index_end() to clean up the
lzma_index structs. The memory leaks were discovered by using
-fsanitize=address with GCC.

2 years agoTests: Fix memory leaks in test_block_header.
Jia Tan [Wed, 28 Jun 2023 12:43:29 +0000 (20:43 +0800)] 
Tests: Fix memory leaks in test_block_header.

test_block_header was not properly freeing the filter options between
calls to lzma_block_header_decode(). The memory leaks were discovered by
using -fsanitize=address with GCC.

2 years agoliblzma: Prevent uninitialzed warning in mt stream encoder.
Jia Tan [Wed, 28 Jun 2023 12:31:11 +0000 (20:31 +0800)] 
liblzma: Prevent uninitialzed warning in mt stream encoder.

This change only impacts the compiler warning since it was impossible
for the wait_abs struct in stream_encode_mt() to be used before it was
initialized since mythread_condtime_set() will always be called before
mythread_cond_timedwait().

Since the mythread.h code is different between the POSIX and
Windows versions, this warning was only present on Windows builds.

Thanks to Arthur S for reporting the warning and providing an initial
patch.

2 years agoUpdate THANKS.
Jia Tan [Tue, 6 Jun 2023 16:10:38 +0000 (00:10 +0800)] 
Update THANKS.

2 years agoCMake: Protects against double find_package
Benjamin Buch [Tue, 6 Jun 2023 13:32:45 +0000 (15:32 +0200)] 
CMake: Protects against double find_package

Boost iostream uses `find_package` in quiet mode and then again uses
`find_package` with required. This second call triggers a
`add_library cannot create imported target "LibLZMA::LibLZMA"
because another target with the same name already exists.`

This can simply be fixed by skipping the alias part on secondary
`find_package` runs.

2 years agoTranslations: Update the Esperanto translation.
Jia Tan [Wed, 31 May 2023 12:26:42 +0000 (20:26 +0800)] 
Translations: Update the Esperanto translation.

2 years agoTranslations: Update the Croatian translation.
Jia Tan [Wed, 31 May 2023 12:25:00 +0000 (20:25 +0800)] 
Translations: Update the Croatian translation.

2 years agoTranslations: Update the Chinese (simplified) translation.
Jia Tan [Wed, 31 May 2023 12:15:53 +0000 (20:15 +0800)] 
Translations: Update the Chinese (simplified) translation.

2 years agoTranslations: Update German translation of man pages.
Jia Tan [Wed, 17 May 2023 15:12:13 +0000 (23:12 +0800)] 
Translations: Update German translation of man pages.

2 years agoTranslations: Update the German translation.
Jia Tan [Wed, 17 May 2023 15:09:18 +0000 (23:09 +0800)] 
Translations: Update the German translation.

2 years agoTranslations: Update the Croatian translation.
Jia Tan [Wed, 17 May 2023 12:30:01 +0000 (20:30 +0800)] 
Translations: Update the Croatian translation.

2 years agoTranslations: Update Korean translation of man pages.
Jia Tan [Wed, 17 May 2023 12:26:54 +0000 (20:26 +0800)] 
Translations: Update Korean translation of man pages.

2 years agoTranslations: Update the Korean translation.
Jia Tan [Wed, 17 May 2023 12:13:01 +0000 (20:13 +0800)] 
Translations: Update the Korean translation.

2 years agoTranslations: Update the Spanish translation.
Jia Tan [Tue, 16 May 2023 15:49:09 +0000 (23:49 +0800)] 
Translations: Update the Spanish translation.

2 years agoTranslations: Update the Romanian translation.
Jia Tan [Tue, 16 May 2023 15:47:23 +0000 (23:47 +0800)] 
Translations: Update the Romanian translation.

2 years agoTranslations: Update Romanian translation of man pages.
Jia Tan [Tue, 16 May 2023 15:45:43 +0000 (23:45 +0800)] 
Translations: Update Romanian translation of man pages.

2 years agoTranslations: Update Ukrainian translation of man pages.
Jia Tan [Tue, 16 May 2023 15:43:51 +0000 (23:43 +0800)] 
Translations: Update Ukrainian translation of man pages.

2 years agoTranslations: Update the Ukrainian translation.
Jia Tan [Tue, 16 May 2023 15:37:54 +0000 (23:37 +0800)] 
Translations: Update the Ukrainian translation.

2 years agoTranslations: Update the Polish translation.
Jia Tan [Tue, 16 May 2023 15:07:35 +0000 (23:07 +0800)] 
Translations: Update the Polish translation.

2 years agoTranslations: Update the Swedish translation.
Jia Tan [Tue, 16 May 2023 14:52:14 +0000 (22:52 +0800)] 
Translations: Update the Swedish translation.

2 years agoTranslations: Update the Esperanto translation.
Jia Tan [Tue, 16 May 2023 13:21:38 +0000 (21:21 +0800)] 
Translations: Update the Esperanto translation.

2 years agoliblzma: Adds lzma_nothrow to MicroLZMA API functions.
Jia Tan [Thu, 11 May 2023 15:49:23 +0000 (23:49 +0800)] 
liblzma: Adds lzma_nothrow to MicroLZMA API functions.

None of the liblzma functions may throw an exception, so this
attribute should be applied to all liblzma API functions.

2 years agoTranslations: Update the Croatian translation. v5.4.3
Jia Tan [Thu, 4 May 2023 12:38:52 +0000 (20:38 +0800)] 
Translations: Update the Croatian translation.

2 years agoBump version and soname for 5.4.3.
Jia Tan [Thu, 4 May 2023 11:50:42 +0000 (19:50 +0800)] 
Bump version and soname for 5.4.3.

2 years agoAdd NEWS for 5.4.3.
Jia Tan [Tue, 2 May 2023 12:39:56 +0000 (20:39 +0800)] 
Add NEWS for 5.4.3.

2 years agotuklib_integer.h: Fix a recent copypaste error in Clang detection.
Lasse Collin [Wed, 3 May 2023 19:46:42 +0000 (22:46 +0300)] 
tuklib_integer.h: Fix a recent copypaste error in Clang detection.

Wrong line was changed in 7062348bf35c1e4cbfee00ad9fffb4a21aa6eff7.
Also, this has >= instead of == since ints larger than 32 bits would
work too even if not relevant in practice.

2 years agoUpdate THANKS.
Jia Tan [Thu, 20 Apr 2023 12:15:00 +0000 (20:15 +0800)] 
Update THANKS.

2 years agoWindows: Include <intrin.h> when needed.
Jia Tan [Wed, 19 Apr 2023 14:22:16 +0000 (22:22 +0800)] 
Windows: Include <intrin.h> when needed.

Legacy Windows did not need to #include <intrin.h> to use the MSVC
intrinsics. Newer versions likely just issue a warning, but the MSVC
documentation says to include the header file for the intrinsics we use.

GCC and Clang can "pretend" to be MSVC on Windows, so extra checks are
needed in tuklib_integer.h to only include <intrin.h> when it will is
actually needed.

2 years agotuklib_integer: Use __builtin_clz() with Clang.
Jia Tan [Wed, 19 Apr 2023 13:59:03 +0000 (21:59 +0800)] 
tuklib_integer: Use __builtin_clz() with Clang.

Clang has support for __builtin_clz(), but previously Clang would
fallback to either the MSVC intrinsic or the regular C code. This was
discovered due to a bug where a new version of Clang required the
<intrin.h> header file in order to use the MSVC intrinsics.

Thanks to Anton Kochkov for notifying us about the bug.

2 years agoliblzma: Update project maintainers in lzma.h.
Lasse Collin [Fri, 14 Apr 2023 15:42:33 +0000 (18:42 +0300)] 
liblzma: Update project maintainers in lzma.h.

AUTHORS was updated earlier, lzma.h was simply forgotten.

2 years agoliblzma: Cleans up old commented out code.
Jia Tan [Thu, 13 Apr 2023 12:45:19 +0000 (20:45 +0800)] 
liblzma: Cleans up old commented out code.

2 years agoCMake: Update liblzma-config.cmake generation.
Jia Tan [Tue, 28 Mar 2023 14:32:40 +0000 (22:32 +0800)] 
CMake: Update liblzma-config.cmake generation.

Now that the threading is configurable, the liblzma CMake package only
needs the threading library when using POSIX threads.

2 years agoCMake: Allows setting thread method.
Jia Tan [Tue, 28 Mar 2023 14:25:33 +0000 (22:25 +0800)] 
CMake: Allows setting thread method.

The thread method is now configurable for the CMake build. It matches
the Autotools build by allowing ON (pick the best threading method),
OFF (no threading), posix, win95, and vista. If both Windows and
posix threading are both available, then ON will choose Windows
threading. Windows threading will also not use:

target_link_libraries(liblzma Threads::Threads)

since on systems like MinGW-w64 it would link the posix threads
without purpose.

2 years agoCMake: Only build xzdec if decoders are enabled.
Jia Tan [Fri, 24 Mar 2023 12:05:59 +0000 (20:05 +0800)] 
CMake: Only build xzdec if decoders are enabled.

2 years agoBuild: Removes redundant check for LZMA1 filter support.
Jia Tan [Wed, 22 Mar 2023 07:42:04 +0000 (15:42 +0800)] 
Build: Removes redundant check for LZMA1 filter support.

2 years agoCMake: Bump maximum policy version to 3.26.
Lasse Collin [Thu, 23 Mar 2023 13:14:29 +0000 (15:14 +0200)] 
CMake: Bump maximum policy version to 3.26.

It adds only one new policy related to FOLDERS which we don't use.
This makes it clear that the code is compatible with the policies
up to 3.26.

2 years agoCMake: Conditionally build xz list.* files if decoders are enabled.
Jia Tan [Tue, 21 Mar 2023 15:36:00 +0000 (23:36 +0800)] 
CMake: Conditionally build xz list.* files if decoders are enabled.

2 years agoCMake: Allow configuring features as cache variables.
Jia Tan [Sat, 25 Feb 2023 03:46:50 +0000 (11:46 +0800)] 
CMake: Allow configuring features as cache variables.

This allows users to change the features they build either in
CMakeCache.txt or by using a CMake GUI. The sources built for
liblzma are affected by this too, so only the necessary files
will be compiled.

2 years agoBuild: Add a comment that AC_PROG_CC_C99 is needed for Autoconf 2.69.
Lasse Collin [Tue, 21 Mar 2023 12:07:51 +0000 (14:07 +0200)] 
Build: Add a comment that AC_PROG_CC_C99 is needed for Autoconf 2.69.

It's obsolete in Autoconf >= 2.70 and just an alias for AC_PROG_CC
but Autoconf 2.69 requires AC_PROG_CC_C99 to get a C99 compiler.

2 years agoBuild: configure.ac: Use AS_IF and AS_CASE where required.
Lasse Collin [Tue, 21 Mar 2023 12:04:37 +0000 (14:04 +0200)] 
Build: configure.ac: Use AS_IF and AS_CASE where required.

This makes no functional difference in the generated configure
(at least with the Autotools versions I have installed) but this
change might prevent future bugs like the one that was just
fixed in the commit 5a5bd7f871818029d5ccbe189f087f591258c294.

2 years agoUpdate THANKS.
Lasse Collin [Tue, 21 Mar 2023 11:12:03 +0000 (13:12 +0200)] 
Update THANKS.

2 years agoBuild: Fix --disable-threads breaking the building of shared libs.
Lasse Collin [Tue, 21 Mar 2023 11:11:49 +0000 (13:11 +0200)] 
Build: Fix --disable-threads breaking the building of shared libs.

This is broken in the releases 5.2.6 to 5.4.2. A workaround
for these releases is to pass EGREP='grep -E' as an argument
to configure in addition to --disable-threads.

The problem appeared when m4/ax_pthread.m4 was updated in
the commit 6629ed929cc7d45a11e385f357ab58ec15e7e4ad which
introduced the use of AC_EGREP_CPP. AC_EGREP_CPP calls
AC_REQUIRE([AC_PROG_EGREP]) to set the shell variable EGREP
but this was only executed if POSIX threads were enabled.
Libtool code also has AC_REQUIRE([AC_PROG_EGREP]) but Autoconf
omits it as AC_PROG_EGREP has already been required earlier.
Thus, if not using POSIX threads, the shell variable EGREP
would be undefined in the Libtool code in configure.

ax_pthread.m4 is fine. The bug was in configure.ac which called
AX_PTHREAD conditionally in an incorrect way. Using AS_CASE
ensures that all AC_REQUIREs get always run.

Thanks to Frank Busse for reporting the bug.
Fixes: https://github.com/tukaani-project/xz/issues/45
2 years agoliblzma: Silence -Wsign-conversion in SSE2 code in memcmplen.h.
Lasse Collin [Sun, 19 Mar 2023 20:45:59 +0000 (22:45 +0200)] 
liblzma: Silence -Wsign-conversion in SSE2 code in memcmplen.h.

Thanks to Christian Hesse for reporting the issue.
Fixes: https://github.com/tukaani-project/xz/issues/44
2 years agoBump version and soname for 5.4.2. v5.4.2
Jia Tan [Sat, 18 Mar 2023 15:22:06 +0000 (23:22 +0800)] 
Bump version and soname for 5.4.2.

2 years agoAdd NEWS for 5.4.2.
Jia Tan [Sat, 18 Mar 2023 14:10:57 +0000 (22:10 +0800)] 
Add NEWS for 5.4.2.

2 years agoUpdate the copy of GNU GPLv3 from gnu.org to COPYING.GPLv3.
Lasse Collin [Sat, 18 Mar 2023 14:00:54 +0000 (16:00 +0200)] 
Update the copy of GNU GPLv3 from gnu.org to COPYING.GPLv3.

2 years agoChange a few HTTP URLs to HTTPS.
Lasse Collin [Sat, 18 Mar 2023 13:51:57 +0000 (15:51 +0200)] 
Change a few HTTP URLs to HTTPS.

The xz man page timestamp was intentionally left unchanged.

2 years agoCMake: Fix typo in a comment.
Jia Tan [Fri, 17 Mar 2023 16:40:28 +0000 (00:40 +0800)] 
CMake: Fix typo in a comment.

2 years agoWindows: build.bash: Copy liblzma API docs to the output package.
Lasse Collin [Fri, 17 Mar 2023 16:36:22 +0000 (18:36 +0200)] 
Windows: build.bash: Copy liblzma API docs to the output package.

2 years agoWindows: Add microlzma_*.c to the VS project files.
Lasse Collin [Fri, 17 Mar 2023 06:53:38 +0000 (08:53 +0200)] 
Windows: Add microlzma_*.c to the VS project files.

These should have been included in 5.3.2alpha already.

2 years agoCMake: Add microlzma_*.c to the build.
Lasse Collin [Fri, 17 Mar 2023 06:43:51 +0000 (08:43 +0200)] 
CMake: Add microlzma_*.c to the build.

These should have been included in 5.3.2alpha already.

2 years agoBuild: Update comments about unaligned access to mention 64-bit.
Lasse Collin [Fri, 17 Mar 2023 06:41:36 +0000 (08:41 +0200)] 
Build: Update comments about unaligned access to mention 64-bit.

2 years agoTests: Update .gitignore.
Lasse Collin [Thu, 16 Mar 2023 22:02:30 +0000 (00:02 +0200)] 
Tests: Update .gitignore.

2 years agopo4a/update-po: Display the script name consistently in error messages.
Lasse Collin [Tue, 14 Mar 2023 18:04:03 +0000 (20:04 +0200)] 
po4a/update-po: Display the script name consistently in error messages.

2 years agoDoc: Rename Doxygen HTML doc directory name liblzma => api.
Jia Tan [Thu, 16 Mar 2023 17:30:36 +0000 (01:30 +0800)] 
Doc: Rename Doxygen HTML doc directory name liblzma => api.

When the docs are installed, calling the directory "liblzma" is
confusing since multiple other files in the doc directory are for
liblzma. This should also make it more natural for distros when they
package the documentation.

2 years agoliblzma: Remove note from lzma_options_bcj about the ARM64 exception.
Jia Tan [Thu, 16 Mar 2023 14:07:15 +0000 (22:07 +0800)] 
liblzma: Remove note from lzma_options_bcj about the ARM64 exception.

This was left in by mistake since an early version of the ARM64 filter
used a different struct for its options.

2 years agoCOPYING: Add a note about the included Doxygen-generated HTML.
Lasse Collin [Wed, 15 Mar 2023 17:19:13 +0000 (19:19 +0200)] 
COPYING: Add a note about the included Doxygen-generated HTML.

2 years agoDoc: Update PACKAGERS with details about liblzma API docs install.
Jia Tan [Thu, 16 Mar 2023 13:41:09 +0000 (21:41 +0800)] 
Doc: Update PACKAGERS with details about liblzma API docs install.

2 years agoliblzma: Add set lzma.h as the main page for Doxygen documentation.
Jia Tan [Thu, 16 Mar 2023 13:38:32 +0000 (21:38 +0800)] 
liblzma: Add set lzma.h as the main page for Doxygen documentation.

The \mainpage command is used in the first block of comments in lzma.h.
This changes the previously nearly empty index.html to use the first
comment block in lzma.h for its contents.

lzma.h is no longer documented separately, but this is for the better
since lzma.h only defined a few macros that users do not need to use.
The individual API header files all have a disclaimer that they should
not be #included directly, so there should be no confusion on the fact
that lzma.h should be the only header used by applications.

Additionally, the note "See ../lzma.h for information about liblzma as
a whole." was removed since lzma.h is now the main page of the
generated HTML and does not have its own page anymore. So it would be
confusing in the HTML version and was only a "nice to have" when
browsing the source files.

2 years agoBuild: Generate doxygen documentation in autogen.sh.
Jia Tan [Thu, 16 Mar 2023 13:37:32 +0000 (21:37 +0800)] 
Build: Generate doxygen documentation in autogen.sh.

Another command line option (--no-doxygen) was added to disable
creating the doxygen documenation in cases where it not wanted or
if the doxygen tool is not installed.

2 years agoBuild: Create doxygen/update-doxygen script.
Jia Tan [Thu, 16 Mar 2023 13:35:55 +0000 (21:35 +0800)] 
Build: Create doxygen/update-doxygen script.

This is a helper script to generate the Doxygen documentation. It can be
run in 'liblzma' or 'internal' mode by setting the first argument. It
will default to 'liblzma' mode and only generate documentation for the
liblzma API header files.

The helper script will be run during the custom mydist hook when we
create releases. This hook already alters the source directory, so its
fine to do it here too. This way, we can include the Doxygen generated
files in the distrubtion and when installing.

In 'liblzma' mode, the JavaScript is stripped from the .html files and
the .js files are removed. This avoids license hassle from jQuery and
other libraries that Doxygen 1.9.6 puts into jquery.js in minified form.

2 years agoBuild: Install Doxygen docs and include in distribution if generated.
Jia Tan [Thu, 16 Mar 2023 13:34:36 +0000 (21:34 +0800)] 
Build: Install Doxygen docs and include in distribution if generated.

Added a install-data-local target to install the Doxygen documentation
only when it has been generated. In order to correctly remove the docs,
a corresponding uninstall-local target was added.

If the doxygen docs exist in the source tree, they will also be included
in the distribution now too.

2 years agoDoxygen: Refactor Doxyfile.in to doxygen/Doxyfile.
Jia Tan [Tue, 3 Jan 2023 12:37:30 +0000 (20:37 +0800)] 
Doxygen: Refactor Doxyfile.in to doxygen/Doxyfile.

Instead of having Doxyfile.in configured by Autoconf, the Doxyfile
can have the tags that need to be configured piped into the doxygen
command through stdin with the overrides after Doxyfile's contents.

Going forward, the documentation should be generated in two different
modes: liblzma or internal.

liblzma is useful for most users. It is the documentation for just
the liblzma API header files. This is the default.

internal is for people who want to understand how xz and liblzma work.
It might be useful for people who want to contribute to the project.

2 years agoTests: Remove unused macros and functions.
Jia Tan [Tue, 28 Feb 2023 15:22:36 +0000 (23:22 +0800)] 
Tests: Remove unused macros and functions.

2 years agoTests: Refactors existing lzma_index tests.
Jia Tan [Thu, 12 Jan 2023 14:29:07 +0000 (22:29 +0800)] 
Tests: Refactors existing lzma_index tests.

Converts the existing lzma_index tests into tuktests and covers every
API function from index.h except for lzma_file_info_decoder, which can
be tested in the future.

2 years agoxz: Make Capsicum sandbox more strict with stdin and stdout.
Lasse Collin [Tue, 7 Mar 2023 17:59:23 +0000 (19:59 +0200)] 
xz: Make Capsicum sandbox more strict with stdin and stdout.

2 years agoxz: Don't fail if Capsicum is enabled but kernel doesn't support it.
Lasse Collin [Sat, 11 Mar 2023 17:31:40 +0000 (19:31 +0200)] 
xz: Don't fail if Capsicum is enabled but kernel doesn't support it.

(This commit combines related commits from the master branch.)

If Capsicum support is missing from the kernel or xz is being run
in an emulator that lacks Capsicum suport, the syscalls will fail
and set errno to ENOSYS. Previously xz would display and error and
exit, making xz unusable. Now it will check for ENOSYS and run
without sandbox support. Other tools like ssh behave similarly.

Displaying a warning for missing Capsicum support was considered
but such extra output would quickly become annoying. It would also
break test_scripts.sh in "make check".

Also move cap_enter() to be the first step instead of the last one.
This matches the example in the cap_rights_limit(2) man page. With
the current code it shouldn't make any practical difference though.

Thanks to Xin Li for the bug report, suggesting a fix, and testing:
https://github.com/tukaani-project/xz/pull/43

Thanks to Jia Tan for most of the original commits.

2 years agoBuild: Adjust CMake version search regex.
Jia Tan [Sat, 4 Feb 2023 13:06:35 +0000 (21:06 +0800)] 
Build: Adjust CMake version search regex.

Now, the LZMA_VERSION_MAJOR, LZMA_VERSION_MINOR, and LZMA_VERSION_PATCH
macros do not need to be on consecutive lines in version.h. They can be
separated by more whitespace, comments, or even other content, as long
as they appear in the proper order (major, minor, patch).

2 years agoliblzma: Improve documentation for version.h.
Jia Tan [Thu, 26 Jan 2023 01:50:21 +0000 (09:50 +0800)] 
liblzma: Improve documentation for version.h.

Specified parameter and return values for API functions and documented
a few more of the macros.

2 years agoliblzma: Clarify lzma_lzma_preset() documentation in lzma12.h.
Jia Tan [Fri, 24 Feb 2023 15:46:23 +0000 (23:46 +0800)] 
liblzma: Clarify lzma_lzma_preset() documentation in lzma12.h.

lzma_lzma_preset() does not guarentee that the lzma_options_lzma are
usable in an encoder even if it returns false (success). If liblzma
is built with default configurations, then the options will always be
usable. However if the match finders hc3, hc4, or bt4 are disabled, then
the options may not be usable depending on the preset level requested.

The documentation was updated to reflect this complexity, since this
behavior was unclear before.

2 years agoCMake: Require that the C compiler supports C99 or a newer standard.
Lasse Collin [Mon, 27 Feb 2023 16:38:35 +0000 (18:38 +0200)] 
CMake: Require that the C compiler supports C99 or a newer standard.

Thanks to autoantwort for reporting the issue and suggesting
a different patch:
https://github.com/tukaani-project/xz/pull/42

2 years agoTests: Small tweak to test-vli.c.
Jia Tan [Fri, 24 Feb 2023 10:10:37 +0000 (18:10 +0800)] 
Tests: Small tweak to test-vli.c.

The static global variables can be disabled if encoders and decoders
are not built. If they are not disabled and -Werror is used, it will
cause an usused warning as an error.

2 years agoliblzma: Replace '\n' -> newline in filter.h documentation.
Jia Tan [Mon, 6 Feb 2023 13:46:43 +0000 (21:46 +0800)] 
liblzma: Replace '\n' -> newline in filter.h documentation.

The '\n' renders as a newline when the comments are converted to html
by Doxygen.

2 years agoliblzma: Shorten return description for two functions in filter.h.
Jia Tan [Mon, 6 Feb 2023 13:45:37 +0000 (21:45 +0800)] 
liblzma: Shorten return description for two functions in filter.h.

Shorten the description for lzma_raw_encoder_memusage() and
lzma_raw_decoder_memusage().

2 years agoliblzma: Reword a few lines in filter.h
Jia Tan [Mon, 6 Feb 2023 13:44:45 +0000 (21:44 +0800)] 
liblzma: Reword a few lines in filter.h

2 years agoliblzma: Improve documentation in filter.h.
Jia Tan [Mon, 6 Feb 2023 13:35:06 +0000 (21:35 +0800)] 
liblzma: Improve documentation in filter.h.

All functions now explicitly specify parameter and return values.
The notes and code annotations were moved before the parameter and
return value descriptions for consistency.

Also, the description above lzma_filter_encoder_is_supported() about
not being able to list available filters was removed since
lzma_str_list_filters() will do this.

2 years agoUpdate THANKS.
Lasse Collin [Thu, 23 Feb 2023 18:46:16 +0000 (20:46 +0200)] 
Update THANKS.

2 years agoliblzma: Avoid null pointer + 0 (undefined behavior in C).
Lasse Collin [Tue, 21 Feb 2023 20:57:10 +0000 (22:57 +0200)] 
liblzma: Avoid null pointer + 0 (undefined behavior in C).

In the C99 and C17 standards, section 6.5.6 paragraph 8 means that
adding 0 to a null pointer is undefined behavior. As of writing,
"clang -fsanitize=undefined" (Clang 15) diagnoses this. However,
I'm not aware of any compiler that would take advantage of this
when optimizing (Clang 15 included). It's good to avoid this anyway
since compilers might some day infer that pointer arithmetic implies
that the pointer is not NULL. That is, the following foo() would then
unconditionally return 0, even for foo(NULL, 0):

    void bar(char *a, char *b);

    int foo(char *a, size_t n)
    {
        bar(a, a + n);
        return a == NULL;
    }

In contrast to C, C++ explicitly allows null pointer + 0. So if
the above is compiled as C++ then there is no undefined behavior
in the foo(NULL, 0) call.

To me it seems that changing the C standard would be the sane
thing to do (just add one sentence) as it would ensure that a huge
amount of old code won't break in the future. Based on web searches
it seems that a large number of codebases (where null pointer + 0
occurs) are being fixed instead to be future-proof in case compilers
will some day optimize based on it (like making the above foo(NULL, 0)
return 0) which in the worst case will cause security bugs.

Some projects don't plan to change it. For example, gnulib and thus
many GNU tools currently require that null pointer + 0 is defined:

    https://lists.gnu.org/archive/html/bug-gnulib/2021-11/msg00000.html

    https://www.gnu.org/software/gnulib/manual/html_node/Other-portability-assumptions.html

In XZ Utils null pointer + 0 issue should be fixed after this
commit. This adds a few if-statements and thus branches to avoid
null pointer + 0. These check for size > 0 instead of ptr != NULL
because this way bugs where size > 0 && ptr == NULL will likely
get caught quickly. None of them are in hot spots so it shouldn't
matter for performance.

A little less readable version would be replacing

    ptr + offset

with

    offset != 0 ? ptr + offset : ptr

or creating a macro for it:

    #define my_ptr_add(ptr, offset) \
            ((offset) != 0 ? ((ptr) + (offset)) : (ptr))

Checking for offset != 0 instead of ptr != NULL allows GCC >= 8.1,
Clang >= 7, and Clang-based ICX to optimize it to the very same code
as ptr + offset. That is, it won't create a branch. So for hot code
this could be a good solution to avoid null pointer + 0. Unfortunately
other compilers like ICC 2021 or MSVC 19.33 (VS2022) will create a
branch from my_ptr_add().

Thanks to Marcin Kowalczyk for reporting the problem:
https://github.com/tukaani-project/xz/issues/36

2 years agoliblzma: Adjust container.h for consistency with filter.h.
Jia Tan [Mon, 6 Feb 2023 16:00:44 +0000 (00:00 +0800)] 
liblzma: Adjust container.h for consistency with filter.h.

2 years agoliblzma: Fix small typos and reword a few things in filter.h.
Jia Tan [Mon, 6 Feb 2023 16:00:09 +0000 (00:00 +0800)] 
liblzma: Fix small typos and reword a few things in filter.h.

2 years agoliblzma: Convert list of flags in lzma_mt to bulleted list.
Jia Tan [Mon, 6 Feb 2023 15:42:08 +0000 (23:42 +0800)] 
liblzma: Convert list of flags in lzma_mt to bulleted list.

2 years agoliblzma: Fix typo in documentation in container.h
Jia Tan [Thu, 26 Jan 2023 15:17:41 +0000 (23:17 +0800)] 
liblzma: Fix typo in documentation in container.h

lzma_microlzma_decoder -> lzma_microlzma_encoder

2 years agoliblzma: Improve documentation for container.h
Jia Tan [Thu, 26 Jan 2023 15:16:34 +0000 (23:16 +0800)] 
liblzma: Improve documentation for container.h

Standardizing each function to always specify parameters and return
values. Also moved the parameters and return values to the end of each
function description.

2 years agoCMake: Add LZIP decoder test to list of tests.
Jia Tan [Wed, 22 Feb 2023 12:59:41 +0000 (20:59 +0800)] 
CMake: Add LZIP decoder test to list of tests.

2 years agoUpdate THANKS.
Lasse Collin [Fri, 17 Feb 2023 18:56:49 +0000 (20:56 +0200)] 
Update THANKS.

2 years agoBuild: Use only the generic symbol versioning on MicroBlaze.
Lasse Collin [Fri, 17 Feb 2023 18:48:28 +0000 (20:48 +0200)] 
Build: Use only the generic symbol versioning on MicroBlaze.

On MicroBlaze, GCC 12 is broken in sense that
__has_attribute(__symver__) returns true but it still doesn't
support the __symver__ attribute even though the platform is ELF
and symbol versioning is supported if using the traditional
__asm__(".symver ...") method. Avoiding the traditional method is
good because it breaks LTO (-flto) builds with GCC.

See also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101766

For now the only extra symbols in liblzma_linux.map are the
compatibility symbols with the patch that spread from RHEL/CentOS 7.
These require the use of __symver__ attribute or __asm__(".symver ...")
in the C code. Compatibility with the patch from CentOS 7 doesn't
seem valuable on MicroBlaze so use liblzma_generic.map on MicroBlaze
instead. It doesn't require anything special in the C code and thus
no LTO issues either.

An alternative would be to detect support for __symver__
attribute in configure.ac and CMakeLists.txt and fall back
to __asm__(".symver ...") but then LTO would be silently broken
on MicroBlaze. It sounds likely that MicroBlaze is a special
case so let's treat it as a such because that is simpler. If
a similar issue exists on some other platform too then hopefully
someone will report it and this can be reconsidered.

(This doesn't do the same fix in CMakeLists.txt. Perhaps it should
but perhaps CMake build of liblzma doesn't matter much on MicroBlaze.
The problem breaks the build so it's easy to notice and can be fixed
later.)

Thanks to Vincent Fazio for reporting the problem and proposing
a patch (in the end that solution wasn't used):
https://github.com/tukaani-project/xz/pull/32

2 years agoliblzma: Very minor API doc tweaks.
Lasse Collin [Thu, 16 Feb 2023 19:09:00 +0000 (21:09 +0200)] 
liblzma: Very minor API doc tweaks.

Use "member" to refer to struct members as that's the term used
by the C standard.

Use lzma_options_delta.dist and such in docs so that in Doxygen's
HTML output they will link to the doc of the struct member.

Clean up a few trailing white spaces too.