]> git.ipfire.org Git - thirdparty/dovecot/core.git/log
thirdparty/dovecot/core.git
5 years agolmtp: lmtp-client - Base client trust on the real remote IP.
Stephan Bosch [Fri, 1 May 2020 22:05:06 +0000 (00:05 +0200)] 
lmtp: lmtp-client - Base client trust on the real remote IP.

LMTP uses real_remote_ip for checking the trust. This means:
 * LMTP proxy checks MTA's IP address
 * LMTP backend checks LMTP proxy's IP address
 * If haproxy is used in front of this LMTP server, the haproxy's IP address is
   checked. This may not be what is always wanted, but in LMTP backend it
   wouldn't be correct to check the original client IP (= MTA IP) either.

5 years agolib-storage: mail-storage-service - Add support for sending forward_fields in userdb...
Stephan Bosch [Sun, 26 Apr 2020 09:02:47 +0000 (11:02 +0200)] 
lib-storage: mail-storage-service - Add support for sending forward_fields in userdb lookup.

5 years agolib-auth: auth-master - Add support for sending forward_fields.
Stephan Bosch [Sun, 26 Apr 2020 08:57:57 +0000 (10:57 +0200)] 
lib-auth: auth-master - Add support for sending forward_fields.

5 years agolib-smtp: smtp-client-connection - Allow smtp_client_connection_connect() to be calle...
Stephan Bosch [Thu, 30 Apr 2020 21:57:41 +0000 (23:57 +0200)] 
lib-smtp: smtp-client-connection - Allow smtp_client_connection_connect() to be called several times.

This change allows calling smtp_client_connection_connect() several times with
different login callbacks. If the connection is already available, the
provided login callback is called almost immediately from the ioloop. This way,
several parallel asynchronous activities using the same connection can wait for
its availability and don't need to check whether it is available already. This
is mostly useful to obtain the capabilities of the server.

5 years agolib-smtp: smtp-client-connection - Record login reply.
Stephan Bosch [Fri, 1 May 2020 11:02:57 +0000 (13:02 +0200)] 
lib-smtp: smtp-client-connection - Record login reply.

5 years agolib-smtp: smtp-params - Add support for xtext-encoding/decoding extra parameters.
Stephan Bosch [Wed, 22 Apr 2020 00:27:05 +0000 (02:27 +0200)] 
lib-smtp: smtp-params - Add support for xtext-encoding/decoding extra parameters.

5 years agolib-smtp: smtp-params - Split off smtp_params_equal() from smtp_params_rcpt_equal().
Stephan Bosch [Wed, 22 Apr 2020 21:24:21 +0000 (23:24 +0200)] 
lib-smtp: smtp-params - Split off smtp_params_equal() from smtp_params_rcpt_equal().

5 years agolib-smtp: smtp-params - Remove code duplication between smtp_params_*_write().
Stephan Bosch [Wed, 22 Apr 2020 21:03:57 +0000 (23:03 +0200)] 
lib-smtp: smtp-params - Remove code duplication between smtp_params_*_write().

5 years agolib-smtp: smtp-params - Remove code duplication between smtp_params_*_copy().
Stephan Bosch [Wed, 22 Apr 2020 20:55:54 +0000 (22:55 +0200)] 
lib-smtp: smtp-params - Remove code duplication between smtp_params_*_copy().

5 years agolib-smtp: smtp-params - Remove code duplication between smtp_params_*_drop_extra().
Stephan Bosch [Wed, 22 Apr 2020 20:32:55 +0000 (22:32 +0200)] 
lib-smtp: smtp-params - Remove code duplication between smtp_params_*_drop_extra().

5 years agolib-smtp: smtp-params - Remove code duplication between smtp_params_*_add_extra().
Stephan Bosch [Wed, 22 Apr 2020 20:26:25 +0000 (22:26 +0200)] 
lib-smtp: smtp-params - Remove code duplication between smtp_params_*_add_extra().

5 years agolib-smtp: smtp-params - Remove code duplication between smtp_params_*_get_extra().
Stephan Bosch [Wed, 22 Apr 2020 20:15:43 +0000 (22:15 +0200)] 
lib-smtp: smtp-params - Remove code duplication between smtp_params_*_get_extra().

5 years agolib-smtp: smtp-syntax - Add smtp_xtext_decode().
Stephan Bosch [Wed, 22 Apr 2020 19:52:14 +0000 (21:52 +0200)] 
lib-smtp: smtp-syntax - Add smtp_xtext_decode().

5 years agolib-smtp: smtp-params - Rename smtp_params_rcpt_equals() to smtp_params_rcpt_equal().
Stephan Bosch [Mon, 27 Apr 2020 09:50:13 +0000 (11:50 +0200)] 
lib-smtp: smtp-params - Rename smtp_params_rcpt_equals() to smtp_params_rcpt_equal().

5 years agolmpt: Reformat lmtp-proxy.c.
Stephan Bosch [Fri, 1 May 2020 15:25:05 +0000 (17:25 +0200)] 
lmpt: Reformat lmtp-proxy.c.

5 years agolmtp: Reformat lmtp-commands.c.
Stephan Bosch [Fri, 1 May 2020 15:24:47 +0000 (17:24 +0200)] 
lmtp: Reformat lmtp-commands.c.

5 years agolmtp: Reformat lmtp-client.c.
Stephan Bosch [Mon, 4 May 2020 20:25:47 +0000 (22:25 +0200)] 
lmtp: Reformat lmtp-client.c.

5 years agolib-smtp: Reformat smtp-client-connection.h.
Stephan Bosch [Sat, 2 May 2020 00:34:34 +0000 (02:34 +0200)] 
lib-smtp: Reformat smtp-client-connection.h.

5 years agolib-smtp: Reformat smtp-client-connection.c.
Stephan Bosch [Fri, 1 May 2020 15:16:01 +0000 (17:16 +0200)] 
lib-smtp: Reformat smtp-client-connection.c.

5 years agolib-storage: mail_search_args_init() - Expand "*" in SEARCH_SEQSET
Timo Sirainen [Tue, 19 May 2020 16:11:34 +0000 (19:11 +0300)] 
lib-storage: mail_search_args_init() - Expand "*" in SEARCH_SEQSET

This is now required by the IMAP MOVE code to correctly handle
"MOVE * folder".

5 years agoimap: imap_search_seqset_iter_next() - Assert-crash if iteration doesn't progress
Timo Sirainen [Tue, 19 May 2020 15:31:31 +0000 (18:31 +0300)] 
imap: imap_search_seqset_iter_next() - Assert-crash if iteration doesn't progress

This can be done easily with seq_range_array_remove_seq_range(). This is
cleaner to use than invert+intersect. I originally didn't notice that
this function existed.

5 years agolib: Add unit test for seq_range_array_remove_range()
Timo Sirainen [Tue, 19 May 2020 16:10:59 +0000 (19:10 +0300)] 
lib: Add unit test for seq_range_array_remove_range()

5 years agolib-storage: mail_search_args_init() - Fix converting UIDSET * to SEQSET on empty...
Timo Sirainen [Mon, 18 May 2020 09:01:44 +0000 (12:01 +0300)] 
lib-storage: mail_search_args_init() - Fix converting UIDSET * to SEQSET on empty mailbox

The "*" caused seq=0 to be added to the seqset. This could have caused
unexpected issues.

Fixes at least UID MOVE on empty mailbox:
Panic: file seq-range-array.c: line 471 (seq_range_array_invert): assertion failed: (range[0].seq1 >= min_seq)

Before 1a5d89d2bfa031903e88af9aff7eafc1b373d521 this assert-crash didn't
happen, but it went to infinite loop.

5 years agolib-imap-client: test-imapc-client - Use the new sub-process test API.
Stephan Bosch [Sat, 11 Apr 2020 17:19:41 +0000 (19:19 +0200)] 
lib-imap-client: test-imapc-client - Use the new sub-process test API.

This makes an effort to terminate server processes gracefully. Killing them
bluntly hampers test coverage measurement and valgrind testing.

5 years agolib-imap-client: test-imapc-client - Add server debug messages.
Stephan Bosch [Sat, 11 Apr 2020 16:54:06 +0000 (18:54 +0200)] 
lib-imap-client: test-imapc-client - Add server debug messages.

5 years agolib-imap-client: test-imapc-client - Split off test_run_server/client() from test_run...
Stephan Bosch [Sat, 11 Apr 2020 11:44:45 +0000 (13:44 +0200)] 
lib-imap-client: test-imapc-client - Split off test_run_server/client() from test_run_client_server().

5 years agolib-imap-client: test-imapc-client - Add log prefixes to distinguish client and serve...
Stephan Bosch [Sat, 11 Apr 2020 10:28:25 +0000 (12:28 +0200)] 
lib-imap-client: test-imapc-client - Add log prefixes to distinguish client and server debug messages.

5 years agolib-imap-client: test-imapc-client - Make sure the child server process is killed.
Stephan Bosch [Sat, 11 Apr 2020 08:02:12 +0000 (10:02 +0200)] 
lib-imap-client: test-imapc-client - Make sure the child server process is killed.

5 years agolib-imap-client: test-imapc-client - Use getopt() for parsing command line arguments.
Stephan Bosch [Sat, 11 Apr 2020 08:05:25 +0000 (10:05 +0200)] 
lib-imap-client: test-imapc-client - Use getopt() for parsing command line arguments.

5 years agolib-imap-client: test-imapc-client - Add structural comments.
Stephan Bosch [Sat, 11 Apr 2020 08:00:32 +0000 (10:00 +0200)] 
lib-imap-client: test-imapc-client - Add structural comments.

5 years agolib-imap-client: test-imapc-client - Move client functions.
Stephan Bosch [Sat, 11 Apr 2020 07:30:29 +0000 (09:30 +0200)] 
lib-imap-client: test-imapc-client - Move client functions.

5 years agolib-imap-client: test-imapc-client - Move server functions.
Stephan Bosch [Mon, 13 Apr 2020 16:49:12 +0000 (18:49 +0200)] 
lib-imap-client: test-imapc-client - Move server functions.

5 years agolib-imap-client: test-imapc-client - Move test_open_server_fd().
Stephan Bosch [Sat, 11 Apr 2020 07:27:30 +0000 (09:27 +0200)] 
lib-imap-client: test-imapc-client - Move test_open_server_fd().

5 years agolib-imap-client: Reformat test-imapc-client.c.
Stephan Bosch [Sat, 11 Apr 2020 11:27:58 +0000 (13:27 +0200)] 
lib-imap-client: Reformat test-imapc-client.c.

5 years agolib-imap-client: Remove unnecessary "Authentication failed: disconnected" errors
Timo Sirainen [Sun, 12 Apr 2020 08:51:31 +0000 (11:51 +0300)] 
lib-imap-client: Remove unnecessary "Authentication failed: disconnected" errors

If connection failed during login, there were always two log lines logged.
The first line is enough.

5 years agolib-imap-client: test-imapc-client - Client now sends LOGOUT and server expects it
Timo Sirainen [Sun, 12 Apr 2020 08:34:14 +0000 (11:34 +0300)] 
lib-imap-client: test-imapc-client - Client now sends LOGOUT and server expects it

5 years agolib-imap-client: test-imapc-client - login_hangs: Client stopped too early
Timo Sirainen [Sun, 12 Apr 2020 08:30:28 +0000 (11:30 +0300)] 
lib-imap-client: test-imapc-client - login_hangs: Client stopped too early

5 years agolib-imap-client: test-imapc-client - login_hangs: Server checked wrong connection...
Timo Sirainen [Sun, 12 Apr 2020 08:29:06 +0000 (11:29 +0300)] 
lib-imap-client: test-imapc-client - login_hangs: Server checked wrong connection's input

5 years agomaster: test-master-login-auth - Use the new sub-process test API.
Stephan Bosch [Fri, 10 Apr 2020 22:47:21 +0000 (00:47 +0200)] 
master: test-master-login-auth - Use the new sub-process test API.

This makes an effort to terminate server processes gracefully. Killing them
bluntly hampers test coverage measurement and valgrind testing.

5 years agomaster: test-master-login-auth - Split off test_run_server/client() from test_run_cli...
Stephan Bosch [Sat, 11 Apr 2020 11:51:49 +0000 (13:51 +0200)] 
master: test-master-login-auth - Split off test_run_server/client() from test_run_client_server().

5 years agomaster: test-master-login-auth - Rename test_server_kill() to test_servers_kill_forced().
Stephan Bosch [Fri, 10 Apr 2020 22:40:19 +0000 (00:40 +0200)] 
master: test-master-login-auth - Rename test_server_kill() to test_servers_kill_forced().

5 years agomaster: test-master-login-auth - Move global initialization to main_init/deinit().
Stephan Bosch [Fri, 10 Apr 2020 22:38:26 +0000 (00:38 +0200)] 
master: test-master-login-auth - Move global initialization to main_init/deinit().

5 years agomaster: test-master-login-auth - Avoid using sleep()/usleep().
Stephan Bosch [Fri, 10 Apr 2020 22:32:25 +0000 (00:32 +0200)] 
master: test-master-login-auth - Avoid using sleep()/usleep().

5 years agomaster: test-master-login-auth - Use lib-signals API.
Stephan Bosch [Mon, 13 Apr 2020 16:41:37 +0000 (18:41 +0200)] 
master: test-master-login-auth - Use lib-signals API.

Using signal() is not portable for installing a signal handler.

5 years agomaster: test-master-login-auth - Ignore SIGPIPE.
Stephan Bosch [Fri, 10 Apr 2020 22:29:42 +0000 (00:29 +0200)] 
master: test-master-login-auth - Ignore SIGPIPE.

5 years agomaster: test-master-login-auth - Don't ignore SIGCHLD.
Stephan Bosch [Mon, 13 Apr 2020 16:33:08 +0000 (18:33 +0200)] 
master: test-master-login-auth - Don't ignore SIGCHLD.

5 years agomaster: test-master-login-auth - Add log prefixes to distinguish client and server...
Stephan Bosch [Fri, 10 Apr 2020 22:26:25 +0000 (00:26 +0200)] 
master: test-master-login-auth - Add log prefixes to distinguish client and server debug messages.

5 years agomaster: test-auth-master - Use the new sub-process test API.
Stephan Bosch [Fri, 10 Apr 2020 22:18:08 +0000 (00:18 +0200)] 
master: test-auth-master - Use the new sub-process test API.

This makes an effort to terminate server processes gracefully. Killing them
bluntly hampers test coverage measurement and valgrind testing.

5 years agomaster: test-auth-master - Split off test_run_server/client() from test_run_client_se...
Stephan Bosch [Fri, 10 Apr 2020 22:11:09 +0000 (00:11 +0200)] 
master: test-auth-master - Split off test_run_server/client() from test_run_client_server().

5 years agomaster: test-auth-master - Rename test_server_kill() to test_servers_kill_forced().
Stephan Bosch [Fri, 10 Apr 2020 22:04:32 +0000 (00:04 +0200)] 
master: test-auth-master - Rename test_server_kill() to test_servers_kill_forced().

5 years agomaster: test-auth-master - Move global initialization to main_init/deinit().
Stephan Bosch [Fri, 10 Apr 2020 22:02:17 +0000 (00:02 +0200)] 
master: test-auth-master - Move global initialization to main_init/deinit().

5 years agomaster: test-auth-master - Avoid using sleep()/usleep().
Stephan Bosch [Fri, 10 Apr 2020 21:56:56 +0000 (23:56 +0200)] 
master: test-auth-master - Avoid using sleep()/usleep().

5 years agomaster: test-auth-master - Use lib-signals API.
Stephan Bosch [Mon, 13 Apr 2020 16:39:56 +0000 (18:39 +0200)] 
master: test-auth-master - Use lib-signals API.

Using signal() is not portable for installing a signal handler.

5 years agomaster: test-auth-master - Ignore SIGPIPE.
Stephan Bosch [Fri, 10 Apr 2020 21:54:29 +0000 (23:54 +0200)] 
master: test-auth-master - Ignore SIGPIPE.

5 years agomaster: test-auth-master - Don't ignore SIGCHLD.
Stephan Bosch [Mon, 13 Apr 2020 16:30:54 +0000 (18:30 +0200)] 
master: test-auth-master - Don't ignore SIGCHLD.

5 years agomaster: test-auth-master - Add log prefixes to distinguish client and server debug...
Stephan Bosch [Fri, 10 Apr 2020 21:52:20 +0000 (23:52 +0200)] 
master: test-auth-master - Add log prefixes to distinguish client and server debug messages.

5 years agomaster: test-auth-client - Use the new sub-process test API.
Stephan Bosch [Fri, 10 Apr 2020 21:43:07 +0000 (23:43 +0200)] 
master: test-auth-client - Use the new sub-process test API.

This makes an effort to terminate server processes gracefully. Killing them
bluntly hampers test coverage measurement and valgrind testing.

5 years agomaster: test-auth-client - Split off test_run_server/client() from test_run_client_se...
Stephan Bosch [Fri, 10 Apr 2020 20:17:05 +0000 (22:17 +0200)] 
master: test-auth-client - Split off test_run_server/client() from test_run_client_server().

5 years agomaster: test-auth-client - Rename test_server_kill() to test_servers_kill_forced().
Stephan Bosch [Fri, 10 Apr 2020 20:07:48 +0000 (22:07 +0200)] 
master: test-auth-client - Rename test_server_kill() to test_servers_kill_forced().

5 years agomaster: test-auth-client - Move global initialization to main_init/deinit().
Stephan Bosch [Fri, 10 Apr 2020 19:59:47 +0000 (21:59 +0200)] 
master: test-auth-client - Move global initialization to main_init/deinit().

5 years agomaster: test-auth-client - Avoid using sleep()/usleep().
Stephan Bosch [Fri, 10 Apr 2020 19:53:06 +0000 (21:53 +0200)] 
master: test-auth-client - Avoid using sleep()/usleep().

5 years agomaster: test-auth-client - Use lib-signals API.
Stephan Bosch [Mon, 13 Apr 2020 16:37:55 +0000 (18:37 +0200)] 
master: test-auth-client - Use lib-signals API.

Using signal() is not portable for installing a signal handler.

5 years agomaster: test-auth-client - Ignore SIGPIPE.
Stephan Bosch [Fri, 10 Apr 2020 19:50:16 +0000 (21:50 +0200)] 
master: test-auth-client - Ignore SIGPIPE.

5 years agomaster: test-auth-client - Don't ignore SIGCHLD.
Stephan Bosch [Mon, 13 Apr 2020 16:28:19 +0000 (18:28 +0200)] 
master: test-auth-client - Don't ignore SIGCHLD.

5 years agomaster: test-auth-client - Add log prefixes to distinguish client and server debug...
Stephan Bosch [Fri, 10 Apr 2020 19:48:11 +0000 (21:48 +0200)] 
master: test-auth-client - Add log prefixes to distinguish client and server debug messages.

5 years agomaster: Reformat test-master-login-auth.c.
Stephan Bosch [Sat, 11 Apr 2020 10:58:10 +0000 (12:58 +0200)] 
master: Reformat test-master-login-auth.c.

5 years agomaster: Reformat test-auth-master.c.
Stephan Bosch [Sat, 11 Apr 2020 10:53:40 +0000 (12:53 +0200)] 
master: Reformat test-auth-master.c.

5 years agomaster: Reformat test-auth-client.c.
Stephan Bosch [Sat, 11 Apr 2020 10:42:58 +0000 (12:42 +0200)] 
master: Reformat test-auth-client.c.

5 years agolib-smtp: test-smtp-submit - Use the new sub-process test API.
Stephan Bosch [Thu, 14 May 2020 14:05:00 +0000 (16:05 +0200)] 
lib-smtp: test-smtp-submit - Use the new sub-process test API.

This makes an effort to terminate server processes gracefully. Killing them
bluntly hampers test coverage measurement and valgrind testing.

5 years agolib-smtp: test-smtp-submit - Split off test_run_server/client() from test_run_client_...
Stephan Bosch [Thu, 9 Apr 2020 14:47:45 +0000 (16:47 +0200)] 
lib-smtp: test-smtp-submit - Split off test_run_server/client() from test_run_client_server().

5 years agolib-smtp: test-smtp-submit - Rename test_servers_kill_all() to test_servers_kill_forc...
Stephan Bosch [Thu, 9 Apr 2020 09:05:10 +0000 (11:05 +0200)] 
lib-smtp: test-smtp-submit - Rename test_servers_kill_all() to test_servers_kill_forced().

5 years agolib-smtp: test-smtp-submit - Move global initialization to main_init/deinit().
Stephan Bosch [Thu, 9 Apr 2020 08:53:40 +0000 (10:53 +0200)] 
lib-smtp: test-smtp-submit - Move global initialization to main_init/deinit().

5 years agolib-smtp: test-smtp-submit - Avoid using sleep().
Stephan Bosch [Thu, 9 Apr 2020 08:56:07 +0000 (10:56 +0200)] 
lib-smtp: test-smtp-submit - Avoid using sleep().

5 years agolib-smtp: test-smtp-submit - Use lib-signals API.
Stephan Bosch [Mon, 13 Apr 2020 15:52:09 +0000 (17:52 +0200)] 
lib-smtp: test-smtp-submit - Use lib-signals API.

Using signal() is not portable for installing a signal handler.

5 years agolib-smtp: test-smtp-submit - Ignore SIGPIPE.
Stephan Bosch [Thu, 9 Apr 2020 08:40:23 +0000 (10:40 +0200)] 
lib-smtp: test-smtp-submit - Ignore SIGPIPE.

5 years agolib-smtp: test-smtp-submit - Don't ignore SIGCHLD.
Stephan Bosch [Mon, 13 Apr 2020 15:45:55 +0000 (17:45 +0200)] 
lib-smtp: test-smtp-submit - Don't ignore SIGCHLD.

5 years agolib-smtp: test-smtp-submit - Add log prefixes to distinguish client and server debug...
Stephan Bosch [Thu, 9 Apr 2020 08:37:28 +0000 (10:37 +0200)] 
lib-smtp: test-smtp-submit - Add log prefixes to distinguish client and server debug messages.

5 years agolib-smtp: test-smtp-server-errors - Use the new sub-process test API.
Stephan Bosch [Wed, 8 Apr 2020 22:57:15 +0000 (00:57 +0200)] 
lib-smtp: test-smtp-server-errors - Use the new sub-process test API.

This makes an effort to terminate client processes gracefully. Killing them
bluntly hampers test coverage measurement and valgrind testing.

5 years agolib-smtp: test-smtp-server-errors - Split off test_run_client/server() from test_run_...
Stephan Bosch [Wed, 8 Apr 2020 22:30:11 +0000 (00:30 +0200)] 
lib-smtp: test-smtp-server-errors - Split off test_run_client/server() from test_run_client_server().

5 years agolib-smtp: test-smtp-server-errors - Rename test_clients_kill_all() to test_clients_ki...
Stephan Bosch [Wed, 8 Apr 2020 22:23:46 +0000 (00:23 +0200)] 
lib-smtp: test-smtp-server-errors - Rename test_clients_kill_all() to test_clients_kill_forced().

5 years agolib-smtp: test-smtp-server-errors - Move global initialization to main_init/deinit().
Stephan Bosch [Thu, 9 Apr 2020 08:50:03 +0000 (10:50 +0200)] 
lib-smtp: test-smtp-server-errors - Move global initialization to main_init/deinit().

5 years agolib-smtp: test-smtp-server-errors - Fix name of client_connection_deinit().
Stephan Bosch [Wed, 8 Apr 2020 22:18:32 +0000 (00:18 +0200)] 
lib-smtp: test-smtp-server-errors - Fix name of client_connection_deinit().

5 years agolib-smtp: test-smtp-server-errors - Use lib-signals API.
Stephan Bosch [Mon, 13 Apr 2020 13:40:23 +0000 (15:40 +0200)] 
lib-smtp: test-smtp-server-errors - Use lib-signals API.

Using signal() is not portable for installing a signal handler.

5 years agolib-smtp: test-smtp-server-errors - Ignore SIGPIPE.
Stephan Bosch [Wed, 8 Apr 2020 22:16:54 +0000 (00:16 +0200)] 
lib-smtp: test-smtp-server-errors - Ignore SIGPIPE.

5 years agolib-smtp: test-smtp-server-errors - Remove useless child signal handler.
Stephan Bosch [Mon, 13 Apr 2020 13:15:34 +0000 (15:15 +0200)] 
lib-smtp: test-smtp-server-errors - Remove useless child signal handler.

Restructure code to better match equivalent unit tests.

5 years agolib-smtp: test-smtp-server-errors - Adjust log prefix code to match other similar...
Stephan Bosch [Wed, 8 Apr 2020 22:15:24 +0000 (00:15 +0200)] 
lib-smtp: test-smtp-server-errors - Adjust log prefix code to match other similar unit tests.

5 years agolib-smtp: test-smtp-client-errors - Use the new sub-process test API.
Stephan Bosch [Wed, 8 Apr 2020 21:49:31 +0000 (23:49 +0200)] 
lib-smtp: test-smtp-client-errors - Use the new sub-process test API.

This makes an effort to terminate server processes gracefully. Killing them
bluntly hampers test coverage measurement and valgrind testing.

5 years agolib-smtp: test-smtp-client-errors - Split off test_run_server/dns/client() from test_...
Stephan Bosch [Wed, 8 Apr 2020 20:37:59 +0000 (22:37 +0200)] 
lib-smtp: test-smtp-client-errors - Split off test_run_server/dns/client() from test_run_client_server().

5 years agolib-smtp: test-smtp-client-errors - Rename test_servers_kill_all() to test_servers_ki...
Stephan Bosch [Wed, 8 Apr 2020 20:27:46 +0000 (22:27 +0200)] 
lib-smtp: test-smtp-client-errors - Rename test_servers_kill_all() to test_servers_kill_forced().

5 years agolib-smtp: test-smtp-client-errors - Move global initialization to main_init/deinit().
Stephan Bosch [Wed, 8 Apr 2020 20:24:47 +0000 (22:24 +0200)] 
lib-smtp: test-smtp-client-errors - Move global initialization to main_init/deinit().

5 years agolib-smtp: test-smtp-client-errors - Avoid using sleep().
Stephan Bosch [Wed, 8 Apr 2020 19:10:08 +0000 (21:10 +0200)] 
lib-smtp: test-smtp-client-errors - Avoid using sleep().

5 years agolib-smtp: test-smtp-client-errors - Use lib-signals API.
Stephan Bosch [Mon, 13 Apr 2020 12:18:05 +0000 (14:18 +0200)] 
lib-smtp: test-smtp-client-errors - Use lib-signals API.

Using signal() is not portable for installing a signal handler.

5 years agolib-smtp: test-smtp-client-errors - Generally ignore SIGPIPE.
Stephan Bosch [Wed, 8 Apr 2020 19:04:32 +0000 (21:04 +0200)] 
lib-smtp: test-smtp-client-errors - Generally ignore SIGPIPE.

Remove per-process code that achieves the same.

5 years agolib-smtp: test-smtp-client-errors - Don't ignore SIGCHLD.
Stephan Bosch [Mon, 13 Apr 2020 12:12:25 +0000 (14:12 +0200)] 
lib-smtp: test-smtp-client-errors - Don't ignore SIGCHLD.

5 years agolib-smtp: test-smtp-client-errors - Turn server-side payload read error into a debug...
Stephan Bosch [Mon, 13 Apr 2020 12:44:31 +0000 (14:44 +0200)] 
lib-smtp: test-smtp-client-errors - Turn server-side payload read error into a debug message.

This can readily occur during tests and must not issue a real error message.

5 years agolib-smtp: test-smtp-client-errors - Add log prefixes to distinguish client and server...
Stephan Bosch [Wed, 8 Apr 2020 19:02:18 +0000 (21:02 +0200)] 
lib-smtp: test-smtp-client-errors - Add log prefixes to distinguish client and server debug messages.

5 years agolib-smtp: test-smtp-payload - Use the new sub-process test API.
Stephan Bosch [Sun, 5 Apr 2020 00:40:33 +0000 (02:40 +0200)] 
lib-smtp: test-smtp-payload - Use the new sub-process test API.

This makes an effort to terminate server processes gracefully. Killing them
bluntly hampers test coverage measurement and valgrind testing.

5 years agolib-smtp: test-smtp-payload - Split off test_run_client/server() from test_run_client...
Stephan Bosch [Tue, 7 Apr 2020 22:04:05 +0000 (00:04 +0200)] 
lib-smtp: test-smtp-payload - Split off test_run_client/server() from test_run_client_server().

5 years agolib-smtp: test-smtp-payload - Adjust log prefix code to match other similar unit...
Stephan Bosch [Tue, 7 Apr 2020 21:48:44 +0000 (23:48 +0200)] 
lib-smtp: test-smtp-payload - Adjust log prefix code to match other similar unit tests.

5 years agolib-smtp: test-smtp-payload - Rename test_server_kill() to test_server_kill_forced().
Stephan Bosch [Sun, 5 Apr 2020 00:34:29 +0000 (02:34 +0200)] 
lib-smtp: test-smtp-payload - Rename test_server_kill() to test_server_kill_forced().