]> git.ipfire.org Git - thirdparty/hostap.git/log
thirdparty/hostap.git
7 years agoDefine a QCA vendor command to retrieve SAR Power limits
Jeff Johnson [Tue, 7 Nov 2017 19:15:50 +0000 (11:15 -0800)] 
Define a QCA vendor command to retrieve SAR Power limits

Previously commit c79238b6a460ab6bc6ebc5e2453fd94716393105 ('Define a
QCA vendor command to configure SAR Power limits') implemented a vendor
command interface to allow a userspace entity to dynamically control the
SAR power limits. Now implement a command to retrieve the current SAR
power limits.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoFILS: Driver configuration to disable/enable FILS features
vamsi krishna [Thu, 14 Dec 2017 09:44:51 +0000 (15:14 +0530)] 
FILS: Driver configuration to disable/enable FILS features

The new disable_fils parameter can be used to disable FILS functionality
in the driver. This is currently removing the FILS Capability bit in
Extended Capabilities and providing a callback to the driver wrappers.
driver_nl80211.c implements this using a QCA vendor specific command for
now.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: DPP P-521 test vector (mutual auth)
Jouni Malinen [Wed, 13 Dec 2017 14:25:13 +0000 (16:25 +0200)] 
tests: DPP P-521 test vector (mutual auth)

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: chan_util_avg_period
Jouni Malinen [Mon, 11 Dec 2017 21:46:00 +0000 (23:46 +0200)] 
tests: chan_util_avg_period

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agohostapd: Add average channel utilization in STATUS
Bhagavathi Perumal S [Mon, 4 Dec 2017 09:23:33 +0000 (14:53 +0530)] 
hostapd: Add average channel utilization in STATUS

This allows external programs to get the average channel utilization.
The average channel utilization is calculated and reported through
STATUS command. Users need to configure chan_util_avg_period and
bss_load_update_period in hostapd config to get the average channel
utilization.

Signed-off-by: Bhagavathi Perumal S <bperumal@qti.qualcomm.com>
7 years agohostapd: Update BSS load update period dynamically
Bhagavathi Perumal S [Mon, 4 Dec 2017 09:22:20 +0000 (14:52 +0530)] 
hostapd: Update BSS load update period dynamically

Recalculate the timeout value for each event instead of calculating this
once and then not allowing the timeout configuration to be changed
without fully stopping and restarting the interface.

This allows the bss_load_update_period configuration parameter to be
modified while a BSS continues operating.

Signed-off-by: Bhagavathi Perumal S <bperumal@qti.qualcomm.com>
7 years agoFix error handling in bss_load_update_period parser
Jouni Malinen [Mon, 11 Dec 2017 22:42:40 +0000 (00:42 +0200)] 
Fix error handling in bss_load_update_period parser

Do not update the configuration parameter before having verified the
value to be in the valid range.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agohostapd_cli: Add dpp_listen and dpp_stop_listen
Jouni Malinen [Mon, 11 Dec 2017 17:55:57 +0000 (19:55 +0200)] 
hostapd_cli: Add dpp_listen and dpp_stop_listen

Now that hostapd exposes the DPP_LISTEN and DPP_STOP_LISTEN commands
similarly to wpa_supplicant, expose these through proper hostapd_cli
commands as well to match wpa_cli functionality.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: OWE and unsupported group using cfg80211 connect command
Jouni Malinen [Mon, 11 Dec 2017 12:01:45 +0000 (14:01 +0200)] 
tests: OWE and unsupported group using cfg80211 connect command

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoOWE: Allow DH Parameters element overriding with driver SME
Jouni Malinen [Mon, 11 Dec 2017 11:59:55 +0000 (13:59 +0200)] 
OWE: Allow DH Parameters element overriding with driver SME

Commit 265bda34441da14249cb22ce8a459cebe8015a55 ('OWE: Allow DH
Parameters element to be overridden for testing purposes') provided
means for using "VENDOR_ELEM_ADD 13 <IE>" in OWE protocol testing, but
that commit covered only the sme.c case (i.e., drivers that use
wpa_supplicant SME). Extend this to cover drivers that use internal SME
(e.g., use the nl80211 Connect command).

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoOWE: Fix error case handling with drivers that implement AP SME
Jouni Malinen [Mon, 11 Dec 2017 11:36:48 +0000 (13:36 +0200)] 
OWE: Fix error case handling with drivers that implement AP SME

owe_auth_req_process() can return NULL in error cases, but the caller
was not prepared for this. The p pointer cannot be overridden in such
cases since that would result in buffer length (p - buf) overflows. Fix
this by using a temporary variable to check the return value before
overriding p so that the hostapd_sta_assoc() ends up using correct
length for the IE buffer.

Fixes: 33c8bbd8ca7a ("OWE: Add AP mode handling of OWE with drivers that implement SME")
Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoOpenSSL: Replace EVP_PKEY_paramgen() with EC_KEY_new_by_curve_name()
Jouni Malinen [Sun, 10 Dec 2017 21:49:39 +0000 (23:49 +0200)] 
OpenSSL: Replace EVP_PKEY_paramgen() with EC_KEY_new_by_curve_name()

The BoringSSL version of crypto_ecdh_init() and dpp_gen_keypair() works
fine with OpenSSL as well, so use that same implementation for both to
avoid unnecessary maintanence of multiple versions.

Signed-off-by: Jouni Malinen <j@w1.fi>
7 years agoBoringSSL: Use EC_KEY_new_by_curve_name() to simplify implementation
Jouni Malinen [Sun, 10 Dec 2017 21:41:29 +0000 (23:41 +0200)] 
BoringSSL: Use EC_KEY_new_by_curve_name() to simplify implementation

There is no need to go through EC_GROUP_new_by_curve_name(),
EC_KEY_new(), and EC_KEY_set_group() when a single call to
EC_KEY_new_by_curve_name() takes care of all that.

Signed-off-by: Jouni Malinen <j@w1.fi>
7 years agoRevert "BoringSSL: Add DPP special cases regardless of claimed version number"
Jouni Malinen [Sun, 10 Dec 2017 21:24:31 +0000 (23:24 +0200)] 
Revert "BoringSSL: Add DPP special cases regardless of claimed version number"

This reverts commit 5548453a2d0061cf5d65180dca5d0141e15e14bb since
BoringSSL added ECDSA_SIG_set0() and ECDSA_SIG_get0() in commit
8dc226ca8f1ef60737e1c1bf8cfcabf51d4068c7 ('Add some missing OpenSSL
1.1.0 accessors.') and updated X509_ALGOR_get0() prototype to match
OpenSSL 1.1.0 changes in commit e3b2a5d30d309091cab3e6a19dee7323c40d968d
('Const-correct X509_ALGOR_get0.').

Signed-off-by: Jouni Malinen <j@w1.fi>
7 years agoRevert "BoringSSL: Define RSA_bits() helper"
Jouni Malinen [Sun, 10 Dec 2017 21:22:05 +0000 (23:22 +0200)] 
Revert "BoringSSL: Define RSA_bits() helper"

This reverts commit 3cfbd3b0f63fb299f1187f16db6fcec9421e3df4 since
BoringSSL added RSA_bits() in commit
8dc226ca8f1ef60737e1c1bf8cfcabf51d4068c7 ('Add some missing OpenSSL
1.1.0 accessors.').

Signed-off-by: Jouni Malinen <j@w1.fi>
7 years agotests: Suite B 192-bit with RSA and RADIUS
Jouni Malinen [Sun, 10 Dec 2017 19:18:06 +0000 (21:18 +0200)] 
tests: Suite B 192-bit with RSA and RADIUS

This tests use of RSA >3K keys and forcing ECDHE on both the server and
client side.

Signed-off-by: Jouni Malinen <j@w1.fi>
7 years agoOpenSSL: Allow cipher list to be overridden for tls_suiteb=1 case
Jouni Malinen [Sun, 10 Dec 2017 19:16:26 +0000 (21:16 +0200)] 
OpenSSL: Allow cipher list to be overridden for tls_suiteb=1 case

This allows wpa_supplicant configuration with phase1="tls_suiteb=1" to
use openssl_ciphers="ECDHE-RSA-AES256-GCM-SHA384" to further limit the
possible TLS cipher suites when using Suite B with RSA >3K keys. This
combination disables use of DHE and as such, mandates ECDHE to be used.

Signed-off-by: Jouni Malinen <j@w1.fi>
7 years agoFix wnm-fuzzer build
Jouni Malinen [Sat, 9 Dec 2017 16:45:34 +0000 (18:45 +0200)] 
Fix wnm-fuzzer build

Need to include couple more wpa_supplicant source code files into the
build.

Signed-off-by: Jouni Malinen <j@w1.fi>
7 years agoFix ap-mgmt-fuzzer build
Jouni Malinen [Sat, 9 Dec 2017 16:41:55 +0000 (18:41 +0200)] 
Fix ap-mgmt-fuzzer build

Add src/ap/eth_p_oui.o into libap.a to be able to link ap-mgmt-fuzzer.

Signed-off-by: Jouni Malinen <j@w1.fi>
7 years agoeapol-fuzzer: Resolve circular library references with --start-group
Jouni Malinen [Sat, 9 Dec 2017 16:36:48 +0000 (18:36 +0200)] 
eapol-fuzzer: Resolve circular library references with --start-group

src/crypto/libcrypto.a and src/tls/libtls.a have circular references
and will need special handling with the linker at least for the time
being. This could be cleaned up eventually, but for now, provide a
mechanism to get the program linked.

This was already done in tests/Makefile, but tests/eapol-fuzzer/Makefile
needs the same.

Signed-off-by: Jouni Malinen <j@w1.fi>
7 years agoOpenSSL: Avoid SSL*_use_default_passwd_cb()
David Benjamin [Mon, 18 Sep 2017 15:47:47 +0000 (11:47 -0400)] 
OpenSSL: Avoid SSL*_use_default_passwd_cb()

These functions are a bit awkward to use for one-off file loads, as
suggested by the tls_clear_default_passwd_cb() logic. There was also
some historical mess with OpenSSL versions and either not having per-SSL
settings, having per-SSL settings but ignoring them, and requiring the
per-SSL settings.

Instead, loading the key with the lower-level functions seems a bit
tidier and also allows abstracting away trying both formats, one after
another.

Signed-off-by: David Benjamin <davidben@google.com>
7 years agoOpenSSL: Remove unnecessary os_strdup() from password callback
David Benjamin [Mon, 18 Sep 2017 04:33:43 +0000 (00:33 -0400)] 
OpenSSL: Remove unnecessary os_strdup() from password callback

There's no need to make an extra copy of private_key_passwd for
SSL_{CTX_,}set_default_passwd_cb().

Signed-off-by: David Benjamin <davidben@google.com>
7 years agoAndroid: Set CONFIG_NO_RANDOM_POOL=y
Jeff Vander Stoep [Thu, 30 Nov 2017 22:46:26 +0000 (14:46 -0800)] 
Android: Set CONFIG_NO_RANDOM_POOL=y

Wpa_supplicant's random pool is not necessary on Android. Randomness
is already provided by the entropymixer service which ensures
sufficient entropy is maintained across reboots. Commit b410eb1913
'Initialize /dev/urandom earlier in boot' seeds /dev/urandom with
that entropy before either wpa_supplicant or hostapd are run.

Signed-off-by: Jeff Vander Stoep <jeffv@google.com>
7 years agoAndroid: Move hostapd to vendor partition
Po-Chien Hsueh [Thu, 30 Nov 2017 22:45:51 +0000 (14:45 -0800)] 
Android: Move hostapd to vendor partition

Move hostapd to /vendor/bin/ because it's only used by WIFI HAL.

Signed-off-by: Jeff Vander Stoep <jeffv@google.com>
7 years agowlantest: Try harder to find a STA entry with PTK for 4-address frames
Jouni Malinen [Fri, 8 Dec 2017 19:51:47 +0000 (21:51 +0200)] 
wlantest: Try harder to find a STA entry with PTK for 4-address frames

Commit aab66128369c5953e70f867e997a54146bcca88b ('wlantest: Search
bss/sta entry more thoroughly for 4-address frames') allowed wlantest to
find a STA entry in this type of cases, but it was still possible for
that STA entry to be the one that has no derived PTK while the STA entry
for the other side of the link might have the derived PTK available.

Extend this BSS/STA selection mechanism to use sta->ptk_set to determine
which STA entry is more useful for decryption, i.e., select the one with
a known PTK.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoAdd new QCA vendor attribute for WLAN Latency Module (WLM)
Paul Zhang [Thu, 30 Nov 2017 13:40:30 +0000 (21:40 +0800)] 
Add new QCA vendor attribute for WLAN Latency Module (WLM)

A new vendor attribute QCA_WLAN_VENDOR_ATTR_CONFIG_LATENCY_LEVEL is added
for vendor sub-command QCA_NL80211_VENDOR_SUBCMD_SET_WIFI_CONFIGURATION.
This attribute is for setting the level of WLM.

Signed-off-by: Paul Zhang <paulz@qti.qualcomm.com>
7 years agotests: DPP P-256 test vectors
Jouni Malinen [Thu, 7 Dec 2017 11:35:19 +0000 (13:35 +0200)] 
tests: DPP P-256 test vectors

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Allow protocol key to be overridden for testing purposes
Jouni Malinen [Tue, 5 Dec 2017 21:49:55 +0000 (23:49 +0200)] 
DPP: Allow protocol key to be overridden for testing purposes

This can be used for various testing needs.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: sigma_dut and DPPAuthDirection,Mutual on Initiator
Jouni Malinen [Tue, 5 Dec 2017 19:13:30 +0000 (21:13 +0200)] 
tests: sigma_dut and DPPAuthDirection,Mutual on Initiator

Do not include this argument in normal case, but add a test case to
cover the special extra check case.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: sigma_dut DPP protocol testing - Stop at RX
Jouni Malinen [Tue, 5 Dec 2017 18:22:07 +0000 (20:22 +0200)] 
tests: sigma_dut DPP protocol testing - Stop at RX

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: WPS with other AES-based ciphers
Jouni Malinen [Fri, 1 Dec 2017 23:43:58 +0000 (01:43 +0200)] 
tests: WPS with other AES-based ciphers

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoWPS: Add GCMP-256 and CCMP-256 cipher options on Enrollee
Jouni Malinen [Fri, 1 Dec 2017 23:42:50 +0000 (01:42 +0200)] 
WPS: Add GCMP-256 and CCMP-256 cipher options on Enrollee

If a credential with encp type AES is received, add GCMP-256 and
CCMP-256 cipher options on station Enrollee based on local capabilities.
This is needed to allow connection with an AP using either of these
newer ciphers.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: Make ap_wps_ap_scan_2 work with multiple AES-ciphers
Jouni Malinen [Sat, 2 Dec 2017 10:12:27 +0000 (12:12 +0200)] 
tests: Make ap_wps_ap_scan_2 work with multiple AES-ciphers

This test case is not really realistic and the second connection attempt
would fail if additional AES-based ciphers get provisioned. Work this
around by dropping to CCMP only if other ciphers are present.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: Allow more ciphers in ap_wps_mixed_cred
Jouni Malinen [Sat, 2 Dec 2017 10:03:53 +0000 (12:03 +0200)] 
tests: Allow more ciphers in ap_wps_mixed_cred

This is needed to avoid false errors with GCMP-256 and CCMP-256 to be
added in the implementation.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoWPS: Check BSS table against current BSSID if credential does not match
Jouni Malinen [Fri, 1 Dec 2017 23:37:41 +0000 (01:37 +0200)] 
WPS: Check BSS table against current BSSID if credential does not match

The credential MAC address is not necessarily that of the AP, i.e., it
is more likely to be that of the Enrollee. Check the scan results
against the current BSSID as well if match is not found otherwise when
going through the mixed mode workaround.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoWPS: Map GCMP-256 and CCMP-256 to AES encryption type
Jouni Malinen [Fri, 1 Dec 2017 23:36:43 +0000 (01:36 +0200)] 
WPS: Map GCMP-256 and CCMP-256 to AES encryption type

This is needed to allow a credential to be built for GCMP-256/CCMP-256
networks that do not enable GCMP-128/CCMP-128.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoWPS: Allow WPS to be enabled in CCMP-256 and GCMP-256 only cases
Shiva Sankar Gajula [Fri, 1 Dec 2017 23:22:55 +0000 (01:22 +0200)] 
WPS: Allow WPS to be enabled in CCMP-256 and GCMP-256 only cases

Extend the check against WPA/TKIP only configuration by adding CCMP-256
and GCMP-256 to the list of allowed ciphers. This is needed to allow WPS
to be enabled in AP configurations where neither CCMP-128 nor GCMP-128
are enabled.

Signed-off-by: Shiva Sankar Gajula <sgajula@qti.qualcomm.com>
7 years agotests: DPP testing to check for mutual authentication on Initiator
Jouni Malinen [Fri, 1 Dec 2017 23:17:37 +0000 (01:17 +0200)] 
tests: DPP testing to check for mutual authentication on Initiator

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Indicate to upper layers whether mutual authentication was used
Jouni Malinen [Fri, 1 Dec 2017 23:16:17 +0000 (01:16 +0200)] 
DPP: Indicate to upper layers whether mutual authentication was used

DPP Responder selects whether mutual authentication is used. This commit
adds information about that selection to upper layers (ctrl_iface event
DPP-AUTH-DIRECTION mutual=<0/1>) on the Initiator side.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: DPP exchange stopping unexpectedly
Jouni Malinen [Fri, 1 Dec 2017 23:05:50 +0000 (01:05 +0200)] 
tests: DPP exchange stopping unexpectedly

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Extend protocol testing to allow exchange termination
Jouni Malinen [Fri, 1 Dec 2017 23:04:42 +0000 (01:04 +0200)] 
DPP: Extend protocol testing to allow exchange termination

This extends dpp_test functionality to allow DPP exchanges to be stopped
when receiving a specified message.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Change Authentication Response retry time to 1 second
Jouni Malinen [Fri, 1 Dec 2017 22:38:12 +0000 (00:38 +0200)] 
DPP: Change Authentication Response retry time to 1 second

The previously used 10 second timer did not really make much sense since
the Initiator is not going to be waiting for the response that long.
Change this to 1 second based on the DPP tech spec change.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: nl80211.py: Fix attribute padding
Johannes Berg [Fri, 1 Dec 2017 20:37:40 +0000 (21:37 +0100)] 
tests: nl80211.py: Fix attribute padding

The kernel started enforcing attribute lengths, and nl80211.py had been
doing it all wrong - the padding must be present, but not part of the
length.

Fix it to do it the right way.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
7 years agonl80211: Fix NL80211_MESHCONF_AUTO_OPEN_PLINKS encoding
Jouni Malinen [Fri, 1 Dec 2017 20:21:24 +0000 (22:21 +0200)] 
nl80211: Fix NL80211_MESHCONF_AUTO_OPEN_PLINKS encoding

This nl80211 attribute uses NLA_U8 policy in cfg80211 and wpa_supplicant
needs to use same size when writing the attribute.

This fixes mesh mode regression triggered by kernel commit "net:
netlink: Update attr validation to require exact length for some types"
in v4.15-rc1 that resulted in the following debug log entry when trying
to join a mesh:
nl80211: mesh join failed: ret=-22 (Invalid argument)

Fixes: 6c1664f6051f ("nl80211: Add new commands to support mesh interfaces")
Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agonl80211: Fix NL80211_ATTR_SMPS_MODE encoding
Jouni Malinen [Fri, 1 Dec 2017 18:22:44 +0000 (20:22 +0200)] 
nl80211: Fix NL80211_ATTR_SMPS_MODE encoding

This nl80211 attribute uses NLA_U8 policy in cfg80211 and
hostapd/wpa_supplicant needs to use same size when writing the
attribute.

This fixes AP mode regression triggered by kernel commit "net: netlink:
Update attr validation to require exact length for some types" in
v4.15-rc1 that resulted in the following debug log entry when trying to
enable beaconing:
nl80211: Beacon set failed: -34 (Numerical result out of range)

Fixes: da1080d7215f ("nl80211: Advertise and configure SMPS modes")
Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: sigma_dut and WPS PBC Enrollee
Jouni Malinen [Thu, 30 Nov 2017 21:06:33 +0000 (23:06 +0200)] 
tests: sigma_dut and WPS PBC Enrollee

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: sigma_dut controlled connection using preconfigured profile
Jouni Malinen [Thu, 30 Nov 2017 20:54:34 +0000 (22:54 +0200)] 
tests: sigma_dut controlled connection using preconfigured profile

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: DPP protocol testing - invalid E-nonce in Conf Req
Jouni Malinen [Thu, 30 Nov 2017 20:03:07 +0000 (22:03 +0200)] 
tests: DPP protocol testing - invalid E-nonce in Conf Req

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Extend dpp_test with invalid E-Nonce in Config Req
Jouni Malinen [Thu, 30 Nov 2017 20:01:10 +0000 (22:01 +0200)] 
DPP: Extend dpp_test with invalid E-Nonce in Config Req

Allow an E-Nonce attribute with invalid length to be sent for protocol
testing purposes.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: DPP protocol testing - invalid Transaction ID in Peer Disc Req
Jouni Malinen [Thu, 30 Nov 2017 19:56:55 +0000 (21:56 +0200)] 
tests: DPP protocol testing - invalid Transaction ID in Peer Disc Req

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Extend dpp_test with invalid Transaction ID in Peer Disc Req
Jouni Malinen [Thu, 30 Nov 2017 19:56:19 +0000 (21:56 +0200)] 
DPP: Extend dpp_test with invalid Transaction ID in Peer Disc Req

Allow a Transaction ID attribute with invalid length to be sent for
protocol testing purposes.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoAdd QCA vendor command and attributes for RROP
Krishna Rao [Fri, 24 Nov 2017 09:26:16 +0000 (14:56 +0530)] 
Add QCA vendor command and attributes for RROP

Add QCA vendor command and attributes for vendor specific Representative
RF Operating Parameter (RROP) information. This information is intended
for optional use by external ACS. It provides guidance values for some
RF parameters that are used by the system during operation, so that
external ACS can utilize these to compare between channels, bands, etc.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: Make dpp_auth_req_retries* more reliable
Jouni Malinen [Thu, 30 Nov 2017 10:56:24 +0000 (12:56 +0200)] 
tests: Make dpp_auth_req_retries* more reliable

These test cases were failing when run immediately after
dpp_pkex_test_fail. It looks like timing of the TX status and the short
eloop wait were getting reordered in this cases. This ended up with some
of the DPP-TX-STATUS event messages missing. Instead of explicitly
checking for those message, simply count the number of DPP-TX messages
to verify that the correct number of retries are being sent.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agonl80211: Use consistent "0x" prefix for the cookie values
Jouni Malinen [Thu, 30 Nov 2017 10:42:58 +0000 (12:42 +0200)] 
nl80211: Use consistent "0x" prefix for the cookie values

One of the event message for TX status was missing 'x' from the "0x"
prefix. Add that to make the used format consistent for all cookie debug
print cases.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Call wpas_dpp_stop() from wpas_dpp_deinit()
Jouni Malinen [Wed, 29 Nov 2017 22:11:22 +0000 (00:11 +0200)] 
DPP: Call wpas_dpp_stop() from wpas_dpp_deinit()

This makes the full DPP deinit operation more consistent with stopping
of a single operation. In practice, this adds the new GAS client
stopping functionality.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: DPP/PKEX and local failures
Jouni Malinen [Wed, 29 Nov 2017 11:45:39 +0000 (13:45 +0200)] 
tests: DPP/PKEX and local failures

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Stop pending GAS client operation on DPP_STOP_LISTEN
Jouni Malinen [Wed, 29 Nov 2017 22:07:50 +0000 (00:07 +0200)] 
DPP: Stop pending GAS client operation on DPP_STOP_LISTEN

This makes the operation more complete in stopping all ongoing DPP
related functionality.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Do not continue if public key hash derivation fails
Jouni Malinen [Wed, 29 Nov 2017 19:40:31 +0000 (21:40 +0200)] 
DPP: Do not continue if public key hash derivation fails

sha256_vector() result was ignored apart from printing out the failure
in the debug log. This is not really a normal case and it is better to
reject the full operation rather than try to continue with an incorrect
public key hash value.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Fix memory leak on dpp_auth_build_conf() error paths
Jouni Malinen [Wed, 29 Nov 2017 19:20:45 +0000 (21:20 +0200)] 
DPP: Fix memory leak on dpp_auth_build_conf() error paths

The wpabuf for the message needs to be freed on the error paths.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoJSON: Fix a memory leak on an error path
Jouni Malinen [Wed, 29 Nov 2017 11:22:44 +0000 (13:22 +0200)] 
JSON: Fix a memory leak on an error path

If the second json_alloc_token() call failed to allocate memory,
json_parse() missed the first allocation on the error path. Assign the
root pointer earlier for that case to avoid the potential memory leak.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Fix a memory leak on an error path
Jouni Malinen [Wed, 29 Nov 2017 11:03:48 +0000 (13:03 +0200)] 
DPP: Fix a memory leak on an error path

Need to free temporary allocations if dpp_build_conf_start() fails to
allocate memory.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Deinit PKEX instance on DPP_STOP_LISTEN
Jouni Malinen [Wed, 29 Nov 2017 10:24:01 +0000 (12:24 +0200)] 
DPP: Deinit PKEX instance on DPP_STOP_LISTEN

Previously this stopped only the DPP Authentication instance, but it is
better to clear both PKEX and Authentication.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: Generate DPP Config Object for legacy network (PSK)
Jouni Malinen [Wed, 29 Nov 2017 10:12:31 +0000 (12:12 +0200)] 
tests: Generate DPP Config Object for legacy network (PSK)

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Clear authentication instance on configuration completion in AP
Jouni Malinen [Mon, 27 Nov 2017 18:33:43 +0000 (20:33 +0200)] 
DPP: Clear authentication instance on configuration completion in AP

wpa_supplicant was already doing this and hostapd needs to clear
hapd->dpp_auth when completing the exchange in Configurator (GAS server)
role.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: sigma_dut DPP AP Configurator using self-configuration
Jouni Malinen [Mon, 27 Nov 2017 18:26:33 +0000 (20:26 +0200)] 
tests: sigma_dut DPP AP Configurator using self-configuration

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Do not process dpp_auth_ok_on_ack multiple times
Jouni Malinen [Mon, 27 Nov 2017 18:20:26 +0000 (20:20 +0200)] 
DPP: Do not process dpp_auth_ok_on_ack multiple times

An additional TX status callback could result in processing the DPP
authentication completion another time at least with hostapd. Fix this
by clearing the dpp_auth_ok_on_ack when processing it.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Fix compilation without CONFIG_TESTING_OPTIONS=y
Ashok Ponnaiah [Mon, 27 Nov 2017 11:20:58 +0000 (16:50 +0530)] 
DPP: Fix compilation without CONFIG_TESTING_OPTIONS=y

Add CONFIG_TESTING_OPTIONS ifdef protection to couple of forgotten DPP
test parameters in wpa_supplicant ctrl_iface.

Signed-off-by: Ashok Ponnaiah <aponnaia@qti.qualcomm.com>
7 years agoDPP: Ignore GAS server status callback for unknown response
Jouni Malinen [Mon, 27 Nov 2017 11:48:40 +0000 (13:48 +0200)] 
DPP: Ignore GAS server status callback for unknown response

It was possible for a timeout from an old GAS server operation to
trigger DPP configuration failure during the subsequent DPP operation.
Fix this by verifying that the status callback is for the response
generated during the same DPP Authentication/Configuration exchange.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: DPP configurator (AP) signing own connector
Jouni Malinen [Mon, 27 Nov 2017 10:45:05 +0000 (12:45 +0200)] 
tests: DPP configurator (AP) signing own connector

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Add DPP_CONFIGURATOR_SIGN support to hostapd
Jouni Malinen [Mon, 27 Nov 2017 10:43:40 +0000 (12:43 +0200)] 
DPP: Add DPP_CONFIGURATOR_SIGN support to hostapd

Configurator signing its own Connector was previously supported only in
wpa_supplicant. This commit extends that to hostapd to allow an AP
acting as a Configurator to self-configure itself.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Move hostapd Configurator/bootstrap data into global context
Jouni Malinen [Mon, 27 Nov 2017 11:22:32 +0000 (13:22 +0200)] 
DPP: Move hostapd Configurator/bootstrap data into global context

This moves the Configurator and Bootstrapping Information data from
struct hostapd_data (per-BSS) to struct hapd_interfaces (per-hostapd
process). This allows the information to be maintained over interface
restarts and shared between interfaces.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: DPP QR Code and mutual authentication with auto-generated key
Jouni Malinen [Sun, 26 Nov 2017 15:43:43 +0000 (17:43 +0200)] 
tests: DPP QR Code and mutual authentication with auto-generated key

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Auto-generate Initiator bootstrapping info if needed
Jouni Malinen [Sun, 26 Nov 2017 15:41:22 +0000 (17:41 +0200)] 
DPP: Auto-generate Initiator bootstrapping info if needed

Instead of using the all-zeros Initiator Bootstrapping Key Hash when no
local bootstrapping key is configuref for the Initiator, automatically
generate a temporary bootstrapping key for the same curve that the
Responder uses. If the Responder indicates that it wants to do mutual
authentication, provide the URI for the auto-generated bootstrapping key
in the DPP-RESPONSE-PENDING event for upper layers to display the QR
Code.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: Allow ap_ft for remote tests
Janusz Dziedzic [Fri, 3 Nov 2017 19:07:33 +0000 (20:07 +0100)] 
tests: Allow ap_ft for remote tests

Fix problem when running ap_ft test cases with real HW using remote
tests and hwsim wrapper by using the newer hostapd.app_ap() API.

Signed-off-by: Janusz Dziedzic <janusz.dziedzic@gmail.com>
7 years agotests: Split ap_vht160 into two test cases (ap_vht160 and ap_vht160b)
Jouni Malinen [Sun, 26 Nov 2017 11:27:25 +0000 (13:27 +0200)] 
tests: Split ap_vht160 into two test cases (ap_vht160 and ap_vht160b)

These VHT160 with DFS cases were in a single test case to optimize test
execution time with parallel wait for the 60 second CAC. However, this
design has become difficult to support with the kernel changes that
allow radar events to be shared between interfaces. To avoid need for
more workarounds here just for testing purposes, split this into two
test cases so that conflicting events from another interface do not
cause the test case to fail.

Signed-off-by: Jouni Malinen <j@w1.fi>
7 years agotests: Split dfs_radar into two test cases (dfs_radar1 and dfs_radar2)
Jouni Malinen [Sun, 26 Nov 2017 10:57:27 +0000 (12:57 +0200)] 
tests: Split dfs_radar into two test cases (dfs_radar1 and dfs_radar2)

These DFS radar detection cases were in a single test case to optimize
test execution time with parallel wait for the 60 second CAC. However,
this design has become difficult to support with the kernel changes that
allow radar events to be shared between interfaces. To avoid need for
more workarounds here just for testing purposes, split this into two
test cases so that conflicting events from another interface do not
cause the test case to fail.

Signed-off-by: Jouni Malinen <j@w1.fi>
7 years agonl80211: Filter global events based on wiphy
Sriram R [Mon, 20 Nov 2017 12:48:41 +0000 (18:18 +0530)] 
nl80211: Filter global events based on wiphy

Avoid same interface processing nl80211 events when at least one of
IFIDX, WDEV, or WIPHY index attribute is available in the nl80211 event
message.

Previously, a same interface processes events when ifidx and wdev id
attribute were not available in the nl80211 message. This is extended to
check the presence of wiphy index attribute as well since some radar
notifications include only WIPHY index attrbute in the nl80211 message.

Signed-off-by: Sriram R <srirrama@qti.qualcomm.com>
7 years agotests: Enable dynamic debugging for mac80211_hwsim
Lubomir Rintel [Mon, 16 Oct 2017 07:32:47 +0000 (09:32 +0200)] 
tests: Enable dynamic debugging for mac80211_hwsim

mac80211_hwsim module typically dumps a lot of details into the kernel
message buffer. While it's probably okay in a dedicated VM, it's way too
chatty in other setups.

The kernel allows fine-tuning logging via the dynamic debugging
facility. Let's enable all logging locations in the mac80211_hwsim
module so that we don't loose debugging output when the kernel adopts
the dynamic debug mechanism for the driver.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
7 years agotests: ap_ht40_scan to print STATUS and STA information to log
Jouni Malinen [Sat, 25 Nov 2017 11:26:13 +0000 (13:26 +0200)] 
tests: ap_ht40_scan to print STATUS and STA information to log

This can be used to check the supported rate information.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agohostapd: Add supported rate information into STATUS and STA
Bhagavathi Perumal S [Fri, 3 Nov 2017 05:14:15 +0000 (10:44 +0530)] 
hostapd: Add supported rate information into STATUS and STA

These allow external programs to determine supported legacy, HT, and VHT
rates of an interface or a STA.

Signed-off-by: Bhagavathi Perumal S <bperumal@qti.qualcomm.com>
7 years agoFILS: Do not leave error value in left counter
Jouni Malinen [Fri, 24 Nov 2017 10:21:18 +0000 (12:21 +0200)] 
FILS: Do not leave error value in left counter

If fils_decrypt_assoc() were to fail on the AP side, the previous
implementation could have continued through the response generation
using left = -1. That could have resulted in unexpected processing if
this value were to be used as the length of the remaining (unencrypted)
IEs. Fix this by not updating left in the failure case.

Fixes: 78815f3dde6e ("FILS: Decrypt Association Request elements and check Key-Auth (AP)")
Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoWPA: Check wpa_eapol_key_mic() result on TX
Jouni Malinen [Fri, 24 Nov 2017 10:13:26 +0000 (12:13 +0200)] 
WPA: Check wpa_eapol_key_mic() result on TX

Verify that nothing unexpected happened with EAPOL-Key Key MIC
calculation when transmitting EAPOL-Key frames from the Authenticator.
This should not be able to happen in practice, but if if it does, there
is no point in sending out the frame without the correct Key MIC value.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: DPP and PKEX (P-256) test vector
Jouni Malinen [Thu, 23 Nov 2017 23:43:23 +0000 (01:43 +0200)] 
tests: DPP and PKEX (P-256) test vector

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Allow PKEX x/X and y/Y keypairs to be overridden
Jouni Malinen [Thu, 23 Nov 2017 23:41:50 +0000 (01:41 +0200)] 
DPP: Allow PKEX x/X and y/Y keypairs to be overridden

This is for testing purposes to allow a test vector with specific values
to be generated.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Print more interim EC_POINT results into debug log
Jouni Malinen [Thu, 23 Nov 2017 23:02:59 +0000 (01:02 +0200)] 
DPP: Print more interim EC_POINT results into debug log

This makes it easier to debug issues related to DPP/PKEX EC operations.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Allow PKEX own/peer MAC addresses to be overridden
Jouni Malinen [Thu, 23 Nov 2017 21:47:52 +0000 (23:47 +0200)] 
DPP: Allow PKEX own/peer MAC addresses to be overridden

This is for testing purposes to allow a test vector with specific values
to be generated.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Provide peer_mac to PKEX Initiator through function argument
Jouni Malinen [Thu, 23 Nov 2017 21:32:33 +0000 (23:32 +0200)] 
DPP: Provide peer_mac to PKEX Initiator through function argument

Avoid unnecessary direct write to a struct dpp_pkex member from outside
dpp.c.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Work around missing EVP_PKEY_CTX_set_ec_param_enc()
Jouni Malinen [Thu, 23 Nov 2017 18:28:57 +0000 (20:28 +0200)] 
DPP: Work around missing EVP_PKEY_CTX_set_ec_param_enc()

This allows compilation with older OpenSSL 1.0.1.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Remove compiler warnings about signed/unsigned comparisons
Jouni Malinen [Thu, 23 Nov 2017 18:24:37 +0000 (20:24 +0200)] 
DPP: Remove compiler warnings about signed/unsigned comparisons

These timestamp comparisons did not use matching signedness.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Fix error return value in dpp_auth_conf_rx()
Jouni Malinen [Thu, 23 Nov 2017 18:20:39 +0000 (20:20 +0200)] 
DPP: Fix error return value in dpp_auth_conf_rx()

Commit 03abb6b5416d472d473c7017802236f8397d0278 ('DPP: Reject unexpected
Req/Resp message based on Auth/PKEX role') used incorrect type of error
value (NULL vs. -1). Fix that.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agohostapd: Disassoc STA without WPA/RSN IE if AP proto is WPA/RSN
Hu Wang [Wed, 25 Oct 2017 11:51:09 +0000 (19:51 +0800)] 
hostapd: Disassoc STA without WPA/RSN IE if AP proto is WPA/RSN

With the AP proto configured being WPA/RSN and SME in the
driver, the previous implementation in hostapd is to not
process hostapd_notif_assoc() due to "No WPA/RSN IE from STA",
if the (Re)Association Request frame is without the WPA/RSN IEs.

Enhance that to disassociate such station provided the AP is not using
WPS.

Signed-off-by: Hu Wang <huw@codeaurora.org>
7 years agotests: Probe Request frame RX events from hostapd
Jouni Malinen [Thu, 23 Nov 2017 17:46:35 +0000 (19:46 +0200)] 
tests: Probe Request frame RX events from hostapd

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agohostapd: Add wpa_msg_ctrl() to report Probe Request frames from STA
bhagavathi perumal s [Wed, 1 Nov 2017 17:09:55 +0000 (22:39 +0530)] 
hostapd: Add wpa_msg_ctrl() to report Probe Request frames from STA

This allows external applications to get event indication for Probe
Request frames. Extend ctrl iface cmd "ATTACH" to enable this event on
per-request basis. For example, user has to send ctrl iface cmd "ATTACH
probe_rx_events=1" to enable the Probe Request frame events.

Signed-off-by: bhagavathi perumal s <bperumal@qti.qualcomm.com>
7 years agotests: Fix dpp_auth_req_retries* check for DPP capability
Jouni Malinen [Thu, 23 Nov 2017 18:11:38 +0000 (20:11 +0200)] 
tests: Fix dpp_auth_req_retries* check for DPP capability

Need to do this before trying to set the DPP test parameters.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: DPP Auth Req retry behavior
Jouni Malinen [Thu, 23 Nov 2017 11:15:40 +0000 (13:15 +0200)] 
tests: DPP Auth Req retry behavior

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Fix number of Authentication Request retry cases
Jouni Malinen [Thu, 23 Nov 2017 11:08:45 +0000 (13:08 +0200)] 
DPP: Fix number of Authentication Request retry cases

Previous implementation did not handle number of sequences correctly.
Make sure the iteration continues in both unicast and broadcast cases
until the five attempts have been made. In addition, improve timing by
checking 10 second time from the beginning of each iteration round and
not the last channel on which the Auth Req frame has been transmitted.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Take response wait time into account for init retries
Jouni Malinen [Wed, 22 Nov 2017 22:42:20 +0000 (00:42 +0200)] 
DPP: Take response wait time into account for init retries

Previously, the Authentication Request frame was retried after 2+10 = 12
seconds since the wait for the response was not accounted for. Substract
that wait from the 10 second wait time to start the retries more quickly
based on the 10 second timer described in the tech spec.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Stop Authentication Request attempts if no response after ACK
Jouni Malinen [Wed, 22 Nov 2017 22:22:13 +0000 (00:22 +0200)] 
DPP: Stop Authentication Request attempts if no response after ACK

If unicast Authentication Request frame is used and the peer ACKs such a
frame, but does not reply within the two second limit, there is no need
to continue trying to retransmit the request frames since the peer was
found, but not responsive.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agotests: DPP with SAE
Jouni Malinen [Wed, 22 Nov 2017 19:22:10 +0000 (21:22 +0200)] 
tests: DPP with SAE

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
7 years agoDPP: Add SAE credential support to Configurator
Jouni Malinen [Wed, 22 Nov 2017 19:22:23 +0000 (21:22 +0200)] 
DPP: Add SAE credential support to Configurator

The new conf={sta,ap}-{sae,psk-sae} parameter values can now be used to
specify that the legacy configuration object is for SAE.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>