[#2436] Added ChangeLog entry

[#2436] Addressed review comments

src/lib/dhcpsrv/memfile_lease_limits.cc
    ClassLeaseCounter::getLeaseClientClasses()
    - improved error handling

src/lib/dhcpsrv/memfile_lease_limits.h
    ClassLeaseCounter::getLeaseClientClasses()
    - changed from const to static

src/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::checkLimits4() fixed count type
    Memfile_LeaseMgr::checkLimits6() fixed exception

dhcpsrv/memfile_lease_mgr.h
    fixed typos

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
    GenericLeaseMgrTest::testLeaseLimits4()
    GenericLeaseMgrTest::testLeaseLimits6()
    - removed unecesary CfgMgr logic

src/lib/dhcpsrv/tests/memfile_lease_limits_unittest.cc
    TEST_F(ClassLeaseCounterTest, adjustClassCountsTest4)
    TEST_F(ClassLeaseCounterTest, adjustClassCountsTest6)
    TEST_F(ClassLeaseCounterTest, getLeaseClientClassesTest)
    - new tests

src/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::getClassLeaseCount() - added mutex

src/lib/dhcpsrv/memfile_lease_mgr.h
    Added thread-safe comments

[#2426] Addressed review comments

src/lib/dhcpsrv/memfile_lease_limits.cc
    ClassLeaseCounter::getLeaseClientClasses()
    - improved error handling

src/lib/dhcpsrv/memfile_lease_limits.h
    ClassLeaseCounter::getLeaseClientClasses()
    - changed from const to static

src/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::checkLimits4() fixed count type
    Memfile_LeaseMgr::checkLimits6() fixed exception

dhcpsrv/memfile_lease_mgr.h
    fixed typos

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
    GenericLeaseMgrTest::testLeaseLimits4()
    GenericLeaseMgrTest::testLeaseLimits6()
    - removed unecesary CfgMgr logic

src/lib/dhcpsrv/tests/memfile_lease_limits_unittest.cc
    TEST_F(ClassLeaseCounterTest, adjustClassCountsTest4)
    TEST_F(ClassLeaseCounterTest, adjustClassCountsTest6)
    TEST_F(ClassLeaseCounterTest, getLeaseClientClassesTest)
    - new tests

[#2436] Implemement Memfile_LeaseMgr:checkLimitsX functions

src/lib/dhcpsrv/lease_mgr.h
    Make LeaseMgr::getClassLeaseCount() const

src/lib/dhcpsrv/memfile_lease_limits.*
    Add ClassLeaseCounter()::getConstCountMap()
    make  size() const

src/lib/dhcpsrv/memfile_lease_mgr.*
    make Memfile_LeaseMgr::getClassLeaseCount() const
    Memfile_LeaseMgr::checkLimits4()
    Memfile_LeaseMgr::checkLimits6()
    Memfile_LeaseMgr::getSubnetStat()
    Memfile_LeaseMgr::getLeaseLimit() - new functions

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
    GenericLeaseMgrTest::testLeaseLimits4()
    GenericLeaseMgrTest::testLeaseLimits6()
    - use CfgMgr to update subent stats

src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
    Enable checkLimits tests

[#2436]  More review comments

Use "client-classes" not "classes" in user-context

src/lib/dhcpsrv/memfile_lease_limits.cc
src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
src/lib/dhcpsrv/tests/memfile_lease_limits_unittest.cc

[#2436] Fixed broken generic lease mgr test

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
    GenericLeaseMgrTest::testLeaseLimits6() - fixed error created
    one I originally split testLeaseLimits()

src/lib/dhcpsrv/tests/mysql_lease_mgr_unittest.cc
   split TEST_F(MySqlLeaseMgrTest, checkLimits) into v4 and v6 tests

[#2436] Rebased and added generic tests

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.*
    Split GenericLeaseMgrTest::testLeaseLimits() into:
        GenericLeaseMgrTest::testLeaseLimits4()
        GenericLeaseMgrTest::testLeaseLimits6()

src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
    TEST_F(MemfileLeaseMgrTest, isJsonSupported4)
    TEST_F(MemfileLeaseMgrTest, isJsonSupported6)
    TEST_F(MemfileLeaseMgrTest, DISABLED_checkLimitsNull4)
    TEST_F(MemfileLeaseMgrTest, DISABLED_checkLimitsNull6)
    TEST_F(MemfileLeaseMgrTest, DISABLED_checkLimits4)
    TEST_F(MemfileLeaseMgrTest, DISABLED_checkLimits6) - new tests

src/lib/dhcpsrv/tests/mysql_lease_mgr_unittest.cc
    TEST_F(MySqlLeaseMgrTest, DISABLED_classLeaseCount4)
    TEST_F(MySqlLeaseMgrTest, DISABLED_classLeaseCount6_NA)
    TEST_F(MySqlLeaseMgrTest, DISABLED_classLeaseCount6_PD) - new tests

[#2436] More review comments pre-rebase

src/lib/dhcpsrv/memfile_lease_limits.h
    Commentary fixes

rc/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::updateLease4Internal()
    Memfile_LeaseMgr::updateLease6Internal() - adjust counts
    after replacing the lease in store

    Memfile_LeaseMgr::recountClassLeases4()
    Memfile_LeaseMgr::recountClassLeases6() - remove use of index

src/lib/dhcpsrv/tests/memfile_lease_limits_unittest.cc
    Fix wrong lease states.

[#2436] Addressed most review comments prior to rebase

src/lib/dhcpsrv/memfile_lease_limits.cc
    ClassLeaseCounter::getLeaseClientClasses() - looks for classes in "ISC"

src/lib/dhcpsrv/memfile_lease_limits.h
    ClassCountMap& getCountMap() - reordered return logic

src/lib/dhcpsrv/memfile_lease_mgr.h
    override and virtual use correction

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.*
    GenericLeaseMgrTest::makeContextWithClasses() - embed in "ISC" element

src/lib/dhcpsrv/tests/memfile_lease_limits_unittest.cc
    makeContextWithClasses() - embed in "ISC" element

src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
    add using namespace data

Apply 3 suggestion(s) to 2 file(s)

Apply 1 suggestion(s) to 1 file(s)

[#2436] Removed unecessary added include

modified:   memfile_lease_mgr_unittest.cc

[#2436] Make class lease count tests generic

Moved tests from memfile_lease_mgr_unittests.* to
generic_lease_mgr_unitest.*

[#2436] Remove class lease recount definitions from LeaseMgr

[#2436] Memfile_LeaseMgr now counts class leases

src/lib/dhcpsrv/lease_mgr.*
    LeaseMgr - added virtual methods:
    ::recountClassLeases4()
    ::recountClassLeases6()
    ::getClassLeaseCount()

src/lib/dhcpsrv/memfile_lease_mgr.*
    Memfile_LeaseMgr
    ::addLeaseInternal()
    ::updateLeaseXInternal()
    ::deleteLeaseInternal(const Lease4Ptr& lease) {
    - added calls to add/remove leases from count map

    ::recountClassLeases4()
    ::recountClassLeases6()
    ::getClassLeaseCount()

src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
    Added boolean flag to makeLease4 and makeLease6

src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
    New tests:
    TEST_F(MemfileLeaseMgrTest, classLeaseCount4)
    TEST_F(MemfileLeaseMgrTest, classLeaseCount6_NA)
    TEST_F(MemfileLeaseMgrTest, classLeaseCount6_PD)
    TEST_F(MemfileLeaseMgrTest, classLeaseRecount4)
    TEST_F(MemfileLeaseMgrTest, classLeaseRecount6)

[#2436] Added ClassLeaseCounter container

Implemented dhcp::ClassLeaseCounter, a container for
managing lease counts per class

src/lib/dhcpsrv/memfile_lease_limits.h
src/lib/dhcpsrv/memfile_lease_limits.cc
    New files that support class lease counting

src/lib/dhcpsrv/Makefile.am
    added memfile_lease_limits.cc, memfile_lease_limits.h

src/lib/dhcpsrv/lease.h
    added Lease::getType() because I am sick of it not existing

src/lib/dhcpsrv/memfile_lease_limits_unittest.cc
    New file

src/lib/dhcpsrv/tests/Makefile.am
    added memfile_lease_limits_unittest.cc

Update configure.ac

Update platforms.rst

Update platforms.rst

Update platforms.rst

spell check, sphnx config change for RHEL9

Spell check

[#2463] release changes

[#2457] fill vector with zeros in SecBuf without referencing potentially unallocated first element

[#2458] added missing package for pdf documentation in ubuntu 22

[#2455] bump lib versions for 2.1.7

[#2266] updated doxygen

[#2266] fixed indentation

[#2266] addressed comments

[#2266] addressed review comments

[#2266] added unittests for mergeDiffAdd and mergeDiffDel

[#2266] addressed review comments

[#2266] addressed review comments

[#2266] addressed review comments

[#2266] updated documentation

[#2266] add support for merge-add and merge-del for Element types

[#2438] Added override keywords to lease manager API instances

[#1614] Added a ChangeLog entry

[#1614] Added a fix for GNU vs POSIX strerror_r

[#1614] Fixed OpenSSL 3.0 system error messages

[#1614] Checkpoint: update an error message

[#1614] Checkpoint: get rid of EVP_MD_CTX_copy

[#1614] Checkpoint: ported HMAC to EVP

[#2247] Spelling

[#2247] ChangeLog updated

[#2247] gss-tsig example configs updated

[#2247] Rephrased text

[#2247] Added a note against client-keytab

[#2086] Typos in ChangeLog

[#2086] Added a ChangeLog entry

[#2086] Updated lease parser

[#2086] Added subnet id range check

[#2411] ChangeLog added.

[#2411] Updated libreSSL 3.0.2 and 3.5.3 errors

[#2411] Added libreSSL >= 3.5.2 support

[#1706] ChangeLog tabulation fixed

[#1706] ChangeLog added

[#1706] Added comment for http_auth_config_

[#1706] minor ordering of command list

[#1706] Version 2.2.0 -> 2.1.7

[#1706] Added restrict-commands feature

[#1706] Added a command filtering feature

[#1706] Changed the basic HTTP auth config for a class variable

[#1706] Added TLS unit test from MT basic one

[#1706] Enforced boolean output

[#1706] Added require-client-certs doc

[#1706] Added require-client-certs HA flag

[#1706] Added TLS server side to HA

[#1706] Added (too) basic unit tests

[#1706] Added TLS context to CmdHttpListener

[#2438] raise the length of client classes in the limits MySQL schema

[#2438] prevent MySQL lease counters from going negative

[#2438] enable checkLeaseXLimits in the MySQL lease manager

[#2438] prevent MySQL lease counters from going negative

[#2438] add ChangeLog entry

[#2438] add MySqlLeaseMgr::isJsonSupported()

[#2438] return strings from MySQL's checkLeaseXLimits()

[#2438] set @json_supported for a MySQL connection

[#2438] add tests for lease counting in MySQL

[#2438] MySQL schema changes in support of lease limiting

[#2438] some outstanding minor corrections

[#2444] Comments around unused parameter

src/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::checkLimits4()
    Memfile_LeaseMgr::checkLimits6() - commented
    out temporarily unused user_context parameter

[#2444] add checkLimitsX() methods to LeaseMgr

[#2418] Fixed number of DBs supported

[#2418] Addressed all 'four database' occurrences

[#2403] Post merge fixes

[#2403] Text edit

[#2403] Final changes to section header formatting

[#2403] Final changes to section header formatting

[#2403] Final changes to section header formatting

[#2403] Final changes to section header formatting

[#2403] Final changes to section header formatting

[#2403] Final changes to section header formatting

[#2403] Final changes to section header formatting

[#2403] Final changes to section header formatting

[#2403] Final changes to section header formatting

[#2403] Final changes to section header formatting

[#2403] Final changes to section header formatting

[#2403] Final changes to section header formatting

[#2403] Final changes to section header formatting