snapshot: Ensure that pointer it always reset

Even if something else keeps holding a reference to the snapshot.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Sanitise format strings

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

package: Initialize r

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: progress: Remove another unused function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jenkins: Don't build for AlmaLinux 9 any more

AlmaLinux does not support the new mount API and we currently don't
really have a user for Pakfire on this platform.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

job: Sanitise format strings when creating xfers

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Make sure argv is always set

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: progress: Remove unused function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Check for the new mount API

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

daemon: Sanitise format strings when creating xfers

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

buildservice: Don't count packages

I don't know why we are doing this...

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Return the correct return code on errors

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

job: Remove unused variable

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Don't assign r when it not being read

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Mark the assertion function to not return

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: version: Update to new-style function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

repo: Sanitise format strings when creating xfers

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

key: Have pakfire_key_unref return a pointer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dist: Sanitize format strings when creating an xfer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: progressbar: Remove the elements array

This was a dynamically allocated array which was difficult to track as
it was filled in two passes.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packager: Initialize tmppath

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

arch: Initialize interpreter

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

buildservice: Sanitise format strings when creating xfers

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

solutions: Initialize elements

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Check if we actually really absolutely have a buffer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

path: Make the static analyzer happy

I don't see how path can be NULL here, but let's rather be safe and
check for it.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

repo: Check if progress could be started okay

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Correct evaluate some more return codes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

digest: Don't assign r when it is never read

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jenkins: Add a pipeline

This is going to help us to achieve better code quality and
compatibility because we will automatically build Pakfire for a couple
of common distributions and run it through Clang's Static Analyzer.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Identify source files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

config: Avoid updating line when it is never being read back

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: daemon: Correctly catch daemon initialization errors

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

key: Refactor return values

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

path: Fix a potential memory leak if either path is not absolute

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pwd: Initialize array before using it

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Cleanup initializing files

There was a potential memory leak here if the entry could not be
allocated.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

libpakfire: Initialize some return values that could be undefined

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Align the disk reader with the writer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Link against libdw

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Find all ELF files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

repo: Improve return code handling

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Fix return code if the archive could not be opened

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Build scaffolding for a new stripper

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Build out dummy function to scan the payload

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Keep a reference to Pakfire

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Use convenience function to open and walk through the archive

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Log the format and compression

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Simplify opening an archive

There is nothing special needed now we clone the file descriptors. So
this is mainly just to make the file sticky.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Fix passing error codes when opening the archive

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Simplify the walk/filter callbacks

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Cleanup loop when searching for files

This mainly removes the ugly label jump.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: cookie: Rename __f to f now that variable is free again

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Streamline opening and reading from the archive

We will now always create a copy of the file descriptor so that we can
independently run mutliple operations on the same archive without
breaking anything.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Fetch the writer only once

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Move extraction code back to where it belongs

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Remove unnecessary underscores from functions

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Minor code cleanups

No functional changes.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Lint the archives after build

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Check if package name contains whitespace

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Add result callback to print to the CLI

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Make this entirely private

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Store any results

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire-builder: Add command to call the linter

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Base this on archives rather than packages

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pty: Hack to avoid lock-up when we don't have a newline

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Create helper function to capture output

That way, we can have the length as an extra argument.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Have pipe return an error if it could not write

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pty: Replace any CRNL with NL when capturing the output

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pty: Configure like SSH does it

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Immediately send SIGKILL when the timer has expired

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Turn off some broken jail tests

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Try some invalid creations of Pakfire

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

httpclient: Initialize like everything else

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

httpclient: Keep better track of all sorts of references

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: snapshots: Commit forgotten files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

httpclient: Explicitely keep a reference to any xfers

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: python: Load the configuration file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Make Pakfire operate in the stub root all the time

This makes it easier than bind-mounting the command.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Make xfer tests compile again

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Check if we have a valid distribution configuration

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Don't use logging functions when setting up Pakfire fails

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

libpakfire: Export pakfire_update_snapshot

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Fix return values when generating the distro tag

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Catch errors when loading distro information

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshots: Automatically create a new snapshot if there are none

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshot: Remove the option to define packages

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Cleanup old snapshots after creating a new one

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshots: Be more verbose when cleaning up snapshots

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshots: Overlayfs does not like colons in the directory name

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshot: Cleanup old snapshots

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: builder: Add command to update a snapshot

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

snapshots: Add function to create a new snapshot

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Add a function to clone a Pakfire instance

This will create a new independant instance based on the previous one.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Show more information if setup fails

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Pass path when reading /etc/os-release

The Pakfire path is not set at this point.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

config: Add a helper function to dump the configuration into a file handle

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Fail if pakfire_path() is called without the path being set

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

string: Fix incorrect buffer variable

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Refactor

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>