]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
4 years agorelease 3.0.25 release_3_0_25
Matthew Newton [Thu, 7 Oct 2021 18:08:16 +0000 (19:08 +0100)] 
release 3.0.25

4 years agoshut up compiler warning
Matthew Newton [Thu, 7 Oct 2021 16:51:58 +0000 (17:51 +0100)] 
shut up compiler warning

4 years agoNote recent changes
Matthew Newton [Thu, 7 Oct 2021 15:52:16 +0000 (16:52 +0100)] 
Note recent changes

4 years agofix args
Matthew Newton [Thu, 7 Oct 2021 13:40:17 +0000 (14:40 +0100)] 
fix args

4 years agofix compiler warnings
Matthew Newton [Thu, 7 Oct 2021 09:52:27 +0000 (10:52 +0100)] 
fix compiler warnings

4 years agoNeed to update the configure.ac file as well (#4253)
Nick Porter [Thu, 7 Oct 2021 13:54:22 +0000 (14:54 +0100)] 
Need to update the configure.ac file as well (#4253)

4 years agoWe should not send a raw value by default
Arran Cudbard-Bell [Thu, 7 Oct 2021 12:21:48 +0000 (07:21 -0500)] 
We should not send a raw value by default

4 years agoRemove unused has_value (#4167)
Nathan Ward [Thu, 7 Oct 2021 12:20:55 +0000 (01:20 +1300)] 
Remove unused has_value (#4167)

* Fix resolving values to enum strings in rlm_rest

- Restore settings flags.has_value in dict_addvalue, which was removed in bc06a68ef97c654f54f6947125e548e04c5b2709
- Fix the logic which resolves `raw` in `vp_prints_value_json`, and document the intent in a comment. Causes the raw value to be emited (i.e. a number rather than enum string), when raw_value is true OR has_value is false (i.e. there is no enum strings for this attribute) - but only if has_tag is false. If has_tag is true, always attempt to print the enum string, and do not allow it to be overridden with raw_value.
- Set raw_value to default to true (yes) to retain current behaviour

* Fix printing raw values rather than enum strings in rlm_couchbase

- In the rlm_rest enum fix, we also change the behavior here, so need to provide a knob to undo that
- Add a raw_value parameter to mod_json_object_to_value_pairs
- Add a raw_value parameter to rlm_couchbase, enabled by default to retain current behavior

4 years agoFix to support PostgreSQL 14 (#4251)
Nick Porter [Thu, 7 Oct 2021 12:01:20 +0000 (13:01 +0100)] 
Fix to support PostgreSQL 14 (#4251)

4 years agoImprove messages when 'proxy_requests = no' (#4249)
Jorge Pereira [Thu, 7 Oct 2021 00:57:04 +0000 (21:57 -0300)] 
Improve messages when 'proxy_requests = no' (#4249)

If the proxy_requests is off you, we just don't have ANY clue
about what is going on. therefore, that might be helpful when
we're troubleshooting systems expecting to see proxy packets,
but someone had the brillant idea to disable the 'proxy_requests'
option.

4 years agonote recent changes
Matthew Newton [Wed, 6 Oct 2021 21:14:26 +0000 (22:14 +0100)] 
note recent changes

4 years agohere, too
Matthew Newton [Wed, 6 Oct 2021 20:48:40 +0000 (21:48 +0100)] 
here, too

there since 2012, so it's probably never actually
been called...

4 years agouse correct function
Matthew Newton [Wed, 6 Oct 2021 20:44:32 +0000 (21:44 +0100)] 
use correct function

4 years agofix comment
Matthew Newton [Wed, 6 Oct 2021 19:02:35 +0000 (20:02 +0100)] 
fix comment

4 years agoDon't mention proxy when not actually proxying
Matthew Newton [Wed, 6 Oct 2021 18:33:10 +0000 (19:33 +0100)] 
Don't mention proxy when not actually proxying

revert behaviour from 19216a55464

4 years agoFix undeclared variable when compiling with TLS + without DHCP (#4246)
Rob Ward [Mon, 4 Oct 2021 14:24:36 +0000 (15:24 +0100)] 
Fix undeclared variable when compiling with TLS + without DHCP (#4246)

When compiling without DHCP support but with TLS support compile
fails due to an undeclared variable in modules.c

src/main/modules.c:1386:3: error: ‘da’ undeclared

Modify variable declaration to be included based on WITH_TLS flag
as well as WITH_DHCP

4 years agodocument correct_escapes again. Fixes #5245
Alan T. DeKok [Thu, 30 Sep 2021 13:51:00 +0000 (09:51 -0400)] 
document correct_escapes again.  Fixes #5245

4 years agoBump for 3.0.25
Matthew Newton [Wed, 29 Sep 2021 19:42:59 +0000 (20:42 +0100)] 
Bump for 3.0.25

4 years agorelease 3.0.24 release_3_0_24
Matthew Newton [Wed, 29 Sep 2021 15:53:09 +0000 (16:53 +0100)] 
release 3.0.24

note recent changes

4 years agomore docs
Alan T. DeKok [Wed, 29 Sep 2021 14:58:26 +0000 (10:58 -0400)] 
more docs

4 years agoallow status-server packets to update destinations for CoA
Alan T. DeKok [Tue, 28 Sep 2021 20:07:09 +0000 (16:07 -0400)] 
allow status-server packets to update destinations for CoA

4 years agomove from linked list to hash table for reverse CoA keys
Alan T. DeKok [Tue, 28 Sep 2021 19:43:08 +0000 (15:43 -0400)] 
move from linked list to hash table for reverse CoA keys

which then lets us send multiple realms out the same listener.
And, lets us dynamically add / delete realms to CoA listeners

4 years agouse the VP key for proxying, instead of proxy_listener->key
Alan T. DeKok [Tue, 28 Sep 2021 19:42:03 +0000 (15:42 -0400)] 
use the VP key for proxying, instead of proxy_listener->key

and don't break out of the loop with the mutex unlocked. :(

4 years agoadd iteration functions
Alan T. DeKok [Tue, 28 Sep 2021 19:26:45 +0000 (15:26 -0400)] 
add iteration functions

4 years agomore typo fixes
Alan T. DeKok [Tue, 28 Sep 2021 14:40:36 +0000 (10:40 -0400)] 
more typo fixes

4 years agofix typo
Alan T. DeKok [Tue, 28 Sep 2021 12:37:23 +0000 (08:37 -0400)] 
fix typo

4 years agoNew dictionary for Cambium (#4243)
Terry Burton [Fri, 24 Sep 2021 20:42:22 +0000 (21:42 +0100)] 
New dictionary for Cambium (#4243)

Compiled from various sources and tidied up. Untested, but at least the IANA
enterprise number is valid...

4 years agonote recent changes
Alan T. DeKok [Thu, 23 Sep 2021 18:49:17 +0000 (14:49 -0400)] 
note recent changes

4 years agoRevert "Revert "Move EAP TLV definitions to share/dictionary.freeradius""
Alan T. DeKok [Thu, 23 Sep 2021 18:48:46 +0000 (14:48 -0400)] 
Revert "Revert "Move EAP TLV definitions to share/dictionary.freeradius""

This reverts commit 60a5e9298d9bb161d84b7cb5a9646e44d48f3338.

<sigh>  v3 can't do TLVs in the internal namespace

4 years agonote recent changes
Alan T. DeKok [Thu, 23 Sep 2021 18:32:58 +0000 (14:32 -0400)] 
note recent changes

4 years agoRevert "Move EAP TLV definitions to share/dictionary.freeradius"
Alan T. DeKok [Thu, 23 Sep 2021 18:27:03 +0000 (14:27 -0400)] 
Revert "Move EAP TLV definitions to share/dictionary.freeradius"

This reverts commit e340f7ee5de20de907ac4f406993e5fc386add68.

4 years agoencode packet before debugging it
Alan T. DeKok [Thu, 23 Sep 2021 12:37:25 +0000 (08:37 -0400)] 
encode packet before debugging it

so that the debug message contains the correct length

4 years agorlm_unix Fix wrong data-type of Acct-Delay-Time. (#4232)
Jorge Pereira [Fri, 17 Sep 2021 15:40:38 +0000 (12:40 -0300)] 
rlm_unix Fix wrong data-type of Acct-Delay-Time. (#4232)

4 years agotypo
Alan T. DeKok [Fri, 17 Sep 2021 12:20:55 +0000 (08:20 -0400)] 
typo

4 years agocorrect PAC lifetime calculation
Alan T. DeKok [Fri, 17 Sep 2021 12:02:29 +0000 (08:02 -0400)] 
correct PAC lifetime calculation

the lifetime is a delta, and the "expires" field is a wall-clock
time.

4 years agobetter error message
Alan T. DeKok [Tue, 14 Sep 2021 16:39:56 +0000 (12:39 -0400)] 
better error message

4 years agoadd more (TLS) headers to TLS log messages
Alan T. DeKok [Tue, 14 Sep 2021 16:35:52 +0000 (12:35 -0400)] 
add more (TLS) headers to TLS log messages

4 years agodelete attribute after it's no longer needed
Alan T. DeKok [Tue, 14 Sep 2021 00:18:21 +0000 (20:18 -0400)] 
delete attribute after it's no longer needed

4 years agocopy certs even on failure, so that they can be logged.
Alan T. DeKok [Mon, 13 Sep 2021 21:13:24 +0000 (17:13 -0400)] 
copy certs even on failure, so that they can be logged.

finalizing commit c157da82eb

4 years agoadd (TLS) to more messages
Alan T. DeKok [Mon, 13 Sep 2021 21:06:24 +0000 (17:06 -0400)] 
add (TLS) to more messages

4 years agoupdates now that we have TOTP
Alan T. DeKok [Mon, 13 Sep 2021 16:20:11 +0000 (12:20 -0400)] 
updates now that we have TOTP

4 years agonote recent changes
Alan T. DeKok [Sun, 12 Sep 2021 21:30:25 +0000 (17:30 -0400)] 
note recent changes

4 years agoadd last_time_xlat
Alan T. DeKok [Tue, 7 Sep 2021 17:49:33 +0000 (13:49 -0400)] 
add last_time_xlat

4 years agoallow IPv6 parsing
Alan T. DeKok [Tue, 7 Sep 2021 12:04:15 +0000 (08:04 -0400)] 
allow IPv6 parsing

4 years agoallow Simultaneous-Use to use IPv6 addresses, too
Alan T. DeKok [Mon, 6 Sep 2021 12:39:03 +0000 (08:39 -0400)] 
allow Simultaneous-Use to use IPv6 addresses, too

4 years agobetter error messages. Helps with #4219
Alan T. DeKok [Wed, 1 Sep 2021 21:12:20 +0000 (17:12 -0400)] 
better error messages.  Helps with #4219

4 years agoFix Docker typo same as #4215 (#4218)
Jorge Pereira [Wed, 1 Sep 2021 12:52:16 +0000 (09:52 -0300)] 
Fix Docker typo same as #4215 (#4218)

4 years agoAdd 'weeklycounter' for sqlcounter (#4216)
Jorge Pereira [Tue, 31 Aug 2021 22:42:16 +0000 (19:42 -0300)] 
Add 'weeklycounter' for sqlcounter (#4216)

4 years agoFix Docker/Centos8 build (#4215)
Jorge Pereira [Tue, 31 Aug 2021 22:41:29 +0000 (19:41 -0300)] 
Fix Docker/Centos8 build (#4215)

4 years agowhoops... clear this once we're using the packet
Alan T. DeKok [Tue, 31 Aug 2021 13:46:06 +0000 (09:46 -0400)] 
whoops... clear this once we're using the packet

4 years agonote recent changes
Alan T. DeKok [Tue, 31 Aug 2021 12:51:29 +0000 (08:51 -0400)] 
note recent changes

4 years agoread partial packets, ala dual_tcp_recv()
Alan T. DeKok [Tue, 31 Aug 2021 12:42:43 +0000 (08:42 -0400)] 
read partial packets, ala dual_tcp_recv()

4 years agofix debug message, and rename variables
Alan T. DeKok [Mon, 30 Aug 2021 21:35:08 +0000 (17:35 -0400)] 
fix debug message, and rename variables

smurf1 smurf2 and my_smurf are bad names.

4 years agodon't allow: Foo = &Client-Shortname
Alan T. DeKok [Sun, 29 Aug 2021 12:30:58 +0000 (08:30 -0400)] 
don't allow: Foo = &Client-Shortname

it won't work, because the attribut doesn't exist, it's virtual.
It has to be "%{Client-Shortname}"

4 years agodon't allow: Foo = %{...}
Alan T. DeKok [Sun, 29 Aug 2021 12:26:34 +0000 (08:26 -0400)] 
don't allow:  Foo = %{...}

it must be in a double-quoted string.

4 years agowarn on "switch attribute" without "switch &attribute"
Alan T. DeKok [Fri, 27 Aug 2021 22:07:33 +0000 (18:07 -0400)] 
warn on "switch attribute" without "switch &attribute"

4 years agonotes on session timeout
Alan T. DeKok [Fri, 27 Aug 2021 14:39:25 +0000 (10:39 -0400)] 
notes on session timeout

4 years agoLet's keep lowercase as we have in everywhere (#4211)
Jorge Pereira [Thu, 26 Aug 2021 21:58:24 +0000 (18:58 -0300)] 
Let's keep lowercase as we have in everywhere (#4211)

4 years agoFix typo (#4207)
Jorge Pereira [Thu, 26 Aug 2021 18:37:14 +0000 (15:37 -0300)] 
Fix typo (#4207)

4 years agoprint out values we're parsing
Alan T. DeKok [Thu, 26 Aug 2021 12:58:29 +0000 (08:58 -0400)] 
print out values we're parsing

4 years agotypo. Fixes #4209
Alan T. DeKok [Wed, 25 Aug 2021 13:21:15 +0000 (09:21 -0400)] 
typo.  Fixes #4209

4 years agotypo
Alan T. DeKok [Wed, 25 Aug 2021 12:33:17 +0000 (08:33 -0400)] 
typo

4 years agoThis attribute is "abinary"
Alan T. DeKok [Wed, 25 Aug 2021 12:06:15 +0000 (08:06 -0400)] 
This attribute is "abinary"

See https://documentation.nokia.com/cgi-bin/dbaccessfilename.cgi/9304720101_V1_7750%20SR%20OS%20RADIUS%20Attributes%20Reference%20Guide%2011.0.R1.pdf

4 years agoUsage schema extension for SQLite: Typo (#4200)
Terry Burton [Fri, 20 Aug 2021 18:49:59 +0000 (19:49 +0100)] 
Usage schema extension for SQLite: Typo (#4200)

Typo in 4c67d412956d2efed8b6ab4f216eb49abf3119c5 component of PR #3635.

4 years agoData usage for MySQL: Run SP as invoker not definer (#4202)
Terry Burton [Fri, 20 Aug 2021 18:49:48 +0000 (19:49 +0100)] 
Data usage for MySQL: Run SP as invoker not definer (#4202)

4 years agopause and resume sockets if we're not reading from them.
Alan T. DeKok [Fri, 20 Aug 2021 12:51:56 +0000 (08:51 -0400)] 
pause and resume sockets if we're not reading from them.

4 years agoword smithing
Alan T. DeKok [Fri, 20 Aug 2021 00:26:13 +0000 (20:26 -0400)] 
word smithing

4 years agoadd --allow-mschapv2
Alan T. DeKok [Thu, 12 Aug 2021 12:44:01 +0000 (08:44 -0400)] 
add  --allow-mschapv2

4 years agoPROXY Protocol howto (#4197)
Terry Burton [Thu, 19 Aug 2021 14:33:48 +0000 (15:33 +0100)] 
PROXY Protocol howto (#4197)

4 years agonote recent changes (#4193)
Jorge Pereira [Wed, 18 Aug 2021 13:50:45 +0000 (10:50 -0300)] 
note recent changes (#4193)

4 years agoAdd missing '-v' in 'radmin' (#4189)
Jorge Pereira [Wed, 18 Aug 2021 13:36:53 +0000 (10:36 -0300)] 
Add missing '-v' in 'radmin' (#4189)

4 years agosqlcounter: Fix wrong memory free (#4192)
Jorge Pereira [Wed, 18 Aug 2021 13:36:45 +0000 (10:36 -0300)] 
sqlcounter: Fix wrong memory free (#4192)

4 years agoAdd missing '-v' in 'radwho' (#4188)
Jorge Pereira [Tue, 17 Aug 2021 22:41:59 +0000 (19:41 -0300)] 
Add missing '-v' in 'radwho' (#4188)

4 years agorlm_rest Fix typo (#4184)
Jorge Pereira [Sun, 15 Aug 2021 13:21:11 +0000 (10:21 -0300)] 
rlm_rest Fix typo (#4184)

It should be '='

4 years agoippool: Fix missing 'Called-Station-Id' in the MySQL/procedure.sql (#4185)
Jorge Pereira [Sun, 15 Aug 2021 13:20:51 +0000 (10:20 -0300)] 
ippool: Fix missing 'Called-Station-Id' in the MySQL/procedure.sql (#4185)

As the scheme.sql has the 'calledstationid' field, we should fill it up.

4 years agoadd Debian 11 Bullseye Dockerfile and to CI
Matthew Newton [Sat, 14 Aug 2021 20:47:06 +0000 (21:47 +0100)] 
add Debian 11 Bullseye Dockerfile and to CI

4 years agoUpdate package dependencies for Debian 11 Bullseye
Matthew Newton [Sat, 14 Aug 2021 21:34:33 +0000 (22:34 +0100)] 
Update package dependencies for Debian 11 Bullseye

4 years agoMariADB >= 10.6 also support 'SKIP LOCK' (#4180)
Jorge Pereira [Fri, 13 Aug 2021 13:01:50 +0000 (10:01 -0300)] 
MariADB >= 10.6 also support 'SKIP LOCK' (#4180)

4 years agoadd (commented out) docs on using the haproxy protocol
Alan T. DeKok [Wed, 11 Aug 2021 15:07:51 +0000 (11:07 -0400)] 
add (commented out) docs on using the haproxy protocol

4 years agouse EOL. which removes the listener from the event list
Alan T. DeKok [Wed, 11 Aug 2021 14:48:25 +0000 (10:48 -0400)] 
use EOL. which removes the listener from the event list

4 years agoRevert "close connection on "no TLS data, but connection isn't set up""
Alan T. DeKok [Wed, 11 Aug 2021 14:46:31 +0000 (10:46 -0400)] 
Revert "close connection on "no TLS data, but connection isn't set up""

This reverts commit 75620b2fb9e7eb4f7853373fe3ffc2f67e97bb22.

not needed

4 years agominor word smithing
Alan T. DeKok [Sat, 7 Aug 2021 16:12:36 +0000 (12:12 -0400)] 
minor word smithing

4 years agodon't unlock the mutex if it was never locked.
Alan T. DeKok [Fri, 6 Aug 2021 16:38:34 +0000 (12:38 -0400)] 
don't unlock the mutex if it was never locked.

4 years agonote recent changes
Alan T. DeKok [Fri, 6 Aug 2021 13:44:19 +0000 (09:44 -0400)] 
note recent changes

4 years agoallocate from the request, which is thread-safe. Helps with #3188
Alan T. DeKok [Thu, 5 Aug 2021 15:22:12 +0000 (11:22 -0400)] 
allocate from the request, which is thread-safe.  Helps with #3188

The "check" item is taken from the "huntgroups" file.  It's in
a statically allocated list which doesn't change, and shouldn't
change during run-time.  Allocating memory in its context is
not thread-safe, and can cause issues

4 years agosimple config for testing
Alan T. DeKok [Thu, 5 Aug 2021 14:17:22 +0000 (10:17 -0400)] 
simple config for testing

4 years agoStatus-Server packets are left in the TCP proxy hash
Alan T. DeKok [Wed, 4 Aug 2021 23:05:10 +0000 (19:05 -0400)] 
Status-Server packets are left in the TCP proxy hash

until such time as the listener is being shut down

4 years agoallow status-server checks for TCP
Alan T. DeKok [Wed, 4 Aug 2021 22:59:20 +0000 (18:59 -0400)] 
allow status-server checks for TCP

nothing yet implements that, but it's a start.

We still have to allocate a permanent ID for status-server checks

4 years agowe cache preg only for PCRE
Alan T. DeKok [Wed, 4 Aug 2021 12:25:31 +0000 (08:25 -0400)] 
we cache preg only for PCRE

4 years agomore assertions
Alan T. DeKok [Wed, 4 Aug 2021 12:26:38 +0000 (08:26 -0400)] 
more assertions

4 years agoMySQL sqlippool SP: Run as invoker, not definer; close transaction on error (#4170)
Terry Burton [Tue, 3 Aug 2021 21:17:04 +0000 (22:17 +0100)] 
MySQL sqlippool SP: Run as invoker, not definer; close transaction on error (#4170)

In MariaDB/MySQL, stored procedures default to running in the context of
the definer rather than the invoker.

This is a problem in a streaming replication scenario since the definer
is often the root user who has the "super" power to write to a read-only
database (unless super-read-only is enabled, which is not available for
MariaDB), thus breaking the replication timeline.

Additionally, exiting an SP does not finalise any running transaction.
If an exception is raised within the SP (e.g. due to the database being
read-only) we must handle this and finalise the transaction, otherwise
subsequent calls to "SET TRANSACTION ISOLATION LEVEL READ COMMITTED"
will fail ad nauseam until the connection is finally closed.

4 years agodon't build coa tunnel by default
Alan T. DeKok [Tue, 3 Aug 2021 18:42:15 +0000 (14:42 -0400)] 
don't build coa tunnel by default

4 years agoproxy_listener may not exist
Alan T. DeKok [Tue, 3 Aug 2021 18:41:18 +0000 (14:41 -0400)] 
proxy_listener may not exist

4 years agoprint out better errors
Alan T. DeKok [Tue, 3 Aug 2021 17:24:25 +0000 (13:24 -0400)] 
print out better errors

4 years agoreturn type is ssize_t if we return -1
Alan T. DeKok [Tue, 3 Aug 2021 17:16:04 +0000 (13:16 -0400)] 
return type is ssize_t if we return -1

4 years agosimple test haproxy configuration file
Alan T. DeKok [Mon, 2 Aug 2021 12:19:18 +0000 (08:19 -0400)] 
simple test haproxy configuration file

4 years agodocument proxy_protocol
Alan T. DeKok [Fri, 30 Jul 2021 13:58:41 +0000 (09:58 -0400)] 
document proxy_protocol

4 years agoprint ip, not fr_ipaddr_t
Alan T. DeKok [Fri, 30 Jul 2021 13:24:18 +0000 (09:24 -0400)] 
print ip, not fr_ipaddr_t

4 years agothe end client must be known, too.
Alan T. DeKok [Fri, 30 Jul 2021 13:07:01 +0000 (09:07 -0400)] 
the end client must be known, too.

4 years agoreturn 1 for "done" instead of "error"
Alan T. DeKok [Thu, 29 Jul 2021 21:41:12 +0000 (17:41 -0400)] 
return 1 for "done" instead of "error"