git.ipfire.org Git - thirdparty/squid.git/log

An unfortunate bug.  The hdr->entries array is initialized
such that count is set to zero.  httpHeaderClean() seems to
be called both when 'hdr' is created, and destroyed.  Thus,
we accumulate a large number of zero counts for 'hdr' before
it is ever used.  Can't think of a good way to fix it, except
adding a state variable that indicates whether or not 'hdr'
has been used.  As a hack, just never count zero-sized header
arrays.

bugzilla #710: round-robin cache_dir selection incorrectly compares max-size

Bootstrapped

Bugzilla #709: cbdata.c:186: "c->valid" assertion due to peer digest not found

Restore default value of access_log like it has always been

minor nit - don't append -{date}

and bootstrap

had teh version wrong

updated mkrelease.sh to newer configure syntax

bootstrapped

start release snapshots

Remove bitfield definition of quote. Having it as a bitfield only marginally
saves memory, but probably both confuses compilers and make more inefficient
code. Robert reported issues with using GCC-2.95 related to this.

Fix merge conflict in TCP_DENIED_REPLY

assert on double cbdataFree()

Summary: Add forgotten test-script.
Keywords:

Add a test case for delete - checking that the correct delete operator is used in a class hierarchy.

bootstrapped

Summary: More MSVC compatability tweaks.
Keywords:

More pointer construction to pointer assignment replacements.
Add a test case for delete - checking that the correct delete operator is used in a class hierarchy.
Partly fix g++ 2.95 builds - there sstream includes the system assert, which breaks our custom assert macro. So, a couple of undefs and we have an ugly fix.

Summary: MSVC compatability fixes from Guido.
Keywords:

Remove pointer-to-type constructors.
More consistency between struct/class defn's and use.

Bugzilla #686
Summary: requests denied due to http_reply_access are now logged with
TCP_DENIED_REPLY.
Keywords: http_reply_access TCP_DENIED_REPLY

This differs from squid-2.5, where such requests are logged with
TCP_DENIED.

Bug #708: make ie_refresh send "Cache-Control: no-cache" to have the
refresh propagate properly via cache meshes.

bootstrapped

Summary: Fix ufsdump bitrot.
Keywords:

Add new needed objects into its build recipe.
Add <cassert> for STL safe assert definition.

bootstrap

Summary: Fix Makefile.am
Keywords:

Yup, did it again, astyle'd Makefile.am.

Summary: Remove more global mem pools.
Keywords:

Give HttpRequest it's own mempool.
Give storeSwapLogData it's own file, mem pool.
  Provide a file_write adapter for objects.
Give helper_stateful_request it's own mem pool.
  Move into new file helper.h
Give helper_request it's own mem pool.
  Move into new file helper.h

bootstrapped

Summary: Make all Arrays typesafe.
Keywords:

Make all arrays typesafe.
Remove C bindinds to Array logic (we can instate new ones easily if desired later on).
Make all users of HttpHeader classes: htcpReplyData.
Ensure all class contianing HttpHeader are constructed and destructed:
htcpReplyData, request_t, HttpReply.
rename request_t to HttpRequest.
Move htcp prototypes to htcp.h.

Summary: Remove MemPool dependence on Array.h.
Keywords:

Remove Array.h include from MemPool.h.
Add to headers that implicitly included it before.

Summary: Be consistent with ESIElements type.
Keywords:

Make it class ESIElement throughout.

bootstrapped

Summary: Adjust post-merge.
Keywords:

Set ESI to 0, not undefined when building without --enable-esi.
Fixup test suite Makefile to not test ESI unless ESI was built.

Summary: Merge of robertc@squid-cache.org--squid/squid--esi--3.0
Keywords:

Patches applied:

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-149
     Fixup test-suite makefile pre-merge.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-148
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-262

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-147
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-261

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-146
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-260

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-145
     More merge fixups.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-144
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-259

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-143
     Adjust for recent merges.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-142
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-258

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-141
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-257

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-140
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-256

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-139
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-255

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-138
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-254

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-137
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-253

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-136
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-252

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-135
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-251

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-134
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-250

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-133
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-249

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-132
     Merge of projects@swelltech.com--private/squid--mem-to-disk--3.0--patch-1

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-131
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-247

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-130
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-246

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-129
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-245

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-128
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-244

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-127
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-243

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-126
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-242

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-125
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-241

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-124
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-240

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-123
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-239

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-122
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-238

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-121
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-237

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-120
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-236

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-119
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-235

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-118
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-234

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-117
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-233

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-116
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-232

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-115
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-231

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-114
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-230

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-113
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-229

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-112
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-228

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-111
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-227

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-110
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-226

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-109
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-225

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-108
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-224

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-107
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-223

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-106
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-222

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-105
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-221

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-104
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-220

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-103
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-219

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-102
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-218

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-101
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-217

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-100
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-216

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-99
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-215

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-98
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-214

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-97
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-213

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-96
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-212

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-95
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-211

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-94
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-210

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-93
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-209

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-92
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-208

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-91
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-207

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-90
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-206

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-89
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-205

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-88
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-204

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-87
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-203

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-86
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-202

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-85
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-201

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-84
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-200

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-83
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-199

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-82
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-198

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-81
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-197

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-80
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-196

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-79
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-195

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-78
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-194

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-77
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-193

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-76
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-192

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-75
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-191

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-74
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-190

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-73
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-189

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-72
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-188

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-71
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-187

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-70
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-186

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-69
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-185

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-68
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-184

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-67
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-183

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-66
     Towards esi Functions.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-65
     Refactoring towards ESI Functions.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-64
     Propogate message headers to ESI includes.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-63
     Extract HttpHeader class to HttpHeader.h

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-62
     Extract ESIInclude to separate files.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-61
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-182

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-60
     Merge of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-181

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-59
     Merge from HEAD

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-58
     Prevent a race condition in esi includes.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-57
     Merge from HEAD.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-56
     Merge from HEAD.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-55
     BUGFIX: Memory leak in ESI requests.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-54
     BUGFIX: libTrie was returning random values when adding a node.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-53
     Give libTrie stricter g++ flags.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-52
     Parse '' correctly in esi expressions.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-51
     Fixup build.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-50
     Merge from HEAD.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-49
     Merge from HEAD.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-48
     ESI logging tweaks.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-47
     Bugfix: redirection of internal requests would segv.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-46
     Merge from HEAD

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-45
     Merge from HEAD.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-44
     Implement variable evaluation in esi:assign short form.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-43
     Implement ESI long form variable assignment.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-42
     Inital addition of ESIAssign.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-41
     Finish inserting all variables for ESI into a trie.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-40
     Variable logic extraction.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-39
     Separate out various variable logic.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-38
     Allow character transforms for tries.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-37
     ESI Variable refactoring to ease support of dynamic variables.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-36
     Allow low expiry dates on objects when using ESI.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-35
     Bugfix TrieNode constructor.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-34
     Eliminate esiVarState::esiVar_t.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-33
     Introduce esiVarState::Variable class.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-32
     Merge from HEAD.

  * robertc@squid-cache.org--squid/squid--esi--3.0--patch-31
     Merge CVS changes to ESI.

Summary: Change inline static initialiser to out-of-class.
Keywords:

Change inline static initialiser to out-of-class.

Summary: Convert Stack to typesafe usage.
Keywords:

Convert the Stack Header.
Add a StackTest testcase.
Remove Stack.h from squid.h.
Adjust cbdata to use typesage stacks.
Move cbdata's foreach to Generic.h.
Adjust store.cc to use a typesafe Stack.
Remove unused Stack defines.

Summary: MSVC Compatability.
Keywords:

Don't use inline static initialiser in cbdata.
MSVC Doesn't like
Foo *Class::Static(NULL);
convert to
Foo (*Class::Static)(NULL);
throughout.

Summary: SSL Support for recent changes.
Keywords:

The ConnStateData change broke SSL, which wasn't enabled in my build tree.

Summary: Tweak refcount to be more MSVC compatible.
Keywords:

Guido supplied a tweak to RefCount.h to be MSVC compatible.

Summary: Forgot to remove non-inlined templates in Array.h
Keywords:

Do so!

Summary: MSVC compatability fixes.
Keywords:

Inline a couple of template methods.
Convert an anonymous struct to named.
AuthUser should be a class everywhere.

Summary: Change unnamed struct to named class in MemObject for MSVC compatability.

Change unnamed struct to named class in MemObject for MSVC compatability.

Correct md5-sess calculation

Allow log format specifications to force quoting/escaping even if Squid
thinks it is not needed for the field

squid.conf changes updated

Summary: More support MSVC's broken C++ parser.
Keywords:

MSVC appears to misparse the constructor syntax for Debug::CurrentDebug.

Summary: Merge of projects@swelltech.com--private/squid--mem-to-disk--3.0--patch-1
Keywords:
MergeOf: projects@swelltech.com--private/squid--mem-to-disk--3.0--patch-1

Patches applied:

  * projects@swelltech.com--private/squid--mem-to-disk--3.0--patch-1
     Refactoring store_client.

  * projects@swelltech.com--private/squid--mem-to-disk--3.0--base-0
     tag of projects@swelltech.com--private/squid--ign--3.0--patch-76

* extract disk read scheduling from store_client::doCopy.
* Ditto for mem scheduling.
* Extract choice of memory or disk reads from store_client::doCopy.
* Extract logic surrounding disk opens from store_client::doCopy.

Summary: BUGFIX: ConnStateData needs to own itself.
Keywords:

* I forgot to give ConnStateData a reference to itself, for persistent connections.

Summary: ConnStateData tweaks to address race on close.
Keywords:

* ConnStateData is most appropriate to be reference counted by it's owners, and cbdata locked by it's callees. Make this change and propogate throughout.
* Extract on-closure logic from ConnStateData destructor to ConnStateData::close().
* Fix an apparent break with authenticateOnCloseConnection().
* Move request_t to HttpRequest.h

Bootstrapped

Fix httpHeaderDelById compile failure. Was a old sin where assert_eid was
abused instead of assert. No idea why gcc did not trigger on this issue
until now. The error has been there forwever (17-Oct-01).

indent

Summary: Refactoring: ClientHttpRequest.
Keywords:

* Self encapsulation ClientHttpRequest::conn.

Summary: BUGFIX: httpStateData leaks.
Keywords:

CommRead's operator= was leaking cbdatareferences when assigning to an already extant object.
Fixed. We could benefit by generalising the algorithm for refcounting classes further - to allow the reuse of RefCount's logic with classes owning CBDATA - like CommRead.

Summary: BUGFIX: partial fix for leaking httpStateData.
Keywords:

* ConnectStateData was not being deleted, just freed.
* Added the (optional, but good for clarity) virtual keywords to derived methods of CommCallbackData::deleteSelf.
* Fixup test/debug LDADD - Array.o was there while testing external new and delete.
* Add a test for compiler synthetic copy operators on objects that own ones with overriden operators.

Some missing external acl pieces

- log= result tag, for a string usable in access.log

- access log formats for
ue      User from external acl
et      Tag returned by external acl
ea      Log string returned by external acl

%o error message tag for referring to the message returned by
external acl helper.

Fix a memory corruption bug if log tags carrying "unsafe" data is used
without a quoting context

Additional enhancments to pconn session management for origin servers
split the connection pool for the server on requested port as well
as domain.

Bootstrapped

Remove dependency of src/debug.cc

Summary: debugs tweaks.
Keywords:

* Remove an inappropriate # from the last line of src/debug.cc
* Rename Debug::currentDebug to Debug::CurrentDebug as per the coding standards.

Bootstrapped

debug.cc requires tools.cc

Summary: Clear up debugs test case.
Keywords:

Alan Barrett noted that StreamTest::getAnInt returned a char const * which isn't all that obvious... Fixed to return an int.

Bootstrapped

Summary: BUGFIX: Forgot to update the test converted debugs call in CacheDigest.cc
Keywords:

BUGFIX: Forgot to update the test converted debugs call in CacheDigest.cc

Summary: Merge debugs logic.
Keywords:

Patches applied:

  * robertc@squid-cache.org--squid/squid--cplusplusdebug--3.0--patch-4
     Add tests, change debugs syntax.

  * robertc@squid-cache.org--squid/squid--cplusplusdebug--3.0--patch-3
     Add test case for debugs in the case it doesn't require a ;

  * robertc@squid-cache.org--squid/squid--cplusplusdebug--3.0--patch-2
     Enforce the use of ; at the end of debugs macro calls.

  * robertc@squid-cache.org--squid/squid--cplusplusdebug--3.0--patch-1
     String based debug and operator ::new fixes.

  * robertc@squid-cache.org--squid/squid--cplusplusdebug--3.0--base-0
     tag of robertc@squid-cache.org--squid/squid--HEAD--3.0--patch-222

Added missing %tr response time log format specification

Bug #702: ERR_TOO_BIG spanish translation by Sergio Rua <srua@debian.org>

Custom log formats, and selective access logging. See logformat
and cache_access_log directives

External acl extensions:

%SRCPORT, %MYPORT, %MYADDR
New format tags for matching client TCP connection details

grace=N
defines a grace period on external acl cache entries. If the entry has less
then the grace period left when being refercenced then a new lookup is
initiated but without waiting for the reply.

Bootstrapped

Bugfix: Speed up processing of queued events significantly, to not cause
large delays when under low load.

--disable-optimizations option to force compiler optimizations (including
inlining) to be disabled. Very useful for debugging.

Bugfix: Speed up processing of queued events significantly, to not cause
large delays when under low load.

class DeferredRead is not a cbdata enabled class. Don't attempt to define
the cbdata glue as this confuses GCC when optimization is not enabled

Improvement: Increased time granularity for cache.log, down to msec
precision for debug messages (level > 1).

Bugfix: Make sure the clock is updated after poll/select to account for
the time sleeping waiting for I/O.

Removed 'minimum_retry_timeout' and Config.retry.timeout. This
variable has not been used for some time it seems.

Bootstrapped

* ext_user acl type to match user name returned by external acl

* cleanup of how external acls present a user name to the
  Squid core to make the code more logical and fix a
  minor security issues if there is downstream proxies.

* concept of password returned by external acl type. Integrated
  with login= cache_peer option to have the password forwarded
  to peers (both proxies and origin type peers)

Minor refactoring to C++, and renamed error to message in preparation
of later merge.

Summary: Convert mem_hdr to the use of a splay.
Keywords:

* Add a dataRange() method to mem_node, to allow direct access to the range
available.
* Add mem_node::deleteSelf().
* Update copyright on stmem.[cc|h].
* Test new mem_node methods.
* Add Splay::end() method and test.
* Add mem_hdr::unlink().
* Remove mem_hdr::unlinkHead(), mem_hdr::getHighest.., mem_hdr::head and mem_hdr::tail.
* Remove mem_node::next.
* Introduce mem_hdr::dump().
* Introduce mem_hdr::size().
* Introduce mem_hdr::start().
* Make mem_hdr::getBlockContainingLocation() public.

Bootstrapped

changing type of cacheMesh.cachePeerTable.cachePeerEntry.cachePeerPingsSent
and cachePeerPingsAcked to match the MIB. Was ASN_INTEGER, is not
SMI_COUNTER32.

In parseEtcHosts(), using strtok() to strip comments does not work if
the first character is a comment. The buf[0] check is still necessary.

Summary: Add missing profile counter.
Keywords:

Oops, managed to leave out one of the coutner declarations.

Summary: Profiling additions.
Keywords:

* Added an eventRun profiler hook.
* Added a store_client profiler hook, surrounding kick_reads.
  Prevented reentrancy.
* Added a storeDirCallback profiler hook.
  Refactored to reduce variable scope.
* Added a profiler hook to comm_calliocallback.
  Refactored to reduce variable scope.
* Added surrounding hooks to the read,accept,write and fill
  comm callback callers.
* Added profiling hook around HttpStateData::readReply.
* Added profiling hook around HttpStateData::processReplyData.
* Added profiling hook around StoreEntry::write.
* Added profiling hook around storeGetMemSpace.
* Added profiling hook around MemObject::write.
* Added profiling hook around storeWriteComplete.
* Added profiling hook around mem_hdr::write.

Summary: mem_hdr testing and corrections.
Keywords:

* Introduce operator < for mem_nodes, to provide ordering.
* Create a mem_hdr constructor and destructor.
* bugfix: writing before the lowest offset was broken.
* Reuse the Range template for mem_hdr::hasContigousContentRange.
* Prepare splay trees for replacing the list of mem_nodes.

Summary: Add TODO for mem_node_test.
Keywords:

When MemPools are off, mem_node always returns 0 for the InUseCount. This leads to store.cc never freeing resources.

Regarding store_check_cachable_stats, put check for 'wrong_content_length'
before 'not_entry_cachable' because objects with ENTRY_BAD_LEGNTH
also always have ENTRY_CACHABLE cleared and nothing ever gets counted
as 'wrong_content_length'.

Summary: comm cleanups.
Keywords:

* Add a FIXME comment in disabled client_side code where fd abstraction is broken.
* fde.rwstate is actually specific to writes - rename to wstate.
* The warning about rwstate should be a fatal, as it leads to incorrect callbacks occuring.
disabling persistent connections will disable this bug - so a fatal is no impediment to testers.

Summary: Refactoring: Extract method in comm.cc
Keywords:

Extract common asserts to ensureOpenAndActive.

Summary: strcpy->strncpy in pconn.cc.
Keywords:

Whilst debugging, I noticed we don't use strncpy - converted for safety.

Summary: CBData reference callback pointers in comm_read and related..
Keywords:

We were not cbdata referencing user supplied pointers. This allows user supplied data to be freed before we call back. Still TODO: check for cbdataReferenceValid upon callback.

Summary: Fix segv in RefCount operator=.
Keywords:

When a cycle is broken for refcounted objects, if the breaking smart pointer is in one of the cycled objects, and is freed as a result, we could end up assigned to freed RAM.

Summary: Callback event loop was busted.
Keywords:

The comms callback event loop was not dereferencing the dlink_node correctly, leading to comparing the sequence number to a pointer. Once again, typecasts leads to bugs :[.
* Increment sequence number on each loop.
* Compare to the event's record sequence number.
* Add a virtual destructor to CommCallbackData to remove some (spurious) warnings that apply to the synthetic constructor under -some- gcc's.

Summary: Fix race condition in storeUnlockObject.
Keywords:

storeUnlockObject would, under rare circumstances free the object it is unlocking, and -then- attempt to reference it.

From Reuben Farrelly:

A while ago we introduced the information line in squid that stated the
type of connections being accepted, like this:

2003/06/23 19:14:49| Accepting transparently proxiedHTTP connections at
192.168.0.2, port 3128, FD 12.

Here's a patch (attached) to squid-3 CVS as of now, which fixes up a minor
problem with whitespaces - as illustrated above.

Reuben