]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
5 years agoMerge pull request #13605 from cdown/ono
Chris Down [Fri, 20 Sep 2019 16:10:34 +0000 (18:10 +0200)] 
Merge pull request #13605 from cdown/ono

Fixes for recent SIP work

5 years agobasic/log: put a ratelimit on our logging to /dev/kmsg 13600/head
Zbigniew Jędrzejewski-Szmek [Thu, 19 Sep 2019 16:01:23 +0000 (18:01 +0200)] 
basic/log: put a ratelimit on our logging to /dev/kmsg

See the inline comment for details.

5 years agopid1: disable printk ratelimit in early boot
Zbigniew Jędrzejewski-Szmek [Wed, 18 Sep 2019 19:02:07 +0000 (21:02 +0200)] 
pid1: disable printk ratelimit in early boot

We have the problem that many early boot or late shutdown issues are harder
to solve than they could be because we have no logs. When journald is not
running, messages are redirected to /dev/kmsg. It is also the time when many
things happen in a rapid succession, so we tend to hit the kernel printk
ratelimit fairly reliably. The end result is that we get no logs from the time
where they would be most useful. Thus let's disable the kernels ratelimit.

Once the system is up and running, the ratelimit is not a problem. But during
normal runtime, things also log to journald, and not to /dev/kmsg, so the
ratelimit is not useful. Hence, there doesn't seem to be much point in trying
to restore the ratelimit after boot is finished and journald is up and running.

See kernel's commit 750afe7babd117daabebf4855da18e4418ea845e for the
description of the kenrel interface. Our setting has lower precedence than
explicit configuration on the kenrel command line.

5 years agotree-wide: say "ratelimit" not "rate_limit"
Zbigniew Jędrzejewski-Szmek [Thu, 19 Sep 2019 15:49:14 +0000 (17:49 +0200)] 
tree-wide: say "ratelimit" not "rate_limit"

"ratelimit" is a real word, so we don't need to use the other form anywhere.
We had both forms in various places, let's standarize on the shorter and more
correct one.

5 years agopid1: rename start_limit to start_ratelimit
Zbigniew Jędrzejewski-Szmek [Thu, 19 Sep 2019 15:45:41 +0000 (17:45 +0200)] 
pid1: rename start_limit to start_ratelimit

This way it is clearer what the type is. We also have auto_stop_ratelimit adjacent,
and it feels ugly to have a different suffix for those two.

5 years agoDrop RATELIMIT macros
Zbigniew Jędrzejewski-Szmek [Thu, 19 Sep 2019 15:41:20 +0000 (17:41 +0200)] 
Drop RATELIMIT macros

Using plain structure initialization is both shorter _and_ more clearer.
We get type safety for free.

5 years agosd-radv: if lifetime < SD_RADV_DEFAULT_MAX_TIMEOUT_USEC, adjust timeout (#13491)
Georg Müller [Fri, 20 Sep 2019 08:23:45 +0000 (10:23 +0200)] 
sd-radv: if lifetime < SD_RADV_DEFAULT_MAX_TIMEOUT_USEC, adjust timeout (#13491)

The RFC states that lifetime (AdvDefaultLifetime) must be at least
MaxRtrAdvInterval (which more or less corresponds to SD_RADV_DEFAULT_MAX_TIMEOUT_USEC
in systemd).

To fulfill this limit, virtually lower MaxRtrAdvInterval and MinRtrAdvInterval
accordingly.

Also check that min is not lower than 3s and max is not lower than 4s.

5 years agonetworkd: Fix SIP double-free 13605/head
Chris Down [Fri, 20 Sep 2019 13:14:05 +0000 (15:14 +0200)] 
networkd: Fix SIP double-free

This is already strv_freed right above

5 years agodhcp: Log SIP server information correctly
Chris Down [Fri, 20 Sep 2019 13:13:00 +0000 (15:13 +0200)] 
dhcp: Log SIP server information correctly

5 years agonetwork: DHCP server Add support to transmit SIP server
Susant Sahani [Wed, 18 Sep 2019 13:22:47 +0000 (15:22 +0200)] 
network: DHCP server Add support to transmit SIP server

1. DHCP server trasmit
2. Client parses and saves in leases
Implements http://www.rfc-editor.org/rfc/rfc3361.txt

```
Frame 134: 348 bytes on wire (2784 bits), 348 bytes captured (2784 bits) on interface 0
Ethernet II, Src: 42:65:85:d6:4e:32 (42:65:85:d6:4e:32), Dst: 1e:04:f8:b8:2f:d4 (1e:04:f8:b8:2f:d4)
Internet Protocol Version 4, Src: 192.168.5.1, Dst: 192.168.5.11
User Datagram Protocol, Src Port: 67, Dst Port: 68
Dynamic Host Configuration Protocol (ACK)
    Message type: Boot Reply (2)
    Hardware type: Ethernet (0x01)
    Hardware address length: 6
    Hops: 0
    Transaction ID: 0x7cc87cb4
    Seconds elapsed: 0
    Bootp flags: 0x0000 (Unicast)
    Client IP address: 0.0.0.0
    Your (client) IP address: 192.168.5.11
    Next server IP address: 0.0.0.0
    Relay agent IP address: 0.0.0.0
    Client MAC address: 1e:04:f8:b8:2f:d4 (1e:04:f8:b8:2f:d4)
    Client hardware address padding: 00000000000000000000
    Server host name not given
    Boot file name not given
    Magic cookie: DHCP
    Option: (53) DHCP Message Type (ACK)
        Length: 1
        DHCP: ACK (5)
    Option: (51) IP Address Lease Time
        Length: 4
        IP Address Lease Time: (3600s) 1 hour
    Option: (1) Subnet Mask (255.255.255.0)
        Length: 4
        Subnet Mask: 255.255.255.0
    Option: (3) Router
        Length: 4
        Router: 192.168.5.1
    Option: (6) Domain Name Server
        Length: 4
        Domain Name Server: 192.168.5.1
    Option: (42) Network Time Protocol Servers
        Length: 4
        Network Time Protocol Server: 192.168.1.1
    Option: (120) SIP Servers <=====here
        Length: 9
        SIP Server Encoding: IPv4 Address (1)
        SIP Server Address: 192.168.1.1
        SIP Server Address: 192.168.5.2
    Option: (101) TCode
        Length: 13
        TZ TCode: Europe/Berlin
    Option: (54) DHCP Server Identifier (192.168.5.1)
        Length: 4
        DHCP Server Identifier: 192.168.5.1
    Option: (255) End
        Option End: 255
```

```
cat /run/systemd/netif/state                                                                                                   ✔  ⚡  3148  16:40:51
OPER_STATE=routable
CARRIER_STATE=carrier
ADDRESS_STATE=routable
DNS=192.168.94.2 192.168.5.1
NTP=192.168.5.1
SIP=192.168.1.1 192.168.5.2

```

aa

5 years agonetwork dhcp4: Add support send request options in a generic manner
Susant Sahani [Tue, 17 Sep 2019 12:49:22 +0000 (14:49 +0200)] 
network dhcp4: Add support send request options in a generic manner

5 years agopolkit: fix typo
AsciiWolf [Thu, 19 Sep 2019 12:34:31 +0000 (14:34 +0200)] 
polkit: fix typo

5 years agotest-network: Drop start dnsmasq
Susant Sahani [Wed, 18 Sep 2019 12:14:15 +0000 (14:14 +0200)] 
test-network: Drop start dnsmasq

5 years agodhcp6: use unaligned_read_be32()
Yu Watanabe [Wed, 18 Sep 2019 13:14:45 +0000 (22:14 +0900)] 
dhcp6: use unaligned_read_be32()

Closes #13591.

5 years agopid1: do not warn if /run/systemd/relabel-extra.d/ doesn't exist
Zbigniew Jędrzejewski-Szmek [Wed, 18 Sep 2019 15:52:30 +0000 (17:52 +0200)] 
pid1: do not warn if /run/systemd/relabel-extra.d/ doesn't exist

After all, that is the expected state.

5 years agoMerge pull request #13582 from yuwata/udevadm-reload
Yu Watanabe [Tue, 17 Sep 2019 23:15:01 +0000 (08:15 +0900)] 
Merge pull request #13582 from yuwata/udevadm-reload

udevadm: use 'udevadm control' to reload udevd

5 years agoMerge pull request #13583 from keszybz/networkd-hash-compare-equality
Yu Watanabe [Tue, 17 Sep 2019 23:09:48 +0000 (08:09 +0900)] 
Merge pull request #13583 from keszybz/networkd-hash-compare-equality

Networkd hash compare equality

5 years agodhcp6: add missing option length check
Yu Watanabe [Tue, 17 Sep 2019 13:18:49 +0000 (22:18 +0900)] 
dhcp6: add missing option length check

Closes #13578.

5 years agoMerge pull request #13577 from yuwata/network-fix-ci-failure
Frantisek Sumsal [Tue, 17 Sep 2019 17:42:26 +0000 (17:42 +0000)] 
Merge pull request #13577 from yuwata/network-fix-ci-failure

network: fix CI failure

5 years agonetworkd: unbreak routing_policy_rule_compare_func() 13583/head
Zbigniew Jędrzejewski-Szmek [Tue, 17 Sep 2019 17:27:58 +0000 (19:27 +0200)] 
networkd: unbreak routing_policy_rule_compare_func()

!r is the same r == 0, so this was short-circuiting the comparison when
streq(a->iff, b->iff) or streq(a->off, b->off). Before the parent commit which
moved those comparisons to the end, this was short-circuiting quite a bit
of the comparison function.

5 years agoMerge pull request #13508 from yuwata/network-route-fix-13506
Zbigniew Jędrzejewski-Szmek [Tue, 17 Sep 2019 17:20:21 +0000 (19:20 +0200)] 
Merge pull request #13508 from yuwata/network-route-fix-13506

network: takes more route information into hash func

5 years agonetworkd: make neighbor_hash_func() handle the same data as neighbor_compare_func()
Zbigniew Jędrzejewski-Szmek [Tue, 17 Sep 2019 17:13:09 +0000 (19:13 +0200)] 
networkd: make neighbor_hash_func() handle the same data as neighbor_compare_func()

In practice this probably makes little difference, because we only use AF_INET
and AF_INET6, but it's cleaner to use the same logic in both places.

5 years agonetworkd: use same order in _hash_func() and _compare_func()
Zbigniew Jędrzejewski-Szmek [Tue, 17 Sep 2019 17:11:31 +0000 (19:11 +0200)] 
networkd: use same order in _hash_func() and _compare_func()

This makes it easier to see that the same data is handled in both cases.
No functional change.

5 years agonetworkd: split out helper function for address extraction
Zbigniew Jędrzejewski-Szmek [Tue, 17 Sep 2019 17:09:57 +0000 (19:09 +0200)] 
networkd: split out helper function for address extraction

5 years agounit: add ExecReload= in systemd-udevd.service 13582/head
Yu Watanabe [Tue, 17 Sep 2019 16:32:46 +0000 (01:32 +0900)] 
unit: add ExecReload= in systemd-udevd.service

5 years agoudevadm: use usec_add()
Yu Watanabe [Tue, 17 Sep 2019 16:28:23 +0000 (01:28 +0900)] 
udevadm: use usec_add()

Also fixes description of event source.

5 years agoudevadm: missing initialization of descriptor
Yu Watanabe [Tue, 17 Sep 2019 15:52:07 +0000 (00:52 +0900)] 
udevadm: missing initialization of descriptor

5 years agocore: add ExecXYZEx= bus hook ups to all exec command properties
Anita Zhang [Wed, 21 Aug 2019 00:39:38 +0000 (17:39 -0700)] 
core: add ExecXYZEx= bus hook ups to all exec command properties

The "Ex" variant was originally only added for ExecStartXYZ= but it makes
sense to have feature parity for the rest of the exec command properties
as well (e.g. ExecReload=, ExecStop=, etc).

5 years agotest: rename TEST-EXECRELOAD to avoid name conflict
Frantisek Sumsal [Tue, 17 Sep 2019 10:22:19 +0000 (12:22 +0200)] 
test: rename TEST-EXECRELOAD to avoid name conflict

5 years agoMerge pull request #13559 from ssahani/ipv6ra-route
Yu Watanabe [Tue, 17 Sep 2019 15:13:08 +0000 (00:13 +0900)] 
Merge pull request #13559 from ssahani/ipv6ra-route

network: make networkd able to advertise IPv6 routes on links

5 years agocore: coldplug possible nop_job
ypf791 [Fri, 19 Jul 2019 10:28:04 +0000 (18:28 +0800)] 
core: coldplug possible nop_job

5 years agonetwork: also take Route::initcwnd and ::initrwnd into hash func 13508/head
Yu Watanabe [Mon, 9 Sep 2019 15:18:05 +0000 (00:18 +0900)] 
network: also take Route::initcwnd and ::initrwnd into hash func

Fixes #13506.

5 years agonetwork: take more route information into hash func
Yu Watanabe [Mon, 9 Sep 2019 15:17:28 +0000 (00:17 +0900)] 
network: take more route information into hash func

5 years agonetwork: make route_get() or friends take Route object
Yu Watanabe [Mon, 9 Sep 2019 15:16:41 +0000 (00:16 +0900)] 
network: make route_get() or friends take Route object

5 years agosd-netlink: fix invalid assertion
Yu Watanabe [Sun, 15 Sep 2019 13:50:36 +0000 (22:50 +0900)] 
sd-netlink: fix invalid assertion

It is natural that n_attiributes is less than type. But in that case,
the message does not contain any message about the type. So, we should
not abort execution with assertion, but just return -ENODATA.

5 years agoMerge pull request #13567 from keszybz/logind-two-refactoring-patches
Yu Watanabe [Tue, 17 Sep 2019 12:41:38 +0000 (21:41 +0900)] 
Merge pull request #13567 from keszybz/logind-two-refactoring-patches

Logind two refactoring patches

5 years agonetwork: do not enter failed state if device's sysfs entry does not exist yet 13577/head
Yu Watanabe [Tue, 17 Sep 2019 12:34:06 +0000 (21:34 +0900)] 
network: do not enter failed state if device's sysfs entry does not exist yet

5 years agonetwork: add missing link->network checks
Yu Watanabe [Tue, 17 Sep 2019 12:29:23 +0000 (21:29 +0900)] 
network: add missing link->network checks

When the function is called, no network file may be assigned to the
link.

5 years agoMerge pull request #13573 from fbuihuu/ask-password-small-fixes
Frantisek Sumsal [Tue, 17 Sep 2019 12:21:05 +0000 (12:21 +0000)] 
Merge pull request #13573 from fbuihuu/ask-password-small-fixes

Ask password small fixes

5 years agoAdd test for IPv6 Route advertisement 13559/head
Susant Sahani [Mon, 16 Sep 2019 14:43:34 +0000 (20:13 +0530)] 
Add test for IPv6 Route advertisement

5 years agonetwork: Add support to advertie ipv6 route
Susant Sahani [Sat, 14 Sep 2019 11:14:22 +0000 (16:44 +0530)] 
network: Add support to advertie ipv6 route

Implements https://tools.ietf.org/html/rfc4191

cat veth99.network
```
[Match]
Name=veth99

[Network]
DHCP=no
IPv6PrefixDelegation=yes
Address=2001:db8:0:1::1/64

[IPv6Prefix]
Prefix=2001:db8:0:1::4/64

[IPv6RoutePrefix]
Route=2001:db0:fff::/48

```
Wireshark

```
Frame 481: 142 bytes on wire (1136 bits), 142 bytes captured (1136 bits) on interface 0
Ethernet II, Src: 1e:04:f8:b8:2f:d4 (1e:04:f8:b8:2f:d4), Dst: IPv6mcast_01 (33:33:00:00:00:01)
Internet Protocol Version 6, Src: fe80::1c04:f8ff:feb8:2fd4, Dst: ff02::1
Internet Control Message Protocol v6
    Type: Router Advertisement (134)
    Code: 0
    Checksum: 0xec77 [correct]
    [Checksum Status: Good]
    Cur hop limit: 0
    Flags: 0x00, Prf (Default Router Preference): Medium
    Router lifetime (s): 0
    Reachable time (ms): 0
    Retrans timer (ms): 0
    ICMPv6 Option (Source link-layer address : 1e:04:f8:b8:2f:d4)
        Type: Source link-layer address (1)
        Length: 1 (8 bytes)
        Link-layer address: 1e:04:f8:b8:2f:d4 (1e:04:f8:b8:2f:d4)
    ICMPv6 Option (MTU : 1500)
        Type: MTU (5)
        Length: 1 (8 bytes)
        Reserved
        MTU: 1500
    ICMPv6 Option (Prefix information : 2001:db8:0:1::4/64)
        Type: Prefix information (3)
        Length: 4 (32 bytes)
        Prefix Length: 64
        Flag: 0xc0, On-link flag(L), Autonomous address-configuration flag(A)
        Valid Lifetime: 2592000
        Preferred Lifetime: 604800
        Reserved
        Prefix: 2001:db8:0:1::4
    ICMPv6 Option (Route Information : Medium 2001:db0:fff::/48)
        Type: Route Information (24)
        Length: 3 (24 bytes)
        Prefix Length: 48
        Flag: 0x00, Route Preference: Medium
            ...0 0... = Route Preference: Medium (0)
            000. .000 = Reserved: 0
        Route Lifetime: 604800
        Prefix: 2001:db0:fff::
```

5 years agoMerge pull request #13300 from mrc0mmand/test-execreload
Zbigniew Jędrzejewski-Szmek [Tue, 17 Sep 2019 08:54:18 +0000 (10:54 +0200)] 
Merge pull request #13300 from mrc0mmand/test-execreload

 test: introduce TEST-37-EXECRELOAD

5 years agopath: stop watching path specs once we triggered the target unit
Michal Sekletar [Mon, 9 Sep 2019 12:38:35 +0000 (14:38 +0200)] 
path: stop watching path specs once we triggered the target unit

We start watching them again once we get a notification that triggered
unit entered inactive or failed state.

Fixes: #10503
5 years agoMerge pull request #13565 from yuwata/network-drop-ipv6ll-address
Zbigniew Jędrzejewski-Szmek [Tue, 17 Sep 2019 07:57:21 +0000 (09:57 +0200)] 
Merge pull request #13565 from yuwata/network-drop-ipv6ll-address

network: drop IPv6LL address when LinkLocalAddressing=no|ipv4

5 years agotty-ask-pwd-agent: simplify handling of --wall a bit 13573/head
Franck Bui [Tue, 17 Sep 2019 07:48:12 +0000 (09:48 +0200)] 
tty-ask-pwd-agent: simplify handling of --wall a bit

"wall" was always NULL when passed to parse_password() so let's simplify this
part a bit.

The effective changes are small but wall_tty_match() needed to be moved so it's
still visible from parse_password().

No functional changes.

5 years agoMerge pull request #13494 from yuwata/dhcp6-delay
Zbigniew Jędrzejewski-Szmek [Tue, 17 Sep 2019 07:14:12 +0000 (09:14 +0200)] 
Merge pull request #13494 from yuwata/dhcp6-delay

dhcp6: rfc8415 fixes

5 years agocore: Fix setting StatusUnitFormat from config files
Maciej Stanczew [Mon, 16 Sep 2019 00:09:35 +0000 (02:09 +0200)] 
core: Fix setting StatusUnitFormat from config files

5 years agotest-network: add one more test case for LinkLocalAddressing= 13565/head
Yu Watanabe [Sun, 15 Sep 2019 21:16:48 +0000 (06:16 +0900)] 
test-network: add one more test case for LinkLocalAddressing=

5 years agonetwork: drop IPv6LL address when LinkLocalAddressing=no|ipv4
Yu Watanabe [Sun, 15 Sep 2019 21:07:38 +0000 (06:07 +0900)] 
network: drop IPv6LL address when LinkLocalAddressing=no|ipv4

C.f. disscussion in #13533.

Hopefully fixes #12886.

5 years agonetwork DHCP4: Dont mislead the logs.
Susant Sahani [Mon, 16 Sep 2019 18:46:39 +0000 (20:46 +0200)] 
network DHCP4: Dont mislead the logs.

The debug log making sense to the end user as an error.

5 years agotty-ask-pwd-agent: fix message forwarded to wall(1)
Franck Bui [Mon, 16 Sep 2019 20:03:43 +0000 (22:03 +0200)] 
tty-ask-pwd-agent: fix message forwarded to wall(1)

Commit a1c111c2d12429d2 wrongly replaced '!' with ':' when the message is
forwarded to wall(1).

Indeed in this case we are not requesting the user for providing a password but
instead we are simply displaying a message to suggest starting
tty-ask-password-agent for providing the password.

5 years agoUpdate m4 for selective utmp support.
Donald A. Cupp Jr [Thu, 5 Sep 2019 22:03:54 +0000 (15:03 -0700)] 
Update m4 for selective utmp support.
modified:   tmpfiles.d/systemd.conf.m4

5 years agohwdb: add Medion Akoya E2292 (#13498)
matthiasroos [Mon, 16 Sep 2019 19:10:15 +0000 (21:10 +0200)] 
hwdb: add Medion Akoya E2292 (#13498)

Fixes #13480.

5 years agopo: update Brazilian Portuguese translation
Rafael Fontenelle [Sun, 8 Sep 2019 22:08:14 +0000 (19:08 -0300)] 
po: update Brazilian Portuguese translation

5 years agobootctl: add "system-options" verb 13246/head
Zbigniew Jędrzejewski-Szmek [Thu, 1 Aug 2019 15:15:59 +0000 (17:15 +0200)] 
bootctl: add "system-options" verb

5 years agoman: document SystemdOptions variable
Zbigniew Jędrzejewski-Szmek [Thu, 1 Aug 2019 15:16:39 +0000 (17:16 +0200)] 
man: document SystemdOptions variable

5 years agoAdd support for SystemdOptions EFI var to augment /proc/cmdline
Zbigniew Jędrzejewski-Szmek [Thu, 1 Aug 2019 13:33:35 +0000 (15:33 +0200)] 
Add support for SystemdOptions EFI var to augment /proc/cmdline

In various circumstances, overriding the kernel commandline can be inconvenient.
People have different bootloaders, and e.g. the grub config can be pretty scary.
grubby helps, but it isn't always available.

This option adds an alternative mechanism that can quite convenient on EFI
systems. cmdline settings have higher priority, because they can be (usually)
changed on the bootloader prompt.

$SYSTEMD_EFI_OPTIONS can be used to override, same as $SYSTEMD_PROC_CMDLINE.

5 years agotest-proc-cmdline: use test_setup_logging()
Zbigniew Jędrzejewski-Szmek [Tue, 20 Aug 2019 10:11:24 +0000 (12:11 +0200)] 
test-proc-cmdline: use test_setup_logging()

5 years agoutil-lib: split shared/efivars into basic/efivars and shared/efi-loader
Zbigniew Jędrzejewski-Szmek [Thu, 1 Aug 2019 14:28:29 +0000 (16:28 +0200)] 
util-lib: split shared/efivars into basic/efivars and shared/efi-loader

I want to use efivars.[ch] in proc-cmdline.c, but most of the efivars stuff is
not needed in basic/. Move the file from shared/ to basic/, but then move back
most of the higher-level functions to the new shared/efi-loader.c file.

5 years agoutil-lib: move shall_restore_state() to shared/reboot-util
Zbigniew Jędrzejewski-Szmek [Thu, 1 Aug 2019 12:34:51 +0000 (14:34 +0200)] 
util-lib: move shall_restore_state() to shared/reboot-util

It's just a small function, but it is higher-level functionality.
I don't see a good place for it, reboot-util.[ch] seems least bad

5 years agoutil-lib: move runlevel_to_target() to shared/unit-file
Zbigniew Jędrzejewski-Szmek [Thu, 1 Aug 2019 12:25:14 +0000 (14:25 +0200)] 
util-lib: move runlevel_to_target() to shared/unit-file

It if of course related to /proc/cmdline parsing, but is higher-level
functionality built on top of it. It should be in shared/ because it
is something to be used by pid1 and related utilities, not something for
level-level libraries.

5 years agoutil-lib: move some functions from basic/cgroup-util to shared/cgroup-setup
Zbigniew Jędrzejewski-Szmek [Thu, 1 Aug 2019 11:14:45 +0000 (13:14 +0200)] 
util-lib: move some functions from basic/cgroup-util to shared/cgroup-setup

This way less stuff needs to be in basic. Initially, I wanted to move all the
parts of cgroup-utils.[ch] that depend on efivars.[ch] to shared, because
efivars.[ch] is in shared/. Later on, I decide to split efivars.[ch], so the
move done in this patch is not necessary anymore. Nevertheless, it is still
valid on its own. If at some point we want to expose libbasic, it is better to
to not have stuff that belong in libshared there.

5 years agoutil-lib: move yes_no() and friends to string-util.h
Zbigniew Jędrzejewski-Szmek [Thu, 1 Aug 2019 11:10:49 +0000 (13:10 +0200)] 
util-lib: move yes_no() and friends to string-util.h

5 years agobasic/cgroup-util: let cgroup_unified_flush() return the detected hierarchy
Zbigniew Jędrzejewski-Szmek [Thu, 1 Aug 2019 10:48:41 +0000 (12:48 +0200)] 
basic/cgroup-util: let cgroup_unified_flush() return the detected hierarchy

This avoid the use of the global variable.

Also rename cgroup_unified_update() to cgroup_unified_cached() and
cgroup_unified_flush() to cgroup_unified() to better reflect their new roles.

5 years agocore: restore initialization of u->source_mtime
Franck Bui [Thu, 5 Sep 2019 14:53:50 +0000 (16:53 +0200)] 
core: restore initialization of u->source_mtime

During the rework of unit file loading, commit e8630e695232bdfc dropped the
initialization u->source_mtime. This had the bad side effect that generated
units always needed daemon reloading.

5 years agoMerge pull request #13551 from keszybz/ll-no-default-route
Zbigniew Jędrzejewski-Szmek [Mon, 16 Sep 2019 12:27:41 +0000 (14:27 +0200)] 
Merge pull request #13551 from keszybz/ll-no-default-route

Link local no default route

5 years agoMerge pull request #13354 from keszybz/two-refactoring-patches
Yu Watanabe [Mon, 16 Sep 2019 12:24:13 +0000 (21:24 +0900)] 
Merge pull request #13354 from keszybz/two-refactoring-patches

Two or more refactoring patches

5 years agobasic/conf-files: make conf_files_list() take just a single directory 13354/head
Zbigniew Jędrzejewski-Szmek [Mon, 19 Aug 2019 14:31:27 +0000 (16:31 +0200)] 
basic/conf-files: make conf_files_list() take just a single directory

This function had two users (apart from tests), and both only used one
argument. And it seems likely that if we need to pass more directories,
either the _nulstr() or the _strv() form would be used. Let's simplify
the code.

5 years agocore/mount-setup: use conf_files_list_strv() for relabel-extra.d/
Zbigniew Jędrzejewski-Szmek [Tue, 6 Aug 2019 18:22:23 +0000 (20:22 +0200)] 
core/mount-setup: use conf_files_list_strv() for relabel-extra.d/

5 years agoupdate-utmp: define main() through macro
Zbigniew Jędrzejewski-Szmek [Mon, 5 Aug 2019 13:53:28 +0000 (15:53 +0200)] 
update-utmp: define main() through macro

Update logging a bit: drop logging of the pid, nowadays pid1 and journald
do a very good job of logging that. Always log about failure to open audit
fd, but at DEBUG_LEVEL if not important.

5 years agologind: shorten code a bit 13567/head
Zbigniew Jędrzejewski-Szmek [Fri, 6 Sep 2019 07:38:33 +0000 (09:38 +0200)] 
logind: shorten code a bit

5 years agologind: use newer ret var naming style
Zbigniew Jędrzejewski-Szmek [Fri, 6 Sep 2019 07:18:33 +0000 (09:18 +0200)] 
logind: use newer ret var naming style

5 years agomount-setup: relabel items mentioned directly in relabel-extra.d
Benjamin Gilbert [Wed, 11 Sep 2019 03:23:59 +0000 (23:23 -0400)] 
mount-setup: relabel items mentioned directly in relabel-extra.d

relabel_extra() relabels the descendants of directories listed in
relabel-extra.d, but doesn't relabel the files or directories
explicitly named there.  This makes it impossible to use
relabel-extra.d to relabel the root of a filesystem.  Fix by
relabeling the named items too.

5 years agoCall getgroups() to know size of supplementary groups array to allocate
Renaud Métrich [Fri, 13 Sep 2019 09:18:18 +0000 (11:18 +0200)] 
Call getgroups() to know size of supplementary groups array to allocate

Resolves RHBZ #1743230 - journalctl dumps core when stack limit is reduced to 256 KB

5 years agondisc: make first solicit delayed randomly 13494/head
Yu Watanabe [Fri, 6 Sep 2019 18:36:19 +0000 (03:36 +0900)] 
ndisc: make first solicit delayed randomly

Closes #13460.

5 years agodhcp6: read OPTION_INFORMATION_REFRESH_TIME option
Yu Watanabe [Fri, 6 Sep 2019 18:29:46 +0000 (03:29 +0900)] 
dhcp6: read OPTION_INFORMATION_REFRESH_TIME option

Fixes #13460.

5 years agonetwork: add more debug messages 13551/head
Yu Watanabe [Thu, 29 Aug 2019 19:18:27 +0000 (04:18 +0900)] 
network: add more debug messages

5 years agonetwork: set scope and protocol for default route
Yu Watanabe [Thu, 29 Aug 2019 11:24:27 +0000 (20:24 +0900)] 
network: set scope and protocol for default route

5 years agonetwork: drop redundant and invalid destination address
Yu Watanabe [Wed, 28 Aug 2019 23:11:02 +0000 (08:11 +0900)] 
network: drop redundant and invalid destination address

When dst_prefixlen is not set, the value is not used.

5 years agonetwork: do not use implicit cast to boolean
Yu Watanabe [Wed, 28 Aug 2019 23:13:15 +0000 (08:13 +0900)] 
network: do not use implicit cast to boolean

5 years agonetwork: do not create default route for ipv4 link local addressing
Yu Watanabe [Wed, 28 Aug 2019 13:42:33 +0000 (22:42 +0900)] 
network: do not create default route for ipv4 link local addressing

When nspawn container with private network starts, networkd creates
the default route for the interface. The route may cause problem on
the host side, and it can be created with DefaultRouteOnDevice= now.
Hence, this makes networkd not create the route implicitly any more.

Closes #13418.

5 years agopo: update Polish translation
Piotr Drąg [Sat, 14 Sep 2019 10:44:57 +0000 (12:44 +0200)] 
po: update Polish translation

5 years agoMerge pull request #13405 from yuwata/network-ipv6-privacy-extensions-cleanup
Zbigniew Jędrzejewski-Szmek [Fri, 13 Sep 2019 16:03:29 +0000 (18:03 +0200)] 
Merge pull request #13405 from yuwata/network-ipv6-privacy-extensions-cleanup

Network ipv6 privacy extensions cleanup

5 years agoMerge pull request #13439 from yuwata/core-support-systemctl-clean-more
Zbigniew Jędrzejewski-Szmek [Fri, 13 Sep 2019 14:15:02 +0000 (16:15 +0200)] 
Merge pull request #13439 from yuwata/core-support-systemctl-clean-more

core: support systemctl clean more

5 years agoMerge pull request #13519 from yuwata/udev-fix-multi-match
Zbigniew Jędrzejewski-Szmek [Fri, 13 Sep 2019 13:27:55 +0000 (15:27 +0200)] 
Merge pull request #13519 from yuwata/udev-fix-multi-match

udev: fix multi match

5 years agoman: move TimeoutCleanSec= entry from .service to .exec
Yu Watanabe [Fri, 13 Sep 2019 08:12:59 +0000 (17:12 +0900)] 
man: move TimeoutCleanSec= entry from .service to .exec

Follow-up for 12213aed128456af33ff6131a14b637318227346.

Closes #13546.

5 years agozsh: udpate bootctl completions
Ronan Pigott [Thu, 12 Sep 2019 17:13:13 +0000 (10:13 -0700)] 
zsh: udpate bootctl completions

5 years agoresolved: fix abort when recv() returns 0
Zbigniew Jędrzejewski-Szmek [Thu, 12 Sep 2019 12:52:08 +0000 (14:52 +0200)] 
resolved: fix abort when recv() returns 0

https://bugzilla.redhat.com/show_bug.cgi?id=1703598

5 years agoMerge pull request #13538 from keszybz/doc-tweaks
Yu Watanabe [Fri, 13 Sep 2019 04:31:20 +0000 (13:31 +0900)] 
Merge pull request #13538 from keszybz/doc-tweaks

Various minor tweaks that don't deserve seperate pull requests

5 years agohwdb: Also mark lis3lv02d sensors in "HP" laptops as being in the base
Bastien Nocera [Thu, 12 Sep 2019 17:02:35 +0000 (19:02 +0200)] 
hwdb: Also mark lis3lv02d sensors in "HP" laptops as being in the base

We matched "*Hewlett-Packard*" laptops but not "*HP*" laptops, which
caused a regression for the HP Elite Book 850 G3.

Fixes: 4247938ee13e23eae1afcecbe646de5283b7afc2
Closes: #13543
5 years agopolkit: change "revert settings" to "reset settings" 13538/head
Zbigniew Jędrzejewski-Szmek [Sun, 8 Sep 2019 14:13:15 +0000 (16:13 +0200)] 
polkit: change "revert settings" to "reset settings"

"reset" is more understandable. The verb is "revert", but it might actually be
better to have a description which uses different words instead of duplicating
the name of the command.

https://github.com/systemd/systemd/commit/379158684abd981cc760342aad61b1c813b71eb2#commitcomment-34992552

5 years agoMerge pull request #13500 from yuwata/udev-fix-static_node
Zbigniew Jędrzejewski-Szmek [Thu, 12 Sep 2019 15:36:34 +0000 (17:36 +0200)] 
Merge pull request #13500 from yuwata/udev-fix-static_node

udev: add missing flag for OPTIONS=static_node

5 years agofuzzit: export the API key instead of using `auth`
Evgeny Vereshchagin [Thu, 12 Sep 2019 10:34:26 +0000 (10:34 +0000)] 
fuzzit: export the API key instead of using `auth`

"We removed some cahing related code that auth used and caused problems"

5 years agoman: remove repeated words
Zbigniew Jędrzejewski-Szmek [Sat, 7 Sep 2019 13:16:35 +0000 (15:16 +0200)] 
man: remove repeated words

https://github.com/systemd/systemd/commit/b5328434c91b10ad49647e2352e62b1fbdce329d#commitcomment-34989175

5 years agoman: fix description of ARPIntervalSec= units
Zbigniew Jędrzejewski-Szmek [Thu, 12 Sep 2019 09:15:35 +0000 (11:15 +0200)] 
man: fix description of ARPIntervalSec= units

https://bugzilla.redhat.com/show_bug.cgi?id=1751363

5 years agoTODO: add stuff about timers
Zbigniew Jędrzejewski-Szmek [Thu, 5 Sep 2019 11:41:08 +0000 (13:41 +0200)] 
TODO: add stuff about timers

5 years agoMerge pull request #13526 from yuwata/network-check-access-mode-of-key-file
Yu Watanabe [Thu, 12 Sep 2019 03:02:28 +0000 (12:02 +0900)] 
Merge pull request #13526 from yuwata/network-check-access-mode-of-key-file

network: check access mode of key file

5 years agonetwork: do not abort execution when a config file cannot be loaded 13526/head
Yu Watanabe [Wed, 11 Sep 2019 09:24:41 +0000 (18:24 +0900)] 
network: do not abort execution when a config file cannot be loaded

Closes #13516.

5 years agofileio: update warning message
Yu Watanabe [Wed, 11 Sep 2019 09:11:19 +0000 (18:11 +0900)] 
fileio: update warning message

5 years agonetwork: also check the permission of key file
Yu Watanabe [Wed, 11 Sep 2019 09:09:55 +0000 (18:09 +0900)] 
network: also check the permission of key file