Wayne Davison [Sat, 15 Mar 2008 15:51:07 +0000 (08:51 -0700)]
Generate a helpful message when we get an option-error from a daemon
while requesting a file-listing and we suspect that the remote rsync
is complaining about the -d option.
Wayne Davison [Sat, 15 Mar 2008 07:43:31 +0000 (00:43 -0700)]
- Fixed a crash bug when backing up files with ACLs enabled and we
create a directory in the backup-path area.
- Fixed a bug where make_file() was setting F_PATHNAME() on the
receiving side.
- A non-pool (temp-memory) file structure now stores the size of
its extra_cnt value in the F_DEPTH() int so that unmake_file()
can always be sure of how to free() the memory.
- The ACL-preserving code no longer allocates 4 more bytes per
file entry than it needs.
- Got rid of a useless adding of the symlink length to "bp".
Wayne Davison [Sat, 15 Mar 2008 05:55:59 +0000 (22:55 -0700)]
Have configure check to see if /usr/include/popt/popt.h is around
(rather than /usr/include/popt.h), and use the included popt lib
if it is (to avoid a potential conflict due to our use of -I.).
Wayne Davison [Tue, 11 Mar 2008 04:15:37 +0000 (21:15 -0700)]
Fixed some itemized logging failures:
- If a symlink/device/special-file changes its value without any
attribute changes, the itemized event no longer gets dropped.
- We put a 'c' into the checksum/change field now to indicate when
a symlink/device/special-file changes its value without changing
its type. This lets us properly interpret the --copy-links output
to know which items are getting copied without changes and which
are getting created with new content.
- Fixed the 'T' itemized output for a symlink when rsync tries to
set the right time but fails due to lack of OS/disk support.
Wayne Davison [Sat, 8 Mar 2008 18:54:17 +0000 (10:54 -0800)]
Some popt improvements:
- Fixed a bug in short-opt parsing when an abutting arg has an '='.
- Allow a short-opt to be separated from its arg by an '='.
- Avoid an IBM-checker warning about an impossible case in a switch
and a warning about a potential NULL-pointer dereference.
- Fixed a memory leak.
Wayne Davison [Sat, 8 Mar 2008 00:16:29 +0000 (16:16 -0800)]
Fixed the interaction of --fake-super with --link-dest & --xattrs.
Fixed the munging of non-user namespace xattrs w/--fake-super.
Fixed the sorting of received xattrs when name-munging occurs.
Added xattr tests to verify that these things stay fixed.
Wayne Davison [Wed, 5 Mar 2008 05:46:00 +0000 (21:46 -0800)]
- Made the itemize test check for CAN_HARDLINK_SYMLINK define instead
of running its own test using ln.
- Made the merge test call checkit with absolute paths so that some
folk's cd command won't foul things up with extra output.
Wayne Davison [Tue, 4 Mar 2008 02:33:11 +0000 (18:33 -0800)]
Fixing a problem with a NULL config_file pointer when accessing
a single-use daemon without no --config option specified. Added
a test to ensure that this doesn't break in the future.
Wayne Davison [Mon, 3 Mar 2008 16:46:30 +0000 (08:46 -0800)]
Updated copyright year in --version output and improved the release
script to look for year changes in options.c and to get the version
defaults totally right in the prompts.
Wayne Davison [Thu, 28 Feb 2008 00:19:05 +0000 (16:19 -0800)]
Temporarily set uid_ndx in the delete code if the transfer is not
preserving ownership, but we want to know what the UIDs are on the
files we're deleting. Changed the DEL_OWNED_BY_US flag to be
DEL_NO_UID_WRITE, which is only set when a file is owned by us and
we can't write to it. Fixed a glitch in the error handling of the
--delete-delay code where it might try to enable delete-after in
incremental-transfer mode. Made a simple (well tested) optimization
in the --delete-delay code and a few other readability changes.
Wayne Davison [Thu, 28 Feb 2008 00:15:14 +0000 (16:15 -0800)]
Use preserve_[ug]id values for send/recv checking, which will
allow the delete code to temporarily set [ug]id_ndx during
delete processing, as needed. Got rid of a couple duplicate
tests.
Wayne Davison [Mon, 18 Feb 2008 22:10:13 +0000 (14:10 -0800)]
Extended the protocol-30 info-passing code at startup, and use it to
tell the client if the server can set the times on a symlink (both
the server->client byte and the client->server use of -e). Make use
of this info to allow the proper output of the 't' flag when rsync
can set the time on a symlink (and we're talking protocol >= 30).
Added output of "[no] symtimes" info in the --version message.
Fixed the itemize.test so that it works when rsync believes that it
can set the time of a symlink, but it can't really do it.
Wayne Davison [Mon, 18 Feb 2008 18:02:35 +0000 (10:02 -0800)]
Some permssion fixes:
- Changed itemized output to only report 'p' with -p or -E.
- Fixed a duplicate output of a link-dest file with -vv but no -i.
- Improved unchanged_attrs() to handle -E.
Wayne Davison [Mon, 18 Feb 2008 06:11:44 +0000 (22:11 -0800)]
Don't output a duplicate warning when the daemon-config excludes a
directory or when a directory is ignored via --ignore-non-existing.
Use a new var, is_dir, to simplify the dir code in recv_generator().
Wayne Davison [Sat, 16 Feb 2008 02:55:02 +0000 (18:55 -0800)]
Added a way to specify where the chroot should occur in the module's
path, which allows a daemon admin to have chroot protection and still
have files that are outside the transfer area (such as libraries).
Wayne Davison [Sun, 10 Feb 2008 06:07:03 +0000 (22:07 -0800)]
Add a trailing slash to a modname arg that has no path information.
This ensures that the user gets a "skipping" message if they didn't
specify -r or -d. (A trailing-slash was already being added to a
lone modname for --list-only transfers.)
Wayne Davison [Mon, 4 Feb 2008 15:29:22 +0000 (07:29 -0800)]
Store the key64 flag from hashtable_create() in the hashtable structure
so that hashtable_find() knows which hashtable is which on a 64-bit
architecture.
Wayne Davison [Sun, 27 Jan 2008 22:39:49 +0000 (14:39 -0800)]
Fixed several glitches with failed updates and batch files:
- Correctly identify when a missing batch update is for a resend.
- Made a missing batch update an xfer error.
- Made a failed redo an xfer error.
- Identify a failed transfer file consistently when it is a solo file.
- Have --read-batch say "may try again" instead of "will try again".
Wayne Davison [Sat, 26 Jan 2008 19:56:27 +0000 (11:56 -0800)]
Moved the batch option checking until after the protocol-version
in the batch file is known. Also simplified the do_compress
checking, which had some erroneous def_compress_level code.